Re: svn commit: r781414 - in /ofbiz/trunk/applications/workeffort: entitydef/entitymodel.xml src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java

[Jacques Le Roux]

Hi Adrian,

This is a pity we have no time for that. I would like to have something like this with a sortable todo list in OFBiz. They are very
simple but most of the time very convenient tools
I put this apart in my (long) todo list... I guess I have enough work for my retirement.
The bad thing is that by then I will have much more than I will be able to cope with ;o)

Thanks

Jacques

From: <[hidden email]>

> Author: adrianc
> Date: Wed Jun  3 14:55:34 2009
> New Revision: 781414
>
> URL: http://svn.apache.org/viewvc?rev=781414&view=rev
> Log:
> Removed the partially-implemented popup event reminders. I don't plan on finishing it because popup event reminders can be handled
> by third-party calendar programs.
>
> Modified:
>    ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml
>    ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java
>
> Modified: ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml?rev=781414&r1=781413&r2=781414&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml (original)
> +++ ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml Wed Jun  3 14:55:34 2009
> @@ -470,7 +470,6 @@
>       <field name="workEffortId" type="id-ne"></field>
>       <field name="contactMechId" type="id-ne"></field>
>       <field name="sequenceId" type="id-ne"></field>
> -      <field name="isPopup" type="indicator"></field>
>       <field name="reminderDateTime" type="date-time"></field>
>       <field name="repeatCount" type="numeric"></field>
>       <field name="repeatInterval" type="numeric">
>
> Modified: ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java?rev=781414&r1=781413&r2=781414&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java (original)
> +++ ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java Wed Jun  3 14:55:34 2009
> @@ -749,17 +749,6 @@
>         for (GenericValue reminder : eventReminders) {
>             int repeatCount = reminder.get("repeatCount") == null ? 0 : reminder.getLong("repeatCount").intValue();
>             int currentCount = reminder.get("currentCount") == null ? 0 : reminder.getLong("currentCount").intValue();
> -            String isPopup = reminder.getString("isPopup");
> -            if ("Y".equals(isPopup)) {
> -                if (repeatCount != 0 && repeatCount == currentCount) {
> -                    try {
> -                        reminder.remove();
> -                    } catch (GenericEntityException e) {
> -                        Debug.logWarning("Error while removing work effort event reminder: " + e, module);
> -                    }
> -                }
> -                continue;
> -            }
>             GenericValue workEffort = null;
>             try {
>                 workEffort = reminder.getRelatedOne("WorkEffort");
>
>

[Adrian Crum]

To be more specific, and to give some background information for anyone
interested:

I started to build out the WorkEffort component so that it can be used
as a personal calendar. I had considered including pop-up event
reminders that would work like existing calendaring programs. I soon
realized I was reinventing the wheel - since there are open source
calendaring programs out there already (Sunbird, for example).

So, I changed my strategy to simply provide a means for third party
calendar programs to access WorkEffort data. That's when I created the
iCalendar integration. So, instead of trying to turn OFBiz into a
calendaring program, I made OFBiz data accessible to existing
calendaring programs.

The OFBiz popup reminders are not needed. Just import OFBiz WorkEffort
events into your calendar, and set your popup reminders from there.

-Adrian

Jacques Le Roux wrote:

> Hi Adrian,
>
> This is a pity we have no time for that. I would like to have something
> like this with a sortable todo list in OFBiz. They are very
> simple but most of the time very convenient tools
> I put this apart in my (long) todo list... I guess I have enough work
> for my retirement.
> The bad thing is that by then I will have much more than I will be able
> to cope with ;o)
>
> Thanks
>
> Jacques
>
> From: <[hidden email]>
>> Author: adrianc
>> Date: Wed Jun  3 14:55:34 2009
>> New Revision: 781414
>>
>> URL: http://svn.apache.org/viewvc?rev=781414&view=rev
>> Log:
>> Removed the partially-implemented popup event reminders. I don't plan
>> on finishing it because popup event reminders can be handled
>> by third-party calendar programs.
>>
>> Modified:
>>    ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml
>>    
>> ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java
>>
>>
>> Modified: ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml?rev=781414&r1=781413&r2=781414&view=diff 
>>
>> ==============================================================================
>>
>> --- ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml
>> (original)
>> +++ ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml Wed
>> Jun  3 14:55:34 2009
>> @@ -470,7 +470,6 @@
>>       <field name="workEffortId" type="id-ne"></field>
>>       <field name="contactMechId" type="id-ne"></field>
>>       <field name="sequenceId" type="id-ne"></field>
>> -      <field name="isPopup" type="indicator"></field>
>>       <field name="reminderDateTime" type="date-time"></field>
>>       <field name="repeatCount" type="numeric"></field>
>>       <field name="repeatInterval" type="numeric">
>>
>> Modified:
>> ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java
>>
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java?rev=781414&r1=781413&r2=781414&view=diff 
>>
>> ==============================================================================
>>
>> ---
>> ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java
>> (original)
>> +++
>> ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java
>> Wed Jun  3 14:55:34 2009
>> @@ -749,17 +749,6 @@
>>         for (GenericValue reminder : eventReminders) {
>>             int repeatCount = reminder.get("repeatCount") == null ? 0
>> : reminder.getLong("repeatCount").intValue();
>>             int currentCount = reminder.get("currentCount") == null ?
>> 0 : reminder.getLong("currentCount").intValue();
>> -            String isPopup = reminder.getString("isPopup");
>> -            if ("Y".equals(isPopup)) {
>> -                if (repeatCount != 0 && repeatCount == currentCount) {
>> -                    try {
>> -                        reminder.remove();
>> -                    } catch (GenericEntityException e) {
>> -                        Debug.logWarning("Error while removing work
>> effort event reminder: " + e, module);
>> -                    }
>> -                }
>> -                continue;
>> -            }
>>             GenericValue workEffort = null;
>>             try {
>>                 workEffort = reminder.getRelatedOne("WorkEffort");
>>
>>
>
>
>