Re: svn commit: r785703 - in /ofbiz/trunk/applications/mark
Locked
Re: svn commit: r785703 - in /ofbiz/trunk/applications/mark
 
|
I am sorry to see that more and more ftl is used.
we agreed to use as less as possible ftl's in the backend, they are difficult to maintain and to extend. Asish, I stopped it in the project manager and it is starting here now again. is this the way we want to go...? not my choice. other opinions? On Wed, 2009-06-17 at 16:21 +0000, [hidden email] wrote: > Author: ashish > Date: Wed Jun 17 16:21:29 2009 > New Revision: 785703 > > URL: http://svn.apache.org/viewvc?rev=785703&view=rev > Log: > Applied patch from jira issue OFBIZ-2622 (Paginations in SFA Screens(Account, Contacts and Leads)) > Thanks Chirag for your contribution on this. > > Added: > ofbiz/trunk/applications/marketing/webapp/sfa/account/ > ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl (with props) > ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl (with props) > ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl (with props) > Modified: > ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml > ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml > ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml > ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml > ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml > > Added: ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl?rev=785703&view=auto > ============================================================================== > --- ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl (added) > +++ ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl Wed Jun 17 16:21:29 2009 > @@ -0,0 +1,76 @@ > +<#-- > +Licensed to the Apache Software Foundation (ASF) under one > +or more contributor license agreements. See the NOTICE file > +distributed with this work for additional information > +regarding copyright ownership. The ASF licenses this file > +to you under the Apache License, Version 2.0 (the > +"License"); you may not use this file except in compliance > +with the License. You may obtain a copy of the License at > + > +http://www.apache.org/licenses/LICENSE-2.0 > + > +Unless required by applicable law or agreed to in writing, > +software distributed under the License is distributed on an > +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > +KIND, either express or implied. See the License for the > +specific language governing permissions and limitations > +under the License. > +--> > + > +<div class="screenlet"> > + <div class="screenlet-title-bar"> > + <ul> > + <#if (partyListSize > 0)> > + <#if (partyListSize > highIndex)> > + <li><a class="nav-next button-col" href="<@ofbizUrl>FindAccounts?VIEW_SIZE=${viewSize}&VIEW_INDEX=${viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">${uiLabelMap.CommonNext}</a></li> > + <#else> > + <li class="disabled button-col">${uiLabelMap.CommonNext}</li> > + </#if> > + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} ${partyListSize}</li> > + <#if (viewIndex > 0)> > + <li><a class="nav-previous button-col" href="<@ofbizUrl>FindAccounts?VIEW_SIZE=${viewSize}&VIEW_INDEX=${viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">${uiLabelMap.CommonPrevious}</a></li> > + <#else> > + <li class="disabled button-col">${uiLabelMap.CommonPrevious}</li> > + </#if> > + </#if> > + </ul> > + </div> > + <div class="screenlet-body"> > + <h2>${uiLabelMap.SfaFindResults}</h2> > + <#if partyList?exists> > + <#if partyList?has_content> > + <table class="basic-table hover-bar" cellspacing="0"> > + <tr class="header-row-2"> > + <td>${uiLabelMap.PartyPartyId}</td> > + <td>${uiLabelMap.PartyName}</td> > + <td>${uiLabelMap.PartyType}</td> > + </tr> > + <#assign alt_row = false> > + <#list partyList as partyRow> > + <#assign partyType = partyRow.getRelatedOne("PartyType")?if_exists> > + <tr valign="middle"<#if alt_row> class="alternate-row"</#if>> > + <td><a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> > + <td> > + <#if partyRow.getModelEntity().isField("groupName") && partyRow.groupName?has_content> > + <a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> > + <#else> > + <#assign partyName = Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, true)> > + <#if partyName?has_content> > + <a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyName}</a> > + <#else> > + (${uiLabelMap.PartyNoNameFound}) > + </#if> > + </#if> > + </td> > + <td><#if partyType.description?exists>${partyType.get("description", locale)}<#else>???</#if></td> > + </tr> > + <#-- toggle the row color --> > + <#assign alt_row = !alt_row> > + </#list> > + </table> > + <#else> > + ${uiLabelMap.PartyNoPartiesFound} > + </#if> > + </#if> > + </div> > +</div> > \ No newline at end of file > > Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl > ------------------------------------------------------------------------------ > svn:eol-style = native > > Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl > ------------------------------------------------------------------------------ > svn:keywords = Date Rev Author URL Id > > Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl > ------------------------------------------------------------------------------ > svn:mime-type = text/plain > > Added: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl?rev=785703&view=auto > ============================================================================== > --- ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl (added) > +++ ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl Wed Jun 17 16:21:29 2009 > @@ -0,0 +1,75 @@ > +<#-- > +Licensed to the Apache Software Foundation (ASF) under one > +or more contributor license agreements. See the NOTICE file > +distributed with this work for additional information > +regarding copyright ownership. The ASF licenses this file > +to you under the Apache License, Version 2.0 (the > +"License"); you may not use this file except in compliance > +with the License. You may obtain a copy of the License at > + > +http://www.apache.org/licenses/LICENSE-2.0 > + > +Unless required by applicable law or agreed to in writing, > +software distributed under the License is distributed on an > +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > +KIND, either express or implied. See the License for the > +specific language governing permissions and limitations > +under the License. > +--> > + > +<div class="screenlet"> > + <div class="screenlet-title-bar"> > + <ul> > + <#if (partyListSize > 0)> > + <#if (partyListSize > highIndex)> > + <li><a class="nav-next button-col" href="<@ofbizUrl>FindContacts?VIEW_SIZE=${viewSize}&VIEW_INDEX=${viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">${uiLabelMap.CommonNext}</a></li> > + <#else> > + <li class="disabled button-col">${uiLabelMap.CommonNext}</li> > + </#if> > + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} ${partyListSize}</li> > + <#if (viewIndex > 0)> > + <li><a class="nav-previous button-col" href="<@ofbizUrl>FindContacts?VIEW_SIZE=${viewSize}&VIEW_INDEX=${viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">${uiLabelMap.CommonPrevious}</a></li> > + <#else> > + <li class="disabled button-col">${uiLabelMap.CommonPrevious}</li> > + </#if> > + </#if> > + </ul> > + </div> > + <div class="screenlet-body"> > + <h2>${uiLabelMap.SfaFindResults}</h2> > + <#if partyList?exists> > + <#if partyList?has_content> > + <table class="basic-table hover-bar" cellspacing="0"> > + <tr class="header-row-2"> > + <td>${uiLabelMap.PartyPartyId}</td> > + <td>${uiLabelMap.PartyName}</td> > + <td>${uiLabelMap.SfaVCard}</td> > + </tr> > + <#assign alt_row = false> > + <#list partyList as partyRow> > + <tr valign="middle"<#if alt_row> class="alternate-row"</#if>> > + <td><a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> > + <td> > + <#if partyRow.getModelEntity().isField("lastName") && lastName?has_content> > + <a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if partyRow.firstName?has_content>, ${partyRow.firstName}</#if></a> > + <#else> > + <#assign partyName = Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, true)> > + <#if partyName?has_content> > + <a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyName}</a> > + <#else> > + (${uiLabelMap.PartyNoNameFound}) > + </#if> > + </#if> > + </td> > + <td><a href="<@ofbizUrl>createVCardFromContact?partyId=${partyRow.partyId}</@ofbizUrl>">${uiLabelMap.SfaVCard}<a></td> > + </tr> > + <#-- toggle the row color --> > + <#assign alt_row = !alt_row> > + </#list> > + </table> > + <#else> > + ${uiLabelMap.PartyNoPartiesFound} > + </#if> > + </#if> > + </div> > +</div> > \ No newline at end of file > > Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl > ------------------------------------------------------------------------------ > svn:eol-style = native > > Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl > ------------------------------------------------------------------------------ > svn:keywords = Date Rev Author URL Id > > Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl > ------------------------------------------------------------------------------ > svn:mime-type = text/plain > > Added: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl?rev=785703&view=auto > ============================================================================== > --- ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl (added) > +++ ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl Wed Jun 17 16:21:29 2009 > @@ -0,0 +1,78 @@ > +<#-- > +Licensed to the Apache Software Foundation (ASF) under one > +or more contributor license agreements. See the NOTICE file > +distributed with this work for additional information > +regarding copyright ownership. The ASF licenses this file > +to you under the Apache License, Version 2.0 (the > +"License"); you may not use this file except in compliance > +with the License. You may obtain a copy of the License at > + > +http://www.apache.org/licenses/LICENSE-2.0 > + > +Unless required by applicable law or agreed to in writing, > +software distributed under the License is distributed on an > +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > +KIND, either express or implied. See the License for the > +specific language governing permissions and limitations > +under the License. > +--> > + > +<div class="screenlet"> > + <div class="screenlet-title-bar"> > + <ul> > + <#if (partyListSize > 0)> > + <#if (partyListSize > highIndex)> > + <li><a class="nav-next button-col" href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=${viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">${uiLabelMap.CommonNext}</a></li> > + <#else> > + <li class="disabled button-col">${uiLabelMap.CommonNext}</li> > + </#if> > + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} ${partyListSize}</li> > + <#if (viewIndex > 0)> > + <li><a class="nav-previous button-col" href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=${viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">${uiLabelMap.CommonPrevious}</a></li> > + <#else> > + <li class="disabled button-col">${uiLabelMap.CommonPrevious}</li> > + </#if> > + </#if> > + </ul> > + </div> > + <div class="screenlet-body"> > + <h2>${uiLabelMap.SfaFindResults}</h2> > + <#if partyList?exists> > + <#if partyList?has_content> > + <table class="basic-table hover-bar" cellspacing="0"> > + <tr class="header-row-2"> > + <td>${uiLabelMap.PartyPartyId}</td> > + <td>${uiLabelMap.PartyName}</td> > + <td>${uiLabelMap.CommonStatus}</td> > + </tr> > + <#assign alt_row = false> > + <#list partyList as partyRow> > + <#assign status = delegator.findOne("StatusItem", {"statusId":partyRow.statusId}, false)?if_exists> > + <tr valign="middle"<#if alt_row> class="alternate-row"</#if>> > + <td><a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> > + <td> > + <#if partyRow.getModelEntity().isField("groupName") && partyRow.groupName?has_content> > + <a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> > + <#elseif partyRow.getModelEntity().isField("lastName") && lastName?has_content> > + <a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if partyRow.firstName?has_content>, ${partyRow.firstName}</#if></a> > + <#else> > + <#assign partyName = Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, true)> > + <#if partyName?has_content> > + <a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyName}</a> > + <#else> > + (${uiLabelMap.PartyNoNameFound}) > + </#if> > + </#if> > + </td> > + <td><#if status.description?exists>${status.get("description", locale)}<#else>???</#if></td> > + </tr> > + <#-- toggle the row color --> > + <#assign alt_row = !alt_row> > + </#list> > + </table> > + <#else> > + ${uiLabelMap.PartyNoPartiesFound} > + </#if> > + </#if> > + </div> > +</div> > \ No newline at end of file > > Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl > ------------------------------------------------------------------------------ > svn:eol-style = native > > Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl > ------------------------------------------------------------------------------ > svn:keywords = Date Rev Author URL Id > > Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl > ------------------------------------------------------------------------------ > svn:mime-type = text/plain > > Modified: ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml?rev=785703&r1=785702&r2=785703&view=diff > ============================================================================== > --- ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml (original) > +++ ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml Wed Jun 17 16:21:29 2009 > @@ -40,32 +40,11 @@ > <section> > <widgets> > <platform-specific> > - <html><html-template location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/></html> > + <html> > + <html-template location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/> > + <html-template location="component://marketing/webapp/sfa/account/ListAccounts.ftl"/> > + </html> > </platform-specific> > - <container style="screenlet"> > - <container style="screenlet-title-bar"> > - <container style="h3"> > - <label text="${uiLabelMap.SfaFindResults}"/> > - </container> > - </container> > - <container style="screenlet-body"> > - <section> > - <condition> > - <not> > - <if-empty field="partyList"/> > - </not> > - </condition> > - <widgets> > - <include-form name="ListAccounts" location="component://marketing/widget/sfa/forms/AccountForms.xml"/> > - </widgets> > - <fail-widgets> > - <container style="h3"> > - <label text="${uiLabelMap.PartyNoPartiesFound}"/> > - </container> > - </fail-widgets> > - </section> > - </container> > - </container> > </widgets> > </section> > </widgets> > > Modified: ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml?rev=785703&r1=785702&r2=785703&view=diff > ============================================================================== > --- ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml (original) > +++ ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml Wed Jun 17 16:21:29 2009 > @@ -37,28 +37,11 @@ > <widgets> > <include-menu name="ContactSubTabBar" location="component://marketing/widget/sfa/SfaMenus.xml"/> > <platform-specific> > - <html><html-template location="component://marketing/webapp/sfa/party/findContactParty.ftl"/></html> > + <html> > + <html-template location="component://marketing/webapp/sfa/party/findContactParty.ftl"/> > + <html-template location="component://marketing/webapp/sfa/contact/ListContacts.ftl"/> > + </html> > </platform-specific> > - <container style="screenlet"> > - <container style="screenlet-title-bar"> > - <container style="h3"><label text="${uiLabelMap.SfaFindResults}"/></container> > - </container> > - <container style="screenlet-body"> > - <section> > - <condition> > - <not><if-empty field="partyList"/></not> > - </condition> > - <widgets> > - <include-form name="ListContacts" location="component://marketing/widget/sfa/forms/ContactForms.xml"/> > - </widgets> > - <fail-widgets> > - <container style="h3"> > - <label text="${uiLabelMap.PartyNoPartiesFound}"/> > - </container> > - </fail-widgets> > - </section> > - </container> > - </container> > </widgets> > </section> > </decorator-section> > > Modified: ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml?rev=785703&r1=785702&r2=785703&view=diff > ============================================================================== > --- ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml (original) > +++ ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml Wed Jun 17 16:21:29 2009 > @@ -37,25 +37,11 @@ > <include-menu name="LeadSubTabBar" location="component://marketing/widget/sfa/SfaMenus.xml"/> > <container style="no-clear"> > <platform-specific> > - <html><html-template location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/></html> > + <html> > + <html-template location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/> > + <html-template location="component://marketing/webapp/sfa/lead/ListLeads.ftl"/> > + </html> > </platform-specific> > - <screenlet title="${uiLabelMap.SfaFindResults}"> > - <section> > - <condition> > - <not> > - <if-empty field="partyList"/> > - </not> > - </condition> > - <widgets> > - <include-form name="ListLeads" location="component://marketing/widget/sfa/forms/LeadForms.xml"/> > - </widgets> > - <fail-widgets> > - <container style="h3"> > - <label text="${uiLabelMap.PartyNoPartiesFound}"/> > - </container> > - </fail-widgets> > - </section> > - </screenlet> > </container> > </widgets> > </section> > > Modified: ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml?rev=785703&r1=785702&r2=785703&view=diff > ============================================================================== > --- ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml (original) > +++ ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml Wed Jun 17 16:21:29 2009 > @@ -21,23 +21,6 @@ > <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd"> > > - <form name="ListAccounts" type="list" list-name="partyList" paginate-target="FindAccount" > - odd-row-style="alternate-row" default-table-style="basic-table hover-bar"> > - <row-actions> > - <entity-one entity-name="PartyGroup" value-field="partyGroup"/> > - </row-actions> > - <field name="partyId" title="${uiLabelMap.PartyPartyId}"> > - <hyperlink target="viewprofile" description="${partyId}" target-type="inter-app"> > - <parameter param-name="partyId"/> > - </hyperlink> > - </field> > - <field name="partyName" title="${uiLabelMap.PartyName}"> > - <hyperlink target="viewprofile" description="${partyGroup.groupName}" target-type="inter-app"> > - <parameter param-name="partyId"/> > - </hyperlink> > - </field> > - <field name="partyTypeId" title="${uiLabelMap.PartyType}"><display-entity entity-name="PartyType"/></field> > - </form> > <form name="NewAccount" type="single" target="createAccount" header-row-style="header-row" default-table-style="basic-table"> > <field name="accountType"><hidden value="${accountType}"/></field> > <field name="groupName" title="${uiLabelMap.PartyGroupName}" tooltip="${uiLabelMap.CommonRequired}" widget-style="required"> > > Modified: ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml?rev=785703&r1=785702&r2=785703&view=diff > ============================================================================== > --- ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml (original) > +++ ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml Wed Jun 17 16:21:29 2009 > @@ -21,27 +21,6 @@ > <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd"> > > - <form name="ListLeads" type="list" list-name="partyList" list-entry-name="partyRow" paginate-target="FindLead" > - odd-row-style="alternate-row" default-table-style="basic-table hover-bar" separate-columns="true"> > - <row-actions> > - <entity-one entity-name="PartyNameView" value-field="partyName"> > - <field-map field-name="partyId" from-field="partyRow.partyId"/> > - </entity-one> > - <set field="statusId" from-field="partyRow.statusId"/> > - </row-actions> > - <field name="partyId" title="${uiLabelMap.PartyPartyId}"> > - <hyperlink target="viewprofile" description="${partyRow.partyId}"> > - <parameter param-name="partyId" from-field="partyRow.partyId"/> > - </hyperlink> > - </field> > - <field name="partyName" title="${uiLabelMap.PartyName}"> > - <hyperlink target="viewprofile" description="${partyName.lastName}${partyName.groupName} ${partyName.firstName} "> > - <parameter param-name="partyId" from-field="partyRow.partyId"/> > - </hyperlink> > - </field> > - <field name="statusId" title="${uiLabelMap.CommonStatus}"><display-entity entity-name="StatusItem" description="${description}" key-field-name="statusId"/></field> > - </form> > - > <form name="createLead" type="single" target="createLead" header-row-style="header-row" default-table-style="basic-table" default-map-name="contactDetailMap"> > <field name="firstName" tooltip="${uiLabelMap.CommonRequired}" widget-style="required"><text/></field> > <field name="lastName" tooltip="${uiLabelMap.CommonRequired}" widget-style="required"><text/></field> > > Antwebsystems.com: Quality OFBiz services for competitive rates |
Re: svn commit: r785703 - in /ofbiz/trunk/applications/mark
Administrator
|
I agree we should avoid FTL as much as possible...
Jacques From: "Hans Bakker" <[hidden email]> >I am sorry to see that more and more ftl is used. > > we agreed to use as less as possible ftl's in the backend, they are > difficult to maintain and to extend. > Asish, I stopped it in the project manager and it is starting here now > again. > > is this the way we want to go...? > > not my choice. > > other opinions? > > > On Wed, 2009-06-17 at 16:21 +0000, [hidden email] wrote: >> Author: ashish >> Date: Wed Jun 17 16:21:29 2009 >> New Revision: 785703 >> >> URL: http://svn.apache.org/viewvc?rev=785703&view=rev >> Log: >> Applied patch from jira issue OFBIZ-2622 (Paginations in SFA Screens(Account, Contacts and Leads)) >> Thanks Chirag for your contribution on this. >> >> Added: >> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >> ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl (with props) >> ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl (with props) >> ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl (with props) >> Modified: >> ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml >> ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml >> ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml >> ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml >> ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml >> >> Added: ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl?rev=785703&view=auto >> ============================================================================== >> --- ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl (added) >> +++ ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl Wed Jun 17 16:21:29 2009 >> @@ -0,0 +1,76 @@ >> +<#-- >> +Licensed to the Apache Software Foundation (ASF) under one >> +or more contributor license agreements. See the NOTICE file >> +distributed with this work for additional information >> +regarding copyright ownership. The ASF licenses this file >> +to you under the Apache License, Version 2.0 (the >> +"License"); you may not use this file except in compliance >> +with the License. You may obtain a copy of the License at >> + >> +http://www.apache.org/licenses/LICENSE-2.0 >> + >> +Unless required by applicable law or agreed to in writing, >> +software distributed under the License is distributed on an >> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >> +KIND, either express or implied. See the License for the >> +specific language governing permissions and limitations >> +under the License. >> +--> >> + >> +<div class="screenlet"> >> + <div class="screenlet-title-bar"> >> + <ul> >> + <#if (partyListSize > 0)> >> + <#if (partyListSize > highIndex)> >> + <li><a class="nav-next button-col" >> href="<@ofbizUrl>FindAccounts?VIEW_SIZE=${viewSize}&VIEW_INDEX=${viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">${uiLabelMap.CommonNext}</a></li> >> + <#else> >> + <li class="disabled button-col">${uiLabelMap.CommonNext}</li> >> + </#if> >> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} ${partyListSize}</li> >> + <#if (viewIndex > 0)> >> + <li><a class="nav-previous button-col" >> href="<@ofbizUrl>FindAccounts?VIEW_SIZE=${viewSize}&VIEW_INDEX=${viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">${uiLabelMap.CommonPrevious}</a></li> >> + <#else> >> + <li class="disabled button-col">${uiLabelMap.CommonPrevious}</li> >> + </#if> >> + </#if> >> + </ul> >> + </div> >> + <div class="screenlet-body"> >> + <h2>${uiLabelMap.SfaFindResults}</h2> >> + <#if partyList?exists> >> + <#if partyList?has_content> >> + <table class="basic-table hover-bar" cellspacing="0"> >> + <tr class="header-row-2"> >> + <td>${uiLabelMap.PartyPartyId}</td> >> + <td>${uiLabelMap.PartyName}</td> >> + <td>${uiLabelMap.PartyType}</td> >> + </tr> >> + <#assign alt_row = false> >> + <#list partyList as partyRow> >> + <#assign partyType = partyRow.getRelatedOne("PartyType")?if_exists> >> + <tr valign="middle"<#if alt_row> class="alternate-row"</#if>> >> + <td><a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >> + <td> >> + <#if partyRow.getModelEntity().isField("groupName") && partyRow.groupName?has_content> >> + <a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> >> + <#else> >> + <#assign partyName = Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, true)> >> + <#if partyName?has_content> >> + <a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyName}</a> >> + <#else> >> + (${uiLabelMap.PartyNoNameFound}) >> + </#if> >> + </#if> >> + </td> >> + <td><#if partyType.description?exists>${partyType.get("description", locale)}<#else>???</#if></td> >> + </tr> >> + <#-- toggle the row color --> >> + <#assign alt_row = !alt_row> >> + </#list> >> + </table> >> + <#else> >> + ${uiLabelMap.PartyNoPartiesFound} >> + </#if> >> + </#if> >> + </div> >> +</div> >> \ No newline at end of file >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl >> ------------------------------------------------------------------------------ >> svn:eol-style = native >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl >> ------------------------------------------------------------------------------ >> svn:keywords = Date Rev Author URL Id >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl >> ------------------------------------------------------------------------------ >> svn:mime-type = text/plain >> >> Added: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl?rev=785703&view=auto >> ============================================================================== >> --- ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl (added) >> +++ ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl Wed Jun 17 16:21:29 2009 >> @@ -0,0 +1,75 @@ >> +<#-- >> +Licensed to the Apache Software Foundation (ASF) under one >> +or more contributor license agreements. See the NOTICE file >> +distributed with this work for additional information >> +regarding copyright ownership. The ASF licenses this file >> +to you under the Apache License, Version 2.0 (the >> +"License"); you may not use this file except in compliance >> +with the License. You may obtain a copy of the License at >> + >> +http://www.apache.org/licenses/LICENSE-2.0 >> + >> +Unless required by applicable law or agreed to in writing, >> +software distributed under the License is distributed on an >> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >> +KIND, either express or implied. See the License for the >> +specific language governing permissions and limitations >> +under the License. >> +--> >> + >> +<div class="screenlet"> >> + <div class="screenlet-title-bar"> >> + <ul> >> + <#if (partyListSize > 0)> >> + <#if (partyListSize > highIndex)> >> + <li><a class="nav-next button-col" >> href="<@ofbizUrl>FindContacts?VIEW_SIZE=${viewSize}&VIEW_INDEX=${viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">${uiLabelMap.CommonNext}</a></li> >> + <#else> >> + <li class="disabled button-col">${uiLabelMap.CommonNext}</li> >> + </#if> >> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} ${partyListSize}</li> >> + <#if (viewIndex > 0)> >> + <li><a class="nav-previous button-col" >> href="<@ofbizUrl>FindContacts?VIEW_SIZE=${viewSize}&VIEW_INDEX=${viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">${uiLabelMap.CommonPrevious}</a></li> >> + <#else> >> + <li class="disabled button-col">${uiLabelMap.CommonPrevious}</li> >> + </#if> >> + </#if> >> + </ul> >> + </div> >> + <div class="screenlet-body"> >> + <h2>${uiLabelMap.SfaFindResults}</h2> >> + <#if partyList?exists> >> + <#if partyList?has_content> >> + <table class="basic-table hover-bar" cellspacing="0"> >> + <tr class="header-row-2"> >> + <td>${uiLabelMap.PartyPartyId}</td> >> + <td>${uiLabelMap.PartyName}</td> >> + <td>${uiLabelMap.SfaVCard}</td> >> + </tr> >> + <#assign alt_row = false> >> + <#list partyList as partyRow> >> + <tr valign="middle"<#if alt_row> class="alternate-row"</#if>> >> + <td><a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >> + <td> >> + <#if partyRow.getModelEntity().isField("lastName") && lastName?has_content> >> + <a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if >> partyRow.firstName?has_content>, ${partyRow.firstName}</#if></a> >> + <#else> >> + <#assign partyName = Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, true)> >> + <#if partyName?has_content> >> + <a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyName}</a> >> + <#else> >> + (${uiLabelMap.PartyNoNameFound}) >> + </#if> >> + </#if> >> + </td> >> + <td><a >> href="<@ofbizUrl>createVCardFromContact?partyId=${partyRow.partyId}</@ofbizUrl>">${uiLabelMap.SfaVCard}<a></td> >> + </tr> >> + <#-- toggle the row color --> >> + <#assign alt_row = !alt_row> >> + </#list> >> + </table> >> + <#else> >> + ${uiLabelMap.PartyNoPartiesFound} >> + </#if> >> + </#if> >> + </div> >> +</div> >> \ No newline at end of file >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl >> ------------------------------------------------------------------------------ >> svn:eol-style = native >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl >> ------------------------------------------------------------------------------ >> svn:keywords = Date Rev Author URL Id >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl >> ------------------------------------------------------------------------------ >> svn:mime-type = text/plain >> >> Added: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl?rev=785703&view=auto >> ============================================================================== >> --- ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl (added) >> +++ ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl Wed Jun 17 16:21:29 2009 >> @@ -0,0 +1,78 @@ >> +<#-- >> +Licensed to the Apache Software Foundation (ASF) under one >> +or more contributor license agreements. See the NOTICE file >> +distributed with this work for additional information >> +regarding copyright ownership. The ASF licenses this file >> +to you under the Apache License, Version 2.0 (the >> +"License"); you may not use this file except in compliance >> +with the License. You may obtain a copy of the License at >> + >> +http://www.apache.org/licenses/LICENSE-2.0 >> + >> +Unless required by applicable law or agreed to in writing, >> +software distributed under the License is distributed on an >> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >> +KIND, either express or implied. See the License for the >> +specific language governing permissions and limitations >> +under the License. >> +--> >> + >> +<div class="screenlet"> >> + <div class="screenlet-title-bar"> >> + <ul> >> + <#if (partyListSize > 0)> >> + <#if (partyListSize > highIndex)> >> + <li><a class="nav-next button-col" >> href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=${viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">${uiLabelMap.CommonNext}</a></li> >> + <#else> >> + <li class="disabled button-col">${uiLabelMap.CommonNext}</li> >> + </#if> >> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} ${partyListSize}</li> >> + <#if (viewIndex > 0)> >> + <li><a class="nav-previous button-col" >> href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=${viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">${uiLabelMap.CommonPrevious}</a></li> >> + <#else> >> + <li class="disabled button-col">${uiLabelMap.CommonPrevious}</li> >> + </#if> >> + </#if> >> + </ul> >> + </div> >> + <div class="screenlet-body"> >> + <h2>${uiLabelMap.SfaFindResults}</h2> >> + <#if partyList?exists> >> + <#if partyList?has_content> >> + <table class="basic-table hover-bar" cellspacing="0"> >> + <tr class="header-row-2"> >> + <td>${uiLabelMap.PartyPartyId}</td> >> + <td>${uiLabelMap.PartyName}</td> >> + <td>${uiLabelMap.CommonStatus}</td> >> + </tr> >> + <#assign alt_row = false> >> + <#list partyList as partyRow> >> + <#assign status = delegator.findOne("StatusItem", {"statusId":partyRow.statusId}, false)?if_exists> >> + <tr valign="middle"<#if alt_row> class="alternate-row"</#if>> >> + <td><a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >> + <td> >> + <#if partyRow.getModelEntity().isField("groupName") && partyRow.groupName?has_content> >> + <a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> >> + <#elseif partyRow.getModelEntity().isField("lastName") && lastName?has_content> >> + <a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if >> partyRow.firstName?has_content>, ${partyRow.firstName}</#if></a> >> + <#else> >> + <#assign partyName = Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, true)> >> + <#if partyName?has_content> >> + <a href="<@ofbizUrl>viewprofile?partyId=${partyRow.partyId}</@ofbizUrl>">${partyName}</a> >> + <#else> >> + (${uiLabelMap.PartyNoNameFound}) >> + </#if> >> + </#if> >> + </td> >> + <td><#if status.description?exists>${status.get("description", locale)}<#else>???</#if></td> >> + </tr> >> + <#-- toggle the row color --> >> + <#assign alt_row = !alt_row> >> + </#list> >> + </table> >> + <#else> >> + ${uiLabelMap.PartyNoPartiesFound} >> + </#if> >> + </#if> >> + </div> >> +</div> >> \ No newline at end of file >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl >> ------------------------------------------------------------------------------ >> svn:eol-style = native >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl >> ------------------------------------------------------------------------------ >> svn:keywords = Date Rev Author URL Id >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl >> ------------------------------------------------------------------------------ >> svn:mime-type = text/plain >> >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >> ============================================================================== >> --- ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml (original) >> +++ ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml Wed Jun 17 16:21:29 2009 >> @@ -40,32 +40,11 @@ >> <section> >> <widgets> >> <platform-specific> >> - <html><html-template >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/></html> >> + <html> >> + <html-template >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/> >> + <html-template >> location="component://marketing/webapp/sfa/account/ListAccounts.ftl"/> >> + </html> >> </platform-specific> >> - <container style="screenlet"> >> - <container style="screenlet-title-bar"> >> - <container style="h3"> >> - <label text="${uiLabelMap.SfaFindResults}"/> >> - </container> >> - </container> >> - <container style="screenlet-body"> >> - <section> >> - <condition> >> - <not> >> - <if-empty field="partyList"/> >> - </not> >> - </condition> >> - <widgets> >> - <include-form name="ListAccounts" >> location="component://marketing/widget/sfa/forms/AccountForms.xml"/> >> - </widgets> >> - <fail-widgets> >> - <container style="h3"> >> - <label text="${uiLabelMap.PartyNoPartiesFound}"/> >> - </container> >> - </fail-widgets> >> - </section> >> - </container> >> - </container> >> </widgets> >> </section> >> </widgets> >> >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >> ============================================================================== >> --- ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml (original) >> +++ ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml Wed Jun 17 16:21:29 2009 >> @@ -37,28 +37,11 @@ >> <widgets> >> <include-menu name="ContactSubTabBar" location="component://marketing/widget/sfa/SfaMenus.xml"/> >> <platform-specific> >> - <html><html-template >> location="component://marketing/webapp/sfa/party/findContactParty.ftl"/></html> >> + <html> >> + <html-template location="component://marketing/webapp/sfa/party/findContactParty.ftl"/> >> + <html-template location="component://marketing/webapp/sfa/contact/ListContacts.ftl"/> >> + </html> >> </platform-specific> >> - <container style="screenlet"> >> - <container style="screenlet-title-bar"> >> - <container style="h3"><label text="${uiLabelMap.SfaFindResults}"/></container> >> - </container> >> - <container style="screenlet-body"> >> - <section> >> - <condition> >> - <not><if-empty field="partyList"/></not> >> - </condition> >> - <widgets> >> - <include-form name="ListContacts" >> location="component://marketing/widget/sfa/forms/ContactForms.xml"/> >> - </widgets> >> - <fail-widgets> >> - <container style="h3"> >> - <label text="${uiLabelMap.PartyNoPartiesFound}"/> >> - </container> >> - </fail-widgets> >> - </section> >> - </container> >> - </container> >> </widgets> >> </section> >> </decorator-section> >> >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >> ============================================================================== >> --- ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml (original) >> +++ ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml Wed Jun 17 16:21:29 2009 >> @@ -37,25 +37,11 @@ >> <include-menu name="LeadSubTabBar" location="component://marketing/widget/sfa/SfaMenus.xml"/> >> <container style="no-clear"> >> <platform-specific> >> - <html><html-template >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/></html> >> + <html> >> + <html-template location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/> >> + <html-template location="component://marketing/webapp/sfa/lead/ListLeads.ftl"/> >> + </html> >> </platform-specific> >> - <screenlet title="${uiLabelMap.SfaFindResults}"> >> - <section> >> - <condition> >> - <not> >> - <if-empty field="partyList"/> >> - </not> >> - </condition> >> - <widgets> >> - <include-form name="ListLeads" >> location="component://marketing/widget/sfa/forms/LeadForms.xml"/> >> - </widgets> >> - <fail-widgets> >> - <container style="h3"> >> - <label text="${uiLabelMap.PartyNoPartiesFound}"/> >> - </container> >> - </fail-widgets> >> - </section> >> - </screenlet> >> </container> >> </widgets> >> </section> >> >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml?rev=785703&r1=785702&r2=785703&view=diff >> ============================================================================== >> --- ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml (original) >> +++ ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml Wed Jun 17 16:21:29 2009 >> @@ -21,23 +21,6 @@ >> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd"> >> >> - <form name="ListAccounts" type="list" list-name="partyList" paginate-target="FindAccount" >> - odd-row-style="alternate-row" default-table-style="basic-table hover-bar"> >> - <row-actions> >> - <entity-one entity-name="PartyGroup" value-field="partyGroup"/> >> - </row-actions> >> - <field name="partyId" title="${uiLabelMap.PartyPartyId}"> >> - <hyperlink target="viewprofile" description="${partyId}" target-type="inter-app"> >> - <parameter param-name="partyId"/> >> - </hyperlink> >> - </field> >> - <field name="partyName" title="${uiLabelMap.PartyName}"> >> - <hyperlink target="viewprofile" description="${partyGroup.groupName}" target-type="inter-app"> >> - <parameter param-name="partyId"/> >> - </hyperlink> >> - </field> >> - <field name="partyTypeId" title="${uiLabelMap.PartyType}"><display-entity entity-name="PartyType"/></field> >> - </form> >> <form name="NewAccount" type="single" target="createAccount" header-row-style="header-row" >> default-table-style="basic-table"> >> <field name="accountType"><hidden value="${accountType}"/></field> >> <field name="groupName" title="${uiLabelMap.PartyGroupName}" tooltip="${uiLabelMap.CommonRequired}" >> widget-style="required"> >> >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml?rev=785703&r1=785702&r2=785703&view=diff >> ============================================================================== >> --- ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml (original) >> +++ ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml Wed Jun 17 16:21:29 2009 >> @@ -21,27 +21,6 @@ >> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd"> >> >> - <form name="ListLeads" type="list" list-name="partyList" list-entry-name="partyRow" paginate-target="FindLead" >> - odd-row-style="alternate-row" default-table-style="basic-table hover-bar" separate-columns="true"> >> - <row-actions> >> - <entity-one entity-name="PartyNameView" value-field="partyName"> >> - <field-map field-name="partyId" from-field="partyRow.partyId"/> >> - </entity-one> >> - <set field="statusId" from-field="partyRow.statusId"/> >> - </row-actions> >> - <field name="partyId" title="${uiLabelMap.PartyPartyId}"> >> - <hyperlink target="viewprofile" description="${partyRow.partyId}"> >> - <parameter param-name="partyId" from-field="partyRow.partyId"/> >> - </hyperlink> >> - </field> >> - <field name="partyName" title="${uiLabelMap.PartyName}"> >> - <hyperlink target="viewprofile" description="${partyName.lastName}${partyName.groupName} ${partyName.firstName} "> >> - <parameter param-name="partyId" from-field="partyRow.partyId"/> >> - </hyperlink> >> - </field> >> - <field name="statusId" title="${uiLabelMap.CommonStatus}"><display-entity entity-name="StatusItem" >> description="${description}" key-field-name="statusId"/></field> >> - </form> >> - >> <form name="createLead" type="single" target="createLead" header-row-style="header-row" default-table-style="basic-table" >> default-map-name="contactDetailMap"> >> <field name="firstName" tooltip="${uiLabelMap.CommonRequired}" widget-style="required"><text/></field> >> <field name="lastName" tooltip="${uiLabelMap.CommonRequired}" widget-style="required"><text/></field> >> >> > -- > Antwebsystems.com: Quality OFBiz services for competitive rates > |
Re: svn commit: r785703 - in /ofbiz/trunk/applications/mark
|
In reply to this post by hans_bakker
Hans,
Ashish is claiming that he used ftl because forms widget based artifact did not do the job. If you (or somebody in community) can help to fix the issue then I agree with you, we should not be using ftls. At the end of day, we write screens so they are usable and not because we love to use form widget over freemarker template, right? Regards Anil Patel On Jun 17, 2009, at 12:46 PM, Hans Bakker wrote: > I am sorry to see that more and more ftl is used. > > we agreed to use as less as possible ftl's in the backend, they are > difficult to maintain and to extend. > Asish, I stopped it in the project manager and it is starting here now > again. > > is this the way we want to go...? > > not my choice. > > other opinions? > > > On Wed, 2009-06-17 at 16:21 +0000, [hidden email] wrote: >> Author: ashish >> Date: Wed Jun 17 16:21:29 2009 >> New Revision: 785703 >> >> URL: http://svn.apache.org/viewvc?rev=785703&view=rev >> Log: >> Applied patch from jira issue OFBIZ-2622 (Paginations in SFA >> Screens(Account, Contacts and Leads)) >> Thanks Chirag for your contribution on this. >> >> Added: >> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >> ListAccounts.ftl (with props) >> ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >> ListContacts.ftl (with props) >> ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >> ListLeads.ftl (with props) >> Modified: >> ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml >> ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml >> ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml >> ofbiz/trunk/applications/marketing/widget/sfa/forms/ >> AccountForms.xml >> ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml >> >> Added: ofbiz/trunk/applications/marketing/webapp/sfa/account/ >> ListAccounts.ftl >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl?rev=785703&view=auto >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/applications/marketing/webapp/sfa/account/ >> ListAccounts.ftl (added) >> +++ ofbiz/trunk/applications/marketing/webapp/sfa/account/ >> ListAccounts.ftl Wed Jun 17 16:21:29 2009 >> @@ -0,0 +1,76 @@ >> +<#-- >> +Licensed to the Apache Software Foundation (ASF) under one >> +or more contributor license agreements. See the NOTICE file >> +distributed with this work for additional information >> +regarding copyright ownership. The ASF licenses this file >> +to you under the Apache License, Version 2.0 (the >> +"License"); you may not use this file except in compliance >> +with the License. You may obtain a copy of the License at >> + >> +http://www.apache.org/licenses/LICENSE-2.0 >> + >> +Unless required by applicable law or agreed to in writing, >> +software distributed under the License is distributed on an >> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >> +KIND, either express or implied. See the License for the >> +specific language governing permissions and limitations >> +under the License. >> +--> >> + >> +<div class="screenlet"> >> + <div class="screenlet-title-bar"> >> + <ul> >> + <#if (partyListSize > 0)> >> + <#if (partyListSize > highIndex)> >> + <li><a class="nav-next button-col" >> href="<@ofbizUrl>FindAccounts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ >> {uiLabelMap.CommonNext}</a></li> >> + <#else> >> + <li class="disabled button-col">$ >> {uiLabelMap.CommonNext}</li> >> + </#if> >> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} $ >> {partyListSize}</li> >> + <#if (viewIndex > 0)> >> + <li><a class="nav-previous button-col" >> href="<@ofbizUrl>FindAccounts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ >> {uiLabelMap.CommonPrevious}</a></li> >> + <#else> >> + <li class="disabled button-col">$ >> {uiLabelMap.CommonPrevious}</li> >> + </#if> >> + </#if> >> + </ul> >> + </div> >> + <div class="screenlet-body"> >> + <h2>${uiLabelMap.SfaFindResults}</h2> >> + <#if partyList?exists> >> + <#if partyList?has_content> >> + <table class="basic-table hover-bar" cellspacing="0"> >> + <tr class="header-row-2"> >> + <td>${uiLabelMap.PartyPartyId}</td> >> + <td>${uiLabelMap.PartyName}</td> >> + <td>${uiLabelMap.PartyType}</td> >> + </tr> >> + <#assign alt_row = false> >> + <#list partyList as partyRow> >> + <#assign partyType = >> partyRow.getRelatedOne("PartyType")?if_exists> >> + <tr valign="middle"<#if alt_row> class="alternate- >> row"</#if>> >> + <td><a href="<@ofbizUrl>viewprofile?partyId=$ >> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >> + <td> >> + <#if >> partyRow.getModelEntity().isField("groupName") && >> partyRow.groupName?has_content> >> + <a href="<@ofbizUrl>viewprofile?partyId=$ >> {partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> >> + <#else> >> + <#assign partyName = >> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, >> true)> >> + <#if partyName?has_content> >> + <a href="<@ofbizUrl>viewprofile?partyId=$ >> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> >> + <#else> >> + (${uiLabelMap.PartyNoNameFound}) >> + </#if> >> + </#if> >> + </td> >> + <td><#if partyType.description?exists>$ >> {partyType.get("description", locale)}<#else>???</#if></td> >> + </tr> >> + <#-- toggle the row color --> >> + <#assign alt_row = !alt_row> >> + </#list> >> + </table> >> + <#else> >> + ${uiLabelMap.PartyNoPartiesFound} >> + </#if> >> + </#if> >> + </div> >> +</div> >> \ No newline at end of file >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ >> ListAccounts.ftl >> ------------------------------------------------------------------------------ >> svn:eol-style = native >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ >> ListAccounts.ftl >> ------------------------------------------------------------------------------ >> svn:keywords = Date Rev Author URL Id >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ >> ListAccounts.ftl >> ------------------------------------------------------------------------------ >> svn:mime-type = text/plain >> >> Added: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >> ListContacts.ftl >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl?rev=785703&view=auto >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >> ListContacts.ftl (added) >> +++ ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >> ListContacts.ftl Wed Jun 17 16:21:29 2009 >> @@ -0,0 +1,75 @@ >> +<#-- >> +Licensed to the Apache Software Foundation (ASF) under one >> +or more contributor license agreements. See the NOTICE file >> +distributed with this work for additional information >> +regarding copyright ownership. The ASF licenses this file >> +to you under the Apache License, Version 2.0 (the >> +"License"); you may not use this file except in compliance >> +with the License. You may obtain a copy of the License at >> + >> +http://www.apache.org/licenses/LICENSE-2.0 >> + >> +Unless required by applicable law or agreed to in writing, >> +software distributed under the License is distributed on an >> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >> +KIND, either express or implied. See the License for the >> +specific language governing permissions and limitations >> +under the License. >> +--> >> + >> +<div class="screenlet"> >> + <div class="screenlet-title-bar"> >> + <ul> >> + <#if (partyListSize > 0)> >> + <#if (partyListSize > highIndex)> >> + <li><a class="nav-next button-col" >> href="<@ofbizUrl>FindContacts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ >> {uiLabelMap.CommonNext}</a></li> >> + <#else> >> + <li class="disabled button-col">$ >> {uiLabelMap.CommonNext}</li> >> + </#if> >> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} $ >> {partyListSize}</li> >> + <#if (viewIndex > 0)> >> + <li><a class="nav-previous button-col" >> href="<@ofbizUrl>FindContacts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ >> {uiLabelMap.CommonPrevious}</a></li> >> + <#else> >> + <li class="disabled button-col">$ >> {uiLabelMap.CommonPrevious}</li> >> + </#if> >> + </#if> >> + </ul> >> + </div> >> + <div class="screenlet-body"> >> + <h2>${uiLabelMap.SfaFindResults}</h2> >> + <#if partyList?exists> >> + <#if partyList?has_content> >> + <table class="basic-table hover-bar" cellspacing="0"> >> + <tr class="header-row-2"> >> + <td>${uiLabelMap.PartyPartyId}</td> >> + <td>${uiLabelMap.PartyName}</td> >> + <td>${uiLabelMap.SfaVCard}</td> >> + </tr> >> + <#assign alt_row = false> >> + <#list partyList as partyRow> >> + <tr valign="middle"<#if alt_row> class="alternate- >> row"</#if>> >> + <td><a href="<@ofbizUrl>viewprofile?partyId=$ >> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >> + <td> >> + <#if partyRow.getModelEntity().isField("lastName") >> && lastName?has_content> >> + <a href="<@ofbizUrl>viewprofile?partyId=$ >> {partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if >> partyRow.firstName?has_content>, ${partyRow.firstName}</#if></a> >> + <#else> >> + <#assign partyName = >> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, >> true)> >> + <#if partyName?has_content> >> + <a href="<@ofbizUrl>viewprofile?partyId=$ >> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> >> + <#else> >> + (${uiLabelMap.PartyNoNameFound}) >> + </#if> >> + </#if> >> + </td> >> + <td><a href="<@ofbizUrl>createVCardFromContact? >> partyId=${partyRow.partyId}</@ofbizUrl>">${uiLabelMap.SfaVCard}<a></ >> td> >> + </tr> >> + <#-- toggle the row color --> >> + <#assign alt_row = !alt_row> >> + </#list> >> + </table> >> + <#else> >> + ${uiLabelMap.PartyNoPartiesFound} >> + </#if> >> + </#if> >> + </div> >> +</div> >> \ No newline at end of file >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >> ListContacts.ftl >> ------------------------------------------------------------------------------ >> svn:eol-style = native >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >> ListContacts.ftl >> ------------------------------------------------------------------------------ >> svn:keywords = Date Rev Author URL Id >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >> ListContacts.ftl >> ------------------------------------------------------------------------------ >> svn:mime-type = text/plain >> >> Added: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >> ListLeads.ftl >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl?rev=785703&view=auto >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >> ListLeads.ftl (added) >> +++ ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >> ListLeads.ftl Wed Jun 17 16:21:29 2009 >> @@ -0,0 +1,78 @@ >> +<#-- >> +Licensed to the Apache Software Foundation (ASF) under one >> +or more contributor license agreements. See the NOTICE file >> +distributed with this work for additional information >> +regarding copyright ownership. The ASF licenses this file >> +to you under the Apache License, Version 2.0 (the >> +"License"); you may not use this file except in compliance >> +with the License. You may obtain a copy of the License at >> + >> +http://www.apache.org/licenses/LICENSE-2.0 >> + >> +Unless required by applicable law or agreed to in writing, >> +software distributed under the License is distributed on an >> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >> +KIND, either express or implied. See the License for the >> +specific language governing permissions and limitations >> +under the License. >> +--> >> + >> +<div class="screenlet"> >> + <div class="screenlet-title-bar"> >> + <ul> >> + <#if (partyListSize > 0)> >> + <#if (partyListSize > highIndex)> >> + <li><a class="nav-next button-col" >> href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ >> {uiLabelMap.CommonNext}</a></li> >> + <#else> >> + <li class="disabled button-col">$ >> {uiLabelMap.CommonNext}</li> >> + </#if> >> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} $ >> {partyListSize}</li> >> + <#if (viewIndex > 0)> >> + <li><a class="nav-previous button-col" >> href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ >> {uiLabelMap.CommonPrevious}</a></li> >> + <#else> >> + <li class="disabled button-col">$ >> {uiLabelMap.CommonPrevious}</li> >> + </#if> >> + </#if> >> + </ul> >> + </div> >> + <div class="screenlet-body"> >> + <h2>${uiLabelMap.SfaFindResults}</h2> >> + <#if partyList?exists> >> + <#if partyList?has_content> >> + <table class="basic-table hover-bar" cellspacing="0"> >> + <tr class="header-row-2"> >> + <td>${uiLabelMap.PartyPartyId}</td> >> + <td>${uiLabelMap.PartyName}</td> >> + <td>${uiLabelMap.CommonStatus}</td> >> + </tr> >> + <#assign alt_row = false> >> + <#list partyList as partyRow> >> + <#assign status = delegator.findOne("StatusItem", >> {"statusId":partyRow.statusId}, false)?if_exists> >> + <tr valign="middle"<#if alt_row> class="alternate- >> row"</#if>> >> + <td><a href="<@ofbizUrl>viewprofile?partyId=$ >> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >> + <td> >> + <#if >> partyRow.getModelEntity().isField("groupName") && >> partyRow.groupName?has_content> >> + <a href="<@ofbizUrl>viewprofile?partyId=$ >> {partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> >> + <#elseif >> partyRow.getModelEntity().isField("lastName") && lastName? >> has_content> >> + <a href="<@ofbizUrl>viewprofile?partyId=$ >> {partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if >> partyRow.firstName?has_content>, ${partyRow.firstName}</#if></a> >> + <#else> >> + <#assign partyName = >> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, >> true)> >> + <#if partyName?has_content> >> + <a href="<@ofbizUrl>viewprofile?partyId=$ >> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> >> + <#else> >> + (${uiLabelMap.PartyNoNameFound}) >> + </#if> >> + </#if> >> + </td> >> + <td><#if status.description?exists>$ >> {status.get("description", locale)}<#else>???</#if></td> >> + </tr> >> + <#-- toggle the row color --> >> + <#assign alt_row = !alt_row> >> + </#list> >> + </table> >> + <#else> >> + ${uiLabelMap.PartyNoPartiesFound} >> + </#if> >> + </#if> >> + </div> >> +</div> >> \ No newline at end of file >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >> ListLeads.ftl >> ------------------------------------------------------------------------------ >> svn:eol-style = native >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >> ListLeads.ftl >> ------------------------------------------------------------------------------ >> svn:keywords = Date Rev Author URL Id >> >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >> ListLeads.ftl >> ------------------------------------------------------------------------------ >> svn:mime-type = text/plain >> >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/ >> AccountScreens.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/applications/marketing/widget/sfa/ >> AccountScreens.xml (original) >> +++ ofbiz/trunk/applications/marketing/widget/sfa/ >> AccountScreens.xml Wed Jun 17 16:21:29 2009 >> @@ -40,32 +40,11 @@ >> <section> >> <widgets> >> <platform-specific> >> - <html><html-template >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/ >> ></html> >> + <html> >> + <html-template >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/> >> + <html-template >> location="component://marketing/webapp/sfa/account/ >> ListAccounts.ftl"/> >> + </html> >> </platform-specific> >> - <container >> style="screenlet"> >> - <container >> style="screenlet-title-bar"> >> - <container >> style="h3"> >> - <label text="$ >> {uiLabelMap.SfaFindResults}"/> >> - </container> >> - </container> >> - <container >> style="screenlet-body"> >> - <section> >> - <condition> >> - <not> >> - <if- >> empty field="partyList"/> >> - </not> >> - </condition> >> - <widgets> >> - <include- >> form name="ListAccounts" location="component://marketing/widget/sfa/ >> forms/AccountForms.xml"/> >> - </widgets> >> - <fail-widgets> >> - <container >> style="h3"> >> - <label >> text="${uiLabelMap.PartyNoPartiesFound}"/> >> - </container> >> - </fail-widgets> >> - </section> >> - </container> >> - </container> >> </widgets> >> </section> >> </widgets> >> >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/ >> ContactScreens.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/applications/marketing/widget/sfa/ >> ContactScreens.xml (original) >> +++ ofbiz/trunk/applications/marketing/widget/sfa/ >> ContactScreens.xml Wed Jun 17 16:21:29 2009 >> @@ -37,28 +37,11 @@ >> <widgets> >> <include-menu >> name="ContactSubTabBar" location="component://marketing/widget/sfa/ >> SfaMenus.xml"/> >> <platform-specific> >> - <html><html-template >> location="component://marketing/webapp/sfa/party/ >> findContactParty.ftl"/></html> >> + <html> >> + <html-template >> location="component://marketing/webapp/sfa/party/ >> findContactParty.ftl"/> >> + <html-template >> location="component://marketing/webapp/sfa/contact/ >> ListContacts.ftl"/> >> + </html> >> </platform-specific> >> - <container style="screenlet"> >> - <container style="screenlet- >> title-bar"> >> - <container >> style="h3"><label text="${uiLabelMap.SfaFindResults}"/></container> >> - </container> >> - <container style="screenlet- >> body"> >> - <section> >> - <condition> >> - <not><if-empty >> field="partyList"/></not> >> - </condition> >> - <widgets> >> - <include-form >> name="ListContacts" location="component://marketing/widget/sfa/ >> forms/ContactForms.xml"/> >> - </widgets> >> - <fail-widgets> >> - <container >> style="h3"> >> - <label text="$ >> {uiLabelMap.PartyNoPartiesFound}"/> >> - </container> >> - </fail-widgets> >> - </section> >> - </container> >> - </container> >> </widgets> >> </section> >> </decorator-section> >> >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/ >> LeadScreens.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml >> (original) >> +++ ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml >> Wed Jun 17 16:21:29 2009 >> @@ -37,25 +37,11 @@ >> <include-menu name="LeadSubTabBar" >> location="component://marketing/widget/sfa/SfaMenus.xml"/> >> <container style="no-clear"> >> <platform-specific> >> - <html><html-template >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/ >> ></html> >> + <html> >> + <html-template >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/> >> + <html-template >> location="component://marketing/webapp/sfa/lead/ListLeads.ftl"/> >> + </html> >> </platform-specific> >> - <screenlet title="$ >> {uiLabelMap.SfaFindResults}"> >> - <section> >> - <condition> >> - <not> >> - <if-empty >> field="partyList"/> >> - </not> >> - </condition> >> - <widgets> >> - <include-form >> name="ListLeads" location="component://marketing/widget/sfa/forms/ >> LeadForms.xml"/> >> - </widgets> >> - <fail-widgets> >> - <container >> style="h3"> >> - <label text="$ >> {uiLabelMap.PartyNoPartiesFound}"/> >> - </container> >> - </fail-widgets> >> - </section> >> - </screenlet> >> </container> >> </widgets> >> </section> >> >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/forms/ >> AccountForms.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml?rev=785703&r1=785702&r2=785703&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/applications/marketing/widget/sfa/forms/ >> AccountForms.xml (original) >> +++ ofbiz/trunk/applications/marketing/widget/sfa/forms/ >> AccountForms.xml Wed Jun 17 16:21:29 2009 >> @@ -21,23 +21,6 @@ >> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd >> "> >> >> - <form name="ListAccounts" type="list" list-name="partyList" >> paginate-target="FindAccount" >> - odd-row-style="alternate-row" default-table-style="basic- >> table hover-bar"> >> - <row-actions> >> - <entity-one entity-name="PartyGroup" value- >> field="partyGroup"/> >> - </row-actions> >> - <field name="partyId" title="${uiLabelMap.PartyPartyId}"> >> - <hyperlink target="viewprofile" description="$ >> {partyId}" target-type="inter-app"> >> - <parameter param-name="partyId"/> >> - </hyperlink> >> - </field> >> - <field name="partyName" title="${uiLabelMap.PartyName}"> >> - <hyperlink target="viewprofile" description="$ >> {partyGroup.groupName}" target-type="inter-app"> >> - <parameter param-name="partyId"/> >> - </hyperlink> >> - </field> >> - <field name="partyTypeId" title="$ >> {uiLabelMap.PartyType}"><display-entity entity-name="PartyType"/></ >> field> >> - </form> >> <form name="NewAccount" type="single" target="createAccount" >> header-row-style="header-row" default-table-style="basic-table"> >> <field name="accountType"><hidden value="${accountType}"/></ >> field> >> <field name="groupName" title="$ >> {uiLabelMap.PartyGroupName}" tooltip="${uiLabelMap.CommonRequired}" >> widget-style="required"> >> >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/forms/ >> LeadForms.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml?rev=785703&r1=785702&r2=785703&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/applications/marketing/widget/sfa/forms/ >> LeadForms.xml (original) >> +++ ofbiz/trunk/applications/marketing/widget/sfa/forms/ >> LeadForms.xml Wed Jun 17 16:21:29 2009 >> @@ -21,27 +21,6 @@ >> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd >> "> >> >> - <form name="ListLeads" type="list" list-name="partyList" list- >> entry-name="partyRow" paginate-target="FindLead" >> - odd-row-style="alternate-row" default-table-style="basic- >> table hover-bar" separate-columns="true"> >> - <row-actions> >> - <entity-one entity-name="PartyNameView" value- >> field="partyName"> >> - <field-map field-name="partyId" from- >> field="partyRow.partyId"/> >> - </entity-one> >> - <set field="statusId" from-field="partyRow.statusId"/> >> - </row-actions> >> - <field name="partyId" title="${uiLabelMap.PartyPartyId}"> >> - <hyperlink target="viewprofile" description="$ >> {partyRow.partyId}"> >> - <parameter param-name="partyId" from- >> field="partyRow.partyId"/> >> - </hyperlink> >> - </field> >> - <field name="partyName" title="${uiLabelMap.PartyName}"> >> - <hyperlink target="viewprofile" description="$ >> {partyName.lastName}${partyName.groupName} ${partyName.firstName} "> >> - <parameter param-name="partyId" from- >> field="partyRow.partyId"/> >> - </hyperlink> >> - </field> >> - <field name="statusId" title="$ >> {uiLabelMap.CommonStatus}"><display-entity entity-name="StatusItem" >> description="${description}" key-field-name="statusId"/></field> >> - </form> >> - >> <form name="createLead" type="single" target="createLead" >> header-row-style="header-row" default-table-style="basic-table" >> default-map-name="contactDetailMap"> >> <field name="firstName" tooltip="$ >> {uiLabelMap.CommonRequired}" widget-style="required"><text/></field> >> <field name="lastName" tooltip="$ >> {uiLabelMap.CommonRequired}" widget-style="required"><text/></field> >> >> > -- > Antwebsystems.com: Quality OFBiz services for competitive rates > |
Re: svn commit: r785703 - in /ofbiz/trunk/applications/mark
|
|
Hi Anil,
you write: > Ashish is claiming that he used ftl because forms widget based > artifact did not do the job. Then i would like to know why forms did not do the job. i am wondering anyway why the sfa application does not use the standard performfind for contacts/leads/accounts as now most of the applications use and is using the old findParty service which was created way before performFind existed. If you would use the PartyAndContactMech view with perform find, then the same search can be created as exist now with findParty. contact/lead/account can be the same screens, only the role selection is different. If we would have that, extra search fields can then be easily added what is now pretty difficult. This change replaces forms with ftl's and, i am sorry to ask, is that acceptable? Regards, Hans On Wed, 2009-06-17 at 22:41 -0400, Anil Patel wrote: > Hans, > Ashish is claiming that he used ftl because forms widget based > artifact did not do the job. If you (or somebody in community) can > help to fix the issue then I agree with you, we should not be using > ftls. At the end of day, we write screens so they are usable and not > because we love to use form widget over freemarker template, right? > > Regards > Anil Patel > > > > On Jun 17, 2009, at 12:46 PM, Hans Bakker wrote: > > > I am sorry to see that more and more ftl is used. > > > > we agreed to use as less as possible ftl's in the backend, they are > > difficult to maintain and to extend. > > Asish, I stopped it in the project manager and it is starting here now > > again. > > > > is this the way we want to go...? > > > > not my choice. > > > > other opinions? > > > > > > On Wed, 2009-06-17 at 16:21 +0000, [hidden email] wrote: > >> Author: ashish > >> Date: Wed Jun 17 16:21:29 2009 > >> New Revision: 785703 > >> > >> URL: http://svn.apache.org/viewvc?rev=785703&view=rev > >> Log: > >> Applied patch from jira issue OFBIZ-2622 (Paginations in SFA > >> Screens(Account, Contacts and Leads)) > >> Thanks Chirag for your contribution on this. > >> > >> Added: > >> ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >> ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >> ListAccounts.ftl (with props) > >> ofbiz/trunk/applications/marketing/webapp/sfa/contact/ > >> ListContacts.ftl (with props) > >> ofbiz/trunk/applications/marketing/webapp/sfa/lead/ > >> ListLeads.ftl (with props) > >> Modified: > >> ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml > >> ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml > >> ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml > >> ofbiz/trunk/applications/marketing/widget/sfa/forms/ > >> AccountForms.xml > >> ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml > >> > >> Added: ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >> ListAccounts.ftl > >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl?rev=785703&view=auto > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> ===================================================================== > >> --- ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >> ListAccounts.ftl (added) > >> +++ ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >> ListAccounts.ftl Wed Jun 17 16:21:29 2009 > >> @@ -0,0 +1,76 @@ > >> +<#-- > >> +Licensed to the Apache Software Foundation (ASF) under one > >> +or more contributor license agreements. See the NOTICE file > >> +distributed with this work for additional information > >> +regarding copyright ownership. The ASF licenses this file > >> +to you under the Apache License, Version 2.0 (the > >> +"License"); you may not use this file except in compliance > >> +with the License. You may obtain a copy of the License at > >> + > >> +http://www.apache.org/licenses/LICENSE-2.0 > >> + > >> +Unless required by applicable law or agreed to in writing, > >> +software distributed under the License is distributed on an > >> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > >> +KIND, either express or implied. See the License for the > >> +specific language governing permissions and limitations > >> +under the License. > >> +--> > >> + > >> +<div class="screenlet"> > >> + <div class="screenlet-title-bar"> > >> + <ul> > >> + <#if (partyListSize > 0)> > >> + <#if (partyListSize > highIndex)> > >> + <li><a class="nav-next button-col" > >> href="<@ofbizUrl>FindAccounts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ > >> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ > >> {uiLabelMap.CommonNext}</a></li> > >> + <#else> > >> + <li class="disabled button-col">$ > >> {uiLabelMap.CommonNext}</li> > >> + </#if> > >> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} $ > >> {partyListSize}</li> > >> + <#if (viewIndex > 0)> > >> + <li><a class="nav-previous button-col" > >> href="<@ofbizUrl>FindAccounts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ > >> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ > >> {uiLabelMap.CommonPrevious}</a></li> > >> + <#else> > >> + <li class="disabled button-col">$ > >> {uiLabelMap.CommonPrevious}</li> > >> + </#if> > >> + </#if> > >> + </ul> > >> + </div> > >> + <div class="screenlet-body"> > >> + <h2>${uiLabelMap.SfaFindResults}</h2> > >> + <#if partyList?exists> > >> + <#if partyList?has_content> > >> + <table class="basic-table hover-bar" cellspacing="0"> > >> + <tr class="header-row-2"> > >> + <td>${uiLabelMap.PartyPartyId}</td> > >> + <td>${uiLabelMap.PartyName}</td> > >> + <td>${uiLabelMap.PartyType}</td> > >> + </tr> > >> + <#assign alt_row = false> > >> + <#list partyList as partyRow> > >> + <#assign partyType = > >> partyRow.getRelatedOne("PartyType")?if_exists> > >> + <tr valign="middle"<#if alt_row> class="alternate- > >> row"</#if>> > >> + <td><a href="<@ofbizUrl>viewprofile?partyId=$ > >> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> > >> + <td> > >> + <#if > >> partyRow.getModelEntity().isField("groupName") && > >> partyRow.groupName?has_content> > >> + <a href="<@ofbizUrl>viewprofile?partyId=$ > >> {partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> > >> + <#else> > >> + <#assign partyName = > >> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, > >> true)> > >> + <#if partyName?has_content> > >> + <a href="<@ofbizUrl>viewprofile?partyId=$ > >> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> > >> + <#else> > >> + (${uiLabelMap.PartyNoNameFound}) > >> + </#if> > >> + </#if> > >> + </td> > >> + <td><#if partyType.description?exists>$ > >> {partyType.get("description", locale)}<#else>???</#if></td> > >> + </tr> > >> + <#-- toggle the row color --> > >> + <#assign alt_row = !alt_row> > >> + </#list> > >> + </table> > >> + <#else> > >> + ${uiLabelMap.PartyNoPartiesFound} > >> + </#if> > >> + </#if> > >> + </div> > >> +</div> > >> \ No newline at end of file > >> > >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >> ListAccounts.ftl > >> ------------------------------------------------------------------------------ > >> svn:eol-style = native > >> > >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >> ListAccounts.ftl > >> ------------------------------------------------------------------------------ > >> svn:keywords = Date Rev Author URL Id > >> > >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >> ListAccounts.ftl > >> ------------------------------------------------------------------------------ > >> svn:mime-type = text/plain > >> > >> Added: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ > >> ListContacts.ftl > >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl?rev=785703&view=auto > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> ===================================================================== > >> --- ofbiz/trunk/applications/marketing/webapp/sfa/contact/ > >> ListContacts.ftl (added) > >> +++ ofbiz/trunk/applications/marketing/webapp/sfa/contact/ > >> ListContacts.ftl Wed Jun 17 16:21:29 2009 > >> @@ -0,0 +1,75 @@ > >> +<#-- > >> +Licensed to the Apache Software Foundation (ASF) under one > >> +or more contributor license agreements. See the NOTICE file > >> +distributed with this work for additional information > >> +regarding copyright ownership. The ASF licenses this file > >> +to you under the Apache License, Version 2.0 (the > >> +"License"); you may not use this file except in compliance > >> +with the License. You may obtain a copy of the License at > >> + > >> +http://www.apache.org/licenses/LICENSE-2.0 > >> + > >> +Unless required by applicable law or agreed to in writing, > >> +software distributed under the License is distributed on an > >> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > >> +KIND, either express or implied. See the License for the > >> +specific language governing permissions and limitations > >> +under the License. > >> +--> > >> + > >> +<div class="screenlet"> > >> + <div class="screenlet-title-bar"> > >> + <ul> > >> + <#if (partyListSize > 0)> > >> + <#if (partyListSize > highIndex)> > >> + <li><a class="nav-next button-col" > >> href="<@ofbizUrl>FindContacts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ > >> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ > >> {uiLabelMap.CommonNext}</a></li> > >> + <#else> > >> + <li class="disabled button-col">$ > >> {uiLabelMap.CommonNext}</li> > >> + </#if> > >> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} $ > >> {partyListSize}</li> > >> + <#if (viewIndex > 0)> > >> + <li><a class="nav-previous button-col" > >> href="<@ofbizUrl>FindContacts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ > >> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ > >> {uiLabelMap.CommonPrevious}</a></li> > >> + <#else> > >> + <li class="disabled button-col">$ > >> {uiLabelMap.CommonPrevious}</li> > >> + </#if> > >> + </#if> > >> + </ul> > >> + </div> > >> + <div class="screenlet-body"> > >> + <h2>${uiLabelMap.SfaFindResults}</h2> > >> + <#if partyList?exists> > >> + <#if partyList?has_content> > >> + <table class="basic-table hover-bar" cellspacing="0"> > >> + <tr class="header-row-2"> > >> + <td>${uiLabelMap.PartyPartyId}</td> > >> + <td>${uiLabelMap.PartyName}</td> > >> + <td>${uiLabelMap.SfaVCard}</td> > >> + </tr> > >> + <#assign alt_row = false> > >> + <#list partyList as partyRow> > >> + <tr valign="middle"<#if alt_row> class="alternate- > >> row"</#if>> > >> + <td><a href="<@ofbizUrl>viewprofile?partyId=$ > >> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> > >> + <td> > >> + <#if partyRow.getModelEntity().isField("lastName") > >> && lastName?has_content> > >> + <a href="<@ofbizUrl>viewprofile?partyId=$ > >> {partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if > >> partyRow.firstName?has_content>, ${partyRow.firstName}</#if></a> > >> + <#else> > >> + <#assign partyName = > >> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, > >> true)> > >> + <#if partyName?has_content> > >> + <a href="<@ofbizUrl>viewprofile?partyId=$ > >> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> > >> + <#else> > >> + (${uiLabelMap.PartyNoNameFound}) > >> + </#if> > >> + </#if> > >> + </td> > >> + <td><a href="<@ofbizUrl>createVCardFromContact? > >> partyId=${partyRow.partyId}</@ofbizUrl>">${uiLabelMap.SfaVCard}<a></ > >> td> > >> + </tr> > >> + <#-- toggle the row color --> > >> + <#assign alt_row = !alt_row> > >> + </#list> > >> + </table> > >> + <#else> > >> + ${uiLabelMap.PartyNoPartiesFound} > >> + </#if> > >> + </#if> > >> + </div> > >> +</div> > >> \ No newline at end of file > >> > >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ > >> ListContacts.ftl > >> ------------------------------------------------------------------------------ > >> svn:eol-style = native > >> > >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ > >> ListContacts.ftl > >> ------------------------------------------------------------------------------ > >> svn:keywords = Date Rev Author URL Id > >> > >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ > >> ListContacts.ftl > >> ------------------------------------------------------------------------------ > >> svn:mime-type = text/plain > >> > >> Added: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ > >> ListLeads.ftl > >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl?rev=785703&view=auto > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> ===================================================================== > >> --- ofbiz/trunk/applications/marketing/webapp/sfa/lead/ > >> ListLeads.ftl (added) > >> +++ ofbiz/trunk/applications/marketing/webapp/sfa/lead/ > >> ListLeads.ftl Wed Jun 17 16:21:29 2009 > >> @@ -0,0 +1,78 @@ > >> +<#-- > >> +Licensed to the Apache Software Foundation (ASF) under one > >> +or more contributor license agreements. See the NOTICE file > >> +distributed with this work for additional information > >> +regarding copyright ownership. The ASF licenses this file > >> +to you under the Apache License, Version 2.0 (the > >> +"License"); you may not use this file except in compliance > >> +with the License. You may obtain a copy of the License at > >> + > >> +http://www.apache.org/licenses/LICENSE-2.0 > >> + > >> +Unless required by applicable law or agreed to in writing, > >> +software distributed under the License is distributed on an > >> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > >> +KIND, either express or implied. See the License for the > >> +specific language governing permissions and limitations > >> +under the License. > >> +--> > >> + > >> +<div class="screenlet"> > >> + <div class="screenlet-title-bar"> > >> + <ul> > >> + <#if (partyListSize > 0)> > >> + <#if (partyListSize > highIndex)> > >> + <li><a class="nav-next button-col" > >> href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ > >> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ > >> {uiLabelMap.CommonNext}</a></li> > >> + <#else> > >> + <li class="disabled button-col">$ > >> {uiLabelMap.CommonNext}</li> > >> + </#if> > >> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} $ > >> {partyListSize}</li> > >> + <#if (viewIndex > 0)> > >> + <li><a class="nav-previous button-col" > >> href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ > >> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ > >> {uiLabelMap.CommonPrevious}</a></li> > >> + <#else> > >> + <li class="disabled button-col">$ > >> {uiLabelMap.CommonPrevious}</li> > >> + </#if> > >> + </#if> > >> + </ul> > >> + </div> > >> + <div class="screenlet-body"> > >> + <h2>${uiLabelMap.SfaFindResults}</h2> > >> + <#if partyList?exists> > >> + <#if partyList?has_content> > >> + <table class="basic-table hover-bar" cellspacing="0"> > >> + <tr class="header-row-2"> > >> + <td>${uiLabelMap.PartyPartyId}</td> > >> + <td>${uiLabelMap.PartyName}</td> > >> + <td>${uiLabelMap.CommonStatus}</td> > >> + </tr> > >> + <#assign alt_row = false> > >> + <#list partyList as partyRow> > >> + <#assign status = delegator.findOne("StatusItem", > >> {"statusId":partyRow.statusId}, false)?if_exists> > >> + <tr valign="middle"<#if alt_row> class="alternate- > >> row"</#if>> > >> + <td><a href="<@ofbizUrl>viewprofile?partyId=$ > >> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> > >> + <td> > >> + <#if > >> partyRow.getModelEntity().isField("groupName") && > >> partyRow.groupName?has_content> > >> + <a href="<@ofbizUrl>viewprofile?partyId=$ > >> {partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> > >> + <#elseif > >> partyRow.getModelEntity().isField("lastName") && lastName? > >> has_content> > >> + <a href="<@ofbizUrl>viewprofile?partyId=$ > >> {partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if > >> partyRow.firstName?has_content>, ${partyRow.firstName}</#if></a> > >> + <#else> > >> + <#assign partyName = > >> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, > >> true)> > >> + <#if partyName?has_content> > >> + <a href="<@ofbizUrl>viewprofile?partyId=$ > >> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> > >> + <#else> > >> + (${uiLabelMap.PartyNoNameFound}) > >> + </#if> > >> + </#if> > >> + </td> > >> + <td><#if status.description?exists>$ > >> {status.get("description", locale)}<#else>???</#if></td> > >> + </tr> > >> + <#-- toggle the row color --> > >> + <#assign alt_row = !alt_row> > >> + </#list> > >> + </table> > >> + <#else> > >> + ${uiLabelMap.PartyNoPartiesFound} > >> + </#if> > >> + </#if> > >> + </div> > >> +</div> > >> \ No newline at end of file > >> > >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ > >> ListLeads.ftl > >> ------------------------------------------------------------------------------ > >> svn:eol-style = native > >> > >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ > >> ListLeads.ftl > >> ------------------------------------------------------------------------------ > >> svn:keywords = Date Rev Author URL Id > >> > >> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ > >> ListLeads.ftl > >> ------------------------------------------------------------------------------ > >> svn:mime-type = text/plain > >> > >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/ > >> AccountScreens.xml > >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml?rev=785703&r1=785702&r2=785703&view=diff > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> ===================================================================== > >> --- ofbiz/trunk/applications/marketing/widget/sfa/ > >> AccountScreens.xml (original) > >> +++ ofbiz/trunk/applications/marketing/widget/sfa/ > >> AccountScreens.xml Wed Jun 17 16:21:29 2009 > >> @@ -40,32 +40,11 @@ > >> <section> > >> <widgets> > >> <platform-specific> > >> - <html><html-template > >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/ > >> ></html> > >> + <html> > >> + <html-template > >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/> > >> + <html-template > >> location="component://marketing/webapp/sfa/account/ > >> ListAccounts.ftl"/> > >> + </html> > >> </platform-specific> > >> - <container > >> style="screenlet"> > >> - <container > >> style="screenlet-title-bar"> > >> - <container > >> style="h3"> > >> - <label text="$ > >> {uiLabelMap.SfaFindResults}"/> > >> - </container> > >> - </container> > >> - <container > >> style="screenlet-body"> > >> - <section> > >> - <condition> > >> - <not> > >> - <if- > >> empty field="partyList"/> > >> - </not> > >> - </condition> > >> - <widgets> > >> - <include- > >> form name="ListAccounts" location="component://marketing/widget/sfa/ > >> forms/AccountForms.xml"/> > >> - </widgets> > >> - <fail-widgets> > >> - <container > >> style="h3"> > >> - <label > >> text="${uiLabelMap.PartyNoPartiesFound}"/> > >> - </container> > >> - </fail-widgets> > >> - </section> > >> - </container> > >> - </container> > >> </widgets> > >> </section> > >> </widgets> > >> > >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/ > >> ContactScreens.xml > >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml?rev=785703&r1=785702&r2=785703&view=diff > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> ===================================================================== > >> --- ofbiz/trunk/applications/marketing/widget/sfa/ > >> ContactScreens.xml (original) > >> +++ ofbiz/trunk/applications/marketing/widget/sfa/ > >> ContactScreens.xml Wed Jun 17 16:21:29 2009 > >> @@ -37,28 +37,11 @@ > >> <widgets> > >> <include-menu > >> name="ContactSubTabBar" location="component://marketing/widget/sfa/ > >> SfaMenus.xml"/> > >> <platform-specific> > >> - <html><html-template > >> location="component://marketing/webapp/sfa/party/ > >> findContactParty.ftl"/></html> > >> + <html> > >> + <html-template > >> location="component://marketing/webapp/sfa/party/ > >> findContactParty.ftl"/> > >> + <html-template > >> location="component://marketing/webapp/sfa/contact/ > >> ListContacts.ftl"/> > >> + </html> > >> </platform-specific> > >> - <container style="screenlet"> > >> - <container style="screenlet- > >> title-bar"> > >> - <container > >> style="h3"><label text="${uiLabelMap.SfaFindResults}"/></container> > >> - </container> > >> - <container style="screenlet- > >> body"> > >> - <section> > >> - <condition> > >> - <not><if-empty > >> field="partyList"/></not> > >> - </condition> > >> - <widgets> > >> - <include-form > >> name="ListContacts" location="component://marketing/widget/sfa/ > >> forms/ContactForms.xml"/> > >> - </widgets> > >> - <fail-widgets> > >> - <container > >> style="h3"> > >> - <label text="$ > >> {uiLabelMap.PartyNoPartiesFound}"/> > >> - </container> > >> - </fail-widgets> > >> - </section> > >> - </container> > >> - </container> > >> </widgets> > >> </section> > >> </decorator-section> > >> > >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/ > >> LeadScreens.xml > >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml?rev=785703&r1=785702&r2=785703&view=diff > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> ===================================================================== > >> --- ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml > >> (original) > >> +++ ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml > >> Wed Jun 17 16:21:29 2009 > >> @@ -37,25 +37,11 @@ > >> <include-menu name="LeadSubTabBar" > >> location="component://marketing/widget/sfa/SfaMenus.xml"/> > >> <container style="no-clear"> > >> <platform-specific> > >> - <html><html-template > >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/ > >> ></html> > >> + <html> > >> + <html-template > >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/> > >> + <html-template > >> location="component://marketing/webapp/sfa/lead/ListLeads.ftl"/> > >> + </html> > >> </platform-specific> > >> - <screenlet title="$ > >> {uiLabelMap.SfaFindResults}"> > >> - <section> > >> - <condition> > >> - <not> > >> - <if-empty > >> field="partyList"/> > >> - </not> > >> - </condition> > >> - <widgets> > >> - <include-form > >> name="ListLeads" location="component://marketing/widget/sfa/forms/ > >> LeadForms.xml"/> > >> - </widgets> > >> - <fail-widgets> > >> - <container > >> style="h3"> > >> - <label text="$ > >> {uiLabelMap.PartyNoPartiesFound}"/> > >> - </container> > >> - </fail-widgets> > >> - </section> > >> - </screenlet> > >> </container> > >> </widgets> > >> </section> > >> > >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/forms/ > >> AccountForms.xml > >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml?rev=785703&r1=785702&r2=785703&view=diff > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> ===================================================================== > >> --- ofbiz/trunk/applications/marketing/widget/sfa/forms/ > >> AccountForms.xml (original) > >> +++ ofbiz/trunk/applications/marketing/widget/sfa/forms/ > >> AccountForms.xml Wed Jun 17 16:21:29 2009 > >> @@ -21,23 +21,6 @@ > >> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" > >> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd > >> "> > >> > >> - <form name="ListAccounts" type="list" list-name="partyList" > >> paginate-target="FindAccount" > >> - odd-row-style="alternate-row" default-table-style="basic- > >> table hover-bar"> > >> - <row-actions> > >> - <entity-one entity-name="PartyGroup" value- > >> field="partyGroup"/> > >> - </row-actions> > >> - <field name="partyId" title="${uiLabelMap.PartyPartyId}"> > >> - <hyperlink target="viewprofile" description="$ > >> {partyId}" target-type="inter-app"> > >> - <parameter param-name="partyId"/> > >> - </hyperlink> > >> - </field> > >> - <field name="partyName" title="${uiLabelMap.PartyName}"> > >> - <hyperlink target="viewprofile" description="$ > >> {partyGroup.groupName}" target-type="inter-app"> > >> - <parameter param-name="partyId"/> > >> - </hyperlink> > >> - </field> > >> - <field name="partyTypeId" title="$ > >> {uiLabelMap.PartyType}"><display-entity entity-name="PartyType"/></ > >> field> > >> - </form> > >> <form name="NewAccount" type="single" target="createAccount" > >> header-row-style="header-row" default-table-style="basic-table"> > >> <field name="accountType"><hidden value="${accountType}"/></ > >> field> > >> <field name="groupName" title="$ > >> {uiLabelMap.PartyGroupName}" tooltip="${uiLabelMap.CommonRequired}" > >> widget-style="required"> > >> > >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/forms/ > >> LeadForms.xml > >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml?rev=785703&r1=785702&r2=785703&view=diff > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> = > >> ===================================================================== > >> --- ofbiz/trunk/applications/marketing/widget/sfa/forms/ > >> LeadForms.xml (original) > >> +++ ofbiz/trunk/applications/marketing/widget/sfa/forms/ > >> LeadForms.xml Wed Jun 17 16:21:29 2009 > >> @@ -21,27 +21,6 @@ > >> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" > >> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd > >> "> > >> > >> - <form name="ListLeads" type="list" list-name="partyList" list- > >> entry-name="partyRow" paginate-target="FindLead" > >> - odd-row-style="alternate-row" default-table-style="basic- > >> table hover-bar" separate-columns="true"> > >> - <row-actions> > >> - <entity-one entity-name="PartyNameView" value- > >> field="partyName"> > >> - <field-map field-name="partyId" from- > >> field="partyRow.partyId"/> > >> - </entity-one> > >> - <set field="statusId" from-field="partyRow.statusId"/> > >> - </row-actions> > >> - <field name="partyId" title="${uiLabelMap.PartyPartyId}"> > >> - <hyperlink target="viewprofile" description="$ > >> {partyRow.partyId}"> > >> - <parameter param-name="partyId" from- > >> field="partyRow.partyId"/> > >> - </hyperlink> > >> - </field> > >> - <field name="partyName" title="${uiLabelMap.PartyName}"> > >> - <hyperlink target="viewprofile" description="$ > >> {partyName.lastName}${partyName.groupName} ${partyName.firstName} "> > >> - <parameter param-name="partyId" from- > >> field="partyRow.partyId"/> > >> - </hyperlink> > >> - </field> > >> - <field name="statusId" title="$ > >> {uiLabelMap.CommonStatus}"><display-entity entity-name="StatusItem" > >> description="${description}" key-field-name="statusId"/></field> > >> - </form> > >> - > >> <form name="createLead" type="single" target="createLead" > >> header-row-style="header-row" default-table-style="basic-table" > >> default-map-name="contactDetailMap"> > >> <field name="firstName" tooltip="$ > >> {uiLabelMap.CommonRequired}" widget-style="required"><text/></field> > >> <field name="lastName" tooltip="$ > >> {uiLabelMap.CommonRequired}" widget-style="required"><text/></field> > >> > >> > > -- > > Antwebsystems.com: Quality OFBiz services for competitive rates > > > Antwebsystems.com: Quality OFBiz services for competitive rates |
Re: svn commit: r785703 - in /ofbiz/trunk/applications/mark
|
|
Hans,
findParty is a complex service and cannot be simply replaced by performFind on view entity like PartyAndContactMech (or similar) view entity. I don't mind replacing Forms based artifact with ftl if that's what I need to do deliver right behavior. Forms is preferred tools but only when it makes sense. Whoever did forms based screen implementation did not test it enough else they will not add it to trunk and we will not be talking about ftl replacing forms. Regards Anil Patel On Jun 17, 2009, at 10:57 PM, Hans Bakker wrote: > Hi Anil, > > you write: >> Ashish is claiming that he used ftl because forms widget based >> artifact did not do the job. > Then i would like to know why forms did not do the job. > > i am wondering anyway why the sfa application does not use the > standard > performfind for contacts/leads/accounts as now most of the > applications > use and is using the old findParty service which was created way > before > performFind existed. > > If you would use the PartyAndContactMech view with perform find, then > the same search can be created as exist now with findParty. > contact/lead/account can be the same screens, only the role > selection is > different. > > If we would have that, extra search fields can then be easily added > what > is now pretty difficult. > > This change replaces forms with ftl's and, i am sorry to ask, is that > acceptable? > > Regards, > Hans > > > > On Wed, 2009-06-17 at 22:41 -0400, Anil Patel wrote: >> Hans, >> Ashish is claiming that he used ftl because forms widget based >> artifact did not do the job. If you (or somebody in community) can >> help to fix the issue then I agree with you, we should not be using >> ftls. At the end of day, we write screens so they are usable and not >> because we love to use form widget over freemarker template, right? >> >> Regards >> Anil Patel >> >> >> >> On Jun 17, 2009, at 12:46 PM, Hans Bakker wrote: >> >>> I am sorry to see that more and more ftl is used. >>> >>> we agreed to use as less as possible ftl's in the backend, they are >>> difficult to maintain and to extend. >>> Asish, I stopped it in the project manager and it is starting here >>> now >>> again. >>> >>> is this the way we want to go...? >>> >>> not my choice. >>> >>> other opinions? >>> >>> >>> On Wed, 2009-06-17 at 16:21 +0000, [hidden email] wrote: >>>> Author: ashish >>>> Date: Wed Jun 17 16:21:29 2009 >>>> New Revision: 785703 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=785703&view=rev >>>> Log: >>>> Applied patch from jira issue OFBIZ-2622 (Paginations in SFA >>>> Screens(Account, Contacts and Leads)) >>>> Thanks Chirag for your contribution on this. >>>> >>>> Added: >>>> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>> ListAccounts.ftl (with props) >>>> ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>> ListContacts.ftl (with props) >>>> ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>> ListLeads.ftl (with props) >>>> Modified: >>>> ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml >>>> ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml >>>> ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml >>>> ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>> AccountForms.xml >>>> ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml >>>> >>>> Added: ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>> ListAccounts.ftl >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl?rev=785703&view=auto >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> =================================================================== >>>> --- ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>> ListAccounts.ftl (added) >>>> +++ ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>> ListAccounts.ftl Wed Jun 17 16:21:29 2009 >>>> @@ -0,0 +1,76 @@ >>>> +<#-- >>>> +Licensed to the Apache Software Foundation (ASF) under one >>>> +or more contributor license agreements. See the NOTICE file >>>> +distributed with this work for additional information >>>> +regarding copyright ownership. The ASF licenses this file >>>> +to you under the Apache License, Version 2.0 (the >>>> +"License"); you may not use this file except in compliance >>>> +with the License. You may obtain a copy of the License at >>>> + >>>> +http://www.apache.org/licenses/LICENSE-2.0 >>>> + >>>> +Unless required by applicable law or agreed to in writing, >>>> +software distributed under the License is distributed on an >>>> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>>> +KIND, either express or implied. See the License for the >>>> +specific language governing permissions and limitations >>>> +under the License. >>>> +--> >>>> + >>>> +<div class="screenlet"> >>>> + <div class="screenlet-title-bar"> >>>> + <ul> >>>> + <#if (partyListSize > 0)> >>>> + <#if (partyListSize > highIndex)> >>>> + <li><a class="nav-next button-col" >>>> href="<@ofbizUrl>FindAccounts?VIEW_SIZE=$ >>>> {viewSize}&VIEW_INDEX=$ >>>> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>> {uiLabelMap.CommonNext}</a></li> >>>> + <#else> >>>> + <li class="disabled button-col">$ >>>> {uiLabelMap.CommonNext}</li> >>>> + </#if> >>>> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} $ >>>> {partyListSize}</li> >>>> + <#if (viewIndex > 0)> >>>> + <li><a class="nav-previous button-col" >>>> href="<@ofbizUrl>FindAccounts?VIEW_SIZE=$ >>>> {viewSize}&VIEW_INDEX=$ >>>> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>> {uiLabelMap.CommonPrevious}</a></li> >>>> + <#else> >>>> + <li class="disabled button-col">$ >>>> {uiLabelMap.CommonPrevious}</li> >>>> + </#if> >>>> + </#if> >>>> + </ul> >>>> + </div> >>>> + <div class="screenlet-body"> >>>> + <h2>${uiLabelMap.SfaFindResults}</h2> >>>> + <#if partyList?exists> >>>> + <#if partyList?has_content> >>>> + <table class="basic-table hover-bar" cellspacing="0"> >>>> + <tr class="header-row-2"> >>>> + <td>${uiLabelMap.PartyPartyId}</td> >>>> + <td>${uiLabelMap.PartyName}</td> >>>> + <td>${uiLabelMap.PartyType}</td> >>>> + </tr> >>>> + <#assign alt_row = false> >>>> + <#list partyList as partyRow> >>>> + <#assign partyType = >>>> partyRow.getRelatedOne("PartyType")?if_exists> >>>> + <tr valign="middle"<#if alt_row> class="alternate- >>>> row"</#if>> >>>> + <td><a href="<@ofbizUrl>viewprofile?partyId=$ >>>> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >>>> + <td> >>>> + <#if >>>> partyRow.getModelEntity().isField("groupName") && >>>> partyRow.groupName?has_content> >>>> + <a href="<@ofbizUrl>viewprofile?partyId=$ >>>> {partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> >>>> + <#else> >>>> + <#assign partyName = >>>> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, >>>> true)> >>>> + <#if partyName?has_content> >>>> + <a href="<@ofbizUrl>viewprofile?partyId=$ >>>> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> >>>> + <#else> >>>> + (${uiLabelMap.PartyNoNameFound}) >>>> + </#if> >>>> + </#if> >>>> + </td> >>>> + <td><#if partyType.description?exists>$ >>>> {partyType.get("description", locale)}<#else>???</#if></td> >>>> + </tr> >>>> + <#-- toggle the row color --> >>>> + <#assign alt_row = !alt_row> >>>> + </#list> >>>> + </table> >>>> + <#else> >>>> + ${uiLabelMap.PartyNoPartiesFound} >>>> + </#if> >>>> + </#if> >>>> + </div> >>>> +</div> >>>> \ No newline at end of file >>>> >>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>> ListAccounts.ftl >>>> ------------------------------------------------------------------------------ >>>> svn:eol-style = native >>>> >>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>> ListAccounts.ftl >>>> ------------------------------------------------------------------------------ >>>> svn:keywords = Date Rev Author URL Id >>>> >>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>> ListAccounts.ftl >>>> ------------------------------------------------------------------------------ >>>> svn:mime-type = text/plain >>>> >>>> Added: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>> ListContacts.ftl >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl?rev=785703&view=auto >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> =================================================================== >>>> --- ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>> ListContacts.ftl (added) >>>> +++ ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>> ListContacts.ftl Wed Jun 17 16:21:29 2009 >>>> @@ -0,0 +1,75 @@ >>>> +<#-- >>>> +Licensed to the Apache Software Foundation (ASF) under one >>>> +or more contributor license agreements. See the NOTICE file >>>> +distributed with this work for additional information >>>> +regarding copyright ownership. The ASF licenses this file >>>> +to you under the Apache License, Version 2.0 (the >>>> +"License"); you may not use this file except in compliance >>>> +with the License. You may obtain a copy of the License at >>>> + >>>> +http://www.apache.org/licenses/LICENSE-2.0 >>>> + >>>> +Unless required by applicable law or agreed to in writing, >>>> +software distributed under the License is distributed on an >>>> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>>> +KIND, either express or implied. See the License for the >>>> +specific language governing permissions and limitations >>>> +under the License. >>>> +--> >>>> + >>>> +<div class="screenlet"> >>>> + <div class="screenlet-title-bar"> >>>> + <ul> >>>> + <#if (partyListSize > 0)> >>>> + <#if (partyListSize > highIndex)> >>>> + <li><a class="nav-next button-col" >>>> href="<@ofbizUrl>FindContacts?VIEW_SIZE=$ >>>> {viewSize}&VIEW_INDEX=$ >>>> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>> {uiLabelMap.CommonNext}</a></li> >>>> + <#else> >>>> + <li class="disabled button-col">$ >>>> {uiLabelMap.CommonNext}</li> >>>> + </#if> >>>> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} $ >>>> {partyListSize}</li> >>>> + <#if (viewIndex > 0)> >>>> + <li><a class="nav-previous button-col" >>>> href="<@ofbizUrl>FindContacts?VIEW_SIZE=$ >>>> {viewSize}&VIEW_INDEX=$ >>>> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>> {uiLabelMap.CommonPrevious}</a></li> >>>> + <#else> >>>> + <li class="disabled button-col">$ >>>> {uiLabelMap.CommonPrevious}</li> >>>> + </#if> >>>> + </#if> >>>> + </ul> >>>> + </div> >>>> + <div class="screenlet-body"> >>>> + <h2>${uiLabelMap.SfaFindResults}</h2> >>>> + <#if partyList?exists> >>>> + <#if partyList?has_content> >>>> + <table class="basic-table hover-bar" cellspacing="0"> >>>> + <tr class="header-row-2"> >>>> + <td>${uiLabelMap.PartyPartyId}</td> >>>> + <td>${uiLabelMap.PartyName}</td> >>>> + <td>${uiLabelMap.SfaVCard}</td> >>>> + </tr> >>>> + <#assign alt_row = false> >>>> + <#list partyList as partyRow> >>>> + <tr valign="middle"<#if alt_row> class="alternate- >>>> row"</#if>> >>>> + <td><a href="<@ofbizUrl>viewprofile?partyId=$ >>>> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >>>> + <td> >>>> + <#if partyRow.getModelEntity().isField("lastName") >>>> && lastName?has_content> >>>> + <a href="<@ofbizUrl>viewprofile?partyId=$ >>>> {partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if >>>> partyRow.firstName?has_content>, ${partyRow.firstName}</#if></a> >>>> + <#else> >>>> + <#assign partyName = >>>> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, >>>> true)> >>>> + <#if partyName?has_content> >>>> + <a href="<@ofbizUrl>viewprofile?partyId=$ >>>> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> >>>> + <#else> >>>> + (${uiLabelMap.PartyNoNameFound}) >>>> + </#if> >>>> + </#if> >>>> + </td> >>>> + <td><a href="<@ofbizUrl>createVCardFromContact? >>>> partyId=${partyRow.partyId}</@ofbizUrl>">$ >>>> {uiLabelMap.SfaVCard}<a></ >>>> td> >>>> + </tr> >>>> + <#-- toggle the row color --> >>>> + <#assign alt_row = !alt_row> >>>> + </#list> >>>> + </table> >>>> + <#else> >>>> + ${uiLabelMap.PartyNoPartiesFound} >>>> + </#if> >>>> + </#if> >>>> + </div> >>>> +</div> >>>> \ No newline at end of file >>>> >>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>> ListContacts.ftl >>>> ------------------------------------------------------------------------------ >>>> svn:eol-style = native >>>> >>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>> ListContacts.ftl >>>> ------------------------------------------------------------------------------ >>>> svn:keywords = Date Rev Author URL Id >>>> >>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>> ListContacts.ftl >>>> ------------------------------------------------------------------------------ >>>> svn:mime-type = text/plain >>>> >>>> Added: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>> ListLeads.ftl >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl?rev=785703&view=auto >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> =================================================================== >>>> --- ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>> ListLeads.ftl (added) >>>> +++ ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>> ListLeads.ftl Wed Jun 17 16:21:29 2009 >>>> @@ -0,0 +1,78 @@ >>>> +<#-- >>>> +Licensed to the Apache Software Foundation (ASF) under one >>>> +or more contributor license agreements. See the NOTICE file >>>> +distributed with this work for additional information >>>> +regarding copyright ownership. The ASF licenses this file >>>> +to you under the Apache License, Version 2.0 (the >>>> +"License"); you may not use this file except in compliance >>>> +with the License. You may obtain a copy of the License at >>>> + >>>> +http://www.apache.org/licenses/LICENSE-2.0 >>>> + >>>> +Unless required by applicable law or agreed to in writing, >>>> +software distributed under the License is distributed on an >>>> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>>> +KIND, either express or implied. See the License for the >>>> +specific language governing permissions and limitations >>>> +under the License. >>>> +--> >>>> + >>>> +<div class="screenlet"> >>>> + <div class="screenlet-title-bar"> >>>> + <ul> >>>> + <#if (partyListSize > 0)> >>>> + <#if (partyListSize > highIndex)> >>>> + <li><a class="nav-next button-col" >>>> href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >>>> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>> {uiLabelMap.CommonNext}</a></li> >>>> + <#else> >>>> + <li class="disabled button-col">$ >>>> {uiLabelMap.CommonNext}</li> >>>> + </#if> >>>> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} $ >>>> {partyListSize}</li> >>>> + <#if (viewIndex > 0)> >>>> + <li><a class="nav-previous button-col" >>>> href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >>>> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>> {uiLabelMap.CommonPrevious}</a></li> >>>> + <#else> >>>> + <li class="disabled button-col">$ >>>> {uiLabelMap.CommonPrevious}</li> >>>> + </#if> >>>> + </#if> >>>> + </ul> >>>> + </div> >>>> + <div class="screenlet-body"> >>>> + <h2>${uiLabelMap.SfaFindResults}</h2> >>>> + <#if partyList?exists> >>>> + <#if partyList?has_content> >>>> + <table class="basic-table hover-bar" cellspacing="0"> >>>> + <tr class="header-row-2"> >>>> + <td>${uiLabelMap.PartyPartyId}</td> >>>> + <td>${uiLabelMap.PartyName}</td> >>>> + <td>${uiLabelMap.CommonStatus}</td> >>>> + </tr> >>>> + <#assign alt_row = false> >>>> + <#list partyList as partyRow> >>>> + <#assign status = delegator.findOne("StatusItem", >>>> {"statusId":partyRow.statusId}, false)?if_exists> >>>> + <tr valign="middle"<#if alt_row> class="alternate- >>>> row"</#if>> >>>> + <td><a href="<@ofbizUrl>viewprofile?partyId=$ >>>> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >>>> + <td> >>>> + <#if >>>> partyRow.getModelEntity().isField("groupName") && >>>> partyRow.groupName?has_content> >>>> + <a href="<@ofbizUrl>viewprofile?partyId=$ >>>> {partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> >>>> + <#elseif >>>> partyRow.getModelEntity().isField("lastName") && lastName? >>>> has_content> >>>> + <a href="<@ofbizUrl>viewprofile?partyId=$ >>>> {partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if >>>> partyRow.firstName?has_content>, ${partyRow.firstName}</#if></a> >>>> + <#else> >>>> + <#assign partyName = >>>> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, >>>> true)> >>>> + <#if partyName?has_content> >>>> + <a href="<@ofbizUrl>viewprofile?partyId=$ >>>> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> >>>> + <#else> >>>> + (${uiLabelMap.PartyNoNameFound}) >>>> + </#if> >>>> + </#if> >>>> + </td> >>>> + <td><#if status.description?exists>$ >>>> {status.get("description", locale)}<#else>???</#if></td> >>>> + </tr> >>>> + <#-- toggle the row color --> >>>> + <#assign alt_row = !alt_row> >>>> + </#list> >>>> + </table> >>>> + <#else> >>>> + ${uiLabelMap.PartyNoPartiesFound} >>>> + </#if> >>>> + </#if> >>>> + </div> >>>> +</div> >>>> \ No newline at end of file >>>> >>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>> ListLeads.ftl >>>> ------------------------------------------------------------------------------ >>>> svn:eol-style = native >>>> >>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>> ListLeads.ftl >>>> ------------------------------------------------------------------------------ >>>> svn:keywords = Date Rev Author URL Id >>>> >>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>> ListLeads.ftl >>>> ------------------------------------------------------------------------------ >>>> svn:mime-type = text/plain >>>> >>>> Modified: ofbiz/trunk/applications/marketing/widget/sfa/ >>>> AccountScreens.xml >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> =================================================================== >>>> --- ofbiz/trunk/applications/marketing/widget/sfa/ >>>> AccountScreens.xml (original) >>>> +++ ofbiz/trunk/applications/marketing/widget/sfa/ >>>> AccountScreens.xml Wed Jun 17 16:21:29 2009 >>>> @@ -40,32 +40,11 @@ >>>> <section> >>>> <widgets> >>>> <platform-specific> >>>> - <html><html-template >>>> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/ >>>>> </html> >>>> + <html> >>>> + <html-template >>>> location="component://marketing/webapp/sfa/party/ >>>> findSfaParty.ftl"/> >>>> + <html-template >>>> location="component://marketing/webapp/sfa/account/ >>>> ListAccounts.ftl"/> >>>> + </html> >>>> </platform-specific> >>>> - <container >>>> style="screenlet"> >>>> - <container >>>> style="screenlet-title-bar"> >>>> - <container >>>> style="h3"> >>>> - <label text="$ >>>> {uiLabelMap.SfaFindResults}"/> >>>> - </container> >>>> - </container> >>>> - <container >>>> style="screenlet-body"> >>>> - <section> >>>> - <condition> >>>> - <not> >>>> - <if- >>>> empty field="partyList"/> >>>> - </not> >>>> - </condition> >>>> - <widgets> >>>> - <include- >>>> form name="ListAccounts" location="component://marketing/widget/ >>>> sfa/ >>>> forms/AccountForms.xml"/> >>>> - </widgets> >>>> - <fail-widgets> >>>> - <container >>>> style="h3"> >>>> - <label >>>> text="${uiLabelMap.PartyNoPartiesFound}"/> >>>> - </ >>>> container> >>>> - </fail- >>>> widgets> >>>> - </section> >>>> - </container> >>>> - </container> >>>> </widgets> >>>> </section> >>>> </widgets> >>>> >>>> Modified: ofbiz/trunk/applications/marketing/widget/sfa/ >>>> ContactScreens.xml >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> =================================================================== >>>> --- ofbiz/trunk/applications/marketing/widget/sfa/ >>>> ContactScreens.xml (original) >>>> +++ ofbiz/trunk/applications/marketing/widget/sfa/ >>>> ContactScreens.xml Wed Jun 17 16:21:29 2009 >>>> @@ -37,28 +37,11 @@ >>>> <widgets> >>>> <include-menu >>>> name="ContactSubTabBar" location="component://marketing/widget/sfa/ >>>> SfaMenus.xml"/> >>>> <platform-specific> >>>> - <html><html-template >>>> location="component://marketing/webapp/sfa/party/ >>>> findContactParty.ftl"/></html> >>>> + <html> >>>> + <html-template >>>> location="component://marketing/webapp/sfa/party/ >>>> findContactParty.ftl"/> >>>> + <html-template >>>> location="component://marketing/webapp/sfa/contact/ >>>> ListContacts.ftl"/> >>>> + </html> >>>> </platform-specific> >>>> - <container style="screenlet"> >>>> - <container style="screenlet- >>>> title-bar"> >>>> - <container >>>> style="h3"><label text="${uiLabelMap.SfaFindResults}"/></container> >>>> - </container> >>>> - <container style="screenlet- >>>> body"> >>>> - <section> >>>> - <condition> >>>> - <not><if-empty >>>> field="partyList"/></not> >>>> - </condition> >>>> - <widgets> >>>> - <include-form >>>> name="ListContacts" location="component://marketing/widget/sfa/ >>>> forms/ContactForms.xml"/> >>>> - </widgets> >>>> - <fail-widgets> >>>> - <container >>>> style="h3"> >>>> - <label text="$ >>>> {uiLabelMap.PartyNoPartiesFound}"/> >>>> - </container> >>>> - </fail-widgets> >>>> - </section> >>>> - </container> >>>> - </container> >>>> </widgets> >>>> </section> >>>> </decorator-section> >>>> >>>> Modified: ofbiz/trunk/applications/marketing/widget/sfa/ >>>> LeadScreens.xml >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> =================================================================== >>>> --- ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml >>>> (original) >>>> +++ ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml >>>> Wed Jun 17 16:21:29 2009 >>>> @@ -37,25 +37,11 @@ >>>> <include-menu name="LeadSubTabBar" >>>> location="component://marketing/widget/sfa/SfaMenus.xml"/> >>>> <container style="no-clear"> >>>> <platform-specific> >>>> - <html><html-template >>>> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/ >>>>> </html> >>>> + <html> >>>> + <html-template >>>> location="component://marketing/webapp/sfa/party/ >>>> findSfaParty.ftl"/> >>>> + <html-template >>>> location="component://marketing/webapp/sfa/lead/ListLeads.ftl"/> >>>> + </html> >>>> </platform-specific> >>>> - <screenlet title="$ >>>> {uiLabelMap.SfaFindResults}"> >>>> - <section> >>>> - <condition> >>>> - <not> >>>> - <if-empty >>>> field="partyList"/> >>>> - </not> >>>> - </condition> >>>> - <widgets> >>>> - <include-form >>>> name="ListLeads" location="component://marketing/widget/sfa/forms/ >>>> LeadForms.xml"/> >>>> - </widgets> >>>> - <fail-widgets> >>>> - <container >>>> style="h3"> >>>> - <label text="$ >>>> {uiLabelMap.PartyNoPartiesFound}"/> >>>> - </container> >>>> - </fail-widgets> >>>> - </section> >>>> - </screenlet> >>>> </container> >>>> </widgets> >>>> </section> >>>> >>>> Modified: ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>> AccountForms.xml >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml?rev=785703&r1=785702&r2=785703&view=diff >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> =================================================================== >>>> --- ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>> AccountForms.xml (original) >>>> +++ ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>> AccountForms.xml Wed Jun 17 16:21:29 2009 >>>> @@ -21,23 +21,6 @@ >>>> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >>>> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd >>>> "> >>>> >>>> - <form name="ListAccounts" type="list" list-name="partyList" >>>> paginate-target="FindAccount" >>>> - odd-row-style="alternate-row" default-table-style="basic- >>>> table hover-bar"> >>>> - <row-actions> >>>> - <entity-one entity-name="PartyGroup" value- >>>> field="partyGroup"/> >>>> - </row-actions> >>>> - <field name="partyId" title="${uiLabelMap.PartyPartyId}"> >>>> - <hyperlink target="viewprofile" description="$ >>>> {partyId}" target-type="inter-app"> >>>> - <parameter param-name="partyId"/> >>>> - </hyperlink> >>>> - </field> >>>> - <field name="partyName" title="${uiLabelMap.PartyName}"> >>>> - <hyperlink target="viewprofile" description="$ >>>> {partyGroup.groupName}" target-type="inter-app"> >>>> - <parameter param-name="partyId"/> >>>> - </hyperlink> >>>> - </field> >>>> - <field name="partyTypeId" title="$ >>>> {uiLabelMap.PartyType}"><display-entity entity-name="PartyType"/></ >>>> field> >>>> - </form> >>>> <form name="NewAccount" type="single" target="createAccount" >>>> header-row-style="header-row" default-table-style="basic-table"> >>>> <field name="accountType"><hidden value="${accountType}"/></ >>>> field> >>>> <field name="groupName" title="$ >>>> {uiLabelMap.PartyGroupName}" tooltip="${uiLabelMap.CommonRequired}" >>>> widget-style="required"> >>>> >>>> Modified: ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>> LeadForms.xml >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml?rev=785703&r1=785702&r2=785703&view=diff >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> =================================================================== >>>> --- ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>> LeadForms.xml (original) >>>> +++ ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>> LeadForms.xml Wed Jun 17 16:21:29 2009 >>>> @@ -21,27 +21,6 @@ >>>> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >>>> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd >>>> "> >>>> >>>> - <form name="ListLeads" type="list" list-name="partyList" list- >>>> entry-name="partyRow" paginate-target="FindLead" >>>> - odd-row-style="alternate-row" default-table-style="basic- >>>> table hover-bar" separate-columns="true"> >>>> - <row-actions> >>>> - <entity-one entity-name="PartyNameView" value- >>>> field="partyName"> >>>> - <field-map field-name="partyId" from- >>>> field="partyRow.partyId"/> >>>> - </entity-one> >>>> - <set field="statusId" from-field="partyRow.statusId"/> >>>> - </row-actions> >>>> - <field name="partyId" title="${uiLabelMap.PartyPartyId}"> >>>> - <hyperlink target="viewprofile" description="$ >>>> {partyRow.partyId}"> >>>> - <parameter param-name="partyId" from- >>>> field="partyRow.partyId"/> >>>> - </hyperlink> >>>> - </field> >>>> - <field name="partyName" title="${uiLabelMap.PartyName}"> >>>> - <hyperlink target="viewprofile" description="$ >>>> {partyName.lastName}${partyName.groupName} ${partyName.firstName} >>>> "> >>>> - <parameter param-name="partyId" from- >>>> field="partyRow.partyId"/> >>>> - </hyperlink> >>>> - </field> >>>> - <field name="statusId" title="$ >>>> {uiLabelMap.CommonStatus}"><display-entity entity-name="StatusItem" >>>> description="${description}" key-field-name="statusId"/></field> >>>> - </form> >>>> - >>>> <form name="createLead" type="single" target="createLead" >>>> header-row-style="header-row" default-table-style="basic-table" >>>> default-map-name="contactDetailMap"> >>>> <field name="firstName" tooltip="$ >>>> {uiLabelMap.CommonRequired}" widget-style="required"><text/></ >>>> field> >>>> <field name="lastName" tooltip="$ >>>> {uiLabelMap.CommonRequired}" widget-style="required"><text/></ >>>> field> >>>> >>>> >>> -- >>> Antwebsystems.com: Quality OFBiz services for competitive rates >>> >> > -- > Antwebsystems.com: Quality OFBiz services for competitive rates > |
Re: svn commit: r785703 - in /ofbiz/trunk/applications/mark
|
|
In reply to this post by hans_bakker
Anil and Hans, The screen widgets were preferred over FTL originally because they allow rendering to different devices. FTL files are HTML-specific. A Swing interface was considered as an alternative to HTML, but to my knowledge, no one has ever implemented a Swing interface for OFBiz. After the screen widgets caught on, some users preferred them over FTL because of the auto-complete feature available in XML editors. The down side of widgets is they are inflexible - changing their behavior requires changing Java code and a recompile. Changing an FTL file's behavior is much easier. There are pros and cons to both, and the debate between the two will go on... much like Apple vs PC. -Adrian --- On Wed, 6/17/09, Anil Patel <[hidden email]> wrote: > From: Anil Patel <[hidden email]> > Subject: Re: svn commit: r785703 - in /ofbiz/trunk/applications/marketing: webapp/sfa/account/ webapp/sfa/contact/ webapp/sfa/lead/ widget/sfa/ widget/sfa/forms/ > To: [hidden email] > Cc: "Anil Patel" <[hidden email]> > Date: Wednesday, June 17, 2009, 8:49 PM > Hans, > findParty is a complex service and cannot be simply > replaced by performFind on view entity like > PartyAndContactMech (or similar) view entity. > > I don't mind replacing Forms based artifact with ftl if > that's what I need to do deliver right behavior. Forms is > preferred tools but only when it makes sense. Whoever did > forms based screen implementation did not test it enough > else they will not add it to trunk and we will not be > talking about ftl replacing forms. > > Regards > Anil Patel > > On Jun 17, 2009, at 10:57 PM, Hans Bakker wrote: > > > Hi Anil, > > > > you write: > >> Ashish is claiming that he used ftl because forms > widget based > >> artifact did not do the job. > > Then i would like to know why forms did not do the > job. > > > > i am wondering anyway why the sfa application does not > use the standard > > performfind for contacts/leads/accounts as now most of > the applications > > use and is using the old findParty service which was > created way before > > performFind existed. > > > > If you would use the PartyAndContactMech view with > perform find, then > > the same search can be created as exist now with > findParty. > > contact/lead/account can be the same screens, only the > role selection is > > different. > > > > If we would have that, extra search fields can then be > easily added what > > is now pretty difficult. > > > > This change replaces forms with ftl's and, i am sorry > to ask, is that > > acceptable? > > > > Regards, > > Hans > > > > > > > > On Wed, 2009-06-17 at 22:41 -0400, Anil Patel wrote: > >> Hans, > >> Ashish is claiming that he used ftl because forms > widget based > >> artifact did not do the job. If you (or somebody > in community) can > >> help to fix the issue then I agree with you, we > should not be using > >> ftls. At the end of day, we write screens so they > are usable and not > >> because we love to use form widget over freemarker > template, right? > >> > >> Regards > >> Anil Patel > >> > >> > >> > >> On Jun 17, 2009, at 12:46 PM, Hans Bakker wrote: > >> > >>> I am sorry to see that more and more ftl is > used. > >>> > >>> we agreed to use as less as possible ftl's in > the backend, they are > >>> difficult to maintain and to extend. > >>> Asish, I stopped it in the project manager and > it is starting here now > >>> again. > >>> > >>> is this the way we want to go...? > >>> > >>> not my choice. > >>> > >>> other opinions? > >>> > >>> > >>> On Wed, 2009-06-17 at 16:21 +0000, [hidden email] > wrote: > >>>> Author: ashish > >>>> Date: Wed Jun 17 16:21:29 2009 > >>>> New Revision: 785703 > >>>> > >>>> URL: http://svn.apache.org/viewvc?rev=785703&view=rev > >>>> Log: > >>>> Applied patch from jira issue OFBIZ-2622 > (Paginations in SFA > >>>> Screens(Account, Contacts and Leads)) > >>>> Thanks Chirag for your contribution on > this. > >>>> > >>>> Added: > >>>>   ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >>>>   ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >>>> ListAccounts.ftl   (with > props) > >>>>   ofbiz/trunk/applications/marketing/webapp/sfa/contact/ > >>>> ListContacts.ftl   (with > props) > >>>>   ofbiz/trunk/applications/marketing/webapp/sfa/lead/ > >>>> ListLeads.ftl   (with > props) > >>>> Modified: > >>>>   ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml > >>>>   ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml > >>>>   ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml > >>>>   ofbiz/trunk/applications/marketing/widget/sfa/forms/ > >>>> AccountForms.xml > >>>>   ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml > >>>> > >>>> Added: > ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >>>> ListAccounts.ftl > >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl?rev=785703&view=auto > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> > ===================================================================== > >>>> --- > ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >>>> ListAccounts.ftl (added) > >>>> +++ > ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >>>> ListAccounts.ftl Wed Jun 17 16:21:29 2009 > >>>> @@ -0,0 +1,76 @@ > >>>> +<#-- > >>>> +Licensed to the Apache Software > Foundation (ASF) under one > >>>> +or more contributor license > agreements. See the NOTICE file > >>>> +distributed with this work for additional > information > >>>> +regarding copyright ownership. The > ASF licenses this file > >>>> +to you under the Apache License, Version > 2.0 (the > >>>> +"License"); you may not use this file > except in compliance > >>>> +with the License. You may obtain a > copy of the License at > >>>> + > >>>> +http://www.apache.org/licenses/LICENSE-2.0 > >>>> + > >>>> +Unless required by applicable law or > agreed to in writing, > >>>> +software distributed under the License is > distributed on an > >>>> +"AS IS" BASIS, WITHOUT WARRANTIES OR > CONDITIONS OF ANY > >>>> +KIND, either express or implied. > See the License for the > >>>> +specific language governing permissions > and limitations > >>>> +under the License. > >>>> +--> > >>>> + > >>>> +<div class="screenlet"> > >>>> + <div > class="screenlet-title-bar"> > >>>> +  <ul> > >>>> +   <#if > (partyListSize > 0)> > >>>> +    <#if > (partyListSize > highIndex)> > >>>> +     > <li><a class="nav-next button-col" > >>>> > href="<@ofbizUrl>FindAccounts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ > >>>> > {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ > >>>> > {uiLabelMap.CommonNext}</a></li> > >>>> +    > <#else> > >>>> +     <li > class="disabled button-col">$ > >>>> {uiLabelMap.CommonNext}</li> > >>>> +    </#if> > >>>> +    > <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} > $ > >>>> {partyListSize}</li> > >>>> +    <#if > (viewIndex > 0)> > >>>> +     > <li><a class="nav-previous button-col" > >>>> > href="<@ofbizUrl>FindAccounts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ > >>>> > {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ > >>>> > {uiLabelMap.CommonPrevious}</a></li> > >>>> +    > <#else> > >>>> +     <li > class="disabled button-col">$ > >>>> {uiLabelMap.CommonPrevious}</li> > >>>> +    </#if> > >>>> +   </#if> > >>>> +  </ul> > >>>> + </div> > >>>> + <div > class="screenlet-body"> > >>>> +  > <h2>${uiLabelMap.SfaFindResults}</h2> > >>>> +  <#if > partyList?exists> > >>>> +   <#if > partyList?has_content> > >>>> +    <table > class="basic-table hover-bar" cellspacing="0"> > >>>> +     <tr > class="header-row-2"> > >>>> +      > <td>${uiLabelMap.PartyPartyId}</td> > >>>> +      > <td>${uiLabelMap.PartyName}</td> > >>>> +      > <td>${uiLabelMap.PartyType}</td> > >>>> +     > </tr> > >>>> +     > <#assign alt_row = false> > >>>> +     > <#list partyList as partyRow> > >>>> +      > <#assign partyType = > >>>> > partyRow.getRelatedOne("PartyType")?if_exists> > >>>> +      > <tr valign="middle"<#if alt_row> class="alternate- > >>>> row"</#if>> > >>>> +      >  <td><a > href="<@ofbizUrl>viewprofile?partyId=$ > >>>> > {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> > >>>> +      >  <td> > >>>> +      >   <#if > >>>> > partyRow.getModelEntity().isField("groupName") && > >>>> partyRow.groupName?has_content> > >>>> +      >    <a > href="<@ofbizUrl>viewprofile?partyId=$ > >>>> > {partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> > >>>> +      >   <#else> > >>>> +      >    <#assign partyName = > >>>> > Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, > >>>> true)> > >>>> +      >    <#if partyName?has_content> > >>>> +      >     <a > href="<@ofbizUrl>viewprofile?partyId=$ > >>>> > {partyRow.partyId}</@ofbizUrl>">${partyName}</a> > >>>> +      >    <#else> > >>>> +      >     > (${uiLabelMap.PartyNoNameFound}) > >>>> +      >    </#if> > >>>> +      >   </#if> > >>>> +      >  </td> > >>>> +      >  <td><#if partyType.description?exists>$ > >>>> {partyType.get("description", > locale)}<#else>???</#if></td> > >>>> +      > </tr> > >>>> +      > <#-- toggle the row color --> > >>>> +      > <#assign alt_row = !alt_row> > >>>> +     > </#list> > >>>> +    > </table> > >>>> +   <#else> > >>>> +    > ${uiLabelMap.PartyNoPartiesFound} > >>>> +   </#if> > >>>> +  </#if> > >>>> + </div> > >>>> +</div> > >>>> \ No newline at end of file > >>>> > >>>> Propchange: > ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >>>> ListAccounts.ftl > >>>> > ------------------------------------------------------------------------------ > >>>>   svn:eol-style = native > >>>> > >>>> Propchange: > ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >>>> ListAccounts.ftl > >>>> > ------------------------------------------------------------------------------ > >>>>   svn:keywords = Date Rev > Author URL Id > >>>> > >>>> Propchange: > ofbiz/trunk/applications/marketing/webapp/sfa/account/ > >>>> ListAccounts.ftl > >>>> > ------------------------------------------------------------------------------ > >>>>   svn:mime-type = > text/plain > >>>> > >>>> Added: > ofbiz/trunk/applications/marketing/webapp/sfa/contact/ > >>>> ListContacts.ftl > >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl?rev=785703&view=auto > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> > ===================================================================== > >>>> --- > ofbiz/trunk/applications/marketing/webapp/sfa/contact/ > >>>> ListContacts.ftl (added) > >>>> +++ > ofbiz/trunk/applications/marketing/webapp/sfa/contact/ > >>>> ListContacts.ftl Wed Jun 17 16:21:29 2009 > >>>> @@ -0,0 +1,75 @@ > >>>> +<#-- > >>>> +Licensed to the Apache Software > Foundation (ASF) under one > >>>> +or more contributor license > agreements. See the NOTICE file > >>>> +distributed with this work for additional > information > >>>> +regarding copyright ownership. The > ASF licenses this file > >>>> +to you under the Apache License, Version > 2.0 (the > >>>> +"License"); you may not use this file > except in compliance > >>>> +with the License. You may obtain a > copy of the License at > >>>> + > >>>> +http://www.apache.org/licenses/LICENSE-2.0 > >>>> + > >>>> +Unless required by applicable law or > agreed to in writing, > >>>> +software distributed under the License is > distributed on an > >>>> +"AS IS" BASIS, WITHOUT WARRANTIES OR > CONDITIONS OF ANY > >>>> +KIND, either express or implied. > See the License for the > >>>> +specific language governing permissions > and limitations > >>>> +under the License. > >>>> +--> > >>>> + > >>>> +<div class="screenlet"> > >>>> + <div > class="screenlet-title-bar"> > >>>> +  <ul> > >>>> +   <#if > (partyListSize > 0)> > >>>> +    <#if > (partyListSize > highIndex)> > >>>> +     > <li><a class="nav-next button-col" > >>>> > href="<@ofbizUrl>FindContacts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ > >>>> > {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ > >>>> > {uiLabelMap.CommonNext}</a></li> > >>>> +    > <#else> > >>>> +     <li > class="disabled button-col">$ > >>>> {uiLabelMap.CommonNext}</li> > >>>> +    </#if> > >>>> +    > <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} > $ > >>>> {partyListSize}</li> > >>>> +    <#if > (viewIndex > 0)> > >>>> +     > <li><a class="nav-previous button-col" > >>>> > href="<@ofbizUrl>FindContacts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ > >>>> > {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ > >>>> > {uiLabelMap.CommonPrevious}</a></li> > >>>> +    > <#else> > >>>> +     <li > class="disabled button-col">$ > >>>> {uiLabelMap.CommonPrevious}</li> > >>>> +    </#if> > >>>> +   </#if> > >>>> +  </ul> > >>>> + </div> > >>>> + <div > class="screenlet-body"> > >>>> +  > <h2>${uiLabelMap.SfaFindResults}</h2> > >>>> +  <#if > partyList?exists> > >>>> +   <#if > partyList?has_content> > >>>> +    <table > class="basic-table hover-bar" cellspacing="0"> > >>>> +     <tr > class="header-row-2"> > >>>> +      > <td>${uiLabelMap.PartyPartyId}</td> > >>>> +      > <td>${uiLabelMap.PartyName}</td> > >>>> +      > <td>${uiLabelMap.SfaVCard}</td> > >>>> +     > </tr> > >>>> +     > <#assign alt_row = false> > >>>> +     > <#list partyList as partyRow> > >>>> +      > <tr valign="middle"<#if alt_row> class="alternate- > >>>> row"</#if>> > >>>> +      >  <td><a > href="<@ofbizUrl>viewprofile?partyId=$ > >>>> > {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> > >>>> +      >  <td> > >>>> +      >   <#if > partyRow.getModelEntity().isField("lastName") > >>>> && lastName?has_content> > >>>> +      >    <a > href="<@ofbizUrl>viewprofile?partyId=$ > >>>> > {partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if > >>>> partyRow.firstName?has_content>, > ${partyRow.firstName}</#if></a> > >>>> +      >   <#else> > >>>> +      >    <#assign partyName = > >>>> > Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, > >>>> true)> > >>>> +      >    <#if partyName?has_content> > >>>> +      >     <a > href="<@ofbizUrl>viewprofile?partyId=$ > >>>> > {partyRow.partyId}</@ofbizUrl>">${partyName}</a> > >>>> +      >    <#else> > >>>> +      >     > (${uiLabelMap.PartyNoNameFound}) > >>>> +      >    </#if> > >>>> +      >   </#if> > >>>> +      >  </td> > >>>> +      >  <td><a > href="<@ofbizUrl>createVCardFromContact? > >>>> > partyId=${partyRow.partyId}</@ofbizUrl>">${uiLabelMap.SfaVCard}<a></ > >>>> td> > >>>> +      > </tr> > >>>> +      > <#-- toggle the row color --> > >>>> +      > <#assign alt_row = !alt_row> > >>>> +     > </#list> > >>>> +    > </table> > >>>> +   <#else> > >>>> +    > ${uiLabelMap.PartyNoPartiesFound} > >>>> +   </#if> > >>>> +  </#if> > >>>> + </div> > >>>> +</div> > >>>> \ No newline at end of file > >>>> > >>>> Propchange: > ofbiz/trunk/applications/marketing/webapp/sfa/contact/ > >>>> ListContacts.ftl > >>>> > ------------------------------------------------------------------------------ > >>>>   svn:eol-style = native > >>>> > >>>> Propchange: > ofbiz/trunk/applications/marketing/webapp/sfa/contact/ > >>>> ListContacts.ftl > >>>> > ------------------------------------------------------------------------------ > >>>>   svn:keywords = Date Rev > Author URL Id > >>>> > >>>> Propchange: > ofbiz/trunk/applications/marketing/webapp/sfa/contact/ > >>>> ListContacts.ftl > >>>> > ------------------------------------------------------------------------------ > >>>>   svn:mime-type = > text/plain > >>>> > >>>> Added: > ofbiz/trunk/applications/marketing/webapp/sfa/lead/ > >>>> ListLeads.ftl > >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl?rev=785703&view=auto > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> > ===================================================================== > >>>> --- > ofbiz/trunk/applications/marketing/webapp/sfa/lead/ > >>>> ListLeads.ftl (added) > >>>> +++ > ofbiz/trunk/applications/marketing/webapp/sfa/lead/ > >>>> ListLeads.ftl Wed Jun 17 16:21:29 2009 > >>>> @@ -0,0 +1,78 @@ > >>>> +<#-- > >>>> +Licensed to the Apache Software > Foundation (ASF) under one > >>>> +or more contributor license > agreements. See the NOTICE file > >>>> +distributed with this work for additional > information > >>>> +regarding copyright ownership. The > ASF licenses this file > >>>> +to you under the Apache License, Version > 2.0 (the > >>>> +"License"); you may not use this file > except in compliance > >>>> +with the License. You may obtain a > copy of the License at > >>>> + > >>>> +http://www.apache.org/licenses/LICENSE-2.0 > >>>> + > >>>> +Unless required by applicable law or > agreed to in writing, > >>>> +software distributed under the License is > distributed on an > >>>> +"AS IS" BASIS, WITHOUT WARRANTIES OR > CONDITIONS OF ANY > >>>> +KIND, either express or implied. > See the License for the > >>>> +specific language governing permissions > and limitations > >>>> +under the License. > >>>> +--> > >>>> + > >>>> +<div class="screenlet"> > >>>> + <div > class="screenlet-title-bar"> > >>>> +  <ul> > >>>> +   <#if > (partyListSize > 0)> > >>>> +    <#if > (partyListSize > highIndex)> > >>>> +     > <li><a class="nav-next button-col" > >>>> > href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ > >>>> > {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ > >>>> > {uiLabelMap.CommonNext}</a></li> > >>>> +    > <#else> > >>>> +     <li > class="disabled button-col">$ > >>>> {uiLabelMap.CommonNext}</li> > >>>> +    </#if> > >>>> +    > <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} > $ > >>>> {partyListSize}</li> > >>>> +    <#if > (viewIndex > 0)> > >>>> +     > <li><a class="nav-previous button-col" > >>>> > href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ > >>>> > {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ > >>>> > {uiLabelMap.CommonPrevious}</a></li> > >>>> +    > <#else> > >>>> +     <li > class="disabled button-col">$ > >>>> {uiLabelMap.CommonPrevious}</li> > >>>> +    </#if> > >>>> +   </#if> > >>>> +  </ul> > >>>> + </div> > >>>> + <div > class="screenlet-body"> > >>>> +  > <h2>${uiLabelMap.SfaFindResults}</h2> > >>>> +  <#if > partyList?exists> > >>>> +   <#if > partyList?has_content> > >>>> +    <table > class="basic-table hover-bar" cellspacing="0"> > >>>> +     <tr > class="header-row-2"> > >>>> +      > <td>${uiLabelMap.PartyPartyId}</td> > >>>> +      > <td>${uiLabelMap.PartyName}</td> > >>>> +      > <td>${uiLabelMap.CommonStatus}</td> > >>>> +     > </tr> > >>>> +     > <#assign alt_row = false> > >>>> +     > <#list partyList as partyRow> > >>>> +      > <#assign status = delegator.findOne("StatusItem", > >>>> {"statusId":partyRow.statusId}, > false)?if_exists> > >>>> +      > <tr valign="middle"<#if alt_row> class="alternate- > >>>> row"</#if>> > >>>> +      >  <td><a > href="<@ofbizUrl>viewprofile?partyId=$ > >>>> > {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> > >>>> +      >  <td> > >>>> +      >   <#if > >>>> > partyRow.getModelEntity().isField("groupName") && > >>>> partyRow.groupName?has_content> > >>>> +      >    <a > href="<@ofbizUrl>viewprofile?partyId=$ > >>>> > {partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> > >>>> +      >   <#elseif > >>>> > partyRow.getModelEntity().isField("lastName") && > lastName? > >>>> has_content> > >>>> +      >    <a > href="<@ofbizUrl>viewprofile?partyId=$ > >>>> > {partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if > >>>> partyRow.firstName?has_content>, > ${partyRow.firstName}</#if></a> > >>>> +      >   <#else> > >>>> +      >    <#assign partyName = > >>>> > Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, > >>>> true)> > >>>> +      >    <#if partyName?has_content> > >>>> +      >     <a > href="<@ofbizUrl>viewprofile?partyId=$ > >>>> > {partyRow.partyId}</@ofbizUrl>">${partyName}</a> > >>>> +      >    <#else> > >>>> +      >     > (${uiLabelMap.PartyNoNameFound}) > >>>> +      >    </#if> > >>>> +      >   </#if> > >>>> +      >  </td> > >>>> +      >  <td><#if status.description?exists>$ > >>>> {status.get("description", > locale)}<#else>???</#if></td> > >>>> +      > </tr> > >>>> +      > <#-- toggle the row color --> > >>>> +      > <#assign alt_row = !alt_row> > >>>> +     > </#list> > >>>> +    > </table> > >>>> +   <#else> > >>>> +    > ${uiLabelMap.PartyNoPartiesFound} > >>>> +   </#if> > >>>> +  </#if> > >>>> + </div> > >>>> +</div> > >>>> \ No newline at end of file > >>>> > >>>> Propchange: > ofbiz/trunk/applications/marketing/webapp/sfa/lead/ > >>>> ListLeads.ftl > >>>> > ------------------------------------------------------------------------------ > >>>>   svn:eol-style = native > >>>> > >>>> Propchange: > ofbiz/trunk/applications/marketing/webapp/sfa/lead/ > >>>> ListLeads.ftl > >>>> > ------------------------------------------------------------------------------ > >>>>   svn:keywords = Date Rev > Author URL Id > >>>> > >>>> Propchange: > ofbiz/trunk/applications/marketing/webapp/sfa/lead/ > >>>> ListLeads.ftl > >>>> > ------------------------------------------------------------------------------ > >>>>   svn:mime-type = > text/plain > >>>> > >>>> Modified: > ofbiz/trunk/applications/marketing/widget/sfa/ > >>>> AccountScreens.xml > >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml?rev=785703&r1=785702&r2=785703&view=diff > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> > ===================================================================== > >>>> --- > ofbiz/trunk/applications/marketing/widget/sfa/ > >>>> AccountScreens.xml (original) > >>>> +++ > ofbiz/trunk/applications/marketing/widget/sfa/ > >>>> AccountScreens.xml Wed Jun 17 16:21:29 > 2009 > >>>> @@ -40,32 +40,11 @@ > >>>>      >         >   <section> > >>>>      >         >     <widgets> > >>>>      >         >       > <platform-specific> > >>>> -      >         >         > <html><html-template > >>>> > location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/ > >>>>> </html> > >>>> +      >         >         > <html> > >>>> +      >         >         >   <html-template > >>>> > location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/> > >>>> +      >         >         >   <html-template > >>>> > location="component://marketing/webapp/sfa/account/ > >>>> ListAccounts.ftl"/> > >>>> +      >         >         > </html> > >>>>      >         >       > </platform-specific> > >>>> -      >         >       <container > >>>> style="screenlet"> > >>>> -      >         >         > <container > >>>> style="screenlet-title-bar"> > >>>> -      >         >         >   <container > >>>> style="h3"> > >>>> -      >         >         >     <label text="$ > >>>> {uiLabelMap.SfaFindResults}"/> > >>>> -      >         >         >   </container> > >>>> -      >         >         > </container> > >>>> -      >         >         > <container > >>>> style="screenlet-body"> > >>>> -      >         >         >   <section> > >>>> -      >         >         >     <condition> > >>>> -      >         >         >       <not> > >>>> -      >         >         >         > <if- > >>>> empty field="partyList"/> > >>>> -      >         >         >       </not> > >>>> -      >         >         >     </condition> > >>>> -      >         >         >     <widgets> > >>>> -      >         >         >       <include- > >>>> form name="ListAccounts" > location="component://marketing/widget/sfa/ > >>>> forms/AccountForms.xml"/> > >>>> -      >         >         >     </widgets> > >>>> -      >         >         >     <fail-widgets> > >>>> -      >         >         >       <container > >>>> style="h3"> > >>>> -      >         >         >         > <label > >>>> > text="${uiLabelMap.PartyNoPartiesFound}"/> > >>>> -      >         >         >       > </container> > >>>> -      >         >         >     </fail-widgets> > >>>> -      >         >         >   </section> > >>>> -      >         >         > </container> > >>>> -      >         >       > </container> > >>>>      >         >     </widgets> > >>>>      >         >   </section> > >>>>      >         > </widgets> > >>>> > >>>> Modified: > ofbiz/trunk/applications/marketing/widget/sfa/ > >>>> ContactScreens.xml > >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml?rev=785703&r1=785702&r2=785703&view=diff > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> > ===================================================================== > >>>> --- > ofbiz/trunk/applications/marketing/widget/sfa/ > >>>> ContactScreens.xml (original) > >>>> +++ > ofbiz/trunk/applications/marketing/widget/sfa/ > >>>> ContactScreens.xml Wed Jun 17 16:21:29 > 2009 > >>>> @@ -37,28 +37,11 @@ > >>>>      >         > <widgets> > >>>>      >         >   <include-menu > >>>> name="ContactSubTabBar" > location="component://marketing/widget/sfa/ > >>>> SfaMenus.xml"/> > >>>>      >         >   <platform-specific> > >>>> -      >         >     <html><html-template > >>>> > location="component://marketing/webapp/sfa/party/ > >>>> findContactParty.ftl"/></html> > >>>> +      >         >     <html> > >>>> +      >         >       <html-template > >>>> > location="component://marketing/webapp/sfa/party/ > >>>> findContactParty.ftl"/> > >>>> +      >         >       <html-template > >>>> > location="component://marketing/webapp/sfa/contact/ > >>>> ListContacts.ftl"/> > >>>> +      >         >     </html> > >>>>      >         >   </platform-specific> > >>>> -      >         >   <container style="screenlet"> > >>>> -      >         >     <container style="screenlet- > >>>> title-bar"> > >>>> -      >         >       <container > >>>> style="h3"><label > text="${uiLabelMap.SfaFindResults}"/></container> > >>>> -      >         >     </container> > >>>> -      >         >     <container style="screenlet- > >>>> body"> > >>>> -      >         >       <section> > >>>> -      >         >         > <condition> > >>>> -      >         >         >   <not><if-empty > >>>> field="partyList"/></not> > >>>> -      >         >         > </condition> > >>>> -      >         >         > <widgets> > >>>> -      >         >         >   <include-form > >>>> name="ListContacts" > location="component://marketing/widget/sfa/ > >>>> forms/ContactForms.xml"/> > >>>> -      >         >         > </widgets> > >>>> -      >         >         > <fail-widgets> > >>>> -      >         >         >   <container > >>>> style="h3"> > >>>> -      >         >         >     <label text="$ > >>>> {uiLabelMap.PartyNoPartiesFound}"/> > >>>> -      >         >         >   </container> > >>>> -      >         >         > </fail-widgets> > >>>> -      >         >       </section> > >>>> -      >         >     </container> > >>>> -      >         >   </container> > >>>>      >         > </widgets> > >>>>      >       </section> > >>>>      >     </decorator-section> > >>>> > >>>> Modified: > ofbiz/trunk/applications/marketing/widget/sfa/ > >>>> LeadScreens.xml > >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml?rev=785703&r1=785702&r2=785703&view=diff > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> > ===================================================================== > >>>> --- > ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml > >>>> (original) > >>>> +++ > ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml > >>>> Wed Jun 17 16:21:29 2009 > >>>> @@ -37,25 +37,11 @@ > >>>>      >         >   <include-menu name="LeadSubTabBar" > >>>> > location="component://marketing/widget/sfa/SfaMenus.xml"/> > >>>>      >         >   <container style="no-clear"> > >>>>      >         >     <platform-specific> > >>>> -      >         >       > <html><html-template > >>>> > location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/ > >>>>> </html> > >>>> +      >         >       <html> > >>>> +      >         >         > <html-template > >>>> > location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/> > >>>> +      >         >         > <html-template > >>>> > location="component://marketing/webapp/sfa/lead/ListLeads.ftl"/> > >>>> +      >         >       </html> > >>>>      >         >     </platform-specific> > >>>> -      >         >     <screenlet title="$ > >>>> {uiLabelMap.SfaFindResults}"> > >>>> -      >         >       <section> > >>>> -      >         >         > <condition> > >>>> -      >         >         >   <not> > >>>> -      >         >         >     <if-empty > >>>> field="partyList"/> > >>>> -      >         >         >   </not> > >>>> -      >         >         > </condition> > >>>> -      >         >         > <widgets> > >>>> -      >         >         >   <include-form > >>>> name="ListLeads" > location="component://marketing/widget/sfa/forms/ > >>>> LeadForms.xml"/> > >>>> -      >         >         > </widgets> > >>>> -      >         >         > <fail-widgets> > >>>> -      >         >         >   <container > >>>> style="h3"> > >>>> -      >         >         >     <label text="$ > >>>> {uiLabelMap.PartyNoPartiesFound}"/> > >>>> -      >         >         >   </container> > >>>> -      >         >         > </fail-widgets> > >>>> -      >         >       </section> > >>>> -      >         >     </screenlet> > >>>>      >         >   </container> > >>>>      >         > </widgets> > >>>>      >       </section> > >>>> > >>>> Modified: > ofbiz/trunk/applications/marketing/widget/sfa/forms/ > >>>> AccountForms.xml > >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml?rev=785703&r1=785702&r2=785703&view=diff > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> > ===================================================================== > >>>> --- > ofbiz/trunk/applications/marketing/widget/sfa/forms/ > >>>> AccountForms.xml (original) > >>>> +++ > ofbiz/trunk/applications/marketing/widget/sfa/forms/ > >>>> AccountForms.xml Wed Jun 17 16:21:29 2009 > >>>> @@ -21,23 +21,6 @@ > >>>> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" > >>>>    > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd > >>>> "> > >>>> > >>>> -  <form > name="ListAccounts" type="list" list-name="partyList" > >>>> paginate-target="FindAccount" > >>>> -    > odd-row-style="alternate-row" default-table-style="basic- > >>>> table hover-bar"> > >>>> -    > <row-actions> > >>>> -      > <entity-one entity-name="PartyGroup" value- > >>>> field="partyGroup"/> > >>>> -    > </row-actions> > >>>> -    <field > name="partyId" title="${uiLabelMap.PartyPartyId}"> > >>>> -      > <hyperlink target="viewprofile" description="$ > >>>> {partyId}" target-type="inter-app"> > >>>> -      >   <parameter param-name="partyId"/> > >>>> -      > </hyperlink> > >>>> -    > </field> > >>>> -    <field > name="partyName" title="${uiLabelMap.PartyName}"> > >>>> -      > <hyperlink target="viewprofile" description="$ > >>>> {partyGroup.groupName}" > target-type="inter-app"> > >>>> -      >   <parameter param-name="partyId"/> > >>>> -      > </hyperlink> > >>>> -    > </field> > >>>> -    <field > name="partyTypeId" title="$ > >>>> > {uiLabelMap.PartyType}"><display-entity > entity-name="PartyType"/></ > >>>> field> > >>>> -  </form> > >>>>  <form name="NewAccount" > type="single" target="createAccount" > >>>> header-row-style="header-row" > default-table-style="basic-table"> > >>>>    <field > name="accountType"><hidden > value="${accountType}"/></ > >>>> field> > >>>>    <field > name="groupName" title="$ > >>>> {uiLabelMap.PartyGroupName}" > tooltip="${uiLabelMap.CommonRequired}" > >>>> widget-style="required"> > >>>> > >>>> Modified: > ofbiz/trunk/applications/marketing/widget/sfa/forms/ > >>>> LeadForms.xml > >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml?rev=785703&r1=785702&r2=785703&view=diff > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> = > >>>> > ===================================================================== > >>>> --- > ofbiz/trunk/applications/marketing/widget/sfa/forms/ > >>>> LeadForms.xml (original) > >>>> +++ > ofbiz/trunk/applications/marketing/widget/sfa/forms/ > >>>> LeadForms.xml Wed Jun 17 16:21:29 2009 > >>>> @@ -21,27 +21,6 @@ > >>>> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" > >>>>    > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd > >>>> "> > >>>> > >>>> -  <form name="ListLeads" > type="list" list-name="partyList" list- > >>>> entry-name="partyRow" > paginate-target="FindLead" > >>>> -    > odd-row-style="alternate-row" default-table-style="basic- > >>>> table hover-bar" > separate-columns="true"> > >>>> -    > <row-actions> > >>>> -      > <entity-one entity-name="PartyNameView" value- > >>>> field="partyName"> > >>>> -      >   <field-map field-name="partyId" from- > >>>> field="partyRow.partyId"/> > >>>> -      > </entity-one> > >>>> -      > <set field="statusId" > from-field="partyRow.statusId"/> > >>>> -    > </row-actions> > >>>> -    <field > name="partyId" title="${uiLabelMap.PartyPartyId}"> > >>>> -      > <hyperlink target="viewprofile" description="$ > >>>> {partyRow.partyId}"> > >>>> -      >   <parameter param-name="partyId" from- > >>>> field="partyRow.partyId"/> > >>>> -      > </hyperlink> > >>>> -    > </field> > >>>> -    <field > name="partyName" title="${uiLabelMap.PartyName}"> > >>>> -      > <hyperlink target="viewprofile" description="$ > >>>> {partyName.lastName}${partyName.groupName} > ${partyName.firstName} "> > >>>> -      >   <parameter param-name="partyId" from- > >>>> field="partyRow.partyId"/> > >>>> -      > </hyperlink> > >>>> -    > </field> > >>>> -    <field > name="statusId" title="$ > >>>> > {uiLabelMap.CommonStatus}"><display-entity > entity-name="StatusItem" > >>>> description="${description}" > key-field-name="statusId"/></field> > >>>> -  </form> > >>>> - > >>>>  <form name="createLead" > type="single" target="createLead" > >>>> header-row-style="header-row" > default-table-style="basic-table" > >>>> default-map-name="contactDetailMap"> > >>>>    <field > name="firstName" tooltip="$ > >>>> {uiLabelMap.CommonRequired}" > widget-style="required"><text/></field> > >>>>    <field > name="lastName" tooltip="$ > >>>> {uiLabelMap.CommonRequired}" > widget-style="required"><text/></field> > >>>> > >>>> > >>> --Antwebsystems.com: Quality OFBiz services > for competitive rates > >>> > >> > > --Antwebsystems.com: Quality OFBiz services for > competitive rates > > > > |
Re: svn commit: r785703 - in /ofbiz/trunk/applications/mark
|
|
Adrian,
Thanks for your comments. In this case my argument is If Form widget is not doing the Job then I need to use freemarker unless I am ready to invest in Form widget enhancements. At the end software has to do what business requires and not other way round. I cannot deliver something to customer and say we cannot give certain behavior because its not supported by our preferred technology. Regards Anil Patel On Jun 18, 2009, at 12:08 AM, Adrian Crum wrote: > > Anil and Hans, > > The screen widgets were preferred over FTL originally because they > allow rendering to different devices. FTL files are HTML-specific. A > Swing interface was considered as an alternative to HTML, but to my > knowledge, no one has ever implemented a Swing interface for OFBiz. > > After the screen widgets caught on, some users preferred them over > FTL because of the auto-complete feature available in XML editors. > > The down side of widgets is they are inflexible - changing their > behavior requires changing Java code and a recompile. Changing an > FTL file's behavior is much easier. > > There are pros and cons to both, and the debate between the two will > go on... much like Apple vs PC. > > -Adrian > > --- On Wed, 6/17/09, Anil Patel <[hidden email]> wrote: > >> From: Anil Patel <[hidden email]> >> Subject: Re: svn commit: r785703 - in /ofbiz/trunk/applications/ >> marketing: webapp/sfa/account/ webapp/sfa/contact/ webapp/sfa/lead/ >> widget/sfa/ widget/sfa/forms/ >> To: [hidden email] >> Cc: "Anil Patel" <[hidden email]> >> Date: Wednesday, June 17, 2009, 8:49 PM >> Hans, >> findParty is a complex service and cannot be simply >> replaced by performFind on view entity like >> PartyAndContactMech (or similar) view entity. >> >> I don't mind replacing Forms based artifact with ftl if >> that's what I need to do deliver right behavior. Forms is >> preferred tools but only when it makes sense. Whoever did >> forms based screen implementation did not test it enough >> else they will not add it to trunk and we will not be >> talking about ftl replacing forms. >> >> Regards >> Anil Patel >> >> On Jun 17, 2009, at 10:57 PM, Hans Bakker wrote: >> >>> Hi Anil, >>> >>> you write: >>>> Ashish is claiming that he used ftl because forms >> widget based >>>> artifact did not do the job. >>> Then i would like to know why forms did not do the >> job. >>> >>> i am wondering anyway why the sfa application does not >> use the standard >>> performfind for contacts/leads/accounts as now most of >> the applications >>> use and is using the old findParty service which was >> created way before >>> performFind existed. >>> >>> If you would use the PartyAndContactMech view with >> perform find, then >>> the same search can be created as exist now with >> findParty. >>> contact/lead/account can be the same screens, only the >> role selection is >>> different. >>> >>> If we would have that, extra search fields can then be >> easily added what >>> is now pretty difficult. >>> >>> This change replaces forms with ftl's and, i am sorry >> to ask, is that >>> acceptable? >>> >>> Regards, >>> Hans >>> >>> >>> >>> On Wed, 2009-06-17 at 22:41 -0400, Anil Patel wrote: >>>> Hans, >>>> Ashish is claiming that he used ftl because forms >> widget based >>>> artifact did not do the job. If you (or somebody >> in community) can >>>> help to fix the issue then I agree with you, we >> should not be using >>>> ftls. At the end of day, we write screens so they >> are usable and not >>>> because we love to use form widget over freemarker >> template, right? >>>> >>>> Regards >>>> Anil Patel >>>> >>>> >>>> >>>> On Jun 17, 2009, at 12:46 PM, Hans Bakker wrote: >>>> >>>>> I am sorry to see that more and more ftl is >> used. >>>>> >>>>> we agreed to use as less as possible ftl's in >> the backend, they are >>>>> difficult to maintain and to extend. >>>>> Asish, I stopped it in the project manager and >> it is starting here now >>>>> again. >>>>> >>>>> is this the way we want to go...? >>>>> >>>>> not my choice. >>>>> >>>>> other opinions? >>>>> >>>>> >>>>> On Wed, 2009-06-17 at 16:21 +0000, [hidden email] >> wrote: >>>>>> Author: ashish >>>>>> Date: Wed Jun 17 16:21:29 2009 >>>>>> New Revision: 785703 >>>>>> >>>>>> URL: http://svn.apache.org/viewvc?rev=785703&view=rev >>>>>> Log: >>>>>> Applied patch from jira issue OFBIZ-2622 >> (Paginations in SFA >>>>>> Screens(Account, Contacts and Leads)) >>>>>> Thanks Chirag for your contribution on >> this. >>>>>> >>>>>> Added: >>>>>> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>>> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>>> ListAccounts.ftl (with >> props) >>>>>> ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>>>> ListContacts.ftl (with >> props) >>>>>> ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>>>> ListLeads.ftl (with >> props) >>>>>> Modified: >>>>>> ofbiz/trunk/applications/marketing/widget/sfa/ >>>>>> AccountScreens.xml >>>>>> ofbiz/trunk/applications/marketing/widget/sfa/ >>>>>> ContactScreens.xml >>>>>> ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml >>>>>> ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>>> AccountForms.xml >>>>>> ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>>> LeadForms.xml >>>>>> >>>>>> Added: >> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>>> ListAccounts.ftl >>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl?rev=785703&view=auto >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> >> ===================================================================== >>>>>> --- >> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>>> ListAccounts.ftl (added) >>>>>> +++ >> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>>> ListAccounts.ftl Wed Jun 17 16:21:29 2009 >>>>>> @@ -0,0 +1,76 @@ >>>>>> +<#-- >>>>>> +Licensed to the Apache Software >> Foundation (ASF) under one >>>>>> +or more contributor license >> agreements. See the NOTICE file >>>>>> +distributed with this work for additional >> information >>>>>> +regarding copyright ownership. The >> ASF licenses this file >>>>>> +to you under the Apache License, Version >> 2.0 (the >>>>>> +"License"); you may not use this file >> except in compliance >>>>>> +with the License. You may obtain a >> copy of the License at >>>>>> + >>>>>> +http://www.apache.org/licenses/LICENSE-2.0 >>>>>> + >>>>>> +Unless required by applicable law or >> agreed to in writing, >>>>>> +software distributed under the License is >> distributed on an >>>>>> +"AS IS" BASIS, WITHOUT WARRANTIES OR >> CONDITIONS OF ANY >>>>>> +KIND, either express or implied. >> See the License for the >>>>>> +specific language governing permissions >> and limitations >>>>>> +under the License. >>>>>> +--> >>>>>> + >>>>>> +<div class="screenlet"> >>>>>> + <div >> class="screenlet-title-bar"> >>>>>> + <ul> >>>>>> + <#if >> (partyListSize > 0)> >>>>>> + <#if >> (partyListSize > highIndex)> >>>>>> + >> <li><a class="nav-next button-col" >>>>>> >> href="<@ofbizUrl>FindAccounts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >>>>>> >> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>>>> >> {uiLabelMap.CommonNext}</a></li> >>>>>> + >> <#else> >>>>>> + <li >> class="disabled button-col">$ >>>>>> {uiLabelMap.CommonNext}</li> >>>>>> + </#if> >>>>>> + >> <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} >> $ >>>>>> {partyListSize}</li> >>>>>> + <#if >> (viewIndex > 0)> >>>>>> + >> <li><a class="nav-previous button-col" >>>>>> >> href="<@ofbizUrl>FindAccounts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >>>>>> >> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>>>> >> {uiLabelMap.CommonPrevious}</a></li> >>>>>> + >> <#else> >>>>>> + <li >> class="disabled button-col">$ >>>>>> {uiLabelMap.CommonPrevious}</li> >>>>>> + </#if> >>>>>> + </#if> >>>>>> + </ul> >>>>>> + </div> >>>>>> + <div >> class="screenlet-body"> >>>>>> + >> <h2>${uiLabelMap.SfaFindResults}</h2> >>>>>> + <#if >> partyList?exists> >>>>>> + <#if >> partyList?has_content> >>>>>> + <table >> class="basic-table hover-bar" cellspacing="0"> >>>>>> + <tr >> class="header-row-2"> >>>>>> + >> <td>${uiLabelMap.PartyPartyId}</td> >>>>>> + >> <td>${uiLabelMap.PartyName}</td> >>>>>> + >> <td>${uiLabelMap.PartyType}</td> >>>>>> + >> </tr> >>>>>> + >> <#assign alt_row = false> >>>>>> + >> <#list partyList as partyRow> >>>>>> + >> <#assign partyType = >>>>>> >> partyRow.getRelatedOne("PartyType")?if_exists> >>>>>> + >> <tr valign="middle"<#if alt_row> class="alternate- >>>>>> row"</#if>> >>>>>> + >> <td><a >> href="<@ofbizUrl>viewprofile?partyId=$ >>>>>> >> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >>>>>> + >> <td> >>>>>> + >> <#if >>>>>> >> partyRow.getModelEntity().isField("groupName") && >>>>>> partyRow.groupName?has_content> >>>>>> + >> <a >> href="<@ofbizUrl>viewprofile?partyId=$ >>>>>> >> {partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> >>>>>> + >> <#else> >>>>>> + >> <#assign partyName = >>>>>> >> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, >>>>>> true)> >>>>>> + >> <#if partyName?has_content> >>>>>> + >> <a >> href="<@ofbizUrl>viewprofile?partyId=$ >>>>>> >> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> >>>>>> + >> <#else> >>>>>> + >> >> (${uiLabelMap.PartyNoNameFound}) >>>>>> + >> </#if> >>>>>> + >> </#if> >>>>>> + >> </td> >>>>>> + >> <td><#if partyType.description?exists>$ >>>>>> {partyType.get("description", >> locale)}<#else>???</#if></td> >>>>>> + >> </tr> >>>>>> + >> <#-- toggle the row color --> >>>>>> + >> <#assign alt_row = !alt_row> >>>>>> + >> </#list> >>>>>> + >> </table> >>>>>> + <#else> >>>>>> + >> ${uiLabelMap.PartyNoPartiesFound} >>>>>> + </#if> >>>>>> + </#if> >>>>>> + </div> >>>>>> +</div> >>>>>> \ No newline at end of file >>>>>> >>>>>> Propchange: >> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>>> ListAccounts.ftl >>>>>> >> ------------------------------------------------------------------------------ >>>>>> svn:eol-style = native >>>>>> >>>>>> Propchange: >> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>>> ListAccounts.ftl >>>>>> >> ------------------------------------------------------------------------------ >>>>>> svn:keywords = Date Rev >> Author URL Id >>>>>> >>>>>> Propchange: >> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>>> ListAccounts.ftl >>>>>> >> ------------------------------------------------------------------------------ >>>>>> svn:mime-type = >> text/plain >>>>>> >>>>>> Added: >> ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>>>> ListContacts.ftl >>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl?rev=785703&view=auto >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> >> ===================================================================== >>>>>> --- >> ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>>>> ListContacts.ftl (added) >>>>>> +++ >> ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>>>> ListContacts.ftl Wed Jun 17 16:21:29 2009 >>>>>> @@ -0,0 +1,75 @@ >>>>>> +<#-- >>>>>> +Licensed to the Apache Software >> Foundation (ASF) under one >>>>>> +or more contributor license >> agreements. See the NOTICE file >>>>>> +distributed with this work for additional >> information >>>>>> +regarding copyright ownership. The >> ASF licenses this file >>>>>> +to you under the Apache License, Version >> 2.0 (the >>>>>> +"License"); you may not use this file >> except in compliance >>>>>> +with the License. You may obtain a >> copy of the License at >>>>>> + >>>>>> +http://www.apache.org/licenses/LICENSE-2.0 >>>>>> + >>>>>> +Unless required by applicable law or >> agreed to in writing, >>>>>> +software distributed under the License is >> distributed on an >>>>>> +"AS IS" BASIS, WITHOUT WARRANTIES OR >> CONDITIONS OF ANY >>>>>> +KIND, either express or implied. >> See the License for the >>>>>> +specific language governing permissions >> and limitations >>>>>> +under the License. >>>>>> +--> >>>>>> + >>>>>> +<div class="screenlet"> >>>>>> + <div >> class="screenlet-title-bar"> >>>>>> + <ul> >>>>>> + <#if >> (partyListSize > 0)> >>>>>> + <#if >> (partyListSize > highIndex)> >>>>>> + >> <li><a class="nav-next button-col" >>>>>> >> href="<@ofbizUrl>FindContacts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >>>>>> >> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>>>> >> {uiLabelMap.CommonNext}</a></li> >>>>>> + >> <#else> >>>>>> + <li >> class="disabled button-col">$ >>>>>> {uiLabelMap.CommonNext}</li> >>>>>> + </#if> >>>>>> + >> <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} >> $ >>>>>> {partyListSize}</li> >>>>>> + <#if >> (viewIndex > 0)> >>>>>> + >> <li><a class="nav-previous button-col" >>>>>> >> href="<@ofbizUrl>FindContacts?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >>>>>> >> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>>>> >> {uiLabelMap.CommonPrevious}</a></li> >>>>>> + >> <#else> >>>>>> + <li >> class="disabled button-col">$ >>>>>> {uiLabelMap.CommonPrevious}</li> >>>>>> + </#if> >>>>>> + </#if> >>>>>> + </ul> >>>>>> + </div> >>>>>> + <div >> class="screenlet-body"> >>>>>> + >> <h2>${uiLabelMap.SfaFindResults}</h2> >>>>>> + <#if >> partyList?exists> >>>>>> + <#if >> partyList?has_content> >>>>>> + <table >> class="basic-table hover-bar" cellspacing="0"> >>>>>> + <tr >> class="header-row-2"> >>>>>> + >> <td>${uiLabelMap.PartyPartyId}</td> >>>>>> + >> <td>${uiLabelMap.PartyName}</td> >>>>>> + >> <td>${uiLabelMap.SfaVCard}</td> >>>>>> + >> </tr> >>>>>> + >> <#assign alt_row = false> >>>>>> + >> <#list partyList as partyRow> >>>>>> + >> <tr valign="middle"<#if alt_row> class="alternate- >>>>>> row"</#if>> >>>>>> + >> <td><a >> href="<@ofbizUrl>viewprofile?partyId=$ >>>>>> >> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >>>>>> + >> <td> >>>>>> + >> <#if >> partyRow.getModelEntity().isField("lastName") >>>>>> && lastName?has_content> >>>>>> + >> <a >> href="<@ofbizUrl>viewprofile?partyId=$ >>>>>> >> {partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if >>>>>> partyRow.firstName?has_content>, >> ${partyRow.firstName}</#if></a> >>>>>> + >> <#else> >>>>>> + >> <#assign partyName = >>>>>> >> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, >>>>>> true)> >>>>>> + >> <#if partyName?has_content> >>>>>> + >> <a >> href="<@ofbizUrl>viewprofile?partyId=$ >>>>>> >> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> >>>>>> + >> <#else> >>>>>> + >> >> (${uiLabelMap.PartyNoNameFound}) >>>>>> + >> </#if> >>>>>> + >> </#if> >>>>>> + >> </td> >>>>>> + >> <td><a >> href="<@ofbizUrl>createVCardFromContact? >>>>>> >> partyId=${partyRow.partyId}</@ofbizUrl>">${uiLabelMap.SfaVCard}<a></ >>>>>> td> >>>>>> + >> </tr> >>>>>> + >> <#-- toggle the row color --> >>>>>> + >> <#assign alt_row = !alt_row> >>>>>> + >> </#list> >>>>>> + >> </table> >>>>>> + <#else> >>>>>> + >> ${uiLabelMap.PartyNoPartiesFound} >>>>>> + </#if> >>>>>> + </#if> >>>>>> + </div> >>>>>> +</div> >>>>>> \ No newline at end of file >>>>>> >>>>>> Propchange: >> ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>>>> ListContacts.ftl >>>>>> >> ------------------------------------------------------------------------------ >>>>>> svn:eol-style = native >>>>>> >>>>>> Propchange: >> ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>>>> ListContacts.ftl >>>>>> >> ------------------------------------------------------------------------------ >>>>>> svn:keywords = Date Rev >> Author URL Id >>>>>> >>>>>> Propchange: >> ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>>>> ListContacts.ftl >>>>>> >> ------------------------------------------------------------------------------ >>>>>> svn:mime-type = >> text/plain >>>>>> >>>>>> Added: >> ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>>>> ListLeads.ftl >>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl?rev=785703&view=auto >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> >> ===================================================================== >>>>>> --- >> ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>>>> ListLeads.ftl (added) >>>>>> +++ >> ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>>>> ListLeads.ftl Wed Jun 17 16:21:29 2009 >>>>>> @@ -0,0 +1,78 @@ >>>>>> +<#-- >>>>>> +Licensed to the Apache Software >> Foundation (ASF) under one >>>>>> +or more contributor license >> agreements. See the NOTICE file >>>>>> +distributed with this work for additional >> information >>>>>> +regarding copyright ownership. The >> ASF licenses this file >>>>>> +to you under the Apache License, Version >> 2.0 (the >>>>>> +"License"); you may not use this file >> except in compliance >>>>>> +with the License. You may obtain a >> copy of the License at >>>>>> + >>>>>> +http://www.apache.org/licenses/LICENSE-2.0 >>>>>> + >>>>>> +Unless required by applicable law or >> agreed to in writing, >>>>>> +software distributed under the License is >> distributed on an >>>>>> +"AS IS" BASIS, WITHOUT WARRANTIES OR >> CONDITIONS OF ANY >>>>>> +KIND, either express or implied. >> See the License for the >>>>>> +specific language governing permissions >> and limitations >>>>>> +under the License. >>>>>> +--> >>>>>> + >>>>>> +<div class="screenlet"> >>>>>> + <div >> class="screenlet-title-bar"> >>>>>> + <ul> >>>>>> + <#if >> (partyListSize > 0)> >>>>>> + <#if >> (partyListSize > highIndex)> >>>>>> + >> <li><a class="nav-next button-col" >>>>>> >> href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >>>>>> >> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>>>> >> {uiLabelMap.CommonNext}</a></li> >>>>>> + >> <#else> >>>>>> + <li >> class="disabled button-col">$ >>>>>> {uiLabelMap.CommonNext}</li> >>>>>> + </#if> >>>>>> + >> <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} >> $ >>>>>> {partyListSize}</li> >>>>>> + <#if >> (viewIndex > 0)> >>>>>> + >> <li><a class="nav-previous button-col" >>>>>> >> href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >>>>>> >> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>>>> >> {uiLabelMap.CommonPrevious}</a></li> >>>>>> + >> <#else> >>>>>> + <li >> class="disabled button-col">$ >>>>>> {uiLabelMap.CommonPrevious}</li> >>>>>> + </#if> >>>>>> + </#if> >>>>>> + </ul> >>>>>> + </div> >>>>>> + <div >> class="screenlet-body"> >>>>>> + >> <h2>${uiLabelMap.SfaFindResults}</h2> >>>>>> + <#if >> partyList?exists> >>>>>> + <#if >> partyList?has_content> >>>>>> + <table >> class="basic-table hover-bar" cellspacing="0"> >>>>>> + <tr >> class="header-row-2"> >>>>>> + >> <td>${uiLabelMap.PartyPartyId}</td> >>>>>> + >> <td>${uiLabelMap.PartyName}</td> >>>>>> + >> <td>${uiLabelMap.CommonStatus}</td> >>>>>> + >> </tr> >>>>>> + >> <#assign alt_row = false> >>>>>> + >> <#list partyList as partyRow> >>>>>> + >> <#assign status = delegator.findOne("StatusItem", >>>>>> {"statusId":partyRow.statusId}, >> false)?if_exists> >>>>>> + >> <tr valign="middle"<#if alt_row> class="alternate- >>>>>> row"</#if>> >>>>>> + >> <td><a >> href="<@ofbizUrl>viewprofile?partyId=$ >>>>>> >> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >>>>>> + >> <td> >>>>>> + >> <#if >>>>>> >> partyRow.getModelEntity().isField("groupName") && >>>>>> partyRow.groupName?has_content> >>>>>> + >> <a >> href="<@ofbizUrl>viewprofile?partyId=$ >>>>>> >> {partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> >>>>>> + >> <#elseif >>>>>> >> partyRow.getModelEntity().isField("lastName") && >> lastName? >>>>>> has_content> >>>>>> + >> <a >> href="<@ofbizUrl>viewprofile?partyId=$ >>>>>> >> {partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if >>>>>> partyRow.firstName?has_content>, >> ${partyRow.firstName}</#if></a> >>>>>> + >> <#else> >>>>>> + >> <#assign partyName = >>>>>> >> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, >>>>>> true)> >>>>>> + >> <#if partyName?has_content> >>>>>> + >> <a >> href="<@ofbizUrl>viewprofile?partyId=$ >>>>>> >> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> >>>>>> + >> <#else> >>>>>> + >> >> (${uiLabelMap.PartyNoNameFound}) >>>>>> + >> </#if> >>>>>> + >> </#if> >>>>>> + >> </td> >>>>>> + >> <td><#if status.description?exists>$ >>>>>> {status.get("description", >> locale)}<#else>???</#if></td> >>>>>> + >> </tr> >>>>>> + >> <#-- toggle the row color --> >>>>>> + >> <#assign alt_row = !alt_row> >>>>>> + >> </#list> >>>>>> + >> </table> >>>>>> + <#else> >>>>>> + >> ${uiLabelMap.PartyNoPartiesFound} >>>>>> + </#if> >>>>>> + </#if> >>>>>> + </div> >>>>>> +</div> >>>>>> \ No newline at end of file >>>>>> >>>>>> Propchange: >> ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>>>> ListLeads.ftl >>>>>> >> ------------------------------------------------------------------------------ >>>>>> svn:eol-style = native >>>>>> >>>>>> Propchange: >> ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>>>> ListLeads.ftl >>>>>> >> ------------------------------------------------------------------------------ >>>>>> svn:keywords = Date Rev >> Author URL Id >>>>>> >>>>>> Propchange: >> ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>>>> ListLeads.ftl >>>>>> >> ------------------------------------------------------------------------------ >>>>>> svn:mime-type = >> text/plain >>>>>> >>>>>> Modified: >> ofbiz/trunk/applications/marketing/widget/sfa/ >>>>>> AccountScreens.xml >>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> >> ===================================================================== >>>>>> --- >> ofbiz/trunk/applications/marketing/widget/sfa/ >>>>>> AccountScreens.xml (original) >>>>>> +++ >> ofbiz/trunk/applications/marketing/widget/sfa/ >>>>>> AccountScreens.xml Wed Jun 17 16:21:29 >> 2009 >>>>>> @@ -40,32 +40,11 @@ >>>>>> >> >> <section> >>>>>> >> >> <widgets> >>>>>> >> >> >> <platform-specific> >>>>>> - >> >> >> <html><html-template >>>>>> >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/ >>>>>>> </html> >>>>>> + >> >> >> <html> >>>>>> + >> >> >> <html-template >>>>>> >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/> >>>>>> + >> >> >> <html-template >>>>>> >> location="component://marketing/webapp/sfa/account/ >>>>>> ListAccounts.ftl"/> >>>>>> + >> >> >> </html> >>>>>> >> >> >> </platform-specific> >>>>>> - >> >> <container >>>>>> style="screenlet"> >>>>>> - >> >> >> <container >>>>>> style="screenlet-title-bar"> >>>>>> - >> >> >> <container >>>>>> style="h3"> >>>>>> - >> >> >> <label text="$ >>>>>> {uiLabelMap.SfaFindResults}"/> >>>>>> - >> >> >> </container> >>>>>> - >> >> >> </container> >>>>>> - >> >> >> <container >>>>>> style="screenlet-body"> >>>>>> - >> >> >> <section> >>>>>> - >> >> >> <condition> >>>>>> - >> >> >> <not> >>>>>> - >> >> >> >> <if- >>>>>> empty field="partyList"/> >>>>>> - >> >> >> </not> >>>>>> - >> >> >> </condition> >>>>>> - >> >> >> <widgets> >>>>>> - >> >> >> <include- >>>>>> form name="ListAccounts" >> location="component://marketing/widget/sfa/ >>>>>> forms/AccountForms.xml"/> >>>>>> - >> >> >> </widgets> >>>>>> - >> >> >> <fail-widgets> >>>>>> - >> >> >> <container >>>>>> style="h3"> >>>>>> - >> >> >> >> <label >>>>>> >> text="${uiLabelMap.PartyNoPartiesFound}"/> >>>>>> - >> >> >> >> </container> >>>>>> - >> >> >> </fail-widgets> >>>>>> - >> >> >> </section> >>>>>> - >> >> >> </container> >>>>>> - >> >> >> </container> >>>>>> >> >> </widgets> >>>>>> >> >> </section> >>>>>> >> >> </widgets> >>>>>> >>>>>> Modified: >> ofbiz/trunk/applications/marketing/widget/sfa/ >>>>>> ContactScreens.xml >>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> >> ===================================================================== >>>>>> --- >> ofbiz/trunk/applications/marketing/widget/sfa/ >>>>>> ContactScreens.xml (original) >>>>>> +++ >> ofbiz/trunk/applications/marketing/widget/sfa/ >>>>>> ContactScreens.xml Wed Jun 17 16:21:29 >> 2009 >>>>>> @@ -37,28 +37,11 @@ >>>>>> >> >> <widgets> >>>>>> >> >> <include-menu >>>>>> name="ContactSubTabBar" >> location="component://marketing/widget/sfa/ >>>>>> SfaMenus.xml"/> >>>>>> >> >> <platform-specific> >>>>>> - >> >> <html><html-template >>>>>> >> location="component://marketing/webapp/sfa/party/ >>>>>> findContactParty.ftl"/></html> >>>>>> + >> >> <html> >>>>>> + >> >> <html-template >>>>>> >> location="component://marketing/webapp/sfa/party/ >>>>>> findContactParty.ftl"/> >>>>>> + >> >> <html-template >>>>>> >> location="component://marketing/webapp/sfa/contact/ >>>>>> ListContacts.ftl"/> >>>>>> + >> >> </html> >>>>>> >> >> </platform-specific> >>>>>> - >> >> <container style="screenlet"> >>>>>> - >> >> <container style="screenlet- >>>>>> title-bar"> >>>>>> - >> >> <container >>>>>> style="h3"><label >> text="${uiLabelMap.SfaFindResults}"/></container> >>>>>> - >> >> </container> >>>>>> - >> >> <container style="screenlet- >>>>>> body"> >>>>>> - >> >> <section> >>>>>> - >> >> >> <condition> >>>>>> - >> >> >> <not><if-empty >>>>>> field="partyList"/></not> >>>>>> - >> >> >> </condition> >>>>>> - >> >> >> <widgets> >>>>>> - >> >> >> <include-form >>>>>> name="ListContacts" >> location="component://marketing/widget/sfa/ >>>>>> forms/ContactForms.xml"/> >>>>>> - >> >> >> </widgets> >>>>>> - >> >> >> <fail-widgets> >>>>>> - >> >> >> <container >>>>>> style="h3"> >>>>>> - >> >> >> <label text="$ >>>>>> {uiLabelMap.PartyNoPartiesFound}"/> >>>>>> - >> >> >> </container> >>>>>> - >> >> >> </fail-widgets> >>>>>> - >> >> </section> >>>>>> - >> >> </container> >>>>>> - >> >> </container> >>>>>> >> >> </widgets> >>>>>> >> </section> >>>>>> >> </decorator-section> >>>>>> >>>>>> Modified: >> ofbiz/trunk/applications/marketing/widget/sfa/ >>>>>> LeadScreens.xml >>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> >> ===================================================================== >>>>>> --- >> ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml >>>>>> (original) >>>>>> +++ >> ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml >>>>>> Wed Jun 17 16:21:29 2009 >>>>>> @@ -37,25 +37,11 @@ >>>>>> >> >> <include-menu name="LeadSubTabBar" >>>>>> >> location="component://marketing/widget/sfa/SfaMenus.xml"/> >>>>>> >> >> <container style="no-clear"> >>>>>> >> >> <platform-specific> >>>>>> - >> >> >> <html><html-template >>>>>> >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/ >>>>>>> </html> >>>>>> + >> >> <html> >>>>>> + >> >> >> <html-template >>>>>> >> location="component://marketing/webapp/sfa/party/findSfaParty.ftl"/> >>>>>> + >> >> >> <html-template >>>>>> >> location="component://marketing/webapp/sfa/lead/ListLeads.ftl"/> >>>>>> + >> >> </html> >>>>>> >> >> </platform-specific> >>>>>> - >> >> <screenlet title="$ >>>>>> {uiLabelMap.SfaFindResults}"> >>>>>> - >> >> <section> >>>>>> - >> >> >> <condition> >>>>>> - >> >> >> <not> >>>>>> - >> >> >> <if-empty >>>>>> field="partyList"/> >>>>>> - >> >> >> </not> >>>>>> - >> >> >> </condition> >>>>>> - >> >> >> <widgets> >>>>>> - >> >> >> <include-form >>>>>> name="ListLeads" >> location="component://marketing/widget/sfa/forms/ >>>>>> LeadForms.xml"/> >>>>>> - >> >> >> </widgets> >>>>>> - >> >> >> <fail-widgets> >>>>>> - >> >> >> <container >>>>>> style="h3"> >>>>>> - >> >> >> <label text="$ >>>>>> {uiLabelMap.PartyNoPartiesFound}"/> >>>>>> - >> >> >> </container> >>>>>> - >> >> >> </fail-widgets> >>>>>> - >> >> </section> >>>>>> - >> >> </screenlet> >>>>>> >> >> </container> >>>>>> >> >> </widgets> >>>>>> >> </section> >>>>>> >>>>>> Modified: >> ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>>> AccountForms.xml >>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml?rev=785703&r1=785702&r2=785703&view=diff >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> >> ===================================================================== >>>>>> --- >> ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>>> AccountForms.xml (original) >>>>>> +++ >> ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>>> AccountForms.xml Wed Jun 17 16:21:29 2009 >>>>>> @@ -21,23 +21,6 @@ >>>>>> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >>>>>> >> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd >>>>>> "> >>>>>> >>>>>> - <form >> name="ListAccounts" type="list" list-name="partyList" >>>>>> paginate-target="FindAccount" >>>>>> - >> odd-row-style="alternate-row" default-table-style="basic- >>>>>> table hover-bar"> >>>>>> - >> <row-actions> >>>>>> - >> <entity-one entity-name="PartyGroup" value- >>>>>> field="partyGroup"/> >>>>>> - >> </row-actions> >>>>>> - <field >> name="partyId" title="${uiLabelMap.PartyPartyId}"> >>>>>> - >> <hyperlink target="viewprofile" description="$ >>>>>> {partyId}" target-type="inter-app"> >>>>>> - >> <parameter param-name="partyId"/> >>>>>> - >> </hyperlink> >>>>>> - >> </field> >>>>>> - <field >> name="partyName" title="${uiLabelMap.PartyName}"> >>>>>> - >> <hyperlink target="viewprofile" description="$ >>>>>> {partyGroup.groupName}" >> target-type="inter-app"> >>>>>> - >> <parameter param-name="partyId"/> >>>>>> - >> </hyperlink> >>>>>> - >> </field> >>>>>> - <field >> name="partyTypeId" title="$ >>>>>> >> {uiLabelMap.PartyType}"><display-entity >> entity-name="PartyType"/></ >>>>>> field> >>>>>> - </form> >>>>>> <form name="NewAccount" >> type="single" target="createAccount" >>>>>> header-row-style="header-row" >> default-table-style="basic-table"> >>>>>> <field >> name="accountType"><hidden >> value="${accountType}"/></ >>>>>> field> >>>>>> <field >> name="groupName" title="$ >>>>>> {uiLabelMap.PartyGroupName}" >> tooltip="${uiLabelMap.CommonRequired}" >>>>>> widget-style="required"> >>>>>> >>>>>> Modified: >> ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>>> LeadForms.xml >>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml?rev=785703&r1=785702&r2=785703&view=diff >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> = >>>>>> >> ===================================================================== >>>>>> --- >> ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>>> LeadForms.xml (original) >>>>>> +++ >> ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>>> LeadForms.xml Wed Jun 17 16:21:29 2009 >>>>>> @@ -21,27 +21,6 @@ >>>>>> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >>>>>> >> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd >>>>>> "> >>>>>> >>>>>> - <form name="ListLeads" >> type="list" list-name="partyList" list- >>>>>> entry-name="partyRow" >> paginate-target="FindLead" >>>>>> - >> odd-row-style="alternate-row" default-table-style="basic- >>>>>> table hover-bar" >> separate-columns="true"> >>>>>> - >> <row-actions> >>>>>> - >> <entity-one entity-name="PartyNameView" value- >>>>>> field="partyName"> >>>>>> - >> <field-map field-name="partyId" from- >>>>>> field="partyRow.partyId"/> >>>>>> - >> </entity-one> >>>>>> - >> <set field="statusId" >> from-field="partyRow.statusId"/> >>>>>> - >> </row-actions> >>>>>> - <field >> name="partyId" title="${uiLabelMap.PartyPartyId}"> >>>>>> - >> <hyperlink target="viewprofile" description="$ >>>>>> {partyRow.partyId}"> >>>>>> - >> <parameter param-name="partyId" from- >>>>>> field="partyRow.partyId"/> >>>>>> - >> </hyperlink> >>>>>> - >> </field> >>>>>> - <field >> name="partyName" title="${uiLabelMap.PartyName}"> >>>>>> - >> <hyperlink target="viewprofile" description="$ >>>>>> {partyName.lastName}${partyName.groupName} >> ${partyName.firstName} "> >>>>>> - >> <parameter param-name="partyId" from- >>>>>> field="partyRow.partyId"/> >>>>>> - >> </hyperlink> >>>>>> - >> </field> >>>>>> - <field >> name="statusId" title="$ >>>>>> >> {uiLabelMap.CommonStatus}"><display-entity >> entity-name="StatusItem" >>>>>> description="${description}" >> key-field-name="statusId"/></field> >>>>>> - </form> >>>>>> - >>>>>> <form name="createLead" >> type="single" target="createLead" >>>>>> header-row-style="header-row" >> default-table-style="basic-table" >>>>>> default-map-name="contactDetailMap"> >>>>>> <field >> name="firstName" tooltip="$ >>>>>> {uiLabelMap.CommonRequired}" >> widget-style="required"><text/></field> >>>>>> <field >> name="lastName" tooltip="$ >>>>>> {uiLabelMap.CommonRequired}" >> widget-style="required"><text/></field> >>>>>> >>>>>> >>>>> --Antwebsystems.com: Quality OFBiz services >> for competitive rates >>>>> >>>> >>> --Antwebsystems.com: Quality OFBiz services for >> competitive rates >>> >> >> > > > |
Re: svn commit: r785703 - in /ofbiz/trunk/applications/mark
|
|
In reply to this post by Anil Patel-3
Yes, clearly we cannot change that to use the perform find service because the find party service uses a dynamic view entity for performance reasons. If we used a static view in city the temporary table would be so wide that for large databases it could take tens of seconds or many minutes to do a single query. For the forms themselves, it would be great to see what was hard to do that was easier to do in the FTL file and then discuss if an enhancement to the form widget might make sense. - David On Jun 17, 2009, at 9:49 PM, Anil Patel wrote: > Hans, > findParty is a complex service and cannot be simply replaced by > performFind on view entity like PartyAndContactMech (or similar) > view entity. > > I don't mind replacing Forms based artifact with ftl if that's what > I need to do deliver right behavior. Forms is preferred tools but > only when it makes sense. Whoever did forms based screen > implementation did not test it enough else they will not add it to > trunk and we will not be talking about ftl replacing forms. > > Regards > Anil Patel > > On Jun 17, 2009, at 10:57 PM, Hans Bakker wrote: > >> Hi Anil, >> >> you write: >>> Ashish is claiming that he used ftl because forms widget based >>> artifact did not do the job. >> Then i would like to know why forms did not do the job. >> >> i am wondering anyway why the sfa application does not use the >> standard >> performfind for contacts/leads/accounts as now most of the >> applications >> use and is using the old findParty service which was created way >> before >> performFind existed. >> >> If you would use the PartyAndContactMech view with perform find, then >> the same search can be created as exist now with findParty. >> contact/lead/account can be the same screens, only the role >> selection is >> different. >> >> If we would have that, extra search fields can then be easily added >> what >> is now pretty difficult. >> >> This change replaces forms with ftl's and, i am sorry to ask, is that >> acceptable? >> >> Regards, >> Hans >> >> >> >> On Wed, 2009-06-17 at 22:41 -0400, Anil Patel wrote: >>> Hans, >>> Ashish is claiming that he used ftl because forms widget based >>> artifact did not do the job. If you (or somebody in community) can >>> help to fix the issue then I agree with you, we should not be using >>> ftls. At the end of day, we write screens so they are usable and not >>> because we love to use form widget over freemarker template, right? >>> >>> Regards >>> Anil Patel >>> >>> >>> >>> On Jun 17, 2009, at 12:46 PM, Hans Bakker wrote: >>> >>>> I am sorry to see that more and more ftl is used. >>>> >>>> we agreed to use as less as possible ftl's in the backend, they are >>>> difficult to maintain and to extend. >>>> Asish, I stopped it in the project manager and it is starting >>>> here now >>>> again. >>>> >>>> is this the way we want to go...? >>>> >>>> not my choice. >>>> >>>> other opinions? >>>> >>>> >>>> On Wed, 2009-06-17 at 16:21 +0000, [hidden email] wrote: >>>>> Author: ashish >>>>> Date: Wed Jun 17 16:21:29 2009 >>>>> New Revision: 785703 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=785703&view=rev >>>>> Log: >>>>> Applied patch from jira issue OFBIZ-2622 (Paginations in SFA >>>>> Screens(Account, Contacts and Leads)) >>>>> Thanks Chirag for your contribution on this. >>>>> >>>>> Added: >>>>> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>> ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>> ListAccounts.ftl (with props) >>>>> ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>>> ListContacts.ftl (with props) >>>>> ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>>> ListLeads.ftl (with props) >>>>> Modified: >>>>> ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml >>>>> ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml >>>>> ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml >>>>> ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>> AccountForms.xml >>>>> ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml >>>>> >>>>> Added: ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>> ListAccounts.ftl >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/account/ListAccounts.ftl?rev=785703&view=auto >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>> ListAccounts.ftl (added) >>>>> +++ ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>> ListAccounts.ftl Wed Jun 17 16:21:29 2009 >>>>> @@ -0,0 +1,76 @@ >>>>> +<#-- >>>>> +Licensed to the Apache Software Foundation (ASF) under one >>>>> +or more contributor license agreements. See the NOTICE file >>>>> +distributed with this work for additional information >>>>> +regarding copyright ownership. The ASF licenses this file >>>>> +to you under the Apache License, Version 2.0 (the >>>>> +"License"); you may not use this file except in compliance >>>>> +with the License. You may obtain a copy of the License at >>>>> + >>>>> +http://www.apache.org/licenses/LICENSE-2.0 >>>>> + >>>>> +Unless required by applicable law or agreed to in writing, >>>>> +software distributed under the License is distributed on an >>>>> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>>>> +KIND, either express or implied. See the License for the >>>>> +specific language governing permissions and limitations >>>>> +under the License. >>>>> +--> >>>>> + >>>>> +<div class="screenlet"> >>>>> + <div class="screenlet-title-bar"> >>>>> + <ul> >>>>> + <#if (partyListSize > 0)> >>>>> + <#if (partyListSize > highIndex)> >>>>> + <li><a class="nav-next button-col" >>>>> href="<@ofbizUrl>FindAccounts?VIEW_SIZE=$ >>>>> {viewSize}&VIEW_INDEX=$ >>>>> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>>> {uiLabelMap.CommonNext}</a></li> >>>>> + <#else> >>>>> + <li class="disabled button-col">$ >>>>> {uiLabelMap.CommonNext}</li> >>>>> + </#if> >>>>> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} $ >>>>> {partyListSize}</li> >>>>> + <#if (viewIndex > 0)> >>>>> + <li><a class="nav-previous button-col" >>>>> href="<@ofbizUrl>FindAccounts?VIEW_SIZE=$ >>>>> {viewSize}&VIEW_INDEX=$ >>>>> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>>> {uiLabelMap.CommonPrevious}</a></li> >>>>> + <#else> >>>>> + <li class="disabled button-col">$ >>>>> {uiLabelMap.CommonPrevious}</li> >>>>> + </#if> >>>>> + </#if> >>>>> + </ul> >>>>> + </div> >>>>> + <div class="screenlet-body"> >>>>> + <h2>${uiLabelMap.SfaFindResults}</h2> >>>>> + <#if partyList?exists> >>>>> + <#if partyList?has_content> >>>>> + <table class="basic-table hover-bar" cellspacing="0"> >>>>> + <tr class="header-row-2"> >>>>> + <td>${uiLabelMap.PartyPartyId}</td> >>>>> + <td>${uiLabelMap.PartyName}</td> >>>>> + <td>${uiLabelMap.PartyType}</td> >>>>> + </tr> >>>>> + <#assign alt_row = false> >>>>> + <#list partyList as partyRow> >>>>> + <#assign partyType = >>>>> partyRow.getRelatedOne("PartyType")?if_exists> >>>>> + <tr valign="middle"<#if alt_row> class="alternate- >>>>> row"</#if>> >>>>> + <td><a href="<@ofbizUrl>viewprofile?partyId=$ >>>>> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >>>>> + <td> >>>>> + <#if >>>>> partyRow.getModelEntity().isField("groupName") && >>>>> partyRow.groupName?has_content> >>>>> + <a href="<@ofbizUrl>viewprofile?partyId=$ >>>>> {partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> >>>>> + <#else> >>>>> + <#assign partyName = >>>>> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, >>>>> true)> >>>>> + <#if partyName?has_content> >>>>> + <a href="<@ofbizUrl>viewprofile?partyId=$ >>>>> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> >>>>> + <#else> >>>>> + (${uiLabelMap.PartyNoNameFound}) >>>>> + </#if> >>>>> + </#if> >>>>> + </td> >>>>> + <td><#if partyType.description?exists>$ >>>>> {partyType.get("description", locale)}<#else>???</#if></td> >>>>> + </tr> >>>>> + <#-- toggle the row color --> >>>>> + <#assign alt_row = !alt_row> >>>>> + </#list> >>>>> + </table> >>>>> + <#else> >>>>> + ${uiLabelMap.PartyNoPartiesFound} >>>>> + </#if> >>>>> + </#if> >>>>> + </div> >>>>> +</div> >>>>> \ No newline at end of file >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>> ListAccounts.ftl >>>>> ------------------------------------------------------------------------------ >>>>> svn:eol-style = native >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>> ListAccounts.ftl >>>>> ------------------------------------------------------------------------------ >>>>> svn:keywords = Date Rev Author URL Id >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/account/ >>>>> ListAccounts.ftl >>>>> ------------------------------------------------------------------------------ >>>>> svn:mime-type = text/plain >>>>> >>>>> Added: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>>> ListContacts.ftl >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/contact/ListContacts.ftl?rev=785703&view=auto >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>>> ListContacts.ftl (added) >>>>> +++ ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>>> ListContacts.ftl Wed Jun 17 16:21:29 2009 >>>>> @@ -0,0 +1,75 @@ >>>>> +<#-- >>>>> +Licensed to the Apache Software Foundation (ASF) under one >>>>> +or more contributor license agreements. See the NOTICE file >>>>> +distributed with this work for additional information >>>>> +regarding copyright ownership. The ASF licenses this file >>>>> +to you under the Apache License, Version 2.0 (the >>>>> +"License"); you may not use this file except in compliance >>>>> +with the License. You may obtain a copy of the License at >>>>> + >>>>> +http://www.apache.org/licenses/LICENSE-2.0 >>>>> + >>>>> +Unless required by applicable law or agreed to in writing, >>>>> +software distributed under the License is distributed on an >>>>> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>>>> +KIND, either express or implied. See the License for the >>>>> +specific language governing permissions and limitations >>>>> +under the License. >>>>> +--> >>>>> + >>>>> +<div class="screenlet"> >>>>> + <div class="screenlet-title-bar"> >>>>> + <ul> >>>>> + <#if (partyListSize > 0)> >>>>> + <#if (partyListSize > highIndex)> >>>>> + <li><a class="nav-next button-col" >>>>> href="<@ofbizUrl>FindContacts?VIEW_SIZE=$ >>>>> {viewSize}&VIEW_INDEX=$ >>>>> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>>> {uiLabelMap.CommonNext}</a></li> >>>>> + <#else> >>>>> + <li class="disabled button-col">$ >>>>> {uiLabelMap.CommonNext}</li> >>>>> + </#if> >>>>> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} $ >>>>> {partyListSize}</li> >>>>> + <#if (viewIndex > 0)> >>>>> + <li><a class="nav-previous button-col" >>>>> href="<@ofbizUrl>FindContacts?VIEW_SIZE=$ >>>>> {viewSize}&VIEW_INDEX=$ >>>>> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>>> {uiLabelMap.CommonPrevious}</a></li> >>>>> + <#else> >>>>> + <li class="disabled button-col">$ >>>>> {uiLabelMap.CommonPrevious}</li> >>>>> + </#if> >>>>> + </#if> >>>>> + </ul> >>>>> + </div> >>>>> + <div class="screenlet-body"> >>>>> + <h2>${uiLabelMap.SfaFindResults}</h2> >>>>> + <#if partyList?exists> >>>>> + <#if partyList?has_content> >>>>> + <table class="basic-table hover-bar" cellspacing="0"> >>>>> + <tr class="header-row-2"> >>>>> + <td>${uiLabelMap.PartyPartyId}</td> >>>>> + <td>${uiLabelMap.PartyName}</td> >>>>> + <td>${uiLabelMap.SfaVCard}</td> >>>>> + </tr> >>>>> + <#assign alt_row = false> >>>>> + <#list partyList as partyRow> >>>>> + <tr valign="middle"<#if alt_row> class="alternate- >>>>> row"</#if>> >>>>> + <td><a href="<@ofbizUrl>viewprofile?partyId=$ >>>>> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >>>>> + <td> >>>>> + <#if >>>>> partyRow.getModelEntity().isField("lastName") >>>>> && lastName?has_content> >>>>> + <a href="<@ofbizUrl>viewprofile?partyId=$ >>>>> {partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if >>>>> partyRow.firstName?has_content>, ${partyRow.firstName}</#if></a> >>>>> + <#else> >>>>> + <#assign partyName = >>>>> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, >>>>> true)> >>>>> + <#if partyName?has_content> >>>>> + <a href="<@ofbizUrl>viewprofile?partyId=$ >>>>> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> >>>>> + <#else> >>>>> + (${uiLabelMap.PartyNoNameFound}) >>>>> + </#if> >>>>> + </#if> >>>>> + </td> >>>>> + <td><a href="<@ofbizUrl>createVCardFromContact? >>>>> partyId=${partyRow.partyId}</@ofbizUrl>">$ >>>>> {uiLabelMap.SfaVCard}<a></ >>>>> td> >>>>> + </tr> >>>>> + <#-- toggle the row color --> >>>>> + <#assign alt_row = !alt_row> >>>>> + </#list> >>>>> + </table> >>>>> + <#else> >>>>> + ${uiLabelMap.PartyNoPartiesFound} >>>>> + </#if> >>>>> + </#if> >>>>> + </div> >>>>> +</div> >>>>> \ No newline at end of file >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>>> ListContacts.ftl >>>>> ------------------------------------------------------------------------------ >>>>> svn:eol-style = native >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>>> ListContacts.ftl >>>>> ------------------------------------------------------------------------------ >>>>> svn:keywords = Date Rev Author URL Id >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/contact/ >>>>> ListContacts.ftl >>>>> ------------------------------------------------------------------------------ >>>>> svn:mime-type = text/plain >>>>> >>>>> Added: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>>> ListLeads.ftl >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/webapp/sfa/lead/ListLeads.ftl?rev=785703&view=auto >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>>> ListLeads.ftl (added) >>>>> +++ ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>>> ListLeads.ftl Wed Jun 17 16:21:29 2009 >>>>> @@ -0,0 +1,78 @@ >>>>> +<#-- >>>>> +Licensed to the Apache Software Foundation (ASF) under one >>>>> +or more contributor license agreements. See the NOTICE file >>>>> +distributed with this work for additional information >>>>> +regarding copyright ownership. The ASF licenses this file >>>>> +to you under the Apache License, Version 2.0 (the >>>>> +"License"); you may not use this file except in compliance >>>>> +with the License. You may obtain a copy of the License at >>>>> + >>>>> +http://www.apache.org/licenses/LICENSE-2.0 >>>>> + >>>>> +Unless required by applicable law or agreed to in writing, >>>>> +software distributed under the License is distributed on an >>>>> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>>>> +KIND, either express or implied. See the License for the >>>>> +specific language governing permissions and limitations >>>>> +under the License. >>>>> +--> >>>>> + >>>>> +<div class="screenlet"> >>>>> + <div class="screenlet-title-bar"> >>>>> + <ul> >>>>> + <#if (partyListSize > 0)> >>>>> + <#if (partyListSize > highIndex)> >>>>> + <li><a class="nav-next button-col" >>>>> href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >>>>> {viewIndex+1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>>> {uiLabelMap.CommonNext}</a></li> >>>>> + <#else> >>>>> + <li class="disabled button-col">$ >>>>> {uiLabelMap.CommonNext}</li> >>>>> + </#if> >>>>> + <li>${lowIndex} - ${highIndex} ${uiLabelMap.CommonOf} $ >>>>> {partyListSize}</li> >>>>> + <#if (viewIndex > 0)> >>>>> + <li><a class="nav-previous button-col" >>>>> href="<@ofbizUrl>FindLeads?VIEW_SIZE=${viewSize}&VIEW_INDEX=$ >>>>> {viewIndex-1}&hideFields=Y${paramList}</@ofbizUrl>">$ >>>>> {uiLabelMap.CommonPrevious}</a></li> >>>>> + <#else> >>>>> + <li class="disabled button-col">$ >>>>> {uiLabelMap.CommonPrevious}</li> >>>>> + </#if> >>>>> + </#if> >>>>> + </ul> >>>>> + </div> >>>>> + <div class="screenlet-body"> >>>>> + <h2>${uiLabelMap.SfaFindResults}</h2> >>>>> + <#if partyList?exists> >>>>> + <#if partyList?has_content> >>>>> + <table class="basic-table hover-bar" cellspacing="0"> >>>>> + <tr class="header-row-2"> >>>>> + <td>${uiLabelMap.PartyPartyId}</td> >>>>> + <td>${uiLabelMap.PartyName}</td> >>>>> + <td>${uiLabelMap.CommonStatus}</td> >>>>> + </tr> >>>>> + <#assign alt_row = false> >>>>> + <#list partyList as partyRow> >>>>> + <#assign status = delegator.findOne("StatusItem", >>>>> {"statusId":partyRow.statusId}, false)?if_exists> >>>>> + <tr valign="middle"<#if alt_row> class="alternate- >>>>> row"</#if>> >>>>> + <td><a href="<@ofbizUrl>viewprofile?partyId=$ >>>>> {partyRow.partyId}</@ofbizUrl>">${partyRow.partyId}</a></td> >>>>> + <td> >>>>> + <#if >>>>> partyRow.getModelEntity().isField("groupName") && >>>>> partyRow.groupName?has_content> >>>>> + <a href="<@ofbizUrl>viewprofile?partyId=$ >>>>> {partyRow.partyId}</@ofbizUrl>">${partyRow.groupName}</a> >>>>> + <#elseif >>>>> partyRow.getModelEntity().isField("lastName") && lastName? >>>>> has_content> >>>>> + <a href="<@ofbizUrl>viewprofile?partyId=$ >>>>> {partyRow.partyId}</@ofbizUrl>">${partyRow.lastName}<#if >>>>> partyRow.firstName?has_content>, ${partyRow.firstName}</#if></a> >>>>> + <#else> >>>>> + <#assign partyName = >>>>> Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, >>>>> true)> >>>>> + <#if partyName?has_content> >>>>> + <a href="<@ofbizUrl>viewprofile?partyId=$ >>>>> {partyRow.partyId}</@ofbizUrl>">${partyName}</a> >>>>> + <#else> >>>>> + (${uiLabelMap.PartyNoNameFound}) >>>>> + </#if> >>>>> + </#if> >>>>> + </td> >>>>> + <td><#if status.description?exists>$ >>>>> {status.get("description", locale)}<#else>???</#if></td> >>>>> + </tr> >>>>> + <#-- toggle the row color --> >>>>> + <#assign alt_row = !alt_row> >>>>> + </#list> >>>>> + </table> >>>>> + <#else> >>>>> + ${uiLabelMap.PartyNoPartiesFound} >>>>> + </#if> >>>>> + </#if> >>>>> + </div> >>>>> +</div> >>>>> \ No newline at end of file >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>>> ListLeads.ftl >>>>> ------------------------------------------------------------------------------ >>>>> svn:eol-style = native >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>>> ListLeads.ftl >>>>> ------------------------------------------------------------------------------ >>>>> svn:keywords = Date Rev Author URL Id >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/webapp/sfa/lead/ >>>>> ListLeads.ftl >>>>> ------------------------------------------------------------------------------ >>>>> svn:mime-type = text/plain >>>>> >>>>> Modified: ofbiz/trunk/applications/marketing/widget/sfa/ >>>>> AccountScreens.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/AccountScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/marketing/widget/sfa/ >>>>> AccountScreens.xml (original) >>>>> +++ ofbiz/trunk/applications/marketing/widget/sfa/ >>>>> AccountScreens.xml Wed Jun 17 16:21:29 2009 >>>>> @@ -40,32 +40,11 @@ >>>>> <section> >>>>> <widgets> >>>>> <platform-specific> >>>>> - <html><html-template >>>>> location="component://marketing/webapp/sfa/party/ >>>>> findSfaParty.ftl"/ >>>>>> </html> >>>>> + <html> >>>>> + <html-template >>>>> location="component://marketing/webapp/sfa/party/ >>>>> findSfaParty.ftl"/> >>>>> + <html-template >>>>> location="component://marketing/webapp/sfa/account/ >>>>> ListAccounts.ftl"/> >>>>> + </html> >>>>> </platform-specific> >>>>> - <container >>>>> style="screenlet"> >>>>> - <container >>>>> style="screenlet-title-bar"> >>>>> - <container >>>>> style="h3"> >>>>> - <label >>>>> text="$ >>>>> {uiLabelMap.SfaFindResults}"/> >>>>> - </container> >>>>> - </container> >>>>> - <container >>>>> style="screenlet-body"> >>>>> - <section> >>>>> - <condition> >>>>> - <not> >>>>> - <if- >>>>> empty field="partyList"/> >>>>> - </not> >>>>> - </condition> >>>>> - <widgets> >>>>> - <include- >>>>> form name="ListAccounts" location="component://marketing/widget/ >>>>> sfa/ >>>>> forms/AccountForms.xml"/> >>>>> - </widgets> >>>>> - <fail- >>>>> widgets> >>>>> - >>>>> <container >>>>> style="h3"> >>>>> - >>>>> <label >>>>> text="${uiLabelMap.PartyNoPartiesFound}"/> >>>>> - </ >>>>> container> >>>>> - </fail- >>>>> widgets> >>>>> - </section> >>>>> - </container> >>>>> - </container> >>>>> </widgets> >>>>> </section> >>>>> </widgets> >>>>> >>>>> Modified: ofbiz/trunk/applications/marketing/widget/sfa/ >>>>> ContactScreens.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/ContactScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/marketing/widget/sfa/ >>>>> ContactScreens.xml (original) >>>>> +++ ofbiz/trunk/applications/marketing/widget/sfa/ >>>>> ContactScreens.xml Wed Jun 17 16:21:29 2009 >>>>> @@ -37,28 +37,11 @@ >>>>> <widgets> >>>>> <include-menu >>>>> name="ContactSubTabBar" location="component://marketing/widget/ >>>>> sfa/ >>>>> SfaMenus.xml"/> >>>>> <platform-specific> >>>>> - <html><html-template >>>>> location="component://marketing/webapp/sfa/party/ >>>>> findContactParty.ftl"/></html> >>>>> + <html> >>>>> + <html-template >>>>> location="component://marketing/webapp/sfa/party/ >>>>> findContactParty.ftl"/> >>>>> + <html-template >>>>> location="component://marketing/webapp/sfa/contact/ >>>>> ListContacts.ftl"/> >>>>> + </html> >>>>> </platform-specific> >>>>> - <container style="screenlet"> >>>>> - <container style="screenlet- >>>>> title-bar"> >>>>> - <container >>>>> style="h3"><label text="${uiLabelMap.SfaFindResults}"/></ >>>>> container> >>>>> - </container> >>>>> - <container style="screenlet- >>>>> body"> >>>>> - <section> >>>>> - <condition> >>>>> - <not><if-empty >>>>> field="partyList"/></not> >>>>> - </condition> >>>>> - <widgets> >>>>> - <include-form >>>>> name="ListContacts" location="component://marketing/widget/sfa/ >>>>> forms/ContactForms.xml"/> >>>>> - </widgets> >>>>> - <fail-widgets> >>>>> - <container >>>>> style="h3"> >>>>> - <label >>>>> text="$ >>>>> {uiLabelMap.PartyNoPartiesFound}"/> >>>>> - </container> >>>>> - </fail-widgets> >>>>> - </section> >>>>> - </container> >>>>> - </container> >>>>> </widgets> >>>>> </section> >>>>> </decorator-section> >>>>> >>>>> Modified: ofbiz/trunk/applications/marketing/widget/sfa/ >>>>> LeadScreens.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml?rev=785703&r1=785702&r2=785703&view=diff >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml >>>>> (original) >>>>> +++ ofbiz/trunk/applications/marketing/widget/sfa/LeadScreens.xml >>>>> Wed Jun 17 16:21:29 2009 >>>>> @@ -37,25 +37,11 @@ >>>>> <include-menu name="LeadSubTabBar" >>>>> location="component://marketing/widget/sfa/SfaMenus.xml"/> >>>>> <container style="no-clear"> >>>>> <platform-specific> >>>>> - <html><html-template >>>>> location="component://marketing/webapp/sfa/party/ >>>>> findSfaParty.ftl"/ >>>>>> </html> >>>>> + <html> >>>>> + <html-template >>>>> location="component://marketing/webapp/sfa/party/ >>>>> findSfaParty.ftl"/> >>>>> + <html-template >>>>> location="component://marketing/webapp/sfa/lead/ListLeads.ftl"/> >>>>> + </html> >>>>> </platform-specific> >>>>> - <screenlet title="$ >>>>> {uiLabelMap.SfaFindResults}"> >>>>> - <section> >>>>> - <condition> >>>>> - <not> >>>>> - <if-empty >>>>> field="partyList"/> >>>>> - </not> >>>>> - </condition> >>>>> - <widgets> >>>>> - <include-form >>>>> name="ListLeads" location="component://marketing/widget/sfa/forms/ >>>>> LeadForms.xml"/> >>>>> - </widgets> >>>>> - <fail-widgets> >>>>> - <container >>>>> style="h3"> >>>>> - <label >>>>> text="$ >>>>> {uiLabelMap.PartyNoPartiesFound}"/> >>>>> - </container> >>>>> - </fail-widgets> >>>>> - </section> >>>>> - </screenlet> >>>>> </container> >>>>> </widgets> >>>>> </section> >>>>> >>>>> Modified: ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>> AccountForms.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml?rev=785703&r1=785702&r2=785703&view=diff >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>> AccountForms.xml (original) >>>>> +++ ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>> AccountForms.xml Wed Jun 17 16:21:29 2009 >>>>> @@ -21,23 +21,6 @@ >>>>> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >>>>> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd >>>>> "> >>>>> >>>>> - <form name="ListAccounts" type="list" list-name="partyList" >>>>> paginate-target="FindAccount" >>>>> - odd-row-style="alternate-row" default-table-style="basic- >>>>> table hover-bar"> >>>>> - <row-actions> >>>>> - <entity-one entity-name="PartyGroup" value- >>>>> field="partyGroup"/> >>>>> - </row-actions> >>>>> - <field name="partyId" title="${uiLabelMap.PartyPartyId}"> >>>>> - <hyperlink target="viewprofile" description="$ >>>>> {partyId}" target-type="inter-app"> >>>>> - <parameter param-name="partyId"/> >>>>> - </hyperlink> >>>>> - </field> >>>>> - <field name="partyName" title="${uiLabelMap.PartyName}"> >>>>> - <hyperlink target="viewprofile" description="$ >>>>> {partyGroup.groupName}" target-type="inter-app"> >>>>> - <parameter param-name="partyId"/> >>>>> - </hyperlink> >>>>> - </field> >>>>> - <field name="partyTypeId" title="$ >>>>> {uiLabelMap.PartyType}"><display-entity entity-name="PartyType"/ >>>>> ></ >>>>> field> >>>>> - </form> >>>>> <form name="NewAccount" type="single" target="createAccount" >>>>> header-row-style="header-row" default-table-style="basic-table"> >>>>> <field name="accountType"><hidden value="${accountType}"/></ >>>>> field> >>>>> <field name="groupName" title="$ >>>>> {uiLabelMap.PartyGroupName}" tooltip="$ >>>>> {uiLabelMap.CommonRequired}" >>>>> widget-style="required"> >>>>> >>>>> Modified: ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>> LeadForms.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/LeadForms.xml?rev=785703&r1=785702&r2=785703&view=diff >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>> LeadForms.xml (original) >>>>> +++ ofbiz/trunk/applications/marketing/widget/sfa/forms/ >>>>> LeadForms.xml Wed Jun 17 16:21:29 2009 >>>>> @@ -21,27 +21,6 @@ >>>>> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >>>>> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd >>>>> "> >>>>> >>>>> - <form name="ListLeads" type="list" list-name="partyList" >>>>> list- >>>>> entry-name="partyRow" paginate-target="FindLead" >>>>> - odd-row-style="alternate-row" default-table-style="basic- >>>>> table hover-bar" separate-columns="true"> >>>>> - <row-actions> >>>>> - <entity-one entity-name="PartyNameView" value- >>>>> field="partyName"> >>>>> - <field-map field-name="partyId" from- >>>>> field="partyRow.partyId"/> >>>>> - </entity-one> >>>>> - <set field="statusId" from- >>>>> field="partyRow.statusId"/> >>>>> - </row-actions> >>>>> - <field name="partyId" title="${uiLabelMap.PartyPartyId}"> >>>>> - <hyperlink target="viewprofile" description="$ >>>>> {partyRow.partyId}"> >>>>> - <parameter param-name="partyId" from- >>>>> field="partyRow.partyId"/> >>>>> - </hyperlink> >>>>> - </field> >>>>> - <field name="partyName" title="${uiLabelMap.PartyName}"> >>>>> - <hyperlink target="viewprofile" description="$ >>>>> {partyName.lastName}${partyName.groupName} $ >>>>> {partyName.firstName} "> >>>>> - <parameter param-name="partyId" from- >>>>> field="partyRow.partyId"/> >>>>> - </hyperlink> >>>>> - </field> >>>>> - <field name="statusId" title="$ >>>>> {uiLabelMap.CommonStatus}"><display-entity entity- >>>>> name="StatusItem" >>>>> description="${description}" key-field-name="statusId"/></field> >>>>> - </form> >>>>> - >>>>> <form name="createLead" type="single" target="createLead" >>>>> header-row-style="header-row" default-table-style="basic-table" >>>>> default-map-name="contactDetailMap"> >>>>> <field name="firstName" tooltip="$ >>>>> {uiLabelMap.CommonRequired}" widget-style="required"><text/></ >>>>> field> >>>>> <field name="lastName" tooltip="$ >>>>> {uiLabelMap.CommonRequired}" widget-style="required"><text/></ >>>>> field> >>>>> >>>>> >>>> -- >>>> Antwebsystems.com: Quality OFBiz services for competitive rates >>>> >>> >> -- >> Antwebsystems.com: Quality OFBiz services for competitive rates >> > |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |