Re: svn commit: r789775 - /ofbiz/trunk/framework/images/webapp/images/prototypejs/controls.js

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r789775 - /ofbiz/trunk/framework/images/webapp/images/prototypejs/controls.js

Adrian Crum
Are you sure you want to modify a third-party library?

-Adrian

[hidden email] wrote:

> Author: apatel
> Date: Tue Jun 30 14:55:43 2009
> New Revision: 789775
>
> URL: http://svn.apache.org/viewvc?rev=789775&view=rev
> Log:
> using method passed in options and default to "get"
>
> Modified:
>     ofbiz/trunk/framework/images/webapp/images/prototypejs/controls.js
>
> Modified: ofbiz/trunk/framework/images/webapp/images/prototypejs/controls.js
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/prototypejs/controls.js?rev=789775&r1=789774&r2=789775&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/images/webapp/images/prototypejs/controls.js (original)
> +++ ofbiz/trunk/framework/images/webapp/images/prototypejs/controls.js Tue Jun 30 14:55:43 2009
> @@ -676,7 +676,7 @@
>        });
>        new Ajax.Updater({ success: this.element }, this.url, options);
>      } else {
> -      var options = Object.extend({ method: 'get' }, this.options.ajaxOptions);
> +      var options = Object.extend({ method: this.options.method || 'get' }, this.options.ajaxOptions);
>        Object.extend(options, {
>          parameters: params,
>          onComplete: this._boundWrapperHandler,
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r789775 - /ofbiz/trunk/framework/images/webapp/images/prototypejs/controls.js

Anil Patel-3
Adrian,
I appreciate your concern. Changes in this commit is bug fix. I am  
tracking all the changes I have made to prototype/scriptaculaus  
library. I'll make sure we migrate these changes or find alternatives  
when library is upgraded in ofbiz.
We take enhancements and bug fixes to their community as well.

Regards
Anil Patel

On Jun 30, 2009, at 10:02 PM, Adrian Crum wrote:

> Are you sure you want to modify a third-party library?
>
> -Adrian
>
> [hidden email] wrote:
>> Author: apatel
>> Date: Tue Jun 30 14:55:43 2009
>> New Revision: 789775
>> URL: http://svn.apache.org/viewvc?rev=789775&view=rev
>> Log:
>> using method passed in options and default to "get" Modified:
>>    ofbiz/trunk/framework/images/webapp/images/prototypejs/controls.js
>> Modified: ofbiz/trunk/framework/images/webapp/images/prototypejs/
>> controls.js
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/prototypejs/controls.js?rev=789775&r1=789774&r2=789775&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/framework/images/webapp/images/prototypejs/
>> controls.js (original)
>> +++ ofbiz/trunk/framework/images/webapp/images/prototypejs/
>> controls.js Tue Jun 30 14:55:43 2009
>> @@ -676,7 +676,7 @@
>>       });
>>       new Ajax.Updater({ success: this.element }, this.url, options);
>>     } else {
>> -      var options = Object.extend({ method: 'get' },  
>> this.options.ajaxOptions);
>> +      var options = Object.extend({ method: this.options.method ||  
>> 'get' }, this.options.ajaxOptions);
>>       Object.extend(options, {
>>         parameters: params,
>>         onComplete: this._boundWrapperHandler,