Re: svn commit: r792420 - in /ofbiz/trunk/framework/entity/src/org/ofbiz/entity: condition/ datasource/ finder/ jdbc/ model/

[Adam Heath-2]

[hidden email] wrote:

> Author: jonesde
> Date: Thu Jul  9 06:48:05 2009
> New Revision: 792420
>
> Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java?rev=792420&r1=792419&r2=792420&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java (original)
> +++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java Thu Jul  9 06:48:05 2009
> @@ -745,9 +745,9 @@
>          if (Debug.timingOn()) {
>              long queryEndTime = System.currentTimeMillis();
>              long queryTotalTime = queryEndTime - queryStartTime;
> -            if (queryTotalTime > 150) {
> +            // TODO remove comment: if (queryTotalTime > 150) {
>                  Debug.logTiming("Ran query in " + queryTotalTime + " milli-seconds: " + sql, module);
> -            }
> +            //}
>          }
>          return new EntityListIterator(sqlP, modelEntity, selectFields, modelFieldTypeReader);
>      }

Er, was this really meant to be checked in?

[BJ Freeman]

is there reason, like performance that is was commented out.
I use this adhoc.
if it is to be configurable, then it should be through the webtools
I don't want to have to re-compile just to use it.

Adam Heath sent the following on 7/9/2009 5:53 AM:

> [hidden email] wrote:
>> Author: jonesde
>> Date: Thu Jul  9 06:48:05 2009
>> New Revision: 792420
>>
>> Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java?rev=792420&r1=792419&r2=792420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java (original)
>> +++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java Thu Jul  9 06:48:05 2009
>> @@ -745,9 +745,9 @@
>>          if (Debug.timingOn()) {
>>              long queryEndTime = System.currentTimeMillis();
>>              long queryTotalTime = queryEndTime - queryStartTime;
>> -            if (queryTotalTime > 150) {
>> +            // TODO remove comment: if (queryTotalTime > 150) {
>>                  Debug.logTiming("Ran query in " + queryTotalTime + " milli-seconds: " + sql, module);
>> -            }
>> +            //}
>>          }
>>          return new EntityListIterator(sqlP, modelEntity, selectFields, modelFieldTypeReader);
>>      }
>
> Er, was this really meant to be checked in?
>

--
BJ Freeman
http://www.businessesnetwork.com/automation
http://bjfreeman.elance.com
http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
Systems Integrator.