Re: svn commit: r792578 - in /ofbiz/trunk/applications/product: config/ script/org/ofbiz/shipment/picklist/ servicedef/ webapp/facility/facility/ widget/facility/

[David E. Jones-2]

How is the "No Grouping" option different from just not selecting any
grouping options?

-David


On Thu, 2009-07-09 at 15:19 +0000, [hidden email] wrote:

> Author: mor
> Date: Thu Jul  9 15:19:47 2009
> New Revision: 792578
>
> URL: http://svn.apache.org/viewvc?rev=792578&view=rev
> Log:
> On picking screen, added a new option called No Grouping. This option cannot be used with any other grouping methods (Shipping Method, Warehouse Area and
> Number of Order Items) on this screen.
>
> Modified:
>     ofbiz/trunk/applications/product/config/ProductUiLabels.xml
>     ofbiz/trunk/applications/product/script/org/ofbiz/shipment/picklist/PicklistServices.xml
>     ofbiz/trunk/applications/product/servicedef/services_picklist.xml
>     ofbiz/trunk/applications/product/webapp/facility/facility/PicklistOptions.ftl
>     ofbiz/trunk/applications/product/widget/facility/FacilityScreens.xml

[Vikas Mayur-3]

Initially the default behavior of the Picking screen was to group  
orders by shipping method and user does not have any choice to select  
any other grouping method. With the introduction of additional  
grouping methods like grouping by Warehouse Area and Number of Order  
Items, I tried to keep the same behavior of the screen, that is if  
user does not select any option then system will still show the  
grouping based on shipping method. The Group by Shipping Method  
checkbox will be checked automatically on Submit in this case.

The reason of adding explicitly an option No Grouping on this screen  
is that it will serve following purpose:

1. The default behavior of the screen will be preserved. If user does  
not select any option it still defaults to shipping method.
2. User can select No Grouping explicitly.
3. Any selection made by the user other than No Grouping method will  
be cleared by just clicking on No Grouping checkbox. Similarly if No  
Grouping was selected, it will be cleared if user try to select any  
other grouping method (Shipping Method, Warehouse Area and Number of  
Order Items). This part is not implemented yet but the idea is to keep  
this something like select all checkbox on multi form while making it  
explicitly clear to the user that he can also go with No Grouping.

Also in future this screen can be extended to add few more grouping  
methods so the way it is done would work nicely, IMO.

HTH

Vikas


On Jul 9, 2009, at 10:51 PM, David E. Jones wrote:

>
> How is the "No Grouping" option different from just not selecting any
> grouping options?
>
> -David
>
>
> On Thu, 2009-07-09 at 15:19 +0000, [hidden email] wrote:
>> Author: mor
>> Date: Thu Jul  9 15:19:47 2009
>> New Revision: 792578
>>
>> URL: http://svn.apache.org/viewvc?rev=792578&view=rev
>> Log:
>> On picking screen, added a new option called No Grouping. This  
>> option cannot be used with any other grouping methods (Shipping  
>> Method, Warehouse Area and
>> Number of Order Items) on this screen.
>>
>> Modified:
>>    ofbiz/trunk/applications/product/config/ProductUiLabels.xml
>>    ofbiz/trunk/applications/product/script/org/ofbiz/shipment/
>> picklist/PicklistServices.xml
>>    ofbiz/trunk/applications/product/servicedef/services_picklist.xml
>>    ofbiz/trunk/applications/product/webapp/facility/facility/
>> PicklistOptions.ftl
>>    ofbiz/trunk/applications/product/widget/facility/
>> FacilityScreens.xml
>
>

[David E. Jones-2]

That sounds pretty complicated. For an end-user wouldn't this result  
in confusing and unexpected behavior? In other words, if they  
unselected all of the check boxes wouldn't they expect to see nothing?

If the side effect is that coming to the screen results in only the  
top form showing, I'd say that's fine (yes, there is an issue with  
checkboxes since you can't tell if the user explicitly unchecked the  
box).

Does anyone else have thoughts on this?

-David


On Jul 10, 2009, at 12:05 AM, Vikas Mayur wrote:

> Initially the default behavior of the Picking screen was to group  
> orders by shipping method and user does not have any choice to  
> select any other grouping method. With the introduction of  
> additional grouping methods like grouping by Warehouse Area and  
> Number of Order Items, I tried to keep the same behavior of the  
> screen, that is if user does not select any option then system will  
> still show the grouping based on shipping method. The Group by  
> Shipping Method checkbox will be checked automatically on Submit in  
> this case.
>
> The reason of adding explicitly an option No Grouping on this screen  
> is that it will serve following purpose:
>
> 1. The default behavior of the screen will be preserved. If user  
> does not select any option it still defaults to shipping method.
> 2. User can select No Grouping explicitly.
> 3. Any selection made by the user other than No Grouping method will  
> be cleared by just clicking on No Grouping checkbox. Similarly if No  
> Grouping was selected, it will be cleared if user try to select any  
> other grouping method (Shipping Method, Warehouse Area and Number of  
> Order Items). This part is not implemented yet but the idea is to  
> keep this something like select all checkbox on multi form while  
> making it explicitly clear to the user that he can also go with No  
> Grouping.
>
> Also in future this screen can be extended to add few more grouping  
> methods so the way it is done would work nicely, IMO.
>
> HTH
>
> Vikas
>
>
> On Jul 9, 2009, at 10:51 PM, David E. Jones wrote:
>
>>
>> How is the "No Grouping" option different from just not selecting any
>> grouping options?
>>
>> -David
>>
>>
>> On Thu, 2009-07-09 at 15:19 +0000, [hidden email] wrote:
>>> Author: mor
>>> Date: Thu Jul  9 15:19:47 2009
>>> New Revision: 792578
>>>
>>> URL: http://svn.apache.org/viewvc?rev=792578&view=rev
>>> Log:
>>> On picking screen, added a new option called No Grouping. This  
>>> option cannot be used with any other grouping methods (Shipping  
>>> Method, Warehouse Area and
>>> Number of Order Items) on this screen.
>>>
>>> Modified:
>>>   ofbiz/trunk/applications/product/config/ProductUiLabels.xml
>>>   ofbiz/trunk/applications/product/script/org/ofbiz/shipment/
>>> picklist/PicklistServices.xml
>>>   ofbiz/trunk/applications/product/servicedef/services_picklist.xml
>>>   ofbiz/trunk/applications/product/webapp/facility/facility/
>>> PicklistOptions.ftl
>>>   ofbiz/trunk/applications/product/widget/facility/
>>> FacilityScreens.xml
>>
>>
>

[Vikas Mayur-3]

Okay, I did some changes again to this screen and this should be  
reflected in rev. 792855. I have removed the No Grouping checkbox and  
changed the screen default behavior to No Grouping whenever user  
browse to this screen. User now again have the ability to select any  
grouping method of his choice and results are displayed on the basis  
of grouping as desired.

To see the results without grouping, the user have to clear all of the  
selected grouping methods.

Vikas

On Jul 10, 2009, at 12:08 PM, David E Jones wrote:

>
> That sounds pretty complicated. For an end-user wouldn't this result  
> in confusing and unexpected behavior? In other words, if they  
> unselected all of the check boxes wouldn't they expect to see nothing?
>
> If the side effect is that coming to the screen results in only the  
> top form showing, I'd say that's fine (yes, there is an issue with  
> checkboxes since you can't tell if the user explicitly unchecked the  
> box).
>
> Does anyone else have thoughts on this?
>
> -David
>
>
> On Jul 10, 2009, at 12:05 AM, Vikas Mayur wrote:
>
>> Initially the default behavior of the Picking screen was to group  
>> orders by shipping method and user does not have any choice to  
>> select any other grouping method. With the introduction of  
>> additional grouping methods like grouping by Warehouse Area and  
>> Number of Order Items, I tried to keep the same behavior of the  
>> screen, that is if user does not select any option then system will  
>> still show the grouping based on shipping method. The Group by  
>> Shipping Method checkbox will be checked automatically on Submit in  
>> this case.
>>
>> The reason of adding explicitly an option No Grouping on this  
>> screen is that it will serve following purpose:
>>
>> 1. The default behavior of the screen will be preserved. If user  
>> does not select any option it still defaults to shipping method.
>> 2. User can select No Grouping explicitly.
>> 3. Any selection made by the user other than No Grouping method  
>> will be cleared by just clicking on No Grouping checkbox. Similarly  
>> if No Grouping was selected, it will be cleared if user try to  
>> select any other grouping method (Shipping Method, Warehouse Area  
>> and Number of Order Items). This part is not implemented yet but  
>> the idea is to keep this something like select all checkbox on  
>> multi form while making it explicitly clear to the user that he can  
>> also go with No Grouping.
>>
>> Also in future this screen can be extended to add few more grouping  
>> methods so the way it is done would work nicely, IMO.
>>
>> HTH
>>
>> Vikas
>>
>>
>> On Jul 9, 2009, at 10:51 PM, David E. Jones wrote:
>>
>>>
>>> How is the "No Grouping" option different from just not selecting  
>>> any
>>> grouping options?
>>>
>>> -David
>>>
>>>
>>> On Thu, 2009-07-09 at 15:19 +0000, [hidden email] wrote:
>>>> Author: mor
>>>> Date: Thu Jul  9 15:19:47 2009
>>>> New Revision: 792578
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=792578&view=rev
>>>> Log:
>>>> On picking screen, added a new option called No Grouping. This  
>>>> option cannot be used with any other grouping methods (Shipping  
>>>> Method, Warehouse Area and
>>>> Number of Order Items) on this screen.
>>>>
>>>> Modified:
>>>>  ofbiz/trunk/applications/product/config/ProductUiLabels.xml
>>>>  ofbiz/trunk/applications/product/script/org/ofbiz/shipment/
>>>> picklist/PicklistServices.xml
>>>>  ofbiz/trunk/applications/product/servicedef/services_picklist.xml
>>>>  ofbiz/trunk/applications/product/webapp/facility/facility/
>>>> PicklistOptions.ftl
>>>>  ofbiz/trunk/applications/product/widget/facility/
>>>> FacilityScreens.xml
>>>
>>>
>>
>