Re: svn commit: r808820 [2/2] - in /ofbiz/trunk: applications/accounting/webapp/accounting/agreement/ applications/accounting/webapp/accounting/fixedasset/ applications/accounting/webapp/accounting/invoice/ applications/accounting/webapp/accounting/lookup/...

[Amit Sharma-10]

Hello Scott,

Pagination is not working, Due to few changes below in your commit r808820.

Modified:
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java

> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java?rev=808820&r1=808819&r2=808820&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java (original)
> +++ ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java Fri Aug 28 08:58:10 2009
> @@ -639,6 +639,9 @@
>              EntityFindOptions efo = new EntityFindOptions();
>              efo.setDistinct(true);
>              efo.setResultSetType(EntityFindOptions.TYPE_SCROLL_INSENSITIVE);
> +            if (maxResults != null) {
> +                efo.setMaxRows(maxResults);
> +            }
>  

Create Problem:-

1) Hit URL  https://localhost:8443/catalog/control/advancedsearch
2) Select Demo Catalog.
3) Depress "Find" button..
4) Will be showing only 25 records (But actually having 39 records).

When we revert the above changes, It works. So please have a look on it.

Thanks & Regards,
-Amit Sharma

[Scott Gray-2]

Hi Amit,

The problems should now be resolved, please update past r809425

Regards
Scott

On 31/08/2009, at 11:39 PM, Amit Sharma wrote:

> Hello Scott,
>
> Pagination is not working, Due to few changes below in your commit  
> r808820.
>
> Modified: ofbiz/trunk/applications/product/src/org/ofbiz/product/
> product/ProductSearch.java
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java?rev=808820&r1=808819&r2=808820&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/applications/product/src/org/ofbiz/product/product/
>> ProductSearch.java (original)
>> +++ ofbiz/trunk/applications/product/src/org/ofbiz/product/product/
>> ProductSearch.java Fri Aug 28 08:58:10 2009
>> @@ -639,6 +639,9 @@
>>             EntityFindOptions efo = new EntityFindOptions();
>>             efo.setDistinct(true);
>>              
>> efo.setResultSetType(EntityFindOptions.TYPE_SCROLL_INSENSITIVE);
>> +            if (maxResults != null) {
>> +                efo.setMaxRows(maxResults);
>> +            }
>>
> Create Problem:-
>
> 1) Hit URL  https://localhost:8443/catalog/control/advancedsearch
> 2) Select Demo Catalog.
> 3) Depress "Find" button..
> 4) Will be showing only 25 records (But actually having 39 records).
>
> When we revert the above changes, It works. So please have a look on  
> it.
>
> Thanks & Regards,
> -Amit Sharma

[Amit Sharma-10]

Hello Scott,

I am working on r809554. Its not working on it.

Thanks,
-Amit Sharma

Scott Gray wrote:

> Hi Amit,
>
> The problems should now be resolved, please update past r809425
>
> Regards
> Scott
>
> On 31/08/2009, at 11:39 PM, Amit Sharma wrote:
>
>> Hello Scott,
>>
>> Pagination is not working, Due to few changes below in your commit
>> r808820.
>>
>> Modified:
>> ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java
>>
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java?rev=808820&r1=808819&r2=808820&view=diff 
>>>
>>> ==============================================================================
>>>
>>> ---
>>> ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java
>>> (original)
>>> +++
>>> ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java
>>> Fri Aug 28 08:58:10 2009
>>> @@ -639,6 +639,9 @@
>>>             EntityFindOptions efo = new EntityFindOptions();
>>>             efo.setDistinct(true);
>>>            
>>> efo.setResultSetType(EntityFindOptions.TYPE_SCROLL_INSENSITIVE);
>>> +            if (maxResults != null) {
>>> +                efo.setMaxRows(maxResults);
>>> +            }
>>>
>> Create Problem:-
>>
>> 1) Hit URL  https://localhost:8443/catalog/control/advancedsearch
>> 2) Select Demo Catalog.
>> 3) Depress "Find" button..
>> 4) Will be showing only 25 records (But actually having 39 records).
>>
>> When we revert the above changes, It works. So please have a look on it.
>>
>> Thanks & Regards,
>> -Amit Sharma
>

[Scott Gray-2]

Thanks Amit, fixed in r809585

Regards
Scott

On 1/09/2009, at 12:39 AM, Amit Sharma wrote:

> Hello Scott,
>
> I am working on r809554. Its not working on it.
>
> Thanks,
> -Amit Sharma
>
> Scott Gray wrote:
>> Hi Amit,
>>
>> The problems should now be resolved, please update past r809425
>>
>> Regards
>> Scott
>>
>> On 31/08/2009, at 11:39 PM, Amit Sharma wrote:
>>
>>> Hello Scott,
>>>
>>> Pagination is not working, Due to few changes below in your commit  
>>> r808820.
>>>
>>> Modified: ofbiz/trunk/applications/product/src/org/ofbiz/product/
>>> product/ProductSearch.java
>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java?rev=808820&r1=808819&r2=808820&view=diff
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> ===================================================================
>>>> --- ofbiz/trunk/applications/product/src/org/ofbiz/product/
>>>> product/ProductSearch.java (original)
>>>> +++ ofbiz/trunk/applications/product/src/org/ofbiz/product/
>>>> product/ProductSearch.java Fri Aug 28 08:58:10 2009
>>>> @@ -639,6 +639,9 @@
>>>>            EntityFindOptions efo = new EntityFindOptions();
>>>>            efo.setDistinct(true);
>>>>            
>>>> efo.setResultSetType(EntityFindOptions.TYPE_SCROLL_INSENSITIVE);
>>>> +            if (maxResults != null) {
>>>> +                efo.setMaxRows(maxResults);
>>>> +            }
>>>>
>>> Create Problem:-
>>>
>>> 1) Hit URL  https://localhost:8443/catalog/control/advancedsearch
>>> 2) Select Demo Catalog.
>>> 3) Depress "Find" button..
>>> 4) Will be showing only 25 records (But actually having 39 records).
>>>
>>> When we revert the above changes, It works. So please have a look  
>>> on it.
>>>
>>> Thanks & Regards,
>>> -Amit Sharma
>>
>

[Amit Sharma-10]

Thanks Scott for quick attention on it. Now pagination is working.

But still having two another issues:-

1) It shows wrong listSize of the results (Its showing 54 but it should
be 39, please see attached Screenshot-1.png).
2) "Next" link of pagination is not working (Not showing remaining
records, see Screenshot-2.png).

Thanks
Amit Sharma

Scott Gray wrote:

> Thanks Amit, fixed in r809585
>
> Regards
> Scott
>
> On 1/09/2009, at 12:39 AM, Amit Sharma wrote:
>
>> Hello Scott,
>>
>> I am working on r809554. Its not working on it.
>>
>> Thanks,
>> -Amit Sharma
>>
>> Scott Gray wrote:
>>> Hi Amit,
>>>
>>> The problems should now be resolved, please update past r809425
>>>
>>> Regards
>>> Scott
>>>
>>> On 31/08/2009, at 11:39 PM, Amit Sharma wrote:
>>>
>>>> Hello Scott,
>>>>
>>>> Pagination is not working, Due to few changes below in your commit
>>>> r808820.
>>>>
>>>> Modified:
>>>> ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java
>>>>
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java?rev=808820&r1=808819&r2=808820&view=diff 
>>>>>
>>>>> ==============================================================================
>>>>>
>>>>> ---
>>>>> ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java
>>>>> (original)
>>>>> +++
>>>>> ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java
>>>>> Fri Aug 28 08:58:10 2009
>>>>> @@ -639,6 +639,9 @@
>>>>>            EntityFindOptions efo = new EntityFindOptions();
>>>>>            efo.setDistinct(true);
>>>>>            
>>>>> efo.setResultSetType(EntityFindOptions.TYPE_SCROLL_INSENSITIVE);
>>>>> +            if (maxResults != null) {
>>>>> +                efo.setMaxRows(maxResults);
>>>>> +            }
>>>>>
>>>> Create Problem:-
>>>>
>>>> 1) Hit URL  https://localhost:8443/catalog/control/advancedsearch
>>>> 2) Select Demo Catalog.
>>>> 3) Depress "Find" button..
>>>> 4) Will be showing only 25 records (But actually having 39 records).
>>>>
>>>> When we revert the above changes, It works. So please have a look
>>>> on it.
>>>>
>>>> Thanks & Regards,
>>>> -Amit Sharma
>>>
>>
>

[Scott Gray-2]

Thanks Amit, I've fixed #2 in r809785 but I'm I don't think #1 is  
related to my changes so you'll need to report the issue in jira as I  
don't have time to dig into it right now.

Regards
Scott

On 1/09/2009, at 2:37 AM, Amit Sharma wrote:

> Thanks Scott for quick attention on it. Now pagination is working.
>
> But still having two another issues:-
>
> 1) It shows wrong listSize of the results (Its showing 54 but it  
> should be 39, please see attached Screenshot-1.png).
> 2) "Next" link of pagination is not working (Not showing remaining  
> records, see Screenshot-2.png).
>
> Thanks
> Amit Sharma
>
> Scott Gray wrote:
>> Thanks Amit, fixed in r809585
>>
>> Regards
>> Scott
>>
>> On 1/09/2009, at 12:39 AM, Amit Sharma wrote:
>>
>>> Hello Scott,
>>>
>>> I am working on r809554. Its not working on it.
>>>
>>> Thanks,
>>> -Amit Sharma
>>>
>>> Scott Gray wrote:
>>>> Hi Amit,
>>>>
>>>> The problems should now be resolved, please update past r809425
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> On 31/08/2009, at 11:39 PM, Amit Sharma wrote:
>>>>
>>>>> Hello Scott,
>>>>>
>>>>> Pagination is not working, Due to few changes below in your  
>>>>> commit r808820.
>>>>>
>>>>> Modified: ofbiz/trunk/applications/product/src/org/ofbiz/product/
>>>>> product/ProductSearch.java
>>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java?rev=808820&r1=808819&r2=808820&view=diff
>>>>>> =
>>>>>> =
>>>>>> =
>>>>>> =
>>>>>> =
>>>>>> =
>>>>>> =
>>>>>> =
>>>>>> =
>>>>>> =
>>>>>> =
>>>>>> =
>>>>>> =
>>>>>> =================================================================
>>>>>> --- ofbiz/trunk/applications/product/src/org/ofbiz/product/
>>>>>> product/ProductSearch.java (original)
>>>>>> +++ ofbiz/trunk/applications/product/src/org/ofbiz/product/
>>>>>> product/ProductSearch.java Fri Aug 28 08:58:10 2009
>>>>>> @@ -639,6 +639,9 @@
>>>>>>           EntityFindOptions efo = new EntityFindOptions();
>>>>>>           efo.setDistinct(true);
>>>>>>            
>>>>>> efo.setResultSetType(EntityFindOptions.TYPE_SCROLL_INSENSITIVE);
>>>>>> +            if (maxResults != null) {
>>>>>> +                efo.setMaxRows(maxResults);
>>>>>> +            }
>>>>>>
>>>>> Create Problem:-
>>>>>
>>>>> 1) Hit URL  https://localhost:8443/catalog/control/advancedsearch
>>>>> 2) Select Demo Catalog.
>>>>> 3) Depress "Find" button..
>>>>> 4) Will be showing only 25 records (But actually having 39  
>>>>> records).
>>>>>
>>>>> When we revert the above changes, It works. So please have a  
>>>>> look on it.
>>>>>
>>>>> Thanks & Regards,
>>>>> -Amit Sharma
>>>>
>>>
>>
>