Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
Locked
Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
 
|
Hi Hans
I don't think the id of the themes should be depended upon within the applications, the necessary styling information should go into each themes css file right? Regards Scott HotWax Media http://www.hotwaxmedia.com On 9/09/2009, at 12:13 AM, [hidden email] wrote: > Author: hansbak > Date: Tue Sep 8 12:13:50 2009 > New Revision: 812477 > > URL: http://svn.apache.org/viewvc?rev=812477&view=rev > Log: > make the help screens also display properly in the business theme > > Modified: > ofbiz/trunk/applications/content/template/HelpTemplate.ftl > > Modified: ofbiz/trunk/applications/content/template/HelpTemplate.ftl > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/template/HelpTemplate.ftl?rev=812477&r1=812476&r2=812477&view=diff > = > = > = > = > = > = > = > = > ====================================================================== > --- ofbiz/trunk/applications/content/template/HelpTemplate.ftl > (original) > +++ ofbiz/trunk/applications/content/template/HelpTemplate.ftl Tue > Sep 8 12:13:50 2009 > @@ -21,9 +21,14 @@ > specific language governing permissions and limitations > under the License. > --> > - > -<#if layoutSettings.VT_NAME[0] == "FLAT_GREY"> > -<#-------------------------------------------> > +<style> > +<#if layoutSettings.VT_NAME[0] == "BIZZNESS_TIME"> > +body{background:none;} > +.left-border{float:left;width:25%;} > +.contentarea{margin: 0 0 0 0.5em;padding:0 0 0 0.5em;} > +.leftonly{float:none;min-height:25em;} > +</#if> > +</style> > <#macro para para> > <p> > <#list para?children as child> > @@ -53,7 +58,8 @@ > </#list> > <br/><br/> > </#macro> > - > +<#if layoutSettings.VT_NAME[0] == "FLAT_GREY"> > +<#-------------------------------------------> > <div class="contentarea"> > <div id="column-container"> > <div id="content-main-section"> > @@ -61,39 +67,10 @@ > </div> > </div> > </div> > - > +<#elseif layoutSettings.VT_NAME[0] == "BIZZNESS_TIME"> > + <@section inSection=doc.section first="yes"/> > <#else><#-- other templates --> > <#-----------------------------> > -<#macro para para> > -<p> > - <#list para?children as child> > - <#if child?node_type = "text"> > - ${child} > - <#elseif child?node_type = 'element' && child?node_name = "link"> > - <a href="${child["@xl:href"]}">${child}</a> > - </#if> > - </#list> > - <br/> > -</p> > -</#macro> > - > -<#macro section inSection first="no"> > - <#list inSection.* as subSection> > - <#if subSection?node_name = "title"> > - <#if first = "yes"> > - <h1>${subSection}</h1> > - <#else> > - <h2>${subSection}</h2> > - </#if> > - <#elseif subSection?node_name = "para"> > - <@para para=subSection/> > - <#elseif subSection?node_name = "section"> > - <@section inSection=subSection/> > - </#if> > - </#list> > - <br/><br/> > -</#macro> > - > <div class="contentarea"> > <div id="column-container"> > <div id="content-main-section"> > > |
smime.p7s (3K)
Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
|
Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
|
|
Hi Hans
The "better way" is just our standard best practices, no inline styling. Don't take this as an attack but is this the procedure we're following these days, give it your best shot and then leave it for others to clean up? Anyone else have an opinion on this? Regards Scott On 9/09/2009, at 12:29 AM, Hans Bakker wrote: > Hi Scott, > > we are no css stylesheet specialists. If you have a better way > implementing this, you are very welcome to change it... > > Thanks, > Hans > > On Wed, 2009-09-09 at 00:18 +1200, Scott Gray wrote: >> Hi Hans >> >> I don't think the id of the themes should be depended upon within the >> applications, the necessary styling information should go into each >> themes css file right? >> >> Regards >> Scott >> >> HotWax Media >> http://www.hotwaxmedia.com >> >> On 9/09/2009, at 12:13 AM, [hidden email] wrote: >> >>> Author: hansbak >>> Date: Tue Sep 8 12:13:50 2009 >>> New Revision: 812477 >>> >>> URL: http://svn.apache.org/viewvc?rev=812477&view=rev >>> Log: >>> make the help screens also display properly in the business theme >>> >>> Modified: >>> ofbiz/trunk/applications/content/template/HelpTemplate.ftl >>> >>> Modified: ofbiz/trunk/applications/content/template/HelpTemplate.ftl >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/template/HelpTemplate.ftl?rev=812477&r1=812476&r2=812477&view=diff >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> ==================================================================== >>> --- ofbiz/trunk/applications/content/template/HelpTemplate.ftl >>> (original) >>> +++ ofbiz/trunk/applications/content/template/HelpTemplate.ftl Tue >>> Sep 8 12:13:50 2009 >>> @@ -21,9 +21,14 @@ >>> specific language governing permissions and limitations >>> under the License. >>> --> >>> - >>> -<#if layoutSettings.VT_NAME[0] == "FLAT_GREY"> >>> -<#-------------------------------------------> >>> +<style> >>> +<#if layoutSettings.VT_NAME[0] == "BIZZNESS_TIME"> >>> +body{background:none;} >>> +.left-border{float:left;width:25%;} >>> +.contentarea{margin: 0 0 0 0.5em;padding:0 0 0 0.5em;} >>> +.leftonly{float:none;min-height:25em;} >>> +</#if> >>> +</style> >>> <#macro para para> >>> <p> >>> <#list para?children as child> >>> @@ -53,7 +58,8 @@ >>> </#list> >>> <br/><br/> >>> </#macro> >>> - >>> +<#if layoutSettings.VT_NAME[0] == "FLAT_GREY"> >>> +<#-------------------------------------------> >>> <div class="contentarea"> >>> <div id="column-container"> >>> <div id="content-main-section"> >>> @@ -61,39 +67,10 @@ >>> </div> >>> </div> >>> </div> >>> - >>> +<#elseif layoutSettings.VT_NAME[0] == "BIZZNESS_TIME"> >>> + <@section inSection=doc.section first="yes"/> >>> <#else><#-- other templates --> >>> <#-----------------------------> >>> -<#macro para para> >>> -<p> >>> - <#list para?children as child> >>> - <#if child?node_type = "text"> >>> - ${child} >>> - <#elseif child?node_type = 'element' && child?node_name = >>> "link"> >>> - <a href="${child["@xl:href"]}">${child}</a> >>> - </#if> >>> - </#list> >>> - <br/> >>> -</p> >>> -</#macro> >>> - >>> -<#macro section inSection first="no"> >>> - <#list inSection.* as subSection> >>> - <#if subSection?node_name = "title"> >>> - <#if first = "yes"> >>> - <h1>${subSection}</h1> >>> - <#else> >>> - <h2>${subSection}</h2> >>> - </#if> >>> - <#elseif subSection?node_name = "para"> >>> - <@para para=subSection/> >>> - <#elseif subSection?node_name = "section"> >>> - <@section inSection=subSection/> >>> - </#if> >>> - </#list> >>> - <br/><br/> >>> -</#macro> >>> - >>> <div class="contentarea"> >>> <div id="column-container"> >>> <div id="content-main-section"> >>> >>> >> > -- > Antwebsystems.com: Quality OFBiz services for competitive rates > |
Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
|
|
No excuse for inline styling - Hans, it's not rocket science at all -
let's get this fixed and not leave it for someone else to clean up - as we know sometimes it's not a huge priority for anyone because they may not see the new inline styling. This goes to the bigger question of usability - which is something we've been working on diligently for a while now. Please don't make this more difficult because you don't want to put in the time to learn a standard technology in OFBiz. Cheers, Tim -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Sep 8, 2009, at 6:38 AM, Scott Gray wrote: > Hi Hans > > The "better way" is just our standard best practices, no inline > styling. > > Don't take this as an attack but is this the procedure we're > following these days, give it your best shot and then leave it for > others to clean up? > > Anyone else have an opinion on this? > > Regards > Scott > > On 9/09/2009, at 12:29 AM, Hans Bakker wrote: > >> Hi Scott, >> >> we are no css stylesheet specialists. If you have a better way >> implementing this, you are very welcome to change it... >> >> Thanks, >> Hans >> >> On Wed, 2009-09-09 at 00:18 +1200, Scott Gray wrote: >>> Hi Hans >>> >>> I don't think the id of the themes should be depended upon within >>> the >>> applications, the necessary styling information should go into each >>> themes css file right? >>> >>> Regards >>> Scott >>> >>> HotWax Media >>> http://www.hotwaxmedia.com >>> >>> On 9/09/2009, at 12:13 AM, [hidden email] wrote: >>> >>>> Author: hansbak >>>> Date: Tue Sep 8 12:13:50 2009 >>>> New Revision: 812477 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=812477&view=rev >>>> Log: >>>> make the help screens also display properly in the business theme >>>> >>>> Modified: >>>> ofbiz/trunk/applications/content/template/HelpTemplate.ftl >>>> >>>> Modified: ofbiz/trunk/applications/content/template/ >>>> HelpTemplate.ftl >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/template/HelpTemplate.ftl?rev=812477&r1=812476&r2=812477&view=diff >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> =================================================================== >>>> --- ofbiz/trunk/applications/content/template/HelpTemplate.ftl >>>> (original) >>>> +++ ofbiz/trunk/applications/content/template/HelpTemplate.ftl Tue >>>> Sep 8 12:13:50 2009 >>>> @@ -21,9 +21,14 @@ >>>> specific language governing permissions and limitations >>>> under the License. >>>> --> >>>> - >>>> -<#if layoutSettings.VT_NAME[0] == "FLAT_GREY"> >>>> -<#-------------------------------------------> >>>> +<style> >>>> +<#if layoutSettings.VT_NAME[0] == "BIZZNESS_TIME"> >>>> +body{background:none;} >>>> +.left-border{float:left;width:25%;} >>>> +.contentarea{margin: 0 0 0 0.5em;padding:0 0 0 0.5em;} >>>> +.leftonly{float:none;min-height:25em;} >>>> +</#if> >>>> +</style> >>>> <#macro para para> >>>> <p> >>>> <#list para?children as child> >>>> @@ -53,7 +58,8 @@ >>>> </#list> >>>> <br/><br/> >>>> </#macro> >>>> - >>>> +<#if layoutSettings.VT_NAME[0] == "FLAT_GREY"> >>>> +<#-------------------------------------------> >>>> <div class="contentarea"> >>>> <div id="column-container"> >>>> <div id="content-main-section"> >>>> @@ -61,39 +67,10 @@ >>>> </div> >>>> </div> >>>> </div> >>>> - >>>> +<#elseif layoutSettings.VT_NAME[0] == "BIZZNESS_TIME"> >>>> + <@section inSection=doc.section first="yes"/> >>>> <#else><#-- other templates --> >>>> <#-----------------------------> >>>> -<#macro para para> >>>> -<p> >>>> - <#list para?children as child> >>>> - <#if child?node_type = "text"> >>>> - ${child} >>>> - <#elseif child?node_type = 'element' && child?node_name = >>>> "link"> >>>> - <a href="${child["@xl:href"]}">${child}</a> >>>> - </#if> >>>> - </#list> >>>> - <br/> >>>> -</p> >>>> -</#macro> >>>> - >>>> -<#macro section inSection first="no"> >>>> - <#list inSection.* as subSection> >>>> - <#if subSection?node_name = "title"> >>>> - <#if first = "yes"> >>>> - <h1>${subSection}</h1> >>>> - <#else> >>>> - <h2>${subSection}</h2> >>>> - </#if> >>>> - <#elseif subSection?node_name = "para"> >>>> - <@para para=subSection/> >>>> - <#elseif subSection?node_name = "section"> >>>> - <@section inSection=subSection/> >>>> - </#if> >>>> - </#list> >>>> - <br/><br/> >>>> -</#macro> >>>> - >>>> <div class="contentarea"> >>>> <div id="column-container"> >>>> <div id="content-main-section"> >>>> >>>> >>> >> -- >> Antwebsystems.com: Quality OFBiz services for competitive rates >> > |
Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
|
|
Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
|
|
Hans, now that you're online this morning - can you comment on this
and how we can expect to go about fixing some of these issues? Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Sep 8, 2009, at 8:34 AM, Adrian Crum wrote: > The problem is more than inline styling - there is a reference to a > specific theme in a Freemarker template. That is a terrible way to > write code, and it is unacceptable from my viewpoint. > > -Adrian > > > Scott Gray wrote: >> Hi Hans >> The "better way" is just our standard best practices, no inline >> styling. >> Don't take this as an attack but is this the procedure we're >> following these days, give it your best shot and then leave it for >> others to clean up? >> Anyone else have an opinion on this? >> Regards >> Scott >> On 9/09/2009, at 12:29 AM, Hans Bakker wrote: >>> Hi Scott, >>> >>> we are no css stylesheet specialists. If you have a better way >>> implementing this, you are very welcome to change it... >>> >>> Thanks, >>> Hans >>> >>> On Wed, 2009-09-09 at 00:18 +1200, Scott Gray wrote: >>>> Hi Hans >>>> >>>> I don't think the id of the themes should be depended upon within >>>> the >>>> applications, the necessary styling information should go into each >>>> themes css file right? >>>> >>>> Regards >>>> Scott >>>> >>>> HotWax Media >>>> http://www.hotwaxmedia.com >>>> >>>> On 9/09/2009, at 12:13 AM, [hidden email] wrote: >>>> >>>>> Author: hansbak >>>>> Date: Tue Sep 8 12:13:50 2009 >>>>> New Revision: 812477 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=812477&view=rev >>>>> Log: >>>>> make the help screens also display properly in the business theme >>>>> >>>>> Modified: >>>>> ofbiz/trunk/applications/content/template/HelpTemplate.ftl >>>>> >>>>> Modified: ofbiz/trunk/applications/content/template/ >>>>> HelpTemplate.ftl >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/template/HelpTemplate.ftl?rev=812477&r1=812476&r2=812477&view=diff >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/content/template/HelpTemplate.ftl >>>>> (original) >>>>> +++ ofbiz/trunk/applications/content/template/HelpTemplate.ftl Tue >>>>> Sep 8 12:13:50 2009 >>>>> @@ -21,9 +21,14 @@ >>>>> specific language governing permissions and limitations >>>>> under the License. >>>>> --> >>>>> - >>>>> -<#if layoutSettings.VT_NAME[0] == "FLAT_GREY"> >>>>> -<#-------------------------------------------> >>>>> +<style> >>>>> +<#if layoutSettings.VT_NAME[0] == "BIZZNESS_TIME"> >>>>> +body{background:none;} >>>>> +.left-border{float:left;width:25%;} >>>>> +.contentarea{margin: 0 0 0 0.5em;padding:0 0 0 0.5em;} >>>>> +.leftonly{float:none;min-height:25em;} >>>>> +</#if> >>>>> +</style> >>>>> <#macro para para> >>>>> <p> >>>>> <#list para?children as child> >>>>> @@ -53,7 +58,8 @@ >>>>> </#list> >>>>> <br/><br/> >>>>> </#macro> >>>>> - >>>>> +<#if layoutSettings.VT_NAME[0] == "FLAT_GREY"> >>>>> +<#-------------------------------------------> >>>>> <div class="contentarea"> >>>>> <div id="column-container"> >>>>> <div id="content-main-section"> >>>>> @@ -61,39 +67,10 @@ >>>>> </div> >>>>> </div> >>>>> </div> >>>>> - >>>>> +<#elseif layoutSettings.VT_NAME[0] == "BIZZNESS_TIME"> >>>>> + <@section inSection=doc.section first="yes"/> >>>>> <#else><#-- other templates --> >>>>> <#-----------------------------> >>>>> -<#macro para para> >>>>> -<p> >>>>> - <#list para?children as child> >>>>> - <#if child?node_type = "text"> >>>>> - ${child} >>>>> - <#elseif child?node_type = 'element' && child?node_name = >>>>> "link"> >>>>> - <a href="${child["@xl:href"]}">${child}</a> >>>>> - </#if> >>>>> - </#list> >>>>> - <br/> >>>>> -</p> >>>>> -</#macro> >>>>> - >>>>> -<#macro section inSection first="no"> >>>>> - <#list inSection.* as subSection> >>>>> - <#if subSection?node_name = "title"> >>>>> - <#if first = "yes"> >>>>> - <h1>${subSection}</h1> >>>>> - <#else> >>>>> - <h2>${subSection}</h2> >>>>> - </#if> >>>>> - <#elseif subSection?node_name = "para"> >>>>> - <@para para=subSection/> >>>>> - <#elseif subSection?node_name = "section"> >>>>> - <@section inSection=subSection/> >>>>> - </#if> >>>>> - </#list> >>>>> - <br/><br/> >>>>> -</#macro> >>>>> - >>>>> <div class="contentarea"> >>>>> <div id="column-container"> >>>>> <div id="content-main-section"> >>>>> >>>>> >>>> >>> -- >>> Antwebsystems.com: Quality OFBiz services for competitive rates >>> |
Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
|
|
Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
|
|
Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
|
|
In reply to this post by hans_bakker
Hi Hans,
Have you had a chance to fix this yet? It's been over a week and I just want to make sure that reviewing commits isn't a waste of my time. Thanks Scott On 9/09/2009, at 2:26 PM, Hans Bakker wrote: > Ok sounds reasonable, we will change it. > Hans > > On Wed, 2009-09-09 at 00:38 +1200, Scott Gray wrote: >> Hi Hans >> >> The "better way" is just our standard best practices, no inline >> styling. >> >> Don't take this as an attack but is this the procedure we're >> following >> these days, give it your best shot and then leave it for others to >> clean up? >> >> Anyone else have an opinion on this? >> >> Regards >> Scott >> >> On 9/09/2009, at 12:29 AM, Hans Bakker wrote: >> >>> Hi Scott, >>> >>> we are no css stylesheet specialists. If you have a better way >>> implementing this, you are very welcome to change it... >>> >>> Thanks, >>> Hans >>> >>> On Wed, 2009-09-09 at 00:18 +1200, Scott Gray wrote: >>>> Hi Hans >>>> >>>> I don't think the id of the themes should be depended upon within >>>> the >>>> applications, the necessary styling information should go into each >>>> themes css file right? >>>> >>>> Regards >>>> Scott >>>> >>>> HotWax Media >>>> http://www.hotwaxmedia.com >>>> >>>> On 9/09/2009, at 12:13 AM, [hidden email] wrote: >>>> >>>>> Author: hansbak >>>>> Date: Tue Sep 8 12:13:50 2009 >>>>> New Revision: 812477 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=812477&view=rev >>>>> Log: >>>>> make the help screens also display properly in the business theme >>>>> >>>>> Modified: >>>>> ofbiz/trunk/applications/content/template/HelpTemplate.ftl >>>>> >>>>> Modified: ofbiz/trunk/applications/content/template/ >>>>> HelpTemplate.ftl >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/template/HelpTemplate.ftl?rev=812477&r1=812476&r2=812477&view=diff >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/content/template/HelpTemplate.ftl >>>>> (original) >>>>> +++ ofbiz/trunk/applications/content/template/HelpTemplate.ftl Tue >>>>> Sep 8 12:13:50 2009 >>>>> @@ -21,9 +21,14 @@ >>>>> specific language governing permissions and limitations >>>>> under the License. >>>>> --> >>>>> - >>>>> -<#if layoutSettings.VT_NAME[0] == "FLAT_GREY"> >>>>> -<#-------------------------------------------> >>>>> +<style> >>>>> +<#if layoutSettings.VT_NAME[0] == "BIZZNESS_TIME"> >>>>> +body{background:none;} >>>>> +.left-border{float:left;width:25%;} >>>>> +.contentarea{margin: 0 0 0 0.5em;padding:0 0 0 0.5em;} >>>>> +.leftonly{float:none;min-height:25em;} >>>>> +</#if> >>>>> +</style> >>>>> <#macro para para> >>>>> <p> >>>>> <#list para?children as child> >>>>> @@ -53,7 +58,8 @@ >>>>> </#list> >>>>> <br/><br/> >>>>> </#macro> >>>>> - >>>>> +<#if layoutSettings.VT_NAME[0] == "FLAT_GREY"> >>>>> +<#-------------------------------------------> >>>>> <div class="contentarea"> >>>>> <div id="column-container"> >>>>> <div id="content-main-section"> >>>>> @@ -61,39 +67,10 @@ >>>>> </div> >>>>> </div> >>>>> </div> >>>>> - >>>>> +<#elseif layoutSettings.VT_NAME[0] == "BIZZNESS_TIME"> >>>>> + <@section inSection=doc.section first="yes"/> >>>>> <#else><#-- other templates --> >>>>> <#-----------------------------> >>>>> -<#macro para para> >>>>> -<p> >>>>> - <#list para?children as child> >>>>> - <#if child?node_type = "text"> >>>>> - ${child} >>>>> - <#elseif child?node_type = 'element' && child?node_name = >>>>> "link"> >>>>> - <a href="${child["@xl:href"]}">${child}</a> >>>>> - </#if> >>>>> - </#list> >>>>> - <br/> >>>>> -</p> >>>>> -</#macro> >>>>> - >>>>> -<#macro section inSection first="no"> >>>>> - <#list inSection.* as subSection> >>>>> - <#if subSection?node_name = "title"> >>>>> - <#if first = "yes"> >>>>> - <h1>${subSection}</h1> >>>>> - <#else> >>>>> - <h2>${subSection}</h2> >>>>> - </#if> >>>>> - <#elseif subSection?node_name = "para"> >>>>> - <@para para=subSection/> >>>>> - <#elseif subSection?node_name = "section"> >>>>> - <@section inSection=subSection/> >>>>> - </#if> >>>>> - </#list> >>>>> - <br/><br/> >>>>> -</#macro> >>>>> - >>>>> <div class="contentarea"> >>>>> <div id="column-container"> >>>>> <div id="content-main-section"> >>>>> >>>>> >>>> >>> -- >>> Antwebsystems.com: Quality OFBiz services for competitive rates >>> >> > -- > Antwebsystems.com: Quality OFBiz services for competitive rates > |
Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
|
|
Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
|
|
Okay thanks Hans, I just wanted to check in.
I'll try and forget that you just suggested I pay you to fix your bad code. Thanks Scott On 18/09/2009, at 1:37 AM, Hans Bakker wrote: > We are creating a css for he docbook documents which we hopefully also > can use for the help..... > > so yes we are working on this but have no idea when it is > done....unless you pay us? > > On Fri, 2009-09-18 at 00:14 +1200, Scott Gray wrote: >> Hi Hans, >> >> Have you had a chance to fix this yet? It's been over a week and I >> just want to make sure that reviewing commits isn't a waste of my >> time. >> >> Thanks >> Scott >> >> On 9/09/2009, at 2:26 PM, Hans Bakker wrote: >> >>> Ok sounds reasonable, we will change it. >>> Hans >>> >>> On Wed, 2009-09-09 at 00:38 +1200, Scott Gray wrote: >>>> Hi Hans >>>> >>>> The "better way" is just our standard best practices, no inline >>>> styling. >>>> >>>> Don't take this as an attack but is this the procedure we're >>>> following >>>> these days, give it your best shot and then leave it for others to >>>> clean up? >>>> >>>> Anyone else have an opinion on this? >>>> >>>> Regards >>>> Scott >>>> >>>> On 9/09/2009, at 12:29 AM, Hans Bakker wrote: >>>> >>>>> Hi Scott, >>>>> >>>>> we are no css stylesheet specialists. If you have a better way >>>>> implementing this, you are very welcome to change it... >>>>> >>>>> Thanks, >>>>> Hans >>>>> >>>>> On Wed, 2009-09-09 at 00:18 +1200, Scott Gray wrote: >>>>>> Hi Hans >>>>>> >>>>>> I don't think the id of the themes should be depended upon within >>>>>> the >>>>>> applications, the necessary styling information should go into >>>>>> each >>>>>> themes css file right? >>>>>> >>>>>> Regards >>>>>> Scott >>>>>> >>>>>> HotWax Media >>>>>> http://www.hotwaxmedia.com >>>>>> >>>>>> On 9/09/2009, at 12:13 AM, [hidden email] wrote: >>>>>> >>>>>>> Author: hansbak >>>>>>> Date: Tue Sep 8 12:13:50 2009 >>>>>>> New Revision: 812477 >>>>>>> >>>>>>> URL: http://svn.apache.org/viewvc?rev=812477&view=rev >>>>>>> Log: >>>>>>> make the help screens also display properly in the business >>>>>>> theme >>>>>>> >>>>>>> Modified: >>>>>>> ofbiz/trunk/applications/content/template/HelpTemplate.ftl >>>>>>> >>>>>>> Modified: ofbiz/trunk/applications/content/template/ >>>>>>> HelpTemplate.ftl >>>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/template/HelpTemplate.ftl?rev=812477&r1=812476&r2=812477&view=diff >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> ================================================================ >>>>>>> --- ofbiz/trunk/applications/content/template/HelpTemplate.ftl >>>>>>> (original) >>>>>>> +++ ofbiz/trunk/applications/content/template/HelpTemplate.ftl >>>>>>> Tue >>>>>>> Sep 8 12:13:50 2009 >>>>>>> @@ -21,9 +21,14 @@ >>>>>>> specific language governing permissions and limitations >>>>>>> under the License. >>>>>>> --> >>>>>>> - >>>>>>> -<#if layoutSettings.VT_NAME[0] == "FLAT_GREY"> >>>>>>> -<#-------------------------------------------> >>>>>>> +<style> >>>>>>> +<#if layoutSettings.VT_NAME[0] == "BIZZNESS_TIME"> >>>>>>> +body{background:none;} >>>>>>> +.left-border{float:left;width:25%;} >>>>>>> +.contentarea{margin: 0 0 0 0.5em;padding:0 0 0 0.5em;} >>>>>>> +.leftonly{float:none;min-height:25em;} >>>>>>> +</#if> >>>>>>> +</style> >>>>>>> <#macro para para> >>>>>>> <p> >>>>>>> <#list para?children as child> >>>>>>> @@ -53,7 +58,8 @@ >>>>>>> </#list> >>>>>>> <br/><br/> >>>>>>> </#macro> >>>>>>> - >>>>>>> +<#if layoutSettings.VT_NAME[0] == "FLAT_GREY"> >>>>>>> +<#-------------------------------------------> >>>>>>> <div class="contentarea"> >>>>>>> <div id="column-container"> >>>>>>> <div id="content-main-section"> >>>>>>> @@ -61,39 +67,10 @@ >>>>>>> </div> >>>>>>> </div> >>>>>>> </div> >>>>>>> - >>>>>>> +<#elseif layoutSettings.VT_NAME[0] == "BIZZNESS_TIME"> >>>>>>> + <@section inSection=doc.section first="yes"/> >>>>>>> <#else><#-- other templates --> >>>>>>> <#-----------------------------> >>>>>>> -<#macro para para> >>>>>>> -<p> >>>>>>> - <#list para?children as child> >>>>>>> - <#if child?node_type = "text"> >>>>>>> - ${child} >>>>>>> - <#elseif child?node_type = 'element' && child?node_name = >>>>>>> "link"> >>>>>>> - <a href="${child["@xl:href"]}">${child}</a> >>>>>>> - </#if> >>>>>>> - </#list> >>>>>>> - <br/> >>>>>>> -</p> >>>>>>> -</#macro> >>>>>>> - >>>>>>> -<#macro section inSection first="no"> >>>>>>> - <#list inSection.* as subSection> >>>>>>> - <#if subSection?node_name = "title"> >>>>>>> - <#if first = "yes"> >>>>>>> - <h1>${subSection}</h1> >>>>>>> - <#else> >>>>>>> - <h2>${subSection}</h2> >>>>>>> - </#if> >>>>>>> - <#elseif subSection?node_name = "para"> >>>>>>> - <@para para=subSection/> >>>>>>> - <#elseif subSection?node_name = "section"> >>>>>>> - <@section inSection=subSection/> >>>>>>> - </#if> >>>>>>> - </#list> >>>>>>> - <br/><br/> >>>>>>> -</#macro> >>>>>>> - >>>>>>> <div class="contentarea"> >>>>>>> <div id="column-container"> >>>>>>> <div id="content-main-section"> >>>>>>> >>>>>>> >>>>>> >>>>> -- >>>>> Antwebsystems.com: Quality OFBiz services for competitive rates >>>>> >>>> >>> -- >>> Antwebsystems.com: Quality OFBiz services for competitive rates >>> >> > -- > Antwebsystems.com: Quality OFBiz services for competitive rates > |
Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
|
|
Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
|
|
Re: svn commit: r812477 - /ofbiz/trunk/applications/cont
|
|
In reply to this post by Anil Patel-3
Inline:
-- Ashish Anil Patel wrote: >> >> so yes we are working on this but have no idea when it is >> done....unless you pay us? >> > > Here we are talking about fixing something that is not as per the > community accepted norms. If it was something I had done and asked to > you help fix it then sure it makes sense to ask for money, but not in > this case :) > > I would prefer not have a contribution in trunk over bad work. I am > sure document on responsibilities of committer says this very clearly. > Responsibility: http://docs.ofbiz.org/x/mQ Thanks! > Regards > > > >> On Fri, 2009-09-18 at 00:14 +1200, Scott Gray wrote: >>> Hi Hans, >>> >>> Have you had a chance to fix this yet? It's been over a week and I >>> just want to make sure that reviewing commits isn't a waste of my time. >>> >>> Thanks >>> Scott >>> >>> On 9/09/2009, at 2:26 PM, Hans Bakker wrote: >>> >>>> Ok sounds reasonable, we will change it. >>>> Hans >>>> >>>> On Wed, 2009-09-09 at 00:38 +1200, Scott Gray wrote: >>>>> Hi Hans >>>>> >>>>> The "better way" is just our standard best practices, no inline >>>>> styling. >>>>> >>>>> Don't take this as an attack but is this the procedure we're >>>>> following >>>>> these days, give it your best shot and then leave it for others to >>>>> clean up? >>>>> >>>>> Anyone else have an opinion on this? >>>>> >>>>> Regards >>>>> Scott >>>>> >>>>> On 9/09/2009, at 12:29 AM, Hans Bakker wrote: >>>>> >>>>>> Hi Scott, >>>>>> >>>>>> we are no css stylesheet specialists. If you have a better way >>>>>> implementing this, you are very welcome to change it... >>>>>> >>>>>> Thanks, >>>>>> Hans >>>>>> >>>>>> On Wed, 2009-09-09 at 00:18 +1200, Scott Gray wrote: >>>>>>> Hi Hans >>>>>>> >>>>>>> I don't think the id of the themes should be depended upon within >>>>>>> the >>>>>>> applications, the necessary styling information should go into each >>>>>>> themes css file right? >>>>>>> >>>>>>> Regards >>>>>>> Scott >>>>>>> >>>>>>> HotWax Media >>>>>>> http://www.hotwaxmedia.com >>>>>>> >>>>>>> On 9/09/2009, at 12:13 AM, [hidden email] wrote: >>>>>>> >>>>>>>> Author: hansbak >>>>>>>> Date: Tue Sep 8 12:13:50 2009 >>>>>>>> New Revision: 812477 >>>>>>>> >>>>>>>> URL: http://svn.apache.org/viewvc?rev=812477&view=rev >>>>>>>> Log: >>>>>>>> make the help screens also display properly in the business theme >>>>>>>> >>>>>>>> Modified: >>>>>>>> ofbiz/trunk/applications/content/template/HelpTemplate.ftl >>>>>>>> >>>>>>>> Modified: ofbiz/trunk/applications/content/template/ >>>>>>>> HelpTemplate.ftl >>>>>>>> URL: >>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/template/HelpTemplate.ftl?rev=812477&r1=812476&r2=812477&view=diff >>>>>>>> >>>>>>>> = >>>>>>>> = >>>>>>>> = >>>>>>>> = >>>>>>>> = >>>>>>>> = >>>>>>>> = >>>>>>>> = >>>>>>>> = >>>>>>>> = >>>>>>>> = >>>>>>>> = >>>>>>>> ================================================================== >>>>>>>> --- ofbiz/trunk/applications/content/template/HelpTemplate.ftl >>>>>>>> (original) >>>>>>>> +++ ofbiz/trunk/applications/content/template/HelpTemplate.ftl Tue >>>>>>>> Sep 8 12:13:50 2009 >>>>>>>> @@ -21,9 +21,14 @@ >>>>>>>> specific language governing permissions and limitations >>>>>>>> under the License. >>>>>>>> --> >>>>>>>> - >>>>>>>> -<#if layoutSettings.VT_NAME[0] == "FLAT_GREY"> >>>>>>>> -<#-------------------------------------------> >>>>>>>> +<style> >>>>>>>> +<#if layoutSettings.VT_NAME[0] == "BIZZNESS_TIME"> >>>>>>>> +body{background:none;} >>>>>>>> +.left-border{float:left;width:25%;} >>>>>>>> +.contentarea{margin: 0 0 0 0.5em;padding:0 0 0 0.5em;} >>>>>>>> +.leftonly{float:none;min-height:25em;} >>>>>>>> +</#if> >>>>>>>> +</style> >>>>>>>> <#macro para para> >>>>>>>> <p> >>>>>>>> <#list para?children as child> >>>>>>>> @@ -53,7 +58,8 @@ >>>>>>>> </#list> >>>>>>>> <br/><br/> >>>>>>>> </#macro> >>>>>>>> - >>>>>>>> +<#if layoutSettings.VT_NAME[0] == "FLAT_GREY"> >>>>>>>> +<#-------------------------------------------> >>>>>>>> <div class="contentarea"> >>>>>>>> <div id="column-container"> >>>>>>>> <div id="content-main-section"> >>>>>>>> @@ -61,39 +67,10 @@ >>>>>>>> </div> >>>>>>>> </div> >>>>>>>> </div> >>>>>>>> - >>>>>>>> +<#elseif layoutSettings.VT_NAME[0] == "BIZZNESS_TIME"> >>>>>>>> + <@section inSection=doc.section first="yes"/> >>>>>>>> <#else><#-- other templates --> >>>>>>>> <#-----------------------------> >>>>>>>> -<#macro para para> >>>>>>>> -<p> >>>>>>>> - <#list para?children as child> >>>>>>>> - <#if child?node_type = "text"> >>>>>>>> - ${child} >>>>>>>> - <#elseif child?node_type = 'element' && child?node_name = >>>>>>>> "link"> >>>>>>>> - <a href="${child["@xl:href"]}">${child}</a> >>>>>>>> - </#if> >>>>>>>> - </#list> >>>>>>>> - <br/> >>>>>>>> -</p> >>>>>>>> -</#macro> >>>>>>>> - >>>>>>>> -<#macro section inSection first="no"> >>>>>>>> - <#list inSection.* as subSection> >>>>>>>> - <#if subSection?node_name = "title"> >>>>>>>> - <#if first = "yes"> >>>>>>>> - <h1>${subSection}</h1> >>>>>>>> - <#else> >>>>>>>> - <h2>${subSection}</h2> >>>>>>>> - </#if> >>>>>>>> - <#elseif subSection?node_name = "para"> >>>>>>>> - <@para para=subSection/> >>>>>>>> - <#elseif subSection?node_name = "section"> >>>>>>>> - <@section inSection=subSection/> >>>>>>>> - </#if> >>>>>>>> - </#list> >>>>>>>> - <br/><br/> >>>>>>>> -</#macro> >>>>>>>> - >>>>>>>> <div class="contentarea"> >>>>>>>> <div id="column-container"> >>>>>>>> <div id="content-main-section"> >>>>>>>> >>>>>>>> >>>>>>> >>>>>> -- >>>>>> Antwebsystems.com: Quality OFBiz services for competitive rates >>>>>> >>>>> >>>> -- >>>> Antwebsystems.com: Quality OFBiz services for competitive rates >>>> >>> >> -- >> Antwebsystems.com: Quality OFBiz services for competitive rates >> > |
| Free forum by Nabble | Edit this page |