Re: svn commit: r819845 - /ofbiz/trunk/framework/common/
Locked
Re: svn commit: r819845 - /ofbiz/trunk/framework/common/
 
|
Re: svn commit: r819845 - /ofbiz/trunk/framework/common/
|
Re: svn commit: r819845 - /ofbiz/trunk/framework/common/
|
|
It would probably be better to have it the other way around i.e.
general.properties containing the final fallback if the database record is missing. Regards Scott HotWax Media http://www.hotwaxmedia.com On 30/09/2009, at 6:17 PM, Hans Bakker wrote: > Ok Adrian your record is back, however can now be overridden by values > in general properties: committed in R820178 > > On Tue, 2009-09-29 at 07:46 -0700, Adrian Crum wrote: >> Hans, >> >> The default theme is supposed to be defined in the database - that is >> part of the visual theme design. Please revert this commit. >> >> -Adrian >> >> [hidden email] wrote: >>> Author: hansbak >>> Date: Tue Sep 29 07:07:51 2009 >>> New Revision: 819845 >>> >>> URL: http://svn.apache.org/viewvc?rev=819845&view=rev >>> Log: >>> default visualthemeId already defined in general properties >>> >>> Modified: >>> ofbiz/trunk/framework/common/data/CommonTypeData.xml >>> >>> Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=819845&r1=819844&r2=819845&view=diff >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> ==================================================================== >>> --- ofbiz/trunk/framework/common/data/CommonTypeData.xml (original) >>> +++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Tue Sep >>> 29 07:07:51 2009 >>> @@ -102,7 +102,7 @@ >>> >>> <!-- User preferences seed data --> >>> <UserPrefGroupType userPrefGroupTypeId="GLOBAL_PREFERENCES" >>> description="Global preferences"/> >>> - <UserPreference userLoginId="_NA_" >>> userPrefTypeId="VISUAL_THEME" >>> userPrefGroupTypeId="GLOBAL_PREFERENCES" >>> userPrefValue="BIZZNESS_TIME"/> >>> + <!-- UserPreference userLoginId="_NA_" >>> userPrefTypeId="VISUAL_THEME" >>> userPrefGroupTypeId="GLOBAL_PREFERENCES" >>> userPrefValue="BIZZNESS_TIME" specified in general properties! --> >>> >>> <!-- Visual Themes seed data --> >>> <EnumerationType description="Visual Theme Resource Type >>> (stylesheet, javascript file, etc)" enumTypeId="VT_RES_TYPE" >>> hasTable="N"/> >>> >>> >>> > -- > Antwebsystems.com: Quality OFBiz services for competitive rates > |
smime.p7s (3K)
Re: svn commit: r819845 - /ofbiz/trunk/framework/common/
|
|
Re: svn commit: r819845 - /ofbiz/trunk/framework/common/
|
|
Stepping back a second, why do we need a setting in general.properties
when we have a database setting as seed data? Regards Scott On 30/09/2009, at 6:38 PM, Hans Bakker wrote: > That is difficult because this is only true for values within the > GLOBAL_PREFERENCES group, and when this is missing in the database, > the > keyvalues are unknown.. > > Regards, > Hans > > On Wed, 2009-09-30 at 18:24 +1300, Scott Gray wrote: >> It would probably be better to have it the other way around i.e. >> general.properties containing the final fallback if the database >> record is missing. >> >> Regards >> Scott >> >> HotWax Media >> http://www.hotwaxmedia.com >> >> On 30/09/2009, at 6:17 PM, Hans Bakker wrote: >> >>> Ok Adrian your record is back, however can now be overridden by >>> values >>> in general properties: committed in R820178 >>> >>> On Tue, 2009-09-29 at 07:46 -0700, Adrian Crum wrote: >>>> Hans, >>>> >>>> The default theme is supposed to be defined in the database - >>>> that is >>>> part of the visual theme design. Please revert this commit. >>>> >>>> -Adrian >>>> >>>> [hidden email] wrote: >>>>> Author: hansbak >>>>> Date: Tue Sep 29 07:07:51 2009 >>>>> New Revision: 819845 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=819845&view=rev >>>>> Log: >>>>> default visualthemeId already defined in general properties >>>>> >>>>> Modified: >>>>> ofbiz/trunk/framework/common/data/CommonTypeData.xml >>>>> >>>>> Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=819845&r1=819844&r2=819845&view=diff >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/framework/common/data/CommonTypeData.xml >>>>> (original) >>>>> +++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Tue Sep >>>>> 29 07:07:51 2009 >>>>> @@ -102,7 +102,7 @@ >>>>> >>>>> <!-- User preferences seed data --> >>>>> <UserPrefGroupType userPrefGroupTypeId="GLOBAL_PREFERENCES" >>>>> description="Global preferences"/> >>>>> - <UserPreference userLoginId="_NA_" >>>>> userPrefTypeId="VISUAL_THEME" >>>>> userPrefGroupTypeId="GLOBAL_PREFERENCES" >>>>> userPrefValue="BIZZNESS_TIME"/> >>>>> + <!-- UserPreference userLoginId="_NA_" >>>>> userPrefTypeId="VISUAL_THEME" >>>>> userPrefGroupTypeId="GLOBAL_PREFERENCES" >>>>> userPrefValue="BIZZNESS_TIME" specified in general properties! --> >>>>> >>>>> <!-- Visual Themes seed data --> >>>>> <EnumerationType description="Visual Theme Resource Type >>>>> (stylesheet, javascript file, etc)" enumTypeId="VT_RES_TYPE" >>>>> hasTable="N"/> >>>>> >>>>> >>>>> >>> -- >>> Antwebsystems.com: Quality OFBiz services for competitive rates >>> >> > -- > Antwebsystems.com: Quality OFBiz services for competitive rates > |
Re: svn commit: r819845 - /ofbiz/trunk/framework/common/
|
|
Re: svn commit: r819845 - /ofbiz/trunk/framework/common/
|
|
I thought we were trying to move away from using property files but
whatever, as long as it's easier for you then I guess we're okay. Regards Scott On 30/09/2009, at 7:10 PM, Hans Bakker wrote: > Basic settings should be defined in general.properties like currency, > decimal point and default visual scheme. > > there was a value for default visual scheme in general properties > but it > was not working. > > Especially for new users (and also me) it is completely not > understandable that they have to change a data file and then clean and > reload the data > > So that is solved now and the setting is general properties is working > so for me it is done now. > > Regards, > Hans > > On Wed, 2009-09-30 at 18:55 +1300, Scott Gray wrote: >> Stepping back a second, why do we need a setting in >> general.properties >> when we have a database setting as seed data? >> >> Regards >> Scott >> >> On 30/09/2009, at 6:38 PM, Hans Bakker wrote: >> >>> That is difficult because this is only true for values within the >>> GLOBAL_PREFERENCES group, and when this is missing in the database, >>> the >>> keyvalues are unknown.. >>> >>> Regards, >>> Hans >>> >>> On Wed, 2009-09-30 at 18:24 +1300, Scott Gray wrote: >>>> It would probably be better to have it the other way around i.e. >>>> general.properties containing the final fallback if the database >>>> record is missing. >>>> >>>> Regards >>>> Scott >>>> >>>> HotWax Media >>>> http://www.hotwaxmedia.com >>>> >>>> On 30/09/2009, at 6:17 PM, Hans Bakker wrote: >>>> >>>>> Ok Adrian your record is back, however can now be overridden by >>>>> values >>>>> in general properties: committed in R820178 >>>>> >>>>> On Tue, 2009-09-29 at 07:46 -0700, Adrian Crum wrote: >>>>>> Hans, >>>>>> >>>>>> The default theme is supposed to be defined in the database - >>>>>> that is >>>>>> part of the visual theme design. Please revert this commit. >>>>>> >>>>>> -Adrian >>>>>> >>>>>> [hidden email] wrote: >>>>>>> Author: hansbak >>>>>>> Date: Tue Sep 29 07:07:51 2009 >>>>>>> New Revision: 819845 >>>>>>> >>>>>>> URL: http://svn.apache.org/viewvc?rev=819845&view=rev >>>>>>> Log: >>>>>>> default visualthemeId already defined in general properties >>>>>>> >>>>>>> Modified: >>>>>>> ofbiz/trunk/framework/common/data/CommonTypeData.xml >>>>>>> >>>>>>> Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml >>>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=819845&r1=819844&r2=819845&view=diff >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> = >>>>>>> ================================================================ >>>>>>> --- ofbiz/trunk/framework/common/data/CommonTypeData.xml >>>>>>> (original) >>>>>>> +++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Tue Sep >>>>>>> 29 07:07:51 2009 >>>>>>> @@ -102,7 +102,7 @@ >>>>>>> >>>>>>> <!-- User preferences seed data --> >>>>>>> <UserPrefGroupType userPrefGroupTypeId="GLOBAL_PREFERENCES" >>>>>>> description="Global preferences"/> >>>>>>> - <UserPreference userLoginId="_NA_" >>>>>>> userPrefTypeId="VISUAL_THEME" >>>>>>> userPrefGroupTypeId="GLOBAL_PREFERENCES" >>>>>>> userPrefValue="BIZZNESS_TIME"/> >>>>>>> + <!-- UserPreference userLoginId="_NA_" >>>>>>> userPrefTypeId="VISUAL_THEME" >>>>>>> userPrefGroupTypeId="GLOBAL_PREFERENCES" >>>>>>> userPrefValue="BIZZNESS_TIME" specified in general properties! >>>>>>> --> >>>>>>> >>>>>>> <!-- Visual Themes seed data --> >>>>>>> <EnumerationType description="Visual Theme Resource Type >>>>>>> (stylesheet, javascript file, etc)" enumTypeId="VT_RES_TYPE" >>>>>>> hasTable="N"/> >>>>>>> >>>>>>> >>>>>>> >>>>> -- >>>>> Antwebsystems.com: Quality OFBiz services for competitive rates >>>>> >>>> >>> -- >>> Antwebsystems.com: Quality OFBiz services for competitive rates >>> >> > -- > Antwebsystems.com: Quality OFBiz services for competitive rates > |
Re: svn commit: r819845 - /ofbiz/trunk/framework/common/
|
|
Re: svn commit: r819845 - /ofbiz/trunk/framework/common/
|
|
My voet is to revert this - no reason to continue to maintain this
portion going forward - Adrian's right. Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Sep 30, 2009, at 8:50 AM, Adrian Crum wrote: > In the original design, if a user wanted to change the default > theme, they would do so in the database - not in a properties file. > The goal was to have a visual theme setup UI - where things like > this can be configured, but that was never completed. > > -Adrian > > Hans Bakker wrote: >> Ok Adrian your record is back, however can now be overridden by >> values >> in general properties: committed in R820178 >> On Tue, 2009-09-29 at 07:46 -0700, Adrian Crum wrote: >>> Hans, >>> >>> The default theme is supposed to be defined in the database - that >>> is part of the visual theme design. Please revert this commit. >>> >>> -Adrian >>> >>> [hidden email] wrote: >>>> Author: hansbak >>>> Date: Tue Sep 29 07:07:51 2009 >>>> New Revision: 819845 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=819845&view=rev >>>> Log: >>>> default visualthemeId already defined in general properties >>>> >>>> Modified: >>>> ofbiz/trunk/framework/common/data/CommonTypeData.xml >>>> >>>> Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=819845&r1=819844&r2=819845&view=diff >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> =================================================================== >>>> --- ofbiz/trunk/framework/common/data/CommonTypeData.xml (original) >>>> +++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Tue Sep >>>> 29 07:07:51 2009 >>>> @@ -102,7 +102,7 @@ >>>> <!-- User preferences seed data --> >>>> <UserPrefGroupType userPrefGroupTypeId="GLOBAL_PREFERENCES" >>>> description="Global preferences"/> >>>> - <UserPreference userLoginId="_NA_" >>>> userPrefTypeId="VISUAL_THEME" >>>> userPrefGroupTypeId="GLOBAL_PREFERENCES" >>>> userPrefValue="BIZZNESS_TIME"/> >>>> + <!-- UserPreference userLoginId="_NA_" >>>> userPrefTypeId="VISUAL_THEME" >>>> userPrefGroupTypeId="GLOBAL_PREFERENCES" >>>> userPrefValue="BIZZNESS_TIME" specified in general properties! --> >>>> <!-- Visual Themes seed data --> >>>> <EnumerationType description="Visual Theme Resource Type >>>> (stylesheet, javascript file, etc)" enumTypeId="VT_RES_TYPE" >>>> hasTable="N"/> >>>> >>>> >>>> |
| Free forum by Nabble | Edit this page |