Re: svn commit: r823237 - /ofbiz/trunk/framework/webtool
Locked
Re: svn commit: r823237 - /ofbiz/trunk/framework/webtool
 
|
Bruno,
The "defacto" standard that has been used so far is to eliminate the screenlet body in screenlets that contain tables. The idea is to leave more room for the table contents, plus have any grid lines extend to the screenlet border. -Adrian [hidden email] wrote: > Author: buscob > Date: Thu Oct 8 17:30:56 2009 > New Revision: 823237 > > URL: http://svn.apache.org/viewvc?rev=823237&view=rev > Log: > Added missing "screenlet-body" tag > > Modified: > ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > > Modified: ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl?rev=823237&r1=823236&r2=823237&view=diff > ============================================================================== > --- ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl (original) > +++ ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl Thu Oct 8 17:30:56 2009 > @@ -365,26 +365,28 @@ > <div class="screenlet-title-bar"> > <h3>${uiLabelMap.WebtoolsServicesListFor} ${dispatcherName?default(uiLabelMap.CommonNA)} (${servicesFoundCount} ${uiLabelMap.CommonFound})</h3> > </div> > - <table class="basic-table hover-bar" cellspacing='0'> > - <tr class="header-row"> > - <td>${uiLabelMap.WebtoolsServiceName}</td> > - <td>${uiLabelMap.WebtoolsEngineName}</td> > - <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> > - <td>${uiLabelMap.WebtoolsInvoke}</td> > - <td>${uiLabelMap.WebtoolsLocation}</td> > - </tr> > - <#assign alt_row = false> > - <#list servicesList as service> > - <tr<#if alt_row> class="alternate-row"</#if>> > - <td><a href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> > - <td><a href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> > - <td><a href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> > - <td>${service.invoke}</td> > - <td><a href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> > + <div class="screenlet-body"> > + <table class="basic-table hover-bar" cellspacing='0'> > + <tr class="header-row"> > + <td>${uiLabelMap.WebtoolsServiceName}</td> > + <td>${uiLabelMap.WebtoolsEngineName}</td> > + <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> > + <td>${uiLabelMap.WebtoolsInvoke}</td> > + <td>${uiLabelMap.WebtoolsLocation}</td> > </tr> > - <#assign alt_row = !alt_row> > - </#list> > - </table> > + <#assign alt_row = false> > + <#list servicesList as service> > + <tr<#if alt_row> class="alternate-row"</#if>> > + <td><a href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> > + <td><a href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> > + <td><a href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> > + <td>${service.invoke}</td> > + <td><a href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> > + </tr> > + <#assign alt_row = !alt_row> > + </#list> > + </table> > + </div> > </div> > <#else> > ${uiLabelMap.WebtoolsNoServicesFound}. > > > |
Re: svn commit: r823237 - /ofbiz/trunk/framework/webtool
|
|
Adrian,
I think we should have always the same HTML markup regardless of how it has been obtained: a screenlet widget rendering, a containers sequence rendering of even and FTL file (as we have in this case). Since there no means of putting the screenlet content outside of the screenlet-body tag, I think we should always have it there even when we are able to do it by using an FTL file. This makes the HTML more consistent and the life easier to CSS. If we need to have more room for a special screenlet we could use a special style and work on the CSS. -Bruno 2009/10/8 Adrian Crum <[hidden email]>: > Bruno, > > The "defacto" standard that has been used so far is to eliminate the > screenlet body in screenlets that contain tables. The idea is to leave more > room for the table contents, plus have any grid lines extend to the > screenlet border. > > -Adrian > > [hidden email] wrote: >> >> Author: buscob >> Date: Thu Oct 8 17:30:56 2009 >> New Revision: 823237 >> >> URL: http://svn.apache.org/viewvc?rev=823237&view=rev >> Log: >> Added missing "screenlet-body" tag >> >> Modified: >> >> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >> >> Modified: >> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl?rev=823237&r1=823236&r2=823237&view=diff >> >> ============================================================================== >> --- >> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >> (original) >> +++ >> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >> Thu Oct 8 17:30:56 2009 >> @@ -365,26 +365,28 @@ >> <div class="screenlet-title-bar"> >> <h3>${uiLabelMap.WebtoolsServicesListFor} >> ${dispatcherName?default(uiLabelMap.CommonNA)} (${servicesFoundCount} >> ${uiLabelMap.CommonFound})</h3> >> </div> >> - <table class="basic-table hover-bar" cellspacing='0'> >> - <tr class="header-row"> >> - <td>${uiLabelMap.WebtoolsServiceName}</td> >> - <td>${uiLabelMap.WebtoolsEngineName}</td> >> - <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> >> - <td>${uiLabelMap.WebtoolsInvoke}</td> >> - <td>${uiLabelMap.WebtoolsLocation}</td> >> - </tr> >> - <#assign alt_row = false> >> - <#list servicesList as service> >> - <tr<#if alt_row> class="alternate-row"</#if>> >> - <td><a >> href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> >> - <td><a >> href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> >> - <td><a >> href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> >> - <td>${service.invoke}</td> >> - <td><a >> href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> >> + <div class="screenlet-body"> >> + <table class="basic-table hover-bar" cellspacing='0'> >> + <tr class="header-row"> >> + <td>${uiLabelMap.WebtoolsServiceName}</td> >> + <td>${uiLabelMap.WebtoolsEngineName}</td> >> + <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> >> + <td>${uiLabelMap.WebtoolsInvoke}</td> >> + <td>${uiLabelMap.WebtoolsLocation}</td> >> </tr> >> - <#assign alt_row = !alt_row> >> - </#list> >> - </table> >> + <#assign alt_row = false> >> + <#list servicesList as service> >> + <tr<#if alt_row> class="alternate-row"</#if>> >> + <td><a >> href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> >> + <td><a >> href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> >> + <td><a >> href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> >> + <td>${service.invoke}</td> >> + <td><a >> href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> >> + </tr> >> + <#assign alt_row = !alt_row> >> + </#list> >> + </table> >> + </div> >> </div> >> <#else> >> ${uiLabelMap.WebtoolsNoServicesFound}. >> >> >> > |
Re: svn commit: r823237 - /ofbiz/trunk/framework/webtool
|
|
Why should we always have the same HTML markup? I might want padding
inside the screenlet in some cases, other times not. There are many examples of this in the project. I don't see where it affects CSS. Right now we have a descendant selector that styles the body if it exists. What is being made easier? -Adrian Bruno Busco wrote: > Adrian, > I think we should have always the same HTML markup regardless of how > it has been obtained: a screenlet widget rendering, a containers > sequence rendering of even and FTL file (as we have in this case). > Since there no means of putting the screenlet content outside of the > screenlet-body tag, I think we should always have it there even when > we are able to do it by using an FTL file. > > This makes the HTML more consistent and the life easier to CSS. > > If we need to have more room for a special screenlet we could use a > special style and work on the CSS. > > > -Bruno > > > 2009/10/8 Adrian Crum <[hidden email]>: >> Bruno, >> >> The "defacto" standard that has been used so far is to eliminate the >> screenlet body in screenlets that contain tables. The idea is to leave more >> room for the table contents, plus have any grid lines extend to the >> screenlet border. >> >> -Adrian >> >> [hidden email] wrote: >>> Author: buscob >>> Date: Thu Oct 8 17:30:56 2009 >>> New Revision: 823237 >>> >>> URL: http://svn.apache.org/viewvc?rev=823237&view=rev >>> Log: >>> Added missing "screenlet-body" tag >>> >>> Modified: >>> >>> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >>> >>> Modified: >>> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >>> URL: >>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl?rev=823237&r1=823236&r2=823237&view=diff >>> >>> ============================================================================== >>> --- >>> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >>> (original) >>> +++ >>> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >>> Thu Oct 8 17:30:56 2009 >>> @@ -365,26 +365,28 @@ >>> <div class="screenlet-title-bar"> >>> <h3>${uiLabelMap.WebtoolsServicesListFor} >>> ${dispatcherName?default(uiLabelMap.CommonNA)} (${servicesFoundCount} >>> ${uiLabelMap.CommonFound})</h3> >>> </div> >>> - <table class="basic-table hover-bar" cellspacing='0'> >>> - <tr class="header-row"> >>> - <td>${uiLabelMap.WebtoolsServiceName}</td> >>> - <td>${uiLabelMap.WebtoolsEngineName}</td> >>> - <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> >>> - <td>${uiLabelMap.WebtoolsInvoke}</td> >>> - <td>${uiLabelMap.WebtoolsLocation}</td> >>> - </tr> >>> - <#assign alt_row = false> >>> - <#list servicesList as service> >>> - <tr<#if alt_row> class="alternate-row"</#if>> >>> - <td><a >>> href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> >>> - <td><a >>> href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> >>> - <td><a >>> href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> >>> - <td>${service.invoke}</td> >>> - <td><a >>> href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> >>> + <div class="screenlet-body"> >>> + <table class="basic-table hover-bar" cellspacing='0'> >>> + <tr class="header-row"> >>> + <td>${uiLabelMap.WebtoolsServiceName}</td> >>> + <td>${uiLabelMap.WebtoolsEngineName}</td> >>> + <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> >>> + <td>${uiLabelMap.WebtoolsInvoke}</td> >>> + <td>${uiLabelMap.WebtoolsLocation}</td> >>> </tr> >>> - <#assign alt_row = !alt_row> >>> - </#list> >>> - </table> >>> + <#assign alt_row = false> >>> + <#list servicesList as service> >>> + <tr<#if alt_row> class="alternate-row"</#if>> >>> + <td><a >>> href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> >>> + <td><a >>> href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> >>> + <td><a >>> href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> >>> + <td>${service.invoke}</td> >>> + <td><a >>> href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> >>> + </tr> >>> + <#assign alt_row = !alt_row> >>> + </#list> >>> + </table> >>> + </div> >>> </div> >>> <#else> >>> ${uiLabelMap.WebtoolsNoServicesFound}. >>> >>> >>> > |
Re: svn commit: r823237 - /ofbiz/trunk/framework/webtool
|
|
Adrian,
I looked into the screenlet java rendering code better and I found that the "padded" attribute of the screenlet widget controls if the content of the screenlet is wrapped in a screenlet-body div or not. So effectively the themes must work with this case also. (I will work on this) BTW, even if using the "padded" attribute we can have ALL the content inside a screenlet-body tag or ALL the content in the screenlet tag with no screenlet-body tag. What I think we should do is not have a different markup (like the following) of what can be obtained by a screenlet widget rendering even if using container and FTL could be possible. So in no case we should have something like this: <container style="screenlet"> <container style="screenlet-body"> <container style="h2"> <label text="${uiLabelMap.CommonSearchResults}"/> </container> </container> <container id="search-results"> <decorator-section-include name="search-results"/> </container> </container> but we should have this: <container style="screenlet"> <container style="screenlet-body"> <container style="h2"> <label text="${uiLabelMap.CommonSearchResults}"/> </container> <container id="search-results"> <decorator-section-include name="search-results"/> </container> </container> </container> Is this correct? Thank you, Bruno 2009/10/8 Adrian Crum <[hidden email]>: > Why should we always have the same HTML markup? I might want padding inside > the screenlet in some cases, other times not. There are many examples of > this in the project. > > I don't see where it affects CSS. Right now we have a descendant selector > that styles the body if it exists. What is being made easier? > > -Adrian > > Bruno Busco wrote: >> >> Adrian, >> I think we should have always the same HTML markup regardless of how >> it has been obtained: a screenlet widget rendering, a containers >> sequence rendering of even and FTL file (as we have in this case). >> Since there no means of putting the screenlet content outside of the >> screenlet-body tag, I think we should always have it there even when >> we are able to do it by using an FTL file. >> >> This makes the HTML more consistent and the life easier to CSS. >> >> If we need to have more room for a special screenlet we could use a >> special style and work on the CSS. >> >> >> -Bruno >> >> >> 2009/10/8 Adrian Crum <[hidden email]>: >>> >>> Bruno, >>> >>> The "defacto" standard that has been used so far is to eliminate the >>> screenlet body in screenlets that contain tables. The idea is to leave >>> more >>> room for the table contents, plus have any grid lines extend to the >>> screenlet border. >>> >>> -Adrian >>> >>> [hidden email] wrote: >>>> >>>> Author: buscob >>>> Date: Thu Oct 8 17:30:56 2009 >>>> New Revision: 823237 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=823237&view=rev >>>> Log: >>>> Added missing "screenlet-body" tag >>>> >>>> Modified: >>>> >>>> >>>> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >>>> >>>> Modified: >>>> >>>> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >>>> URL: >>>> >>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl?rev=823237&r1=823236&r2=823237&view=diff >>>> >>>> >>>> ============================================================================== >>>> --- >>>> >>>> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >>>> (original) >>>> +++ >>>> >>>> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >>>> Thu Oct 8 17:30:56 2009 >>>> @@ -365,26 +365,28 @@ >>>> <div class="screenlet-title-bar"> >>>> <h3>${uiLabelMap.WebtoolsServicesListFor} >>>> ${dispatcherName?default(uiLabelMap.CommonNA)} (${servicesFoundCount} >>>> ${uiLabelMap.CommonFound})</h3> >>>> </div> >>>> - <table class="basic-table hover-bar" cellspacing='0'> >>>> - <tr class="header-row"> >>>> - <td>${uiLabelMap.WebtoolsServiceName}</td> >>>> - <td>${uiLabelMap.WebtoolsEngineName}</td> >>>> - <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> >>>> - <td>${uiLabelMap.WebtoolsInvoke}</td> >>>> - <td>${uiLabelMap.WebtoolsLocation}</td> >>>> - </tr> >>>> - <#assign alt_row = false> >>>> - <#list servicesList as service> >>>> - <tr<#if alt_row> class="alternate-row"</#if>> >>>> - <td><a >>>> >>>> href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> >>>> - <td><a >>>> >>>> href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> >>>> - <td><a >>>> >>>> href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> >>>> - <td>${service.invoke}</td> >>>> - <td><a >>>> >>>> href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> >>>> + <div class="screenlet-body"> >>>> + <table class="basic-table hover-bar" cellspacing='0'> >>>> + <tr class="header-row"> >>>> + <td>${uiLabelMap.WebtoolsServiceName}</td> >>>> + <td>${uiLabelMap.WebtoolsEngineName}</td> >>>> + <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> >>>> + <td>${uiLabelMap.WebtoolsInvoke}</td> >>>> + <td>${uiLabelMap.WebtoolsLocation}</td> >>>> </tr> >>>> - <#assign alt_row = !alt_row> >>>> - </#list> >>>> - </table> >>>> + <#assign alt_row = false> >>>> + <#list servicesList as service> >>>> + <tr<#if alt_row> class="alternate-row"</#if>> >>>> + <td><a >>>> >>>> href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> >>>> + <td><a >>>> >>>> href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> >>>> + <td><a >>>> >>>> href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> >>>> + <td>${service.invoke}</td> >>>> + <td><a >>>> >>>> href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> >>>> + </tr> >>>> + <#assign alt_row = !alt_row> >>>> + </#list> >>>> + </table> >>>> + </div> >>>> </div> >>>> <#else> >>>> ${uiLabelMap.WebtoolsNoServicesFound}. >>>> >>>> >>>> >> > |
Re: svn commit: r823237 - /ofbiz/trunk/framework/webtool
|
|
On a second thought we could also change the screenlet widget renderer
to always create a <div class="screenlet-body"> tag when the attribute "padded" is false and <div class="screenlet-body padded"> when the attribute "padded" is true. The CSS can do the job to add padding or not. This will let us have ALWAYS the screenlet-body tag that is useful for correct rendering of things like rounded corners etc. Could this be OK? -Bruno 2009/10/9 Bruno Busco <[hidden email]>: > Adrian, > I looked into the screenlet java rendering code better and I found > that the "padded" attribute of the screenlet widget controls if the > content of the screenlet is wrapped in a screenlet-body div or not. > So effectively the themes must work with this case also. (I will work on this) > > BTW, even if using the "padded" attribute we can have ALL the content > inside a screenlet-body tag or ALL the content in the screenlet tag > with no screenlet-body tag. > What I think we should do is not have a different markup (like the > following) of what can be obtained by a screenlet widget rendering > even if using container and FTL could be possible. > > So in no case we should have something like this: > > <container style="screenlet"> > <container style="screenlet-body"> > <container style="h2"> > <label text="${uiLabelMap.CommonSearchResults}"/> > </container> > </container> > <container id="search-results"> > <decorator-section-include name="search-results"/> > </container> > </container> > > but we should have this: > > <container style="screenlet"> > <container style="screenlet-body"> > <container style="h2"> > <label text="${uiLabelMap.CommonSearchResults}"/> > </container> > <container id="search-results"> > <decorator-section-include name="search-results"/> > </container> > </container> > </container> > > Is this correct? > Thank you, > Bruno > > > 2009/10/8 Adrian Crum <[hidden email]>: >> Why should we always have the same HTML markup? I might want padding inside >> the screenlet in some cases, other times not. There are many examples of >> this in the project. >> >> I don't see where it affects CSS. Right now we have a descendant selector >> that styles the body if it exists. What is being made easier? >> >> -Adrian >> >> Bruno Busco wrote: >>> >>> Adrian, >>> I think we should have always the same HTML markup regardless of how >>> it has been obtained: a screenlet widget rendering, a containers >>> sequence rendering of even and FTL file (as we have in this case). >>> Since there no means of putting the screenlet content outside of the >>> screenlet-body tag, I think we should always have it there even when >>> we are able to do it by using an FTL file. >>> >>> This makes the HTML more consistent and the life easier to CSS. >>> >>> If we need to have more room for a special screenlet we could use a >>> special style and work on the CSS. >>> >>> >>> -Bruno >>> >>> >>> 2009/10/8 Adrian Crum <[hidden email]>: >>>> >>>> Bruno, >>>> >>>> The "defacto" standard that has been used so far is to eliminate the >>>> screenlet body in screenlets that contain tables. The idea is to leave >>>> more >>>> room for the table contents, plus have any grid lines extend to the >>>> screenlet border. >>>> >>>> -Adrian >>>> >>>> [hidden email] wrote: >>>>> >>>>> Author: buscob >>>>> Date: Thu Oct 8 17:30:56 2009 >>>>> New Revision: 823237 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=823237&view=rev >>>>> Log: >>>>> Added missing "screenlet-body" tag >>>>> >>>>> Modified: >>>>> >>>>> >>>>> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >>>>> >>>>> Modified: >>>>> >>>>> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >>>>> URL: >>>>> >>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl?rev=823237&r1=823236&r2=823237&view=diff >>>>> >>>>> >>>>> ============================================================================== >>>>> --- >>>>> >>>>> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >>>>> (original) >>>>> +++ >>>>> >>>>> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >>>>> Thu Oct 8 17:30:56 2009 >>>>> @@ -365,26 +365,28 @@ >>>>> <div class="screenlet-title-bar"> >>>>> <h3>${uiLabelMap.WebtoolsServicesListFor} >>>>> ${dispatcherName?default(uiLabelMap.CommonNA)} (${servicesFoundCount} >>>>> ${uiLabelMap.CommonFound})</h3> >>>>> </div> >>>>> - <table class="basic-table hover-bar" cellspacing='0'> >>>>> - <tr class="header-row"> >>>>> - <td>${uiLabelMap.WebtoolsServiceName}</td> >>>>> - <td>${uiLabelMap.WebtoolsEngineName}</td> >>>>> - <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> >>>>> - <td>${uiLabelMap.WebtoolsInvoke}</td> >>>>> - <td>${uiLabelMap.WebtoolsLocation}</td> >>>>> - </tr> >>>>> - <#assign alt_row = false> >>>>> - <#list servicesList as service> >>>>> - <tr<#if alt_row> class="alternate-row"</#if>> >>>>> - <td><a >>>>> >>>>> href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> >>>>> - <td><a >>>>> >>>>> href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> >>>>> - <td><a >>>>> >>>>> href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> >>>>> - <td>${service.invoke}</td> >>>>> - <td><a >>>>> >>>>> href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> >>>>> + <div class="screenlet-body"> >>>>> + <table class="basic-table hover-bar" cellspacing='0'> >>>>> + <tr class="header-row"> >>>>> + <td>${uiLabelMap.WebtoolsServiceName}</td> >>>>> + <td>${uiLabelMap.WebtoolsEngineName}</td> >>>>> + <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> >>>>> + <td>${uiLabelMap.WebtoolsInvoke}</td> >>>>> + <td>${uiLabelMap.WebtoolsLocation}</td> >>>>> </tr> >>>>> - <#assign alt_row = !alt_row> >>>>> - </#list> >>>>> - </table> >>>>> + <#assign alt_row = false> >>>>> + <#list servicesList as service> >>>>> + <tr<#if alt_row> class="alternate-row"</#if>> >>>>> + <td><a >>>>> >>>>> href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> >>>>> + <td><a >>>>> >>>>> href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> >>>>> + <td><a >>>>> >>>>> href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> >>>>> + <td>${service.invoke}</td> >>>>> + <td><a >>>>> >>>>> href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> >>>>> + </tr> >>>>> + <#assign alt_row = !alt_row> >>>>> + </#list> >>>>> + </table> >>>>> + </div> >>>>> </div> >>>>> <#else> >>>>> ${uiLabelMap.WebtoolsNoServicesFound}. >>>>> >>>>> >>>>> >>> >> > |
Re: svn commit: r823237 - /ofbiz/trunk/framework/webtool
|
|
In reply to this post by Bruno Busco
As I mentioned in he Jira issue - if you want to style the table differently, then use a descendant selector. There is no need to change the markup.
-Adrian --- On Thu, 10/8/09, Bruno Busco <[hidden email]> wrote: > From: Bruno Busco <[hidden email]> > Subject: Re: svn commit: r823237 - /ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > To: [hidden email] > Date: Thursday, October 8, 2009, 11:35 PM > Adrian, > I looked into the screenlet java rendering code better and > I found > that the "padded" attribute of the screenlet widget > controls if the > content of the screenlet is wrapped in a screenlet-body div > or not. > So effectively the themes must work with this case also. (I > will work on this) > > BTW, even if using the "padded" attribute we can have ALL > the content > inside a screenlet-body tag or ALL the content in the > screenlet tag > with no screenlet-body tag. > What I think we should do is not have a different markup > (like the > following) of what can be obtained by a screenlet widget > rendering > even if using container and FTL could be possible. > > So in no case we should have something like this: > > > <container style="screenlet"> > > <container style="screenlet-body"> > > <container style="h2"> > > <label > text="${uiLabelMap.CommonSearchResults}"/> > > </container> > > </container> > > <container id="search-results"> > > <decorator-section-include > name="search-results"/> > > </container> > > </container> > > but we should have this: > > > <container style="screenlet"> > > <container style="screenlet-body"> > > <container style="h2"> > > <label > text="${uiLabelMap.CommonSearchResults}"/> > > </container> > > <container > id="search-results"> > > > <decorator-section-include name="search-results"/> > > </container> > > </container> > > </container> > > Is this correct? > Thank you, > Bruno > > > 2009/10/8 Adrian Crum <[hidden email]>: > > Why should we always have the same HTML markup? I > might want padding inside > > the screenlet in some cases, other times not. There > are many examples of > > this in the project. > > > > I don't see where it affects CSS. Right now we have a > descendant selector > > that styles the body if it exists. What is being made > easier? > > > > -Adrian > > > > Bruno Busco wrote: > >> > >> Adrian, > >> I think we should have always the same HTML markup > regardless of how > >> it has been obtained: a screenlet widget > rendering, a containers > >> sequence rendering of even and FTL file (as we > have in this case). > >> Since there no means of putting the screenlet > content outside of the > >> screenlet-body tag, I think we should always have > it there even when > >> we are able to do it by using an FTL file. > >> > >> This makes the HTML more consistent and the life > easier to CSS. > >> > >> If we need to have more room for a special > screenlet we could use a > >> special style and work on the CSS. > >> > >> > >> -Bruno > >> > >> > >> 2009/10/8 Adrian Crum <[hidden email]>: > >>> > >>> Bruno, > >>> > >>> The "defacto" standard that has been used so > far is to eliminate the > >>> screenlet body in screenlets that contain > tables. The idea is to leave > >>> more > >>> room for the table contents, plus have any > grid lines extend to the > >>> screenlet border. > >>> > >>> -Adrian > >>> > >>> [hidden email] > wrote: > >>>> > >>>> Author: buscob > >>>> Date: Thu Oct 8 17:30:56 2009 > >>>> New Revision: 823237 > >>>> > >>>> URL: http://svn.apache.org/viewvc?rev=823237&view=rev > >>>> Log: > >>>> Added missing "screenlet-body" tag > >>>> > >>>> Modified: > >>>> > >>>> > >>>> > ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > >>>> > >>>> Modified: > >>>> > >>>> > ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > >>>> URL: > >>>> > >>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl?rev=823237&r1=823236&r2=823237&view=diff > >>>> > >>>> > >>>> > ============================================================================== > >>>> --- > >>>> > >>>> > ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > >>>> (original) > >>>> +++ > >>>> > >>>> > ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > >>>> Thu Oct 8 17:30:56 2009 > >>>> @@ -365,26 +365,28 @@ > >>>> <div > class="screenlet-title-bar"> > >>>> > <h3>${uiLabelMap.WebtoolsServicesListFor} > >>>> > ${dispatcherName?default(uiLabelMap.CommonNA)} > (${servicesFoundCount} > >>>> ${uiLabelMap.CommonFound})</h3> > >>>> </div> > >>>> - <table class="basic-table > hover-bar" cellspacing='0'> > >>>> - <tr class="header-row"> > >>>> - > <td>${uiLabelMap.WebtoolsServiceName}</td> > >>>> - > <td>${uiLabelMap.WebtoolsEngineName}</td> > >>>> - > <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> > >>>> - > <td>${uiLabelMap.WebtoolsInvoke}</td> > >>>> - > <td>${uiLabelMap.WebtoolsLocation}</td> > >>>> - </tr> > >>>> - <#assign alt_row = false> > >>>> - <#list servicesList as > service> > >>>> - <tr<#if alt_row> > class="alternate-row"</#if>> > >>>> - <td><a > >>>> > >>>> > href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> > >>>> - <td><a > >>>> > >>>> > href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> > >>>> - <td><a > >>>> > >>>> > href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> > >>>> - > <td>${service.invoke}</td> > >>>> - <td><a > >>>> > >>>> > href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> > >>>> + <div class="screenlet-body"> > >>>> + <table class="basic-table > hover-bar" cellspacing='0'> > >>>> + <tr > class="header-row"> > >>>> + > <td>${uiLabelMap.WebtoolsServiceName}</td> > >>>> + > <td>${uiLabelMap.WebtoolsEngineName}</td> > >>>> + > <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> > >>>> + > <td>${uiLabelMap.WebtoolsInvoke}</td> > >>>> + > <td>${uiLabelMap.WebtoolsLocation}</td> > >>>> </tr> > >>>> - <#assign alt_row = > !alt_row> > >>>> - </#list> > >>>> - </table> > >>>> + <#assign alt_row = > false> > >>>> + <#list servicesList as > service> > >>>> + <tr<#if alt_row> > class="alternate-row"</#if>> > >>>> + <td><a > >>>> > >>>> > href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> > >>>> + <td><a > >>>> > >>>> > href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> > >>>> + <td><a > >>>> > >>>> > href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> > >>>> + > <td>${service.invoke}</td> > >>>> + <td><a > >>>> > >>>> > href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> > >>>> + </tr> > >>>> + <#assign alt_row = > !alt_row> > >>>> + </#list> > >>>> + </table> > >>>> + </div> > >>>> </div> > >>>> <#else> > >>>> ${uiLabelMap.WebtoolsNoServicesFound}. > >>>> > >>>> > >>>> > >> > > > |
Re: svn commit: r823237 - /ofbiz/trunk/framework/webtool
|
|
In reply to this post by Bruno Busco
That would work.
-Adrian --- On Thu, 10/8/09, Bruno Busco <[hidden email]> wrote: > From: Bruno Busco <[hidden email]> > Subject: Re: svn commit: r823237 - /ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > To: [hidden email] > Date: Thursday, October 8, 2009, 11:51 PM > On a second thought we could also > change the screenlet widget renderer > to always create a > <div class="screenlet-body"> tag when the attribute > "padded" is false > and > <div class="screenlet-body padded"> when the > attribute "padded" is true. > > The CSS can do the job to add padding or not. > > This will let us have ALWAYS the screenlet-body tag that is > useful for > correct rendering of things like rounded corners etc. > > Could this be OK? > > -Bruno > > 2009/10/9 Bruno Busco <[hidden email]>: > > Adrian, > > I looked into the screenlet java rendering code better > and I found > > that the "padded" attribute of the screenlet widget > controls if the > > content of the screenlet is wrapped in a > screenlet-body div or not. > > So effectively the themes must work with this case > also. (I will work on this) > > > > BTW, even if using the "padded" attribute we can have > ALL the content > > inside a screenlet-body tag or ALL the content in the > screenlet tag > > with no screenlet-body tag. > > What I think we should do is not have a different > markup (like the > > following) of what can be obtained by a screenlet > widget rendering > > even if using container and FTL could be possible. > > > > So in no case we should have something like this: > > > > <container > style="screenlet"> > > <container > style="screenlet-body"> > > <container > style="h2"> > > <label > text="${uiLabelMap.CommonSearchResults}"/> > > </container> > > </container> > > <container > id="search-results"> > > > <decorator-section-include name="search-results"/> > > </container> > > </container> > > > > but we should have this: > > > > <container > style="screenlet"> > > <container > style="screenlet-body"> > > <container > style="h2"> > > <label > text="${uiLabelMap.CommonSearchResults}"/> > > </container> > > <container > id="search-results"> > > > <decorator-section-include name="search-results"/> > > </container> > > </container> > > </container> > > > > Is this correct? > > Thank you, > > Bruno > > > > > > 2009/10/8 Adrian Crum <[hidden email]>: > >> Why should we always have the same HTML markup? I > might want padding inside > >> the screenlet in some cases, other times not. > There are many examples of > >> this in the project. > >> > >> I don't see where it affects CSS. Right now we > have a descendant selector > >> that styles the body if it exists. What is being > made easier? > >> > >> -Adrian > >> > >> Bruno Busco wrote: > >>> > >>> Adrian, > >>> I think we should have always the same HTML > markup regardless of how > >>> it has been obtained: a screenlet widget > rendering, a containers > >>> sequence rendering of even and FTL file (as we > have in this case). > >>> Since there no means of putting the screenlet > content outside of the > >>> screenlet-body tag, I think we should always > have it there even when > >>> we are able to do it by using an FTL file. > >>> > >>> This makes the HTML more consistent and the > life easier to CSS. > >>> > >>> If we need to have more room for a special > screenlet we could use a > >>> special style and work on the CSS. > >>> > >>> > >>> -Bruno > >>> > >>> > >>> 2009/10/8 Adrian Crum <[hidden email]>: > >>>> > >>>> Bruno, > >>>> > >>>> The "defacto" standard that has been used > so far is to eliminate the > >>>> screenlet body in screenlets that contain > tables.. The idea is to leave > >>>> more > >>>> room for the table contents, plus have any > grid lines extend to the > >>>> screenlet border. > >>>> > >>>> -Adrian > >>>> > >>>> [hidden email] > wrote: > >>>>> > >>>>> Author: buscob > >>>>> Date: Thu Oct 8 17:30:56 2009 > >>>>> New Revision: 823237 > >>>>> > >>>>> URL: http://svn.apache.org/viewvc?rev=823237&view=rev > >>>>> Log: > >>>>> Added missing "screenlet-body" tag > >>>>> > >>>>> Modified: > >>>>> > >>>>> > >>>>> > ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > >>>>> > >>>>> Modified: > >>>>> > >>>>> > ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > >>>>> URL: > >>>>> > >>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl?rev=823237&r1=823236&r2=823237&view=diff > >>>>> > >>>>> > >>>>> > ============================================================================== > >>>>> --- > >>>>> > >>>>> > ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > >>>>> (original) > >>>>> +++ > >>>>> > >>>>> > ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > >>>>> Thu Oct 8 17:30:56 2009 > >>>>> @@ -365,26 +365,28 @@ > >>>>> <div > class="screenlet-title-bar"> > >>>>> > <h3>${uiLabelMap.WebtoolsServicesListFor} > >>>>> > ${dispatcherName?default(uiLabelMap.CommonNA)} > (${servicesFoundCount} > >>>>> ${uiLabelMap.CommonFound})</h3> > >>>>> </div> > >>>>> - <table class="basic-table > hover-bar" cellspacing='0'> > >>>>> - <tr > class="header-row"> > >>>>> - > <td>${uiLabelMap.WebtoolsServiceName}</td> > >>>>> - > <td>${uiLabelMap.WebtoolsEngineName}</td> > >>>>> - > <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> > >>>>> - > <td>${uiLabelMap.WebtoolsInvoke}</td> > >>>>> - > <td>${uiLabelMap.WebtoolsLocation}</td> > >>>>> - </tr> > >>>>> - <#assign alt_row = > false> > >>>>> - <#list servicesList as > service> > >>>>> - <tr<#if alt_row> > class="alternate-row"</#if>> > >>>>> - <td><a > >>>>> > >>>>> > href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> > >>>>> - <td><a > >>>>> > >>>>> > href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> > >>>>> - <td><a > >>>>> > >>>>> > href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> > >>>>> - > <td>${service.invoke}</td> > >>>>> - <td><a > >>>>> > >>>>> > href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> > >>>>> + <div > class="screenlet-body"> > >>>>> + <table class="basic-table > hover-bar" cellspacing='0'> > >>>>> + <tr > class="header-row"> > >>>>> + > <td>${uiLabelMap.WebtoolsServiceName}</td> > >>>>> + > <td>${uiLabelMap.WebtoolsEngineName}</td> > >>>>> + > <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> > >>>>> + > <td>${uiLabelMap.WebtoolsInvoke}</td> > >>>>> + > <td>${uiLabelMap.WebtoolsLocation}</td> > >>>>> </tr> > >>>>> - <#assign alt_row = > !alt_row> > >>>>> - </#list> > >>>>> - </table> > >>>>> + <#assign alt_row = > false> > >>>>> + <#list servicesList as > service> > >>>>> + <tr<#if > alt_row> class="alternate-row"</#if>> > >>>>> + <td><a > >>>>> > >>>>> > href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> > >>>>> + <td><a > >>>>> > >>>>> > href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> > >>>>> + <td><a > >>>>> > >>>>> > href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> > >>>>> + > <td>${service..invoke}</td> > >>>>> + <td><a > >>>>> > >>>>> > href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> > >>>>> + </tr> > >>>>> + <#assign alt_row = > !alt_row> > >>>>> + </#list> > >>>>> + </table> > >>>>> + </div> > >>>>> </div> > >>>>> <#else> > >>>>> > ${uiLabelMap.WebtoolsNoServicesFound}. > >>>>> > >>>>> > >>>>> > >>> > >> > > > |
Re: svn commit: r823237 - /ofbiz/trunk/framework/webtool
|
|
To keep things backward-compatible, it would be better to leave the padding in the screenlet body and have a no-padding style.
-Adrian --- On Fri, 10/9/09, Adrian Crum <[hidden email]> wrote: > From: Adrian Crum <[hidden email]> > Subject: Re: svn commit: r823237 - /ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > To: [hidden email] > Date: Friday, October 9, 2009, 8:31 AM > That would work. > > -Adrian > > --- On Thu, 10/8/09, Bruno Busco <[hidden email]> > wrote: > > > From: Bruno Busco <[hidden email]> > > Subject: Re: svn commit: r823237 - > /ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > > To: [hidden email] > > Date: Thursday, October 8, 2009, 11:51 PM > > On a second thought we could also > > change the screenlet widget renderer > > to always create a > > <div class="screenlet-body"> tag when the > attribute > > "padded" is false > > and > > <div class="screenlet-body padded"> when the > > attribute "padded" is true. > > > > The CSS can do the job to add padding or not. > > > > This will let us have ALWAYS the screenlet-body tag > that is > > useful for > > correct rendering of things like rounded corners etc. > > > > Could this be OK? > > > > -Bruno > > > > 2009/10/9 Bruno Busco <[hidden email]>: > > > Adrian, > > > I looked into the screenlet java rendering code > better > > and I found > > > that the "padded" attribute of the screenlet > widget > > controls if the > > > content of the screenlet is wrapped in a > > screenlet-body div or not. > > > So effectively the themes must work with this > case > > also. (I will work on this) > > > > > > BTW, even if using the "padded" attribute we can > have > > ALL the content > > > inside a screenlet-body tag or ALL the content in > the > > screenlet tag > > > with no screenlet-body tag. > > > What I think we should do is not have a > different > > markup (like the > > > following) of what can be obtained by a > screenlet > > widget rendering > > > even if using container and FTL could be > possible. > > > > > > So in no case we should have something like > this: > > > > > > <container > > style="screenlet"> > > > <container > > style="screenlet-body"> > > > <container > > style="h2"> > > > > <label > > text="${uiLabelMap.CommonSearchResults}"/> > > > > </container> > > > </container> > > > <container > > id="search-results"> > > > > > <decorator-section-include > name="search-results"/> > > > </container> > > > </container> > > > > > > but we should have this: > > > > > > <container > > style="screenlet"> > > > <container > > style="screenlet-body"> > > > <container > > style="h2"> > > > > <label > > text="${uiLabelMap.CommonSearchResults}"/> > > > > </container> > > > <container > > id="search-results"> > > > > > <decorator-section-include > name="search-results"/> > > > > </container> > > > </container> > > > </container> > > > > > > Is this correct? > > > Thank you, > > > Bruno > > > > > > > > > 2009/10/8 Adrian Crum <[hidden email]>: > > >> Why should we always have the same HTML > markup? I > > might want padding inside > > >> the screenlet in some cases, other times > not. > > There are many examples of > > >> this in the project. > > >> > > >> I don't see where it affects CSS. Right now > we > > have a descendant selector > > >> that styles the body if it exists. What is > being > > made easier? > > >> > > >> -Adrian > > >> > > >> Bruno Busco wrote: > > >>> > > >>> Adrian, > > >>> I think we should have always the same > HTML > > markup regardless of how > > >>> it has been obtained: a screenlet widget > > rendering, a containers > > >>> sequence rendering of even and FTL file > (as we > > have in this case). > > >>> Since there no means of putting the > screenlet > > content outside of the > > >>> screenlet-body tag, I think we should > always > > have it there even when > > >>> we are able to do it by using an FTL > file. > > >>> > > >>> This makes the HTML more consistent and > the > > life easier to CSS. > > >>> > > >>> If we need to have more room for a > special > > screenlet we could use a > > >>> special style and work on the CSS. > > >>> > > >>> > > >>> -Bruno > > >>> > > >>> > > >>> 2009/10/8 Adrian Crum <[hidden email]>: > > >>>> > > >>>> Bruno, > > >>>> > > >>>> The "defacto" standard that has been > used > > so far is to eliminate the > > >>>> screenlet body in screenlets that > contain > > tables.. The idea is to leave > > >>>> more > > >>>> room for the table contents, plus > have any > > grid lines extend to the > > >>>> screenlet border. > > >>>> > > >>>> -Adrian > > >>>> > > >>>> [hidden email] > > wrote: > > >>>>> > > >>>>> Author: buscob > > >>>>> Date: Thu Oct 8 17:30:56 2009 > > >>>>> New Revision: 823237 > > >>>>> > > >>>>> URL: http://svn.apache.org/viewvc?rev=823237&view=rev > > >>>>> Log: > > >>>>> Added missing "screenlet-body" > tag > > >>>>> > > >>>>> Modified: > > >>>>> > > >>>>> > > >>>>> > > > ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > > >>>>> > > >>>>> Modified: > > >>>>> > > >>>>> > > > ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > > >>>>> URL: > > >>>>> > > >>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl?rev=823237&r1=823236&r2=823237&view=diff > > >>>>> > > >>>>> > > >>>>> > > > ============================================================================== > > >>>>> --- > > >>>>> > > >>>>> > > > ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > > >>>>> (original) > > >>>>> +++ > > >>>>> > > >>>>> > > > ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl > > >>>>> Thu Oct 8 17:30:56 2009 > > >>>>> @@ -365,26 +365,28 @@ > > >>>>> <div > > class="screenlet-title-bar"> > > >>>>> > > <h3>${uiLabelMap.WebtoolsServicesListFor} > > >>>>> > > ${dispatcherName?default(uiLabelMap.CommonNA)} > > (${servicesFoundCount} > > >>>>> > ${uiLabelMap.CommonFound})</h3> > > >>>>> </div> > > >>>>> - <table > class="basic-table > > hover-bar" cellspacing='0'> > > >>>>> - <tr > > class="header-row"> > > >>>>> - > > > <td>${uiLabelMap.WebtoolsServiceName}</td> > > >>>>> - > > > <td>${uiLabelMap.WebtoolsEngineName}</td> > > >>>>> - > > > <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> > > >>>>> - > > <td>${uiLabelMap.WebtoolsInvoke}</td> > > >>>>> - > > <td>${uiLabelMap.WebtoolsLocation}</td> > > >>>>> - </tr> > > >>>>> - <#assign alt_row = > > false> > > >>>>> - <#list servicesList > as > > service> > > >>>>> - <tr<#if > alt_row> > > class="alternate-row"</#if>> > > >>>>> - <td><a > > >>>>> > > >>>>> > > > href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> > > >>>>> - <td><a > > >>>>> > > >>>>> > > > href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> > > >>>>> - <td><a > > >>>>> > > >>>>> > > > href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> > > >>>>> - > > <td>${service.invoke}</td> > > >>>>> - <td><a > > >>>>> > > >>>>> > > > href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> > > >>>>> + <div > > class="screenlet-body"> > > >>>>> + <table > class="basic-table > > hover-bar" cellspacing='0'> > > >>>>> + <tr > > class="header-row"> > > >>>>> + > > > <td>${uiLabelMap.WebtoolsServiceName}</td> > > >>>>> + > > > <td>${uiLabelMap.WebtoolsEngineName}</td> > > >>>>> + > > > <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> > > >>>>> + > > <td>${uiLabelMap.WebtoolsInvoke}</td> > > >>>>> + > > <td>${uiLabelMap.WebtoolsLocation}</td> > > >>>>> </tr> > > >>>>> - <#assign alt_row > = > > !alt_row> > > >>>>> - </#list> > > >>>>> - </table> > > >>>>> + <#assign alt_row > = > > false> > > >>>>> + <#list > servicesList as > > service> > > >>>>> + <tr<#if > > alt_row> class="alternate-row"</#if>> > > >>>>> + > <td><a > > >>>>> > > >>>>> > > > href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> > > >>>>> + > <td><a > > >>>>> > > >>>>> > > > href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> > > >>>>> + > <td><a > > >>>>> > > >>>>> > > > href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> > > >>>>> + > > <td>${service..invoke}</td> > > >>>>> + > <td><a > > >>>>> > > >>>>> > > > href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> > > >>>>> + </tr> > > >>>>> + <#assign > alt_row = > > !alt_row> > > >>>>> + </#list> > > >>>>> + </table> > > >>>>> + </div> > > >>>>> </div> > > >>>>> <#else> > > >>>>> > > ${uiLabelMap.WebtoolsNoServicesFound}. > > >>>>> > > >>>>> > > >>>>> > > >>> > > >> > > > > > > > > > > |
Re: svn commit: r823237 - /ofbiz/trunk/framework/webtool
|
|
OK,
I will try to implement this in the screenwidget and update the CSS accordly. Thank you, Bruno 2009/10/9 Adrian Crum <[hidden email]>: > To keep things backward-compatible, it would be better to leave the padding in the screenlet body and have a no-padding style. > > -Adrian > > --- On Fri, 10/9/09, Adrian Crum <[hidden email]> wrote: > >> From: Adrian Crum <[hidden email]> >> Subject: Re: svn commit: r823237 - /ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >> To: [hidden email] >> Date: Friday, October 9, 2009, 8:31 AM >> That would work. >> >> -Adrian >> >> --- On Thu, 10/8/09, Bruno Busco <[hidden email]> >> wrote: >> >> > From: Bruno Busco <[hidden email]> >> > Subject: Re: svn commit: r823237 - >> /ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >> > To: [hidden email] >> > Date: Thursday, October 8, 2009, 11:51 PM >> > On a second thought we could also >> > change the screenlet widget renderer >> > to always create a >> > <div class="screenlet-body"> tag when the >> attribute >> > "padded" is false >> > and >> > <div class="screenlet-body padded"> when the >> > attribute "padded" is true. >> > >> > The CSS can do the job to add padding or not. >> > >> > This will let us have ALWAYS the screenlet-body tag >> that is >> > useful for >> > correct rendering of things like rounded corners etc. >> > >> > Could this be OK? >> > >> > -Bruno >> > >> > 2009/10/9 Bruno Busco <[hidden email]>: >> > > Adrian, >> > > I looked into the screenlet java rendering code >> better >> > and I found >> > > that the "padded" attribute of the screenlet >> widget >> > controls if the >> > > content of the screenlet is wrapped in a >> > screenlet-body div or not. >> > > So effectively the themes must work with this >> case >> > also. (I will work on this) >> > > >> > > BTW, even if using the "padded" attribute we can >> have >> > ALL the content >> > > inside a screenlet-body tag or ALL the content in >> the >> > screenlet tag >> > > with no screenlet-body tag. >> > > What I think we should do is not have a >> different >> > markup (like the >> > > following) of what can be obtained by a >> screenlet >> > widget rendering >> > > even if using container and FTL could be >> possible. >> > > >> > > So in no case we should have something like >> this: >> > > >> > > <container >> > style="screenlet"> >> > > <container >> > style="screenlet-body"> >> > > <container >> > style="h2"> >> > > >> <label >> > text="${uiLabelMap.CommonSearchResults}"/> >> > > >> </container> >> > > </container> >> > > <container >> > id="search-results"> >> > > >> > <decorator-section-include >> name="search-results"/> >> > > </container> >> > > </container> >> > > >> > > but we should have this: >> > > >> > > <container >> > style="screenlet"> >> > > <container >> > style="screenlet-body"> >> > > <container >> > style="h2"> >> > > >> <label >> > text="${uiLabelMap.CommonSearchResults}"/> >> > > >> </container> >> > > <container >> > id="search-results"> >> > > >> > <decorator-section-include >> name="search-results"/> >> > > >> </container> >> > > </container> >> > > </container> >> > > >> > > Is this correct? >> > > Thank you, >> > > Bruno >> > > >> > > >> > > 2009/10/8 Adrian Crum <[hidden email]>: >> > >> Why should we always have the same HTML >> markup? I >> > might want padding inside >> > >> the screenlet in some cases, other times >> not. >> > There are many examples of >> > >> this in the project. >> > >> >> > >> I don't see where it affects CSS. Right now >> we >> > have a descendant selector >> > >> that styles the body if it exists. What is >> being >> > made easier? >> > >> >> > >> -Adrian >> > >> >> > >> Bruno Busco wrote: >> > >>> >> > >>> Adrian, >> > >>> I think we should have always the same >> HTML >> > markup regardless of how >> > >>> it has been obtained: a screenlet widget >> > rendering, a containers >> > >>> sequence rendering of even and FTL file >> (as we >> > have in this case). >> > >>> Since there no means of putting the >> screenlet >> > content outside of the >> > >>> screenlet-body tag, I think we should >> always >> > have it there even when >> > >>> we are able to do it by using an FTL >> file. >> > >>> >> > >>> This makes the HTML more consistent and >> the >> > life easier to CSS. >> > >>> >> > >>> If we need to have more room for a >> special >> > screenlet we could use a >> > >>> special style and work on the CSS. >> > >>> >> > >>> >> > >>> -Bruno >> > >>> >> > >>> >> > >>> 2009/10/8 Adrian Crum <[hidden email]>: >> > >>>> >> > >>>> Bruno, >> > >>>> >> > >>>> The "defacto" standard that has been >> used >> > so far is to eliminate the >> > >>>> screenlet body in screenlets that >> contain >> > tables.. The idea is to leave >> > >>>> more >> > >>>> room for the table contents, plus >> have any >> > grid lines extend to the >> > >>>> screenlet border. >> > >>>> >> > >>>> -Adrian >> > >>>> >> > >>>> [hidden email] >> > wrote: >> > >>>>> >> > >>>>> Author: buscob >> > >>>>> Date: Thu Oct 8 17:30:56 2009 >> > >>>>> New Revision: 823237 >> > >>>>> >> > >>>>> URL: http://svn.apache.org/viewvc?rev=823237&view=rev >> > >>>>> Log: >> > >>>>> Added missing "screenlet-body" >> tag >> > >>>>> >> > >>>>> Modified: >> > >>>>> >> > >>>>> >> > >>>>> >> > >> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >> > >>>>> >> > >>>>> Modified: >> > >>>>> >> > >>>>> >> > >> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >> > >>>>> URL: >> > >>>>> >> > >>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl?rev=823237&r1=823236&r2=823237&view=diff >> > >>>>> >> > >>>>> >> > >>>>> >> > >> ============================================================================== >> > >>>>> --- >> > >>>>> >> > >>>>> >> > >> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >> > >>>>> (original) >> > >>>>> +++ >> > >>>>> >> > >>>>> >> > >> ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl >> > >>>>> Thu Oct 8 17:30:56 2009 >> > >>>>> @@ -365,26 +365,28 @@ >> > >>>>> <div >> > class="screenlet-title-bar"> >> > >>>>> >> > <h3>${uiLabelMap.WebtoolsServicesListFor} >> > >>>>> >> > ${dispatcherName?default(uiLabelMap.CommonNA)} >> > (${servicesFoundCount} >> > >>>>> >> ${uiLabelMap.CommonFound})</h3> >> > >>>>> </div> >> > >>>>> - <table >> class="basic-table >> > hover-bar" cellspacing='0'> >> > >>>>> - <tr >> > class="header-row"> >> > >>>>> - >> > >> <td>${uiLabelMap.WebtoolsServiceName}</td> >> > >>>>> - >> > >> <td>${uiLabelMap.WebtoolsEngineName}</td> >> > >>>>> - >> > >> <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> >> > >>>>> - >> > <td>${uiLabelMap.WebtoolsInvoke}</td> >> > >>>>> - >> > <td>${uiLabelMap.WebtoolsLocation}</td> >> > >>>>> - </tr> >> > >>>>> - <#assign alt_row = >> > false> >> > >>>>> - <#list servicesList >> as >> > service> >> > >>>>> - <tr<#if >> alt_row> >> > class="alternate-row"</#if>> >> > >>>>> - <td><a >> > >>>>> >> > >>>>> >> > >> href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> >> > >>>>> - <td><a >> > >>>>> >> > >>>>> >> > >> href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> >> > >>>>> - <td><a >> > >>>>> >> > >>>>> >> > >> href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> >> > >>>>> - >> > <td>${service.invoke}</td> >> > >>>>> - <td><a >> > >>>>> >> > >>>>> >> > >> href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> >> > >>>>> + <div >> > class="screenlet-body"> >> > >>>>> + <table >> class="basic-table >> > hover-bar" cellspacing='0'> >> > >>>>> + <tr >> > class="header-row"> >> > >>>>> + >> > >> <td>${uiLabelMap.WebtoolsServiceName}</td> >> > >>>>> + >> > >> <td>${uiLabelMap.WebtoolsEngineName}</td> >> > >>>>> + >> > >> <td>${uiLabelMap.WebtoolsDefaultEntityName}</td> >> > >>>>> + >> > <td>${uiLabelMap.WebtoolsInvoke}</td> >> > >>>>> + >> > <td>${uiLabelMap.WebtoolsLocation}</td> >> > >>>>> </tr> >> > >>>>> - <#assign alt_row >> = >> > !alt_row> >> > >>>>> - </#list> >> > >>>>> - </table> >> > >>>>> + <#assign alt_row >> = >> > false> >> > >>>>> + <#list >> servicesList as >> > service> >> > >>>>> + <tr<#if >> > alt_row> class="alternate-row"</#if>> >> > >>>>> + >> <td><a >> > >>>>> >> > >>>>> >> > >> href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td> >> > >>>>> + >> <td><a >> > >>>>> >> > >>>>> >> > >> href='<@ofbizUrl>${url}?constraint=engine_name@${service.engineName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td> >> > >>>>> + >> <td><a >> > >>>>> >> > >>>>> >> > >> href='<@ofbizUrl>${url}?constraint=default_entity_name@${service.defaultEntityName?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td> >> > >>>>> + >> > <td>${service..invoke}</td> >> > >>>>> + >> <td><a >> > >>>>> >> > >>>>> >> > >> href='<@ofbizUrl>${url}?constraint=location@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td> >> > >>>>> + </tr> >> > >>>>> + <#assign >> alt_row = >> > !alt_row> >> > >>>>> + </#list> >> > >>>>> + </table> >> > >>>>> + </div> >> > >>>>> </div> >> > >>>>> <#else> >> > >>>>> >> > ${uiLabelMap.WebtoolsNoServicesFound}. >> > >>>>> >> > >>>>> >> > >>>>> >> > >>> >> > >> >> > > >> > >> >> >> >> >> > > > > > |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |