Re: svn commit: r829320 - /ofbiz/trunk/specialpurpose/ec
Locked
Re: svn commit: r829320 - /ofbiz/trunk/specialpurpose/ec
 
|
Hi Jacques
Sorry I only just got around to reviewing this, the correct fix is to provide an empty option value so that the option description doesn't become the value: <option value="">--</option> Regards Scott HotWax Media http://www.hotwaxmedia.com On 24/10/2009, at 9:05 PM, [hidden email] wrote: > Author: jleroux > Date: Sat Oct 24 08:05:41 2009 > New Revision: 829320 > > URL: http://svn.apache.org/viewvc?rev=829320&view=rev > Log: > Reverts a change done in r806206, definitively fix "Error during > Registration (new customer)" reported by Abdullah Shaikh at (https://issues.apache.org/jira/browse/OFBIZ-3076 > ) - OFBIZ-3076 > > Modified: > ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/customer/ > newcustomer.ftl > > Modified: ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/ > customer/newcustomer.ftl > URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/customer/newcustomer.ftl?rev=829320&r1=829319&r2=829320&view=diff > = > = > = > = > = > = > = > = > ====================================================================== > --- ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/customer/ > newcustomer.ftl (original) > +++ ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/customer/ > newcustomer.ftl Sat Oct 24 08:05:41 2009 > @@ -229,7 +229,7 @@ > <select name="CUSTOMER_ADDRESS_ALLOW_SOL" > id="CUSTOMER_ADDRESS_ALLOW_SOL"> > <#if (((requestParameters.CUSTOMER_ADDRESS_ALLOW_SOL)!"") == > "Y")><option value="Y">${uiLabelMap.CommonY}</option></#if> > <#if (((requestParameters.CUSTOMER_ADDRESS_ALLOW_SOL)!"") == > "N")><option value="N">${uiLabelMap.CommonN}</option></#if> > - <option>-</option> > + <option></option> > <option value="Y">${uiLabelMap.CommonY}</option> > <option value="N">${uiLabelMap.CommonN}</option> > </select> > > |
smime.p7s (4K)
Re: svn commit: r829320 - /ofbiz/trunk/specialpurpose/ec
Administrator
|
Re: svn commit: r829320 - /ofbiz/trunk/specialpurpose/ec
|
|
No in this commit you put this:
<option></option> I am saying that the correct fix is this: <option value="">---</option> We use "---" all over the place a separator in drop downs and my example above shows how that is done. Regards Scott On 29/10/2009, at 8:09 PM, Jacques Le Roux wrote: > Hi Scott, > > Yes that's what I done finally in this commit. > But it's obvious below, so do I miss something in your message ? > > Jacques > > From: "Scott Gray" <[hidden email]> >> Hi Jacques >> >> Sorry I only just got around to reviewing this, the correct fix is >> to provide an empty option value so that the option description >> doesn't become the value: >> <option value="">--</option> >> >> Regards >> Scott >> >> HotWax Media >> http://www.hotwaxmedia.com >> >> On 24/10/2009, at 9:05 PM, [hidden email] wrote: >> >>> Author: jleroux >>> Date: Sat Oct 24 08:05:41 2009 >>> New Revision: 829320 >>> >>> URL: http://svn.apache.org/viewvc?rev=829320&view=rev >>> Log: >>> Reverts a change done in r806206, definitively fix "Error during >>> Registration (new customer)" reported by Abdullah Shaikh at (https://issues.apache.org/jira/browse/OFBIZ-3076 >>> ) - OFBIZ-3076 >>> >>> Modified: >>> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/customer/ >>> newcustomer.ftl >>> >>> Modified: ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/ >>> customer/newcustomer.ftl >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/customer/newcustomer.ftl?rev=829320&r1=829319&r2=829320&view=diff >>> = = = = = = = = >>> = >>> = >>> ==================================================================== >>> --- ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/ >>> customer/ newcustomer.ftl (original) >>> +++ ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/ >>> customer/ newcustomer.ftl Sat Oct 24 08:05:41 2009 >>> @@ -229,7 +229,7 @@ >>> <select name="CUSTOMER_ADDRESS_ALLOW_SOL" >>> id="CUSTOMER_ADDRESS_ALLOW_SOL"> >>> <#if (((requestParameters.CUSTOMER_ADDRESS_ALLOW_SOL)!"") >>> == "Y")><option value="Y">${uiLabelMap.CommonY}</option></#if> >>> <#if (((requestParameters.CUSTOMER_ADDRESS_ALLOW_SOL)!"") >>> == "N")><option value="N">${uiLabelMap.CommonN}</option></#if> >>> - <option>-</option> >>> + <option></option> >>> <option value="Y">${uiLabelMap.CommonY}</option> >>> <option value="N">${uiLabelMap.CommonN}</option> >>> </select> >>> >>> >> > > |
Re: svn commit: r829320 - /ofbiz/trunk/specialpurpose/ec
|
Administrator
|
Re: svn commit: r829320 - /ofbiz/trunk/specialpurpose/ec
|
|
On 29/10/2009, at 9:41 PM, Jacques Le Roux wrote:
> Scott, > > I know that we use <option value="">---</option> in may places, but. > Did you try prior to my change (in other word did you read > OFBIZ-3076) ? Yes I read the jira issue and it was broken because the empty value attribute was missing. > Also did you try with your recommendation ? I don't need to, I know it works. > Did you try with my change ? I don't need to, I know it works. > Firts, I put "<option>-</option>" in replacement of "<option>--</ > option>", which, I believe, has been "inadvertently" commited. > Then, I noticed that there was already 6 "<option></option>". So I > followed the trend and I think it the right way there. Okay that's fair I didn't go and dig up the rest of the file. I saw the first commit which was wrong and then on the 2nd I assumed that you weren't aware that an empty value attribute would solve the problem (mostly because of the first commit). If you were bringing the select into line with all the others then that makes perfect sense and I'm sorry to have troubled you. Regards Scott > > From: "Scott Gray" <[hidden email]> >> No in this commit you put this: >> <option></option> >> I am saying that the correct fix is this: >> <option value="">---</option> >> >> We use "---" all over the place a separator in drop downs and my >> example above shows how that is done. >> >> Regards >> Scott >> >> On 29/10/2009, at 8:09 PM, Jacques Le Roux wrote: >> >>> Hi Scott, >>> >>> Yes that's what I done finally in this commit. >>> But it's obvious below, so do I miss something in your message ? >>> >>> Jacques >>> >>> From: "Scott Gray" <[hidden email]> >>>> Hi Jacques >>>> >>>> Sorry I only just got around to reviewing this, the correct fix >>>> is to provide an empty option value so that the option >>>> description doesn't become the value: >>>> <option value="">--</option> >>>> >>>> Regards >>>> Scott >>>> >>>> HotWax Media >>>> http://www.hotwaxmedia.com >>>> >>>> On 24/10/2009, at 9:05 PM, [hidden email] wrote: >>>> >>>>> Author: jleroux >>>>> Date: Sat Oct 24 08:05:41 2009 >>>>> New Revision: 829320 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=829320&view=rev >>>>> Log: >>>>> Reverts a change done in r806206, definitively fix "Error >>>>> during Registration (new customer)" reported by Abdullah >>>>> Shaikh at (https://issues.apache.org/jira/browse/OFBIZ-3076 ) - >>>>> OFBIZ-3076 >>>>> >>>>> Modified: >>>>> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/ >>>>> customer/ newcustomer.ftl >>>>> >>>>> Modified: ofbiz/trunk/specialpurpose/ecommerce/webapp/ >>>>> ecommerce/ customer/newcustomer.ftl >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/customer/newcustomer.ftl?rev=829320&r1=829319&r2=829320&view=diff >>>>> = = = = = = = = = = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/ >>>>> customer/ newcustomer.ftl (original) >>>>> +++ ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/ >>>>> customer/ newcustomer.ftl Sat Oct 24 08:05:41 2009 >>>>> @@ -229,7 +229,7 @@ >>>>> <select name="CUSTOMER_ADDRESS_ALLOW_SOL" >>>>> id="CUSTOMER_ADDRESS_ALLOW_SOL"> >>>>> <#if (((requestParameters.CUSTOMER_ADDRESS_ALLOW_SOL)!"") >>>>> == "Y")><option value="Y">${uiLabelMap.CommonY}</option></#if> >>>>> <#if (((requestParameters.CUSTOMER_ADDRESS_ALLOW_SOL)!"") >>>>> == "N")><option value="N">${uiLabelMap.CommonN}</option></#if> >>>>> - <option>-</option> >>>>> + <option></option> >>>>> <option value="Y">${uiLabelMap.CommonY}</option> >>>>> <option value="N">${uiLabelMap.CommonN}</option> >>>>> </select> >>>>> >>>>> >>>> >>> >>> >> > > |
Re: svn commit: r829320 - /ofbiz/trunk/specialpurpose/ec
|
Administrator
|
| Free forum by Nabble | Edit this page |