Re: svn commit: r829434 - in /ofbiz/trunk/applications/product: webapp/catalog/product/ProductForms.xml widget/catalog/ProductForms.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r829434 - in /ofbiz/trunk/applications/product: webapp/catalog/product/ProductForms.xml widget/catalog/ProductForms.xml

Bruno Busco
Hi Marco,
sorry for this, I understand that having files moved or renamed is an
issue for pending commits...
-Bruno


2009/10/24  <[hidden email]>:

> Author: mrisaliti
> Date: Sat Oct 24 19:08:42 2009
> New Revision: 829434
>
> URL: http://svn.apache.org/viewvc?rev=829434&view=rev
> Log:
> Sorry, I have not seen that in the meantime the ProductForms.xml has been moved to widget folder.
> Best Selling Products does not support product name internationalization (OFBIZ-3081)
>
> Removed:
>    ofbiz/trunk/applications/product/webapp/catalog/product/ProductForms.xml
> Modified:
>    ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml
>
> Modified: ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml?rev=829434&r1=829433&r2=829434&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml (original)
> +++ ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml Sat Oct 24 19:08:42 2009
> @@ -1913,10 +1913,7 @@
>
>     <form name="ListBestProduct" type="list" paginate="false" list-name="bestSellingProducts" view-size="5"
>             header-row-style="header-row" odd-row-style="alternate-row" default-table-style="basic-table hover-bar">
> -        <row-actions>
> -            <entity-one entity-name="Product" value-field="product"/>
> -        </row-actions>
> -        <field name="productName" title="${uiLabelMap.ProductName}"><display description="${product.productName}"/></field>
> +        <field name="productName" title="${uiLabelMap.ProductName}"><display description="${productName}"/></field>
>         <field name="amount"><display/></field>
>         <field name="qtyOrdered" title="${uiLabelMap.OrderQtyOrdered}"><display/></field>
>     </form>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r829434 - in /ofbiz/trunk/applications/product: webapp/catalog/product/ProductForms.xml widget/catalog/ProductForms.xml

risalitim@gmail.com
Hi Bruno,

no problem, it was very easy to fix it.
I have done also a commit rev. 829436 about a wrong reference to  
ShipmentForms.xml that now has been moved to product/widget/facility.
Please take a look at it if there are some other wrong references to  
previous folder where the forms was before.

Thanks
Marco


Il giorno 24/ott/2009, alle ore 21.50, Bruno Busco ha scritto:

> Hi Marco,
> sorry for this, I understand that having files moved or renamed is an
> issue for pending commits...
> -Bruno
>
>
> 2009/10/24  <[hidden email]>:
>> Author: mrisaliti
>> Date: Sat Oct 24 19:08:42 2009
>> New Revision: 829434
>>
>> URL: http://svn.apache.org/viewvc?rev=829434&view=rev
>> Log:
>> Sorry, I have not seen that in the meantime the ProductForms.xml  
>> has been moved to widget folder.
>> Best Selling Products does not support product name  
>> internationalization (OFBIZ-3081)
>>
>> Removed:
>>    ofbiz/trunk/applications/product/webapp/catalog/product/
>> ProductForms.xml
>> Modified:
>>    ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml
>>
>> Modified: ofbiz/trunk/applications/product/widget/catalog/
>> ProductForms.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml?rev=829434&r1=829433&r2=829434&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/applications/product/widget/catalog/
>> ProductForms.xml (original)
>> +++ ofbiz/trunk/applications/product/widget/catalog/
>> ProductForms.xml Sat Oct 24 19:08:42 2009
>> @@ -1913,10 +1913,7 @@
>>
>>     <form name="ListBestProduct" type="list" paginate="false" list-
>> name="bestSellingProducts" view-size="5"
>>             header-row-style="header-row" odd-row-style="alternate-
>> row" default-table-style="basic-table hover-bar">
>> -        <row-actions>
>> -            <entity-one entity-name="Product" value-
>> field="product"/>
>> -        </row-actions>
>> -        <field name="productName" title="$
>> {uiLabelMap.ProductName}"><display description="$
>> {product.productName}"/></field>
>> +        <field name="productName" title="$
>> {uiLabelMap.ProductName}"><display description="${productName}"/></
>> field>
>>         <field name="amount"><display/></field>
>>         <field name="qtyOrdered" title="$
>> {uiLabelMap.OrderQtyOrdered}"><display/></field>
>>     </form>
>>
>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r829434 - in /ofbiz/trunk/applications/product: webapp/catalog/product/ProductForms.xml widget/catalog/ProductForms.xml

Bruno Busco
Thank you Marco for the fix on the ShipmentForms.xml.
I missed it. I hope I did not miss any other reference.

-Bruno

2009/10/24 [hidden email] <[hidden email]>:

> Hi Bruno,
>
> no problem, it was very easy to fix it.
> I have done also a commit rev. 829436 about a wrong reference to
> ShipmentForms.xml that now has been moved to product/widget/facility.
> Please take a look at it if there are some other wrong references to
> previous folder where the forms was before.
>
> Thanks
> Marco
>
>
> Il giorno 24/ott/2009, alle ore 21.50, Bruno Busco ha scritto:
>
>> Hi Marco,
>> sorry for this, I understand that having files moved or renamed is an
>> issue for pending commits...
>> -Bruno
>>
>>
>> 2009/10/24  <[hidden email]>:
>>>
>>> Author: mrisaliti
>>> Date: Sat Oct 24 19:08:42 2009
>>> New Revision: 829434
>>>
>>> URL: http://svn.apache.org/viewvc?rev=829434&view=rev
>>> Log:
>>> Sorry, I have not seen that in the meantime the ProductForms.xml has been
>>> moved to widget folder.
>>> Best Selling Products does not support product name internationalization
>>> (OFBIZ-3081)
>>>
>>> Removed:
>>>
>>> ofbiz/trunk/applications/product/webapp/catalog/product/ProductForms.xml
>>> Modified:
>>>   ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml
>>>
>>> Modified:
>>> ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml?rev=829434&r1=829433&r2=829434&view=diff
>>>
>>> ==============================================================================
>>> --- ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml
>>> (original)
>>> +++ ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml Sat
>>> Oct 24 19:08:42 2009
>>> @@ -1913,10 +1913,7 @@
>>>
>>>    <form name="ListBestProduct" type="list" paginate="false"
>>> list-name="bestSellingProducts" view-size="5"
>>>            header-row-style="header-row" odd-row-style="alternate-row"
>>> default-table-style="basic-table hover-bar">
>>> -        <row-actions>
>>> -            <entity-one entity-name="Product" value-field="product"/>
>>> -        </row-actions>
>>> -        <field name="productName"
>>> title="${uiLabelMap.ProductName}"><display
>>> description="${product.productName}"/></field>
>>> +        <field name="productName"
>>> title="${uiLabelMap.ProductName}"><display
>>> description="${productName}"/></field>
>>>        <field name="amount"><display/></field>
>>>        <field name="qtyOrdered"
>>> title="${uiLabelMap.OrderQtyOrdered}"><display/></field>
>>>    </form>
>>>
>>>
>>>
>
>