Re: svn commit: r880871 - in /ofbiz/trunk: framework/common/widget/CommonMenus.xml themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css

[Jacques Le Roux]

Adrian,

There is a little problem with this change. Have a look at https://localhost:8443/catalog/control/ListShipmentMethodTypes.
On the ohrer hand https://localhost:8443/webtools/control/xmldsdump looks far better

Thanks

Jacques

From: <[hidden email]>

> Author: adrianc
> Date: Mon Nov 16 17:48:42 2009
> New Revision: 880871
>
> URL: http://svn.apache.org/viewvc?rev=880871&view=rev
> Log:
> Fixed layout problems in the new visual theme.
>
> I took the no-clear style out of the tab bar - that should not have been put there. The no-clear style is intended to be used on a
> case-by-case basis when the layout is adversely affected by clearing floats.
>
> Modified:
>    ofbiz/trunk/framework/common/widget/CommonMenus.xml
>    ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css
>
> Modified: ofbiz/trunk/framework/common/widget/CommonMenus.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonMenus.xml?rev=880871&r1=880870&r2=880871&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/common/widget/CommonMenus.xml (original)
> +++ ofbiz/trunk/framework/common/widget/CommonMenus.xml Mon Nov 16 17:48:42 2009
> @@ -28,5 +28,5 @@
>     </menu>
>
>     <menu name="CommonTabBarMenu" selected-menuitem-context-field-name="tabButtonItem" type="simple"
> -          menu-container-style="button-bar tab-bar no-clear" default-selected-style="selected"/>
> +          menu-container-style="button-bar tab-bar" default-selected-style="selected"/>
> </menus>
>
> Modified: ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css?rev=880871&r1=880870&r2=880871&view=diff
> ==============================================================================
> --- ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css (original)
> +++ ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css Mon Nov 16 17:48:42 2009
> @@ -1268,7 +1268,8 @@
> /* ===== Button Bar Navigation Styles ===== */
> /* ======================================== */
> .button-bar {
> -margin: 0 1em 1em 0;
> +margin-bottom: 1em;
> +/*margin: 0 1em 1em 0; */
> }
>
> .button-bar ul {
> @@ -1278,8 +1279,8 @@
> .button-bar ul li {
> float: left;
> font-weight: bold;
> -padding: 0.1em 0.4em 0.1em 0.4em;
> -background-color: #0099CC;
> +/*padding: 0.1em 0.4em 0.1em 0.4em; */
> +/*background-color: #0099CC; */
> }
>
> .button-bar ul .opposed {
> @@ -1367,8 +1368,8 @@
> background-color: #0099CC;
> padding:5px 10px 0px 10px;
> font-size:1.1em;
> -margin: -7px -12px 10px -12px;
> -height:19px;
> +margin-top: -7px;
> +/*height:19px; */
> }
>
> .tab-bar ul li {
>
>

[Adrian Crum]

Jacques,

The solution to that problem is in the commit log. Specific menus that
have that problem need to use the no-clear class, but not ALL menus.

-Adrian

Jacques Le Roux wrote:

> Adrian,
>
> There is a little problem with this change. Have a look at
> https://localhost:8443/catalog/control/ListShipmentMethodTypes.
> On the ohrer hand https://localhost:8443/webtools/control/xmldsdump 
> looks far better
>
> Thanks
>
> Jacques
>
> From: <[hidden email]>
>> Author: adrianc
>> Date: Mon Nov 16 17:48:42 2009
>> New Revision: 880871
>>
>> URL: http://svn.apache.org/viewvc?rev=880871&view=rev
>> Log:
>> Fixed layout problems in the new visual theme.
>>
>> I took the no-clear style out of the tab bar - that should not have
>> been put there. The no-clear style is intended to be used on a
>> case-by-case basis when the layout is adversely affected by clearing
>> floats.
>>
>> Modified:
>>    ofbiz/trunk/framework/common/widget/CommonMenus.xml
>>    ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css
>>
>> Modified: ofbiz/trunk/framework/common/widget/CommonMenus.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonMenus.xml?rev=880871&r1=880870&r2=880871&view=diff 
>>
>> ==============================================================================
>>
>> --- ofbiz/trunk/framework/common/widget/CommonMenus.xml (original)
>> +++ ofbiz/trunk/framework/common/widget/CommonMenus.xml Mon Nov 16
>> 17:48:42 2009
>> @@ -28,5 +28,5 @@
>>     </menu>
>>
>>     <menu name="CommonTabBarMenu"
>> selected-menuitem-context-field-name="tabButtonItem" type="simple"
>> -          menu-container-style="button-bar tab-bar no-clear"
>> default-selected-style="selected"/>
>> +          menu-container-style="button-bar tab-bar"
>> default-selected-style="selected"/>
>> </menus>
>>
>> Modified:
>> ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css?rev=880871&r1=880870&r2=880871&view=diff 
>>
>> ==============================================================================
>>
>> ---
>> ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css
>> (original)
>> +++
>> ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css
>> Mon Nov 16 17:48:42 2009
>> @@ -1268,7 +1268,8 @@
>> /* ===== Button Bar Navigation Styles ===== */
>> /* ======================================== */
>> .button-bar {
>> -margin: 0 1em 1em 0;
>> +margin-bottom: 1em;
>> +/*margin: 0 1em 1em 0; */
>> }
>>
>> .button-bar ul {
>> @@ -1278,8 +1279,8 @@
>> .button-bar ul li {
>> float: left;
>> font-weight: bold;
>> -padding: 0.1em 0.4em 0.1em 0.4em;
>> -background-color: #0099CC;
>> +/*padding: 0.1em 0.4em 0.1em 0.4em; */
>> +/*background-color: #0099CC; */
>> }
>>
>> .button-bar ul .opposed {
>> @@ -1367,8 +1368,8 @@
>> background-color: #0099CC;
>> padding:5px 10px 0px 10px;
>> font-size:1.1em;
>> -margin: -7px -12px 10px -12px;
>> -height:19px;
>> +margin-top: -7px;
>> +/*height:19px; */
>> }
>>
>> .tab-bar ul li {
>>
>>
>
>
>

[Jacques Le Roux]

Adrian,

Ha sorry, as it has fixed https://localhost:8443/webtools/control/xmldsdump I thought it should have fixed all of them

Thanks

Jacques

From: "Adrian Crum" <[hidden email]>

> Jacques,
>
> The solution to that problem is in the commit log. Specific menus that have that problem need to use the no-clear class, but not
> ALL menus.
>
> -Adrian
>
> Jacques Le Roux wrote:
>> Adrian,
>>
>> There is a little problem with this change. Have a look at https://localhost:8443/catalog/control/ListShipmentMethodTypes.
>> On the ohrer hand https://localhost:8443/webtools/control/xmldsdump looks far better
>>
>> Thanks
>>
>> Jacques
>>
>> From: <[hidden email]>
>>> Author: adrianc
>>> Date: Mon Nov 16 17:48:42 2009
>>> New Revision: 880871
>>>
>>> URL: http://svn.apache.org/viewvc?rev=880871&view=rev
>>> Log:
>>> Fixed layout problems in the new visual theme.
>>>
>>> I took the no-clear style out of the tab bar - that should not have been put there. The no-clear style is intended to be used on
>>> a case-by-case basis when the layout is adversely affected by clearing floats.
>>>
>>> Modified:
>>>    ofbiz/trunk/framework/common/widget/CommonMenus.xml
>>>    ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css
>>>
>>> Modified: ofbiz/trunk/framework/common/widget/CommonMenus.xml
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonMenus.xml?rev=880871&r1=880870&r2=880871&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/framework/common/widget/CommonMenus.xml (original)
>>> +++ ofbiz/trunk/framework/common/widget/CommonMenus.xml Mon Nov 16 17:48:42 2009
>>> @@ -28,5 +28,5 @@
>>>     </menu>
>>>
>>>     <menu name="CommonTabBarMenu" selected-menuitem-context-field-name="tabButtonItem" type="simple"
>>> -          menu-container-style="button-bar tab-bar no-clear" default-selected-style="selected"/>
>>> +          menu-container-style="button-bar tab-bar" default-selected-style="selected"/>
>>> </menus>
>>>
>>> Modified: ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css?rev=880871&r1=880870&r2=880871&view=diff
>>> ==============================================================================
>>> ---
>>> ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css (original)
>>> +++ ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/css/style.css Mon Nov 16 17:48:42 2009
>>> @@ -1268,7 +1268,8 @@
>>> /* ===== Button Bar Navigation Styles ===== */
>>> /* ======================================== */
>>> .button-bar {
>>> -margin: 0 1em 1em 0;
>>> +margin-bottom: 1em;
>>> +/*margin: 0 1em 1em 0; */
>>> }
>>>
>>> .button-bar ul {
>>> @@ -1278,8 +1279,8 @@
>>> .button-bar ul li {
>>> float: left;
>>> font-weight: bold;
>>> -padding: 0.1em 0.4em 0.1em 0.4em;
>>> -background-color: #0099CC;
>>> +/*padding: 0.1em 0.4em 0.1em 0.4em; */
>>> +/*background-color: #0099CC; */
>>> }
>>>
>>> .button-bar ul .opposed {
>>> @@ -1367,8 +1368,8 @@
>>> background-color: #0099CC;
>>> padding:5px 10px 0px 10px;
>>> font-size:1.1em;
>>> -margin: -7px -12px 10px -12px;
>>> -height:19px;
>>> +margin-top: -7px;
>>> +/*height:19px; */
>>> }
>>>
>>> .tab-bar ul li {
>>>
>>>
>>
>>
>>
>