Re: svn commit: r890175 [1/2] - in /ofbiz/trunk: ./ applications/content/ applications/content/data/ framework/ framework/base/config/ framework/birt/ framework/birt/config/ framework/birt/data/ framework/birt/data/helpdata/ framework/birt/lib/ framework/b...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
27 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r890175 [1/2] - in /ofbiz/trunk: ./ applications/content/ applications/content/data/ framework/ framework/base/config/ framework/birt/ framework/birt/config/ framework/birt/data/ framework/birt/data/helpdata/ framework/birt/lib/ framework/b...

Adam Heath-2
Adam Heath wrote:
> David E Jones wrote:
>> Yes, I agree with you there Scott. Hans or Adam should have researched
>> and resolved legal questions before committing.
>
> The person committing the code is responsible for making certain it
> follows licensing guidelines.  Please refer back to the SCA that we
> all had to sign before becomming a committer.

s/SCA/CLA/

> If you aren't willing to follow those guidelines, then you shouldn't
> be committing code.

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r890175 [1/2] - in /ofbiz/trunk: ./ applications/content/ applications/content/data/ framework/ framework/base/config/ framework/birt/ framework/birt/config/ framework/birt/data/ framework/birt/data/helpdata/ framework/birt/lib/ framework/b

Jacques Le Roux
Administrator
In reply to this post by Scott Gray-2
Inline...

From: "Scott Gray" <[hidden email]>
> On 19/12/2009, at 9:44 AM, David E Jones wrote:
>
>>
>> Thanks for your comments Ean, this is a voice of sanity IMO....
>
> If there is any doubt or disagreement the only sane thing to do is to  ask legal, anything else is just noise.

So who will ask ?
I'm not sure to understand why they use "may" in these sentences instead of must?
IANAL and English is not my mother tongues, any ideas?

>> On Dec 18, 2009, at 1:46 PM, Ean Schuessler wrote:
>>
>>> I have done some more reading on Apache 3rd party licensing and after
>>> some careful reading, I believe that Hans' use of BIRT is acceptably
>>> within the policy. The latest copy of the policy is available at
>>> "http://www.apache.org/legal/3party.html" with the key area being
>>> "Category B: Reciprocal Licenses". The important phrase in that  section
>>> that we seem to have missed is the reference to code "not directly
>>> consumed at runtime in source
>>> <http://www.apache.org/legal/3party.html#define-source> form". To me,
>>> that phrase says that source which is "consumed at runtime in source
>>> form" is not required to be shipped as a binary.
>
> Selective quoting FTW?
>
> "For small amounts of source that is directly consumed by the ASF  product at runtime in source form, and for which that source is
> unlikely to be changed anyway (say, by virtue of being specified by a  standard), this action is sufficient. An example of this is
> the web- facesconfig_1_0.dtd, whose inclusion is mandated by the JSR 127:  JavaServer Facesspecification.
> Code that is more substantial, more volatile, or not directly consumed  at runtime in source form may only be distributed in
> binary form."
>
> Small amount of source? I don't consider an entire 45 file javascript  library and 37 jsp files to be a small amount of source.
>
> Unlikely to be changed? The javascript perhaps but I think there is a  decent chance of a downstream user changing the jsp files


As long as s/he does not distribute her/his work it's not a problem.
But ok, it's possible and then it breaks reciprocity: <<requiring that the distribution of modifications or derivative works be made
available under the same license as the original work>>

>
>>
>> I agree with this and tried to make this point early on in the  discussion. We should be able to include these files just fine in
>> source form, as long as they are not modified.

Mmm, we let open the possibibilty to break reciprocity, isn'it ?

> You didn't try very hard, I responded to you and you didn't reply.
>
>> For any that need to be modified we would need to do a "clean room"  style implementation. Coding it in a different language, or
>> templating tool, even using the same concepts as the original, is  fine AFAIK as there is no violation of copyright possible then
>> (same  ideas, substantially different implementation).
>>
>> For EPL code we can call it and refer to it, but not change it  without having to license the changes as EPL as well (ie it is
>> not  viral by reference/use, only by change).
>
> "We" being the community at large, the primary concern of the policy  is how these licenses will affect downstream users, hence
> the  restrictions on including source code that can be modified.  While we  all seem to understand the implications of modifying
> EPL source code  there is a good chance that our users will not.

Right, and it's clearly our responsability

Jacques

>>
>>> The policy does suggest that source under a reciprocal license  should be
>>> clearly marked as such, primarily to avoid it (or dependencies on it)
>>> being intermingled with other ASL code. I think that since BIRT is
>>> packaged as its own component we are well on the way to this. We may
>>> just want to consider whether this code belongs in "framework" as
>>> opposed to "applications" or "specialpurpose". At the least, we  should
>>> include a NOTICE-BIRT-IS-EPL file or something at the root of the  component.
>>
>> Where to put it is another good point. IMO if we're going to have  OOTB reports using it then it probably should go in the
>> framework.  If not, then specialpurpose is probably best.
>>
>> -David
>>
>>
>>
>>> Those issues aside, my opinion is that including the EPL licensed  code
>>> is legitimate.
>>>
>>> Hans Bakker wrote:
>>>> We will either remove or replace all jsp's wih ftl's of the birt
>>>> component in the next few days...
>>>>
>>> --
>>> Ean Schuessler, CTO
>>> [hidden email]
>>> 214-720-0700 x 315
>>> Brainfood, Inc.
>>> http://www.brainfood.com
>>>
>>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r890175 [1/2] - in /ofbiz/trunk: ./ applications/content/ applications/content/data/ framework/ framework/base/config/ framework/birt/ framework/birt/config/ framework/birt/data/ framework/birt/data/helpdata/ framework/birt/lib/ framework/b

Jacques Le Roux
Administrator
In reply to this post by Ean Schuessler
From: "Ean Schuessler" <[hidden email]>
To: <[hidden email]>
Sent: Friday, December 18, 2009 10:44 PM
Subject: Re: svn commit: r890175 [1/2] - in /ofbiz/trunk: ./ applications/content/ applications/content/data/ framework/
framework/base/config/ framework/birt/ framework/birt/config/ framework/birt/data/ framework/birt/data/helpdata/ framework/birt/lib/
framework/b...


> Scott Gray wrote:
>> Selective quoting FTW?
>>
>> "For small amounts of source that is directly consumed by the ASF
>> product at runtime in source form, and for which that source is
>> unlikely to be changed anyway (say, by virtue of being specified by a
>> standard), this action is sufficient. An example of this is the
>> web-facesconfig_1_0.dtd, whose inclusion is mandated by the JSR 127:
>> JavaServer Facesspecification.
>> Code that is more substantial, more volatile, or not directly consumed
>> at runtime in source form may only be distributed in binary form."
>>
>> Small amount of source? I don't consider an entire 45 file javascript
>> library and 37 jsp files to be a small amount of source.
>>
>> Unlikely to be changed? The javascript perhaps but I think there is a
>> decent chance of a downstream user changing the jsp files
> I suppose it depends on what you decide is a "more substantial" amount
> of code. Is the limit 34K? (the size of the example DTD) That seems
> arbitrary to me. The .js, .jsp and .css files, taken together constitute
> 1.7% of the BIRT runtime, and they are uncompressed. That seems fairly
> insubstantial to me but I suppose we must at this point defer to higher
> authorities.

Yes, it's all about that. As IIRW it has been already said, I don't think it's a problem for the code already commited.
The intention is more important, anybody can make an error, intentionally not repairing this error is where the real problems
begin...
At least it's how I see justice. And anyway as long as nobody as modified and distributed this code it's not a problem, is it?

> It does seem crystal clear that including the BIRT runtime as a WAR is
> in compliance because it "reduces the exposed surface area" of the code.
> If they want to split that hair I suppose we can go that way or write a
> ROT13 decoder to strap onto the JSP resource loader.

Maybe the solution

Jacques

> --
> Ean Schuessler, CTO
> [hidden email]
> 214-720-0700 x 315
> Brainfood, Inc.
> http://www.brainfood.com
>
>


Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r890175 [1/2] - in /ofbiz/trunk: ./ applications/content/ applications/content/data/ framework/ framework/base/config/ framework/birt/ framework/birt/config/ framework/birt/data/ framework/birt/data/helpdata/ framework/birt/lib/ framework/b

Jacques Le Roux
Administrator
In reply to this post by Scott Gray-2
From: "Scott Gray" <[hidden email]>

> On 19/12/2009, at 10:09 AM, David E Jones wrote:
>
>>
>> On Dec 18, 2009, at 3:03 PM, Scott Gray wrote:
>>
>>> On 19/12/2009, at 9:44 AM, David E Jones wrote:
>>>> I agree with this and tried to make this point early on in the  
>>>> discussion. We should be able to include these files just fine in  
>>>> source form, as long as they are not modified.
>>>
>>> You didn't try very hard, I responded to you and you didn't reply.
>>
>> I'm not into shouting into the wind any more. I used to be, but not  
>> any more. That's why I won't try to argue this one either.  
>> Eventually people will tire of fighting, and then something will  
>> happen. I'm perfectly willing to wait.
>
> I'm sending an email to legal-discuss now.  The frustrating thing from  
> my point of view is that this was discussed and the code of concern  
> was subsequently removed from the branch but then added back in when  
> BIRT came into the trunk.  An email to legal-discuss should have been  
> sent over a month ago and I don't think it was my responsibility to do  
> so.

Thanks Scott,

I agree it should have been done at least before this code was commited

Jacques

> Regards
> Scott

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r890175 [1/2] - in /ofbiz/trunk: ./ applications/content/ applications/content/data/ framework/ framework/base/config/ framework/birt/ framework/birt/config/ framework/birt/data/ framework/birt/data/helpdata/ framework/birt/lib/ framework/b...

hans_bakker
In reply to this post by Scott Gray-2
On Sat, 2009-12-19 at 10:23 +1300, Scott Gray wrote:
> The frustrating thing from  
> my point of view is that this was discussed and the code of concern  
> was subsequently removed from the branch but then added back in when  
> BIRT came into the trunk.  

I used the svn merge command to move thinks into the trunk. It seems
that the merge command does ignore 'deleted' files and still adds them.

Let me know where this merge went wrong and we will correct it.

My Intention was to merge the 'addbirt' branch into he trunk at the
agreed status at the end.

Regards,
Hans

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r890175 [1/2] - in /ofbiz/trunk: ./ applications/content/ applications/content/data/ framework/ framework/base/config/ framework/birt/ framework/birt/config/ framework/birt/data/ framework/birt/data/helpdata/ framework/birt/lib/ framework/b...

Jacopo Cappellato-4

On Dec 19, 2009, at 12:10 AM, Hans Bakker wrote:

> On Sat, 2009-12-19 at 10:23 +1300, Scott Gray wrote:
>> The frustrating thing from  
>> my point of view is that this was discussed and the code of concern  
>> was subsequently removed from the branch but then added back in when  
>> BIRT came into the trunk.  
>
> I used the svn merge command to move thinks into the trunk. It seems
> that the merge command does ignore 'deleted' files and still adds them.
>
> Let me know where this merge went wrong and we will correct it.

Isn't it clear from the previous messages of this thread?

Jacopo

>
> My Intention was to merge the 'addbirt' branch into he trunk at the
> agreed status at the end.
>
> Regards,
> Hans
>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r890175 [1/2] - in /ofbiz/trunk: ./ applications/content/ applications/content/data/ framework/ framework/base/config/ framework/birt/ framework/birt/config/ framework/birt/data/ framework/birt/data/helpdata/ framework/birt/lib/ framework/b...

hans_bakker
In reply to this post by hans_bakker
I had a local svn problem here where these files did not show.
Did a new checkout and deleted these files in the same way as was done
in the adbirt branch: New Revision: 892454

On Sat, 2009-12-19 at 06:10 +0700, Hans Bakker wrote:

> On Sat, 2009-12-19 at 10:23 +1300, Scott Gray wrote:
> > The frustrating thing from  
> > my point of view is that this was discussed and the code of concern  
> > was subsequently removed from the branch but then added back in when  
> > BIRT came into the trunk.  
>
> I used the svn merge command to move thinks into the trunk. It seems
> that the merge command does ignore 'deleted' files and still adds them.
>
> Let me know where this merge went wrong and we will correct it.
>
> My Intention was to merge the 'addbirt' branch into he trunk at the
> agreed status at the end.
>
> Regards,
> Hans
>
--
Antwebsystems.com: Quality OFBiz services for competitive rates

12