Re: svn commit: r916608 - in /ofbiz/trunk/framework/service: config/service.properties src/org/ofbiz/service/ModelService.java src/org/ofbiz/service/ModelServiceReader.java src/org/ofbiz/service/ServiceDispatcher.java

[Adam Heath-2]

[hidden email] wrote:

> Author: jacopoc
> Date: Fri Feb 26 08:01:21 2010
> New Revision: 916608
>
> URL: http://svn.apache.org/viewvc?rev=916608&view=rev
> Log:
> Added flag to switch off the debug mode for services that is causing out of memory errors for JVM PermGen space.
> Warning: the default setting is still set to true but it is highly recommended to set it to false, especially for non-development instances (production, demo etc...).
>
> Modified:
>     ofbiz/trunk/framework/service/config/service.properties
>     ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelService.java
>     ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java
>     ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceDispatcher.java

I would have done this slightly differently, by creating an invoker
that was a dummy class, so that you wouldn't have had to touch the
other classes.  But your change appears fine to me.