Re: svn commit: r920212 - in /ofbiz/trunk/specialpurpose/projectmgr: script/org/ofbiz/project/ProjectServices.xml servicedef/services.xml webapp/projectmgr/WEB-INF/actions/EditWeekTimesheet.groovy widget/forms/TimeSheetForms.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r920212 - in /ofbiz/trunk/specialpurpose/projectmgr: script/org/ofbiz/project/ProjectServices.xml servicedef/services.xml webapp/projectmgr/WEB-INF/actions/EditWeekTimesheet.groovy widget/forms/TimeSheetForms.xml

Jacopo Cappellato-4

> Date: Mon Mar  8 06:59:23 2010
> New Revision: 920212
>
> URL: http://svn.apache.org/viewvc?rev=920212&view=rev
> Log:
> show wbsId on project manager timesheets

After recent increas of temperature on this list I don't feel very comfortable in commenting because I fear this could be interpreted as an unfair attack but... the quality of code committed in this revision could be highly improved. I don't want to point out specific issues, but I think that it will not be difficult how to change the above code to look better (more reusable etc...).

Kind regards,

Jacopo