OFBiz › OFBiz - Dev

Re: svn commit: r927876 - in /ofbiz/branches/release09.04: ./ .project applications/accounting/webapp/accounting/WEB-INF/actions/invoice/ListNotAppliedPayments.groovy startofbiz.bat

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

Adam Heath-2

Re: svn commit: r927876 - in /ofbiz/branches/release09.04: ./ .project applications/accounting/webapp/accounting/WEB-INF/actions/invoice/ListNotAppliedPayments.groovy startofbiz.bat

[hidden email] wrote:

> Author: jleroux
> Date: Fri Mar 26 14:39:45 2010
> New Revision: 927876
>
> URL: http://svn.apache.org/viewvc?rev=927876&view=rev
> Log:
> "Applied fix from trunk for revision: 927870 "
> ------------------------------------------------------------------------
> r927870 | jleroux | 2010-03-26 15:34:02 +0100 (ven. 26 mars 2010) | 2 lignes
>
> Fix a NPE I got on actualCurrencyAmount while working with R9.04.
> Since the files are identical I commit in trunk and will backport
> ------------------------------------------------------------------------
>
>
> Modified:
> ofbiz/branches/release09.04/ (props changed)
> ofbiz/branches/release09.04/.project
> ofbiz/branches/release09.04/applications/accounting/webapp/accounting/WEB-INF/actions/invoice/ListNotAppliedPayments.groovy
> ofbiz/branches/release09.04/startofbiz.bat
>
> Propchange: ofbiz/branches/release09.04/
> ------------------------------------------------------------------------------
> --- svn:mergeinfo (original)
> +++ svn:mergeinfo Fri Mar 26 14:39:45 2010
> @@ -1 +1 @@
> -/ofbiz/trunk:765933,766011,766015,766293,766307,766316,766325,766462,766522,766800,767060,767072,767093,767098-767099,767102,767123,767125,767127,767279,767287,767671,767688,767694,767822,767845,768358,768490,768550,768675,768686,768705,768811,768815,768960,769030,769500,770272,770308,770997,771073,771477,772401,772464-772465,773076,773557,773628,773659,773697,774014,774632,774661,774995,775292,775667,776227,776594,776620,776922,777004,777020,777768,777792,777893,777947,778078,778094,778107,778273,778278,778280,778364,778374,778402,778576,778594,778628,779020,779477,779496,779639,779834,779856,779866,779873,780111,780138,780180,780199,780203,780906,780945,781201,781534,781549,781669,781680,781694,782663,783257,783266,783833,783913,783917,785123,785764,785967,786778,787126,787435-787436,787442,787520,788965,788983,788987,789329,789337,789506,789548,796769,799185,800461,800846,801023,802346,804364,805307,806127,806377,806914,808786-808787,808792,809141,810370,810438,810465,8

10
> 807,810809,810814,810832,810836,810878,810917,811020,811280,811297,811419,811528,811708,811714,811716,811793,811838,811860,811865,811870,812159,812182,812192,812456,812540,813126,813131,813283,813672,813702,814168,814205,814251,814349,814531,814576,814681,814731,815158,815165,815350,815687,815977,816255,816863,818030,818049,818150,818494,818500,818716,818976,819275-819276,819282,819337,821263,821270,822659,823877-823878,823883,823888,823892,824511,825181-825182,826253,827730,828971,829085,829376,829412,829416,829527,830091,830112,830366,830528,830677,830874,830880,831238,831801,832361,832698,832776,832908,833324,833686,833703,834825,835161,835357,835585,836015,881194,881713,882072,882326,882918,883933,884023,884529,884546,884758,885122,885702,887916,888111,888559,888587,889666,890050,890107,890245,891378,891620,896649,899188,899833,900024,900026,900050,900217,900273,901628,907342-907343,910460,912587,915332,916252,916703,916925,917435,922042,923828
> +/ofbiz/trunk:765933,766011,766015,766293,766307,766316,766325,766462,766522,766800,767060,767072,767093,767098-767099,767102,767123,767125,767127,767279,767287,767671,767688,767694,767822,767845,768358,768490,768550,768675,768686,768705,768811,768815,768960,769030,769500,770272,770308,770997,771073,771477,772401,772464-772465,773076,773557,773628,773659,773697,774014,774632,774661,774995,775292,775667,776227,776594,776620,776922,777004,777020,777768,777792,777893,777947,778078,778094,778107,778273,778278,778280,778364,778374,778402,778576,778594,778628,779020,779477,779496,779639,779834,779856,779866,779873,780111,780138,780180,780199,780203,780906,780945,781201,781534,781549,781669,781680,781694,782663,783257,783266,783833,783913,783917,785123,785764,785967,786778,787126,787435-787436,787442,787520,788965,788983,788987,789329,789337,789506,789548,796769,799185,800461,800846,801023,802346,804364,805307,806127,806377,806914,808786-808787,808792,809141,810370,810438,810465,8
10

Oops?

> Modified: ofbiz/branches/release09.04/startofbiz.bat
> URL: http://svn.apache.org/viewvc/ofbiz/branches/release09.04/startofbiz.bat?rev=927876&r1=927875&r2=927876&view=diff
> ==============================================================================
> --- ofbiz/branches/release09.04/startofbiz.bat (original)
> +++ ofbiz/branches/release09.04/startofbiz.bat Fri Mar 26 14:39:45 2010
> @@ -51,5 +51,5 @@ rem "%JAVA_HOME%\bin\java" -Xms128M -Xmx
>
> rem ### Simple easy to read line
> echo on
> -"%JAVA_HOME%\bin\java" -Xms128M -Xmx512M -jar ofbiz.jar > runtime\logs\console.log
> +"%JAVA_HOME%\bin\java" -Xms128M -Xmx512M -jar ofbiz.jar

Oops?

Jacques Le Roux

Re: svn commit: r927876 - in /ofbiz/branches/release09.04: ./ .project applications/accounting/webapp/accounting/WEB-INF/actions/invoice/ListNotAppliedPayments.groovy startofbiz.bat

Administrator

Sorry,

Actually I did not notice that the backport did changes also in .project and .bat.
I wonder now if we should revert or not. Obviously these are improvements that can't introduce any bugs.
But if somebody feels that I should strictly follow the policy I will revert

Jacques

From: <[hidden email]>
To: <[hidden email]>
Sent: Friday, March 26, 2010 3:39 PM
Subject: svn commit: r927876 - in /ofbiz/branches/release09.04: ./ .project
applications/accounting/webapp/accounting/WEB-INF/actions/invoice/ListNotAppliedPayments.groovy startofbiz.bat

> 807,810809,810814,810832,810836,810878,810917,811020,811280,811297,811419,811528,811708,811714,811716,811793,811838,811860,811865,811870,812159,812182,812192,812456,812540,813126,813131,813283,813672,813702,814168,814205,814251,814349,814531,814576,814681,814731,815158,815165,815350,815687,815977,816255,816863,818030,818049,818150,818494,818500,818716,818976,819275-819276,819282,819337,821263,821270,822659,823877-823878,823883,823888,823892,824511,825181-825182,826253,827730,828971,829085,829376,829412,829416,829527,830091,830112,830366,830528,830677,830874,830880,831238,831801,832361,832698,832776,832908,833324,833686,833703,834825,835161,835357,835585,836015,881194,881713,882072,882326,882918,883933,884023,884529,884546,884758,885122,885702,887916,888111,888559,888587,889666,890050,890107,890245,891378,891620,896649,899188,899833,900024,900026,900050,900217,900273,901628,907342-907343,910460,912587,915332,916252,916703,916925,917435,922042,923828,927870
>
> Modified: ofbiz/branches/release09.04/.project
> URL: http://svn.apache.org/viewvc/ofbiz/branches/release09.04/.project?rev=927876&r1=927875&r2=927876&view=diff
> ==============================================================================
> --- ofbiz/branches/release09.04/.project (original)
> +++ ofbiz/branches/release09.04/.project Fri Mar 26 14:39:45 2010
> @@ -10,14 +10,9 @@
> <arguments>
> </arguments>
> </buildCommand>
> - <buildCommand>
> - <name>org.codehaus.groovy.eclipse.groovyBuilder</name>
> - <arguments>
> - </arguments>
> - </buildCommand>
> </buildSpec>
> <natures>
> + <nature>org.eclipse.jdt.groovy.core.groovyNature</nature>
> <nature>org.eclipse.jdt.core.javanature</nature>
> - <nature>org.codehaus.groovy.eclipse.groovyNature</nature>
> </natures>
> </projectDescription>
>
> Modified:
> ofbiz/branches/release09.04/applications/accounting/webapp/accounting/WEB-INF/actions/invoice/ListNotAppliedPayments.groovy
> URL:
> http://svn.apache.org/viewvc/ofbiz/branches/release09.04/applications/accounting/webapp/accounting/WEB-INF/actions/invoice/ListNotAppliedPayments.groovy?rev=927876&r1=927875&r2=927876&view=diff
> ==============================================================================
> --- ofbiz/branches/release09.04/applications/accounting/webapp/accounting/WEB-INF/actions/invoice/ListNotAppliedPayments.groovy
> (original)
> +++ ofbiz/branches/release09.04/applications/accounting/webapp/accounting/WEB-INF/actions/invoice/ListNotAppliedPayments.groovy
> Fri Mar 26 14:39:45 2010
> @@ -68,13 +68,19 @@ List getPayments(List payments, boolean
> if (actual) {
> paymentMap.amount = payment.actualCurrencyAmount;
> paymentMap.currencyUomId = payment.actualCurrencyUomId;
> - paymentToApply =
> payment.getBigDecimal("actualCurrencyAmount").setScale(decimals,rounding).subtract(paymentApplied);
> + paymentToApply = payment.getBigDecimal("actualCurrencyAmount");
> + if (paymentToApply) {
> + paymentToApply = paymentToApply.setScale(decimals,rounding).subtract(paymentApplied);
> + }
> } else {
> paymentMap.amount = payment.amount;
> paymentMap.currencyUomId = payment.currencyUomId;
> - paymentToApply = payment.getBigDecimal("amount").setScale(decimals,rounding).subtract(paymentApplied);
> + paymentToApply = payment.getBigDecimal("amount");
> + if (paymentToApply) {
> + paymentToApply = paymentToApply.setScale(decimals,rounding).subtract(paymentApplied);
> + }
> }
> - if (paymentToApply.signum() == 1) {
> + if (paymentToApply && paymentToApply.signum() == 1) {
> paymentMap.paymentId = payment.paymentId;
> paymentMap.effectiveDate = payment.effectiveDate;
> if (paymentToApply.compareTo(invoiceToApply) < 0 ) {
>
> Modified: ofbiz/branches/release09.04/startofbiz.bat
> URL: http://svn.apache.org/viewvc/ofbiz/branches/release09.04/startofbiz.bat?rev=927876&r1=927875&r2=927876&view=diff
> ==============================================================================
> --- ofbiz/branches/release09.04/startofbiz.bat (original)
> +++ ofbiz/branches/release09.04/startofbiz.bat Fri Mar 26 14:39:45 2010
> @@ -51,5 +51,5 @@ rem "%JAVA_HOME%\bin\java" -Xms128M -Xmx
>
> rem ### Simple easy to read line
> echo on
> -"%JAVA_HOME%\bin\java" -Xms128M -Xmx512M -jar ofbiz.jar > runtime\logs\console.log
> +"%JAVA_HOME%\bin\java" -Xms128M -Xmx512M -jar ofbiz.jar
>
>
>