Re: svn commit: r928451 - /ofbiz/trunk/framework/widget/
Locked
Re: svn commit: r928451 - /ofbiz/trunk/framework/widget/
 
|
[hidden email] wrote:
> Author: adrianc > Date: Sun Mar 28 16:48:22 2010 > New Revision: 928451 > > URL: http://svn.apache.org/viewvc?rev=928451&view=rev > Log: > Simplified label html renderer macro. > > Modified: > ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl > > Modified: ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl > URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=928451&r1=928450&r2=928451&view=diff > ============================================================================== > --- ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl (original) > +++ ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl Sun Mar 28 16:48:22 2010 > @@ -66,47 +66,10 @@ under the License. > <#if text?has_content> > <#-- Label is considered block level element in screen widget. There is not reason to render text outside of any html element. Use of style element has set pattern and we'll use style > to determine appropriate html element to use --> > - <#if style?has_content> > - <#if style=="h1"> > - <h1 > - <#elseif style=="h2"> > - <h2 > - <#elseif style=="h3"> > - <h3 > - <#elseif style=="h4"> > - <h4 > - <#elseif style=="h5"> > - <h5 > - <#elseif style=="h6"> > - <h6 > - <#else> > - <p class="${style}" > - </#if> > + <#if "h1~h2~h3~h4~h5~h6"?contains(style)> > + <${style}<#if id?has_content> id="${id}"</#if>>${text}</${style}> And if style="arch1"? |
Re: svn commit: r928451 - /ofbiz/trunk/framework/widget/
|
|
--- On Sun, 3/28/10, Adam Heath <[hidden email]> wrote:
> [hidden email] > wrote: > > Author: adrianc > > Date: Sun Mar 28 16:48:22 2010 > > New Revision: 928451 > > > > URL: http://svn.apache.org/viewvc?rev=928451&view=rev > > Log: > > Simplified label html renderer macro. > > > > Modified: > > > ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl > > > > Modified: > ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl > > URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=928451&r1=928450&r2=928451&view=diff > > > ============================================================================== > > --- > ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl > (original) > > +++ > ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl > Sun Mar 28 16:48:22 2010 > > @@ -66,47 +66,10 @@ under the License. > > <#if text?has_content> > > <#-- Label is considered block > level element in screen widget. There is not reason to > render text outside of any html element. Use of style > element has set pattern and we'll use style > > to determine > appropriate html element to use --> > > - <#if style?has_content> > > - <#if style=="h1"> > > - <h1 > > - <#elseif style=="h2"> > > - <h2 > > - <#elseif style=="h3"> > > - <h3 > > - <#elseif style=="h4"> > > - <h4 > > - <#elseif style=="h5"> > > - <h5 > > - <#elseif style=="h6"> > > - <h6 > > - <#else> > > - <p class="${style}" > > - </#if> > > + <#if > "h1~h2~h3~h4~h5~h6"?contains(style)> > > + <${style}<#if > id?has_content> > id="${id}"</#if>>${text}</${style}> > > And if style="arch1"? + <p<#if style?has_content> class="${style}"</#if><#if id?has_content> id="${id}"</#if>>${text}</p> |
Re: svn commit: r928451 - /ofbiz/trunk/framework/widget/
|
|
Adrian Crum wrote:
> --- On Sun, 3/28/10, Adam Heath <[hidden email]> wrote: >> [hidden email] >> wrote: >>> Author: adrianc >>> Date: Sun Mar 28 16:48:22 2010 >>> New Revision: 928451 >>> >>> URL: http://svn.apache.org/viewvc?rev=928451&view=rev >>> Log: >>> Simplified label html renderer macro. >>> >>> Modified: >>> >> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl >>> Modified: >> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=928451&r1=928450&r2=928451&view=diff >>> >> ============================================================================== >>> --- >> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl >> (original) >>> +++ >> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl >> Sun Mar 28 16:48:22 2010 >>> @@ -66,47 +66,10 @@ under the License. >>> <#if text?has_content> >>> <#-- Label is considered block >> level element in screen widget. There is not reason to >> render text outside of any html element. Use of style >> element has set pattern and we'll use style >>> to determine >> appropriate html element to use --> >>> - <#if style?has_content> >>> - <#if style=="h1"> >>> - <h1 >>> - <#elseif style=="h2"> >>> - <h2 >>> - <#elseif style=="h3"> >>> - <h3 >>> - <#elseif style=="h4"> >>> - <h4 >>> - <#elseif style=="h5"> >>> - <h5 >>> - <#elseif style=="h6"> >>> - <h6 >>> - <#else> >>> - <p class="${style}" >>> - </#if> >>> + <#if >> "h1~h2~h3~h4~h5~h6"?contains(style)> >>> + <${style}<#if >> id?has_content> >> id="${id}"</#if>>${text}</${style}> >> >> And if style="arch1"? > > + <p<#if style?has_content> class="${style}"</#if><#if id?has_content> id="${id}"</#if>>${text}</p> You aren't making any sense. Based on what I see this change doing, we'll end up with with: <arch1 as the tag name, when style="arch1". |
Re: svn commit: r928451 - /ofbiz/trunk/framework/widget/
|
|
--- On Sun, 3/28/10, Adam Heath <[hidden email]> wrote:
> Adrian Crum wrote: > > --- On Sun, 3/28/10, Adam Heath <[hidden email]> > wrote: > >> [hidden email] > >> wrote: > >>> Author: adrianc > >>> Date: Sun Mar 28 16:48:22 2010 > >>> New Revision: 928451 > >>> > >>> URL: http://svn.apache.org/viewvc?rev=928451&view=rev > >>> Log: > >>> Simplified label html renderer macro. > >>> > >>> Modified: > >>> > >> > ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl > >>> Modified: > >> > ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl > >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=928451&r1=928450&r2=928451&view=diff > >>> > >> > ============================================================================== > >>> --- > >> > ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl > >> (original) > >>> +++ > >> > ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl > >> Sun Mar 28 16:48:22 2010 > >>> @@ -66,47 +66,10 @@ under the License. > >>> <#if > text?has_content> > >>> <#-- Label > is considered block > >> level element in screen widget. There is not > reason to > >> render text outside of any html element. Use of > style > >> element has set pattern and we'll use style > >>> to > determine > >> appropriate html element to use --> > >>> - <#if style?has_content> > >>> - <#if style=="h1"> > >>> - <h1 > >>> - <#elseif > style=="h2"> > >>> - <h2 > >>> - <#elseif > style=="h3"> > >>> - <h3 > >>> - <#elseif > style=="h4"> > >>> - <h4 > >>> - <#elseif > style=="h5"> > >>> - <h5 > >>> - <#elseif > style=="h6"> > >>> - <h6 > >>> - <#else> > >>> - <p > class="${style}" > >>> - </#if> > >>> + <#if > >> "h1~h2~h3~h4~h5~h6"?contains(style)> > >>> + <${style}<#if > >> id?has_content> > >> > id="${id}"</#if>>${text}</${style}> > >> > >> And if style="arch1"? > > > > + <p<#if > style?has_content> class="${style}"</#if><#if > id?has_content> > id="${id}"</#if>>${text}</p> > > You aren't making any sense. > > Based on what I see this change doing, we'll end up with > with: > > <arch1 > > as the tag name, when style="arch1". Unless you try it out on your local copy, you will just have to trust me that it works. :-) |
Re: svn commit: r928451 - /ofbiz/trunk/framework/widget/
|
|
Adrian Crum wrote:
> --- On Sun, 3/28/10, Adam Heath <[hidden email]> wrote: >> Adrian Crum wrote: >>> --- On Sun, 3/28/10, Adam Heath <[hidden email]> >> wrote: >>>> [hidden email] >>>> wrote: >>>>> Author: adrianc >>>>> Date: Sun Mar 28 16:48:22 2010 >>>>> New Revision: 928451 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=928451&view=rev >>>>> Log: >>>>> Simplified label html renderer macro. >>>>> >>>>> Modified: >>>>> >>>> >> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl >>>>> Modified: >> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=928451&r1=928450&r2=928451&view=diff >>>>> >> ============================================================================== >>>>> --- >> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl >>>> (original) >>>>> +++ >> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl >>>> Sun Mar 28 16:48:22 2010 >>>>> @@ -66,47 +66,10 @@ under the License. >>>>> <#if >> text?has_content> >>>>> <#-- Label >> is considered block >>>> level element in screen widget. There is not >> reason to >>>> render text outside of any html element. Use of >> style >>>> element has set pattern and we'll use style >>>>> to >> determine >>>> appropriate html element to use --> >>>>> - <#if style?has_content> >>>>> - <#if style=="h1"> >>>>> - <h1 >>>>> - <#elseif >> style=="h2"> >>>>> - <h2 >>>>> - <#elseif >> style=="h3"> >>>>> - <h3 >>>>> - <#elseif >> style=="h4"> >>>>> - <h4 >>>>> - <#elseif >> style=="h5"> >>>>> - <h5 >>>>> - <#elseif >> style=="h6"> >>>>> - <h6 >>>>> - <#else> >>>>> - <p >> class="${style}" >>>>> - </#if> >>>>> + <#if >>>> "h1~h2~h3~h4~h5~h6"?contains(style)> >>>>> + <${style}<#if >>>> id?has_content> >>>> >> id="${id}"</#if>>${text}</${style}> >>>> And if style="arch1"? >>> + <p<#if >> style?has_content> class="${style}"</#if><#if >> id?has_content> >> id="${id}"</#if>>${text}</p> >> >> You aren't making any sense. >> >> Based on what I see this change doing, we'll end up with >> with: >> >> <arch1 >> >> as the tag name, when style="arch1". > > Unless you try it out on your local copy, you will just have to trust me that it works. :-) That's not a useful response. "Just trust me" is not helpful. If you know why something will work, and someone obvious doesn't(me), then just go ahead and explain it. Doing a bunch of hand-waving just gives the hand-waver a feeling of superiority, and makes the receiver feel inferior. However, upon further reflection, my initial example of wrongness was not correct. Consider when style="h1~h2". The original code would do <p class="h1~h2">, which could be matched in css as p."h1~h2" { }. Now, with this change, the tag will be <h1~h2>, which is very wrong. The question to ask yourself, is: are the widget systems, and their internal helper files, supposed to be general purpose, or are they just to be used by ofbiz? If the latter, then we can do whatever we want with not checking various parameters, as we can just fix all bad uses. However, if the former is the correct answer, then we have to handle, and allow, all possible cases. This change keeps that from occuring. |
Re: svn commit: r928451 - /ofbiz/trunk/framework/widget/
|
|
--- On Sun, 3/28/10, Adam Heath <[hidden email]> wrote:
> Adrian Crum wrote: > > --- On Sun, 3/28/10, Adam Heath <[hidden email]> > wrote: > >> Adrian Crum wrote: > >>> --- On Sun, 3/28/10, Adam Heath <[hidden email]> > >> wrote: > >>>> [hidden email] > >>>> wrote: > >>>>> Author: adrianc > >>>>> Date: Sun Mar 28 16:48:22 2010 > >>>>> New Revision: 928451 > >>>>> > >>>>> URL: http://svn.apache.org/viewvc?rev=928451&view=rev > >>>>> Log: > >>>>> Simplified label html renderer macro. > >>>>> > >>>>> Modified: > >>>>> > >>>> > >> > ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl > >>>>> Modified: > >> > ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl > >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=928451&r1=928450&r2=928451&view=diff > >>>>> > >> > ============================================================================== > >>>>> --- > >> > ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl > >>>> (original) > >>>>> +++ > >> > ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl > >>>> Sun Mar 28 16:48:22 2010 > >>>>> @@ -66,47 +66,10 @@ under the > License. > >>>>> <#if > >> text?has_content> > >>>>> <#-- > Label > >> is considered block > >>>> level element in screen widget. There is > not > >> reason to > >>>> render text outside of any html element. > Use of > >> style > >>>> element has set pattern and we'll use > style > >>>>> > to > >> determine > >>>> appropriate html element to use --> > >>>>> - <#if > style?has_content> > >>>>> - <#if > style=="h1"> > >>>>> - <h1 > >>>>> - <#elseif > >> style=="h2"> > >>>>> - <h2 > >>>>> - <#elseif > >> style=="h3"> > >>>>> - <h3 > >>>>> - <#elseif > >> style=="h4"> > >>>>> - <h4 > >>>>> - <#elseif > >> style=="h5"> > >>>>> - <h5 > >>>>> - <#elseif > >> style=="h6"> > >>>>> - <h6 > >>>>> - <#else> > >>>>> - <p > >> class="${style}" > >>>>> - </#if> > >>>>> + <#if > >>>> "h1~h2~h3~h4~h5~h6"?contains(style)> > >>>>> + > <${style}<#if > >>>> id?has_content> > >>>> > >> > id="${id}"</#if>>${text}</${style}> > >>>> And if style="arch1"? > >>> + <p<#if > >> style?has_content> > class="${style}"</#if><#if > >> id?has_content> > >> id="${id}"</#if>>${text}</p> > >> > >> You aren't making any sense. > >> > >> Based on what I see this change doing, we'll end > up with > >> with: > >> > >> <arch1 > >> > >> as the tag name, when style="arch1". > > > > Unless you try it out on your local copy, you will > just have to trust me that it works. :-) > > That's not a useful response. "Just trust me" is not > helpful. If you > know why something will work, and someone obvious > doesn't(me), then > just go ahead and explain it. Doing a bunch of > hand-waving just gives > the hand-waver a feeling of superiority, and makes the > receiver feel > inferior. > > However, upon further reflection, my initial example of > wrongness was > not correct. Consider when style="h1~h2". The > original code would do > <p class="h1~h2">, which could be matched in css as > p."h1~h2" { }. > > Now, with this change, the tag will be <h1~h2>, which > is very wrong. > > The question to ask yourself, is: are the widget systems, > and their > internal helper files, supposed to be general purpose, or > are they > just to be used by ofbiz? If the latter, then we can > do whatever we > want with not checking various parameters, as we can just > fix all bad > uses. > > However, if the former is the correct answer, then we have > to handle, > and allow, all possible cases. This change keeps that > from occuring. Checking for the h* styles is OFBiz-specific behavior. You are correct that odd class names will trick the code - but the chances that someone would create a "h1~h2" class are pretty small. In any event, I will revert it. |
Re: svn commit: r928451 - /ofbiz/trunk/framework/widget/
|
|
Adrian Crum wrote:
>> However, upon further reflection, my initial example of >> wrongness was >> not correct. Consider when style="h1~h2". The >> original code would do >> <p class="h1~h2">, which could be matched in css as >> p."h1~h2" { }. >> >> Now, with this change, the tag will be <h1~h2>, which >> is very wrong. >> >> The question to ask yourself, is: are the widget systems, >> and their >> internal helper files, supposed to be general purpose, or >> are they >> just to be used by ofbiz? If the latter, then we can >> do whatever we >> want with not checking various parameters, as we can just >> fix all bad >> uses. >> >> However, if the former is the correct answer, then we have >> to handle, >> and allow, all possible cases. This change keeps that >> from occuring. > > Checking for the h* styles is OFBiz-specific behavior. You are correct that odd class names will trick the code - but the chances that someone would create a "h1~h2" class are pretty small. In any event, I will revert it. Checking for the h* styles is fine. If it is documented to that, then end-users can expect that to occur. But if the code is also documented as allowing any other specified style to be encoded as a <p> with a class, then it has to allow any other value to be used. Including my example of "h1~h2". Now, if you want, you could use ?matches. Or, use a bunch of || in the <#if>. |
Re: svn commit: r928451 - /ofbiz/trunk/framework/widget/
|
|
In reply to this post by Adam Heath-2
--- On Sun, 3/28/10, Adam Heath <[hidden email]> wrote:
> That's not a useful response. "Just trust me" is not > helpful. If you > know why something will work, and someone obvious > doesn't(me), then > just go ahead and explain it. Doing a bunch of > hand-waving just gives > the hand-waver a feeling of superiority, and makes the > receiver feel > inferior. One of the things I try to do whenever the opportunity presents itself, is to meet other OFBiz developers in person. I believe doing so helps us understand each other better. One of the drawbacks with mailing list collaboration is the inability to know the other collaborators personally. That leads to messages having feelings and motives assigned to them that don't belong there. This is one of those cases. I don't feel superior to any other developer. In my mind we are all peers. In this particular reply, I was viewing *you* as being superior - you are a programming guru in my opinion. When you seemed puzzled by (what I thought was) a very simple code construct, I *assumed* you just hadn't looked at it carefully enough and I was sure it would make sense if you just looked at it again, or tried it out on your local copy. I would have explained it in more detail to anyone else. I apologize if I made you feel slighted. That wasn't my intention. It is never my intention to offend anyone or to appear to take a superior role. If I come across that way, then I am not aware of it and I truly appreciate it when someone points it out to me. -Adrian |
Re: svn commit: r928451 - /ofbiz/trunk/framework/widget/
|
|
Adrian Crum wrote:
> --- On Sun, 3/28/10, Adam Heath <[hidden email]> wrote: >> That's not a useful response. "Just trust me" is not >> helpful. If you >> know why something will work, and someone obvious >> doesn't(me), then >> just go ahead and explain it. Doing a bunch of >> hand-waving just gives >> the hand-waver a feeling of superiority, and makes the >> receiver feel >> inferior. > > One of the things I try to do whenever the opportunity presents > itself, is to meet other OFBiz developers in person. I believe > doing so helps us understand each other better. > > One of the drawbacks with mailing list collaboration is the > inability to know the other collaborators personally. That leads > to messages having feelings and motives assigned to them that > don't belong there. This is one of those cases. You're on my short list......... of people I'd like to meet in person. > I don't feel superior to any other developer. In my mind we are > all peers. In this particular reply, I was viewing *you* as being > superior - you are a programming guru in my opinion. When you > seemed puzzled by (what I thought was) a very simple code > construct, I *assumed* you just hadn't looked at it carefully > enough and I was sure it would make sense if you just looked at > it again, or tried it out on your local copy. I would have > explained it in more detail to anyone else. I wasn't puzzled by it. From a very quick glance, I knew that it would have problems with real-world parameters. I was just trying to get you to explain to me what you were trying to do. It's been my experience over the years, that when you try to explain to someone else, that you discover that what you think isn't really the case. Both Ean and I have gotten stuck on problems, as no sooner do we start the pair programming thing, and try to explain to the other what is happening, that we go "oh, duh, there it is." and we move on. I was just trying to get you to see that, by explaining to me what the code did. It's true that my initial example was wrong; if I had used a better one, you may have seen the issue earlier. > I apologize if I made you feel slighted. That wasn't my > intention. It is never my intention to offend anyone or to appear > to take a superior role. If I come across that way, then I am not > aware of it and I truly appreciate it when someone points it out > to me. Oh, I wasn't slighted at all. What you saw there was my special style, of trying to word things to not target any one person, or any one situation. Trying to make my explanations be helpful to anyone who happens to read it now, or at some future point. |
Re: svn commit: r928451 - /ofbiz/trunk/framework/widget/
|
|
--- On Sun, 3/28/10, Adam Heath <[hidden email]> wrote:
> Adrian Crum wrote: > > --- On Sun, 3/28/10, Adam Heath <[hidden email]> > wrote: > >> That's not a useful response. "Just trust > me" is not > >> helpful. If you > >> know why something will work, and someone obvious > >> doesn't(me), then > >> just go ahead and explain it. Doing a bunch > of > >> hand-waving just gives > >> the hand-waver a feeling of superiority, and makes > the > >> receiver feel > >> inferior. > > > > One of the things I try to do whenever the opportunity > presents > > itself, is to meet other OFBiz developers in person. I > believe > > doing so helps us understand each other better. > > > > One of the drawbacks with mailing list collaboration > is the > > inability to know the other collaborators personally. > That leads > > to messages having feelings and motives assigned to > them that > > don't belong there. This is one of those cases. > > You're on my short list......... > > > > > > of people I'd like to meet in person. > > > I don't feel superior to any other developer. In my > mind we are > > all peers. In this particular reply, I was viewing > *you* as being > > superior - you are a programming guru in my opinion. > When you > > seemed puzzled by (what I thought was) a very simple > code > > construct, I *assumed* you just hadn't looked at it > carefully > > enough and I was sure it would make sense if you just > looked at > > it again, or tried it out on your local copy. I would > have > > explained it in more detail to anyone else. > > I wasn't puzzled by it. From a very quick glance, I > knew that it > would have problems with real-world parameters. I was > just trying to > get you to explain to me what you were trying to do. Understood. You pointed out a flaw in the logic, I agreed with you and reverted it. Then I took a little break and asked myself how I can prevent that from happening again. It boils down to me having worked as a one man programming team for so long. It was common for me to commit code like that because I knew how it worked and I understood what not to do with it. Of course, that approach doesn't fly in this project. I try not to allow myself to commit code like that, but it still happens anyway. Maybe after enough embarrassing reverts I'll finally learn my lesson. :-) -Adrian |
Re: svn commit: r928451 - /ofbiz/trunk/framework/widget/
|
|
Adrian Crum wrote:
> --- On Sun, 3/28/10, Adam Heath <[hidden email]> wrote: >> Adrian Crum wrote: >>> --- On Sun, 3/28/10, Adam Heath <[hidden email]> >> wrote: >>>> That's not a useful response. "Just trust >> me" is not >>>> helpful. If you >>>> know why something will work, and someone obvious >>>> doesn't(me), then >>>> just go ahead and explain it. Doing a bunch >> of >>>> hand-waving just gives >>>> the hand-waver a feeling of superiority, and makes >> the >>>> receiver feel >>>> inferior. >>> One of the things I try to do whenever the opportunity >> presents >>> itself, is to meet other OFBiz developers in person. I >> believe >>> doing so helps us understand each other better. >>> >>> One of the drawbacks with mailing list collaboration >> is the >>> inability to know the other collaborators personally. >> That leads >>> to messages having feelings and motives assigned to >> them that >>> don't belong there. This is one of those cases. >> You're on my short list......... >> >> >> >> >> >> of people I'd like to meet in person. >> >>> I don't feel superior to any other developer. In my >> mind we are >>> all peers. In this particular reply, I was viewing >> *you* as being >>> superior - you are a programming guru in my opinion. >> When you >>> seemed puzzled by (what I thought was) a very simple >> code >>> construct, I *assumed* you just hadn't looked at it >> carefully >>> enough and I was sure it would make sense if you just >> looked at >>> it again, or tried it out on your local copy. I would >> have >>> explained it in more detail to anyone else. >> I wasn't puzzled by it. From a very quick glance, I >> knew that it >> would have problems with real-world parameters. I was >> just trying to >> get you to explain to me what you were trying to do. > > Understood. You pointed out a flaw in the logic, I agreed > with you and reverted it. Then I took a little break and > asked myself how I can prevent that from happening again. > It boils down to me having worked as a one man programming > team for so long. It was common for me to commit code like > that because I knew how it worked and I understood what > not to do with it. Of course, that approach doesn't fly in > this project. I try not to allow myself to commit code > like that, but it still happens anyway. Maybe after enough > embarrassing reverts I'll finally learn my lesson. :-) I haven't work in big, in-person teams. Most number of physical people I've programmed with is 4 or 5. But I've worked with Ean for 10 years, and that I've had to put up with countless issues over the years(wink wink). I have 11 years working with open source communities, starting with Debian. As you may or may not know, Debian is famous for having very(ahem) heated discussions(sic) on their mailing lists. The things I've gotten out of that, are the ability to not let most words phase me, and the ability to get people to 'shut the hell up and stop fighting and think, you morons!' Note, that the last is the way I would sometimes steer a heated flamewar back into the normal realm. I'd lurk, then when some thread that I had interest in was degrading, I would do the equivalent of a slap in the face to all those invovled, showing them both sides of where they went wrong, and often, it would lead to a good outcome. I've tended to do the same here. There has never been anything personal in it. Even in this, it's always been about the code, first and foremost. One other thing that we should all keep in mind. Why did we all start working with ofbiz? Was it because some suit, some PHB, made an executive decision, and said that "YOU MUST USE OFBIZ!"? Or, was it because those in charge looked at all the choices out there, and came to the conclusion that having all this wonderful code available as open source made it better, because it was open? I would dare say that it is the latter. As such, it's the code that matters. Above all else. Anything I have ever said has never been meant to be taken as a personal attack, or directed at any one person. It's meant to make the code better for me, you, everyone else, and those that don't even know that they need to be using ofbiz. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |