Re: svn commit: r929593 - /ofbiz/trunk/applications/product/entitydef/entitymodel.xml

[Scott Gray-2]

On 31/03/2010, at 9:45 AM, [hidden email] wrote:

> Author: jleroux
> Date: Wed Mar 31 15:45:07 2010
> New Revision: 929593
>
> URL: http://svn.apache.org/viewvc?rev=929593&view=rev
> Log:
> Completes r929503: adds a relation between facility and uom for facilitySizeUomId
>
> Modified:
>    ofbiz/trunk/applications/product/entitydef/entitymodel.xml
>
> Modified: ofbiz/trunk/applications/product/entitydef/entitymodel.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/entitydef/entitymodel.xml?rev=929593&r1=929592&r2=929593&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/product/entitydef/entitymodel.xml (original)
> +++ ofbiz/trunk/applications/product/entitydef/entitymodel.xml Wed Mar 31 15:45:07 2010
> @@ -1034,6 +1034,9 @@ under the License.
>         <relation type="one" fk-name="FACILITY_GEOPT" rel-entity-name="GeoPoint">
>           <key-map field-name="geoPointId"/>
>         </relation>
> +      <relation type="one" fk-name="FACILITY_SUOM" title="Size" rel-entity-name="Uom">
> +        <key-map field-name="facilitySizeUomId" rel-field-name="uomId"/>
> +      </relation>      

I think ideally the title would be FacilitySize wouldn't it?

facility.getRelatedOne("FacilitySizeUom");
seems more intuitive than
facility.getRelatedOne("SizeUom");

[Jacques Le Roux]

Right! I will change that...

Jacques

From: "Scott Gray" <[hidden email]>

> Author: jleroux
> Date: Wed Mar 31 15:45:07 2010
> New Revision: 929593
>
> URL: http://svn.apache.org/viewvc?rev=929593&view=rev
> Log:
> Completes r929503: adds a relation between facility and uom for facilitySizeUomId
>
> Modified:
>    ofbiz/trunk/applications/product/entitydef/entitymodel.xml
>
> Modified: ofbiz/trunk/applications/product/entitydef/entitymodel.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/entitydef/entitymodel.xml?rev=929593&r1=929592&r2=929593&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/product/entitydef/entitymodel.xml (original)
> +++ ofbiz/trunk/applications/product/entitydef/entitymodel.xml Wed Mar 31 15:45:07 2010
> @@ -1034,6 +1034,9 @@ under the License.
>         <relation type="one" fk-name="FACILITY_GEOPT" rel-entity-name="GeoPoint">
>           <key-map field-name="geoPointId"/>
>         </relation>
> +      <relation type="one" fk-name="FACILITY_SUOM" title="Size" rel-entity-name="Uom">
> +        <key-map field-name="facilitySizeUomId" rel-field-name="uomId"/>
> +      </relation>

I think ideally the title would be FacilitySize wouldn't it?

facility.getRelatedOne("FacilitySizeUom");
seems more intuitive than
facility.getRelatedOne("SizeUom");