Re: svn commit: r931024 - /ofbiz/trunk/applications/order/testdef/OrderTest.xml

[Scott Gray-2]

Reviewed, I give it a 10/10

Regards
Scott

On 5/04/2010, at 11:28 PM, [hidden email] wrote:

> Author: doogie
> Date: Tue Apr  6 05:28:12 2010
> New Revision: 931024
>
> URL: http://svn.apache.org/viewvc?rev=931024&view=rev
> Log:
> Remove testdef to a class that doesn't exist.
>
> Modified:
>    ofbiz/trunk/applications/order/testdef/OrderTest.xml
>
> Modified: ofbiz/trunk/applications/order/testdef/OrderTest.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/testdef/OrderTest.xml?rev=931024&r1=931023&r2=931024&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/testdef/OrderTest.xml (original)
> +++ ofbiz/trunk/applications/order/testdef/OrderTest.xml Tue Apr  6 05:28:12 2010
> @@ -21,13 +21,10 @@ under the License.
> <test-suite suite-name="ordertests"
>         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>         xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/test-suite.xsd">
> -    <test-case case-name="custRequest-test">
> -        <junit-test-suite class-name="org.ofbiz.order.test.CustRequestTest"/>
> -    </test-case>
>     <test-case case-name="purchaseOrder-test">
>         <junit-test-suite class-name="org.ofbiz.order.test.PurchaseOrderTest"/>
>     </test-case>
>     <test-case case-name="salesOrder-test">
>         <junit-test-suite class-name="org.ofbiz.order.test.SalesOrderTest"/>
>     </test-case>
> -</test-suite>
> \ No newline at end of file
> +</test-suite>
>
>

[Adrian Crum-2]

--- On Mon, 4/5/10, [hidden email] <[hidden email]> wrote:

> Author: doogie
> Date: Tue Apr  6 05:28:12 2010
> New Revision: 931024
>
> URL: http://svn.apache.org/viewvc?rev=931024&view=rev
> Log:
> Remove testdef to a class that doesn't exist.
>
> Modified:
>    
> ofbiz/trunk/applications/order/testdef/OrderTest.xml
>
> Modified:
> ofbiz/trunk/applications/order/testdef/OrderTest.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/testdef/OrderTest.xml?rev=931024&r1=931023&r2=931024&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/testdef/OrderTest.xml
> (original)
> +++ ofbiz/trunk/applications/order/testdef/OrderTest.xml
> Tue Apr  6 05:28:12 2010
> @@ -21,13 +21,10 @@ under the License.
>  <test-suite suite-name="ordertests"
>          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>      
>    xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/test-suite.xsd">
> -    <test-case
> case-name="custRequest-test">
> -        <junit-test-suite
> class-name="org.ofbiz.order.test.CustRequestTest"/>
> -    </test-case>
>      <test-case
> case-name="purchaseOrder-test">
>          <junit-test-suite
> class-name="org.ofbiz.order.test.PurchaseOrderTest"/>
>      </test-case>
>      <test-case
> case-name="salesOrder-test">
>          <junit-test-suite
> class-name="org.ofbiz.order.test.SalesOrderTest"/>
>      </test-case>
> -</test-suite>
> \ No newline at end of file
> +</test-suite>

That should have been two separate commits - one to fix the error, and another one to add the newline at end of file (formatting change).

[Ashish Vijaywargiya]

:-).

--
Ashish

On Tue, Apr 6, 2010 at 11:10 AM, Adrian Crum <[hidden email]> wrote:
>
> That should have been two separate commits - one to fix the error, and another one to add the newline at end of file (formatting change).
>

[Scott Gray-2]

On 5/04/2010, at 11:40 PM, Adrian Crum wrote:

> --- On Mon, 4/5/10, [hidden email] <[hidden email]> wrote:
>> Author: doogie
>> Date: Tue Apr  6 05:28:12 2010
>> New Revision: 931024
>>
>> URL: http://svn.apache.org/viewvc?rev=931024&view=rev
>> Log:
>> Remove testdef to a class that doesn't exist.
>>
>> Modified:
>>    
>> ofbiz/trunk/applications/order/testdef/OrderTest.xml
>>
>> Modified:
>> ofbiz/trunk/applications/order/testdef/OrderTest.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/testdef/OrderTest.xml?rev=931024&r1=931023&r2=931024&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/order/testdef/OrderTest.xml
>> (original)
>> +++ ofbiz/trunk/applications/order/testdef/OrderTest.xml
>> Tue Apr  6 05:28:12 2010
>> @@ -21,13 +21,10 @@ under the License.
>> <test-suite suite-name="ordertests"
>>          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>>      
>>    xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/test-suite.xsd">
>> -    <test-case
>> case-name="custRequest-test">
>> -        <junit-test-suite
>> class-name="org.ofbiz.order.test.CustRequestTest"/>
>> -    </test-case>
>>      <test-case
>> case-name="purchaseOrder-test">
>>          <junit-test-suite
>> class-name="org.ofbiz.order.test.PurchaseOrderTest"/>
>>      </test-case>
>>      <test-case
>> case-name="salesOrder-test">
>>          <junit-test-suite
>> class-name="org.ofbiz.order.test.SalesOrderTest"/>
>>      </test-case>
>> -</test-suite>
>> \ No newline at end of file
>> +</test-suite>
>
> That should have been two separate commits - one to fix the error, and another one to add the newline at end of file (formatting change).

Damn, I totally missed that.  Adam, I only have one thing to say:
no, nO, NO, NO!

[Bob Morley]

On 2010-04-06, at 1:41 AM, Adrian Crum <[hidden email]> wrote:

> --- On Mon, 4/5/10, [hidden email] <[hidden email]> wrote:
>> Author: doogie
>> Date: Tue Apr  6 05:28:12 2010
>> New Revision: 931024
>>
>> URL: http://svn.apache.org/viewvc?rev=931024&view=rev
>> Log:
>> Remove testdef to a class that doesn't exist.
>>
>> Modified:
>>
>> ofbiz/trunk/applications/order/testdef/OrderTest.xml
>>
>> Modified:
>> ofbiz/trunk/applications/order/testdef/OrderTest.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/testdef/OrderTest.xml?rev=931024&r1=931023&r2=931024&view=diff
>> ===
>> ===
>> ===
>> =====================================================================
>> --- ofbiz/trunk/applications/order/testdef/OrderTest.xml
>> (original)
>> +++ ofbiz/trunk/applications/order/testdef/OrderTest.xml
>> Tue Apr  6 05:28:12 2010
>> @@ -21,13 +21,10 @@ under the License.
>> <test-suite suite-name="ordertests"
>>          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>>
>>    xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/test-suite.xsd 
>> ">
>> -    <test-case
>> case-name="custRequest-test">
>> -        <junit-test-suite
>> class-name="org.ofbiz.order.test.CustRequestTest"/>
>> -    </test-case>
>>      <test-case
>> case-name="purchaseOrder-test">
>>          <junit-test-suite
>> class-name="org.ofbiz.order.test.PurchaseOrderTest"/>
>>      </test-case>
>>      <test-case
>> case-name="salesOrder-test">
>>          <junit-test-suite
>> class-name="org.ofbiz.order.test.SalesOrderTest"/>
>>      </test-case>
>> -</test-suite>
>> \ No newline at end of file
>> +</test-suite>
>
> That should have been two separate commits - one to fix the error,  
> and another one to add the newline at end of file (formatting change).
>

no no no create a stub test class with that name and mark it  
depreciated.

[Scott Gray-2]

On 5/04/2010, at 11:55 PM, Robert Morley wrote:

> On 2010-04-06, at 1:41 AM, Adrian Crum <[hidden email]> wrote:
>
>> --- On Mon, 4/5/10, [hidden email] <[hidden email]> wrote:
>>> Author: doogie
>>> Date: Tue Apr  6 05:28:12 2010
>>> New Revision: 931024
>>>
>>> URL: http://svn.apache.org/viewvc?rev=931024&view=rev
>>> Log:
>>> Remove testdef to a class that doesn't exist.
>>>
>>> Modified:
>>>
>>> ofbiz/trunk/applications/order/testdef/OrderTest.xml
>>>
>>> Modified:
>>> ofbiz/trunk/applications/order/testdef/OrderTest.xml
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/testdef/OrderTest.xml?rev=931024&r1=931023&r2=931024&view=diff
>>> ===
>>> ===
>>> ===
>>> =====================================================================
>>> --- ofbiz/trunk/applications/order/testdef/OrderTest.xml
>>> (original)
>>> +++ ofbiz/trunk/applications/order/testdef/OrderTest.xml
>>> Tue Apr  6 05:28:12 2010
>>> @@ -21,13 +21,10 @@ under the License.
>>> <test-suite suite-name="ordertests"
>>>         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>>>
>>>   xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/test-suite.xsd">
>>> -    <test-case
>>> case-name="custRequest-test">
>>> -        <junit-test-suite
>>> class-name="org.ofbiz.order.test.CustRequestTest"/>
>>> -    </test-case>
>>>     <test-case
>>> case-name="purchaseOrder-test">
>>>         <junit-test-suite
>>> class-name="org.ofbiz.order.test.PurchaseOrderTest"/>
>>>     </test-case>
>>>     <test-case
>>> case-name="salesOrder-test">
>>>         <junit-test-suite
>>> class-name="org.ofbiz.order.test.SalesOrderTest"/>
>>>     </test-case>
>>> -</test-suite>
>>> \ No newline at end of file
>>> +</test-suite>
>>
>> That should have been two separate commits - one to fix the error, and another one to add the newline at end of file (formatting change).
>>
>
> mark it depreciated.

because it has decreased in value :-)