Re: svn commit: r942700 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java

[Scott Gray-2]

Just an FYI (I don't care if you change it or not), if that shipEstimate is coming in from user input then we're likely to a get bug report at some point because new BigDecimal(String) won't handle some localized currency input (1,00).

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 10/05/2010, at 9:58 PM, [hidden email] wrote:

> Author: hansbak
> Date: Mon May 10 09:58:12 2010
> New Revision: 942700
>
> URL: http://svn.apache.org/viewvc?rev=942700&view=rev
> Log:
> fix for revision 940803 to add a shipping estimate. If a shipping extimate was not provided however created an exception
>
> Modified:
>    ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
>
> Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java?rev=942700&r1=942699&r2=942700&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java (original)
> +++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java Mon May 10 09:58:12 2010
> @@ -808,7 +808,7 @@ public class CheckOutEvents {
>                     shipAfterDate = request.getParameter("sgi" + shipGroupIndex + "_shipAfterDate");
>                     internalOrderNotes = request.getParameter("internal_order_notes");
>                     shippingNotes = request.getParameter("shippingNotes");
> -                    if (request.getParameter(shipGroupIndex + "_ship_estimate") != null) {
> +                    if (UtilValidate.isNotEmpty(request.getParameter(shipGroupIndex + "_ship_estimate"))) {
>                         shipEstimate = new BigDecimal(request.getParameter(shipGroupIndex + "_ship_estimate"));
>                     }
>
>
>