Re: svn commit: r947993 - in /ofbiz/trunk: .classpath LICENSE framework/base/lib/clhm-20100316.jar framework/base/lib/clhm-release-1.0-lru.jar

[Christian Geisert]

Seems like this broke the build.... (errors in UtilCache.java after a
clean build)
I have no more time right now, will fix it later this afternoon if no
one else beats me

Christian

[hidden email] schrieb:

> Author: jleroux
> Date: Tue May 25 10:08:04 2010
> New Revision: 947993
>
> URL: http://svn.apache.org/viewvc?rev=947993&view=rev
> Log:
> As suggested by Ben Manes at "Upgrade ConcurrentLinkedHashMap" (https://issues.apache.org/jira/browse/OFBIZ-3779) - OFBIZ-3779
>
> The UtilCache class should use v1.0 of the CLHM library. While the previous version is fully functional, I am no longer supporting it. The new design should be faster and more reliable due to not needing to use a pseudo LRU algorithm for performance (which has degradation scenarios). A true LRU is now supported with no lock contention issues. Please consider upgrading when convenient.
>
> http://code.google.com/p/concurrentlinkedhashmap/
>
> JavaDoc:
> http://concurrentlinkedhashmap.googlecode.com/svn/wiki/release-1.0-LRU/index.html
>
> Added:
>     ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar   (with props)
> Removed:
>     ofbiz/trunk/framework/base/lib/clhm-20100316.jar
> Modified:
>     ofbiz/trunk/.classpath
>     ofbiz/trunk/LICENSE
>
> Modified: ofbiz/trunk/.classpath
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/.classpath?rev=947993&r1=947992&r2=947993&view=diff
> ==============================================================================
> --- ofbiz/trunk/.classpath (original)
> +++ ofbiz/trunk/.classpath Tue May 25 10:08:04 2010
> @@ -15,7 +15,7 @@
>      <classpathentry kind="lib" path="framework/base/lib/avalon-util-exception-1.0.0.jar"/>
>      <classpathentry kind="lib" path="framework/base/lib/barcode4j-fop-ext-complete-2.0.jar"/>
>      <classpathentry kind="lib" path="framework/base/lib/batik-all-1.7.jar"/>
> -    <classpathentry kind="lib" path="framework/base/lib/clhm-20100316.jar"/>
> +    <classpathentry kind="lib" path="framework/base/lib/clhm-release-1.0-lru.jar"/>
>      <classpathentry kind="lib" path="framework/base/lib/hamcrest-all-1.2.jar"/>
>      <classpathentry kind="lib" path="framework/base/lib/fop-0.95.jar"/>
>      <classpathentry kind="lib" path="framework/base/lib/freemarker-2.3.15.jar"/>
>
> Modified: ofbiz/trunk/LICENSE
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/LICENSE?rev=947993&r1=947992&r2=947993&view=diff
> ==============================================================================
> --- ofbiz/trunk/LICENSE (original)
> +++ ofbiz/trunk/LICENSE Tue May 25 10:08:04 2010
> @@ -21,7 +21,7 @@ ofbiz/trunk/framework/base/lib/avalon-fr
>  ofbiz/trunk/framework/base/lib/avalon-util-exception-1.0.0.jar
>  ofbiz/trunk/framework/base/lib/batik-all-1.7.jar
>  ofbiz/trunk/framework/base/lib/barcode4j-fop-ext-complete-2.0.jar
> -ofbiz/trunk/framework/base/lib/clhm-20100316.jar
> +ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar
>  ofbiz/trunk/framework/base/lib/jakarta-regexp-1.5.jar
>  ofbiz/trunk/framework/base/lib/jpim-0.1.jar
>  ofbiz/trunk/framework/base/lib/juel-2.2.1.jar
>
> Added: ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar?rev=947993&view=auto
> ==============================================================================
> Binary file - no diff available.
>
> Propchange: ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar
> ------------------------------------------------------------------------------
>     svn:mime-type = application/octet-stream
>
>
>

[Jacques Le Roux]

Thanks and sorry Christian,

I'm taking care of it right now...

Jacques

From: "Christian Geisert" <[hidden email]>

> Seems like this broke the build.... (errors in UtilCache.java after a clean build)
> I have no more time right now, will fix it later this afternoon if no one else beats me
>
> Christian
>
> [hidden email] schrieb:
>> Author: jleroux
>> Date: Tue May 25 10:08:04 2010
>> New Revision: 947993
>>
>> URL: http://svn.apache.org/viewvc?rev=947993&view=rev
>> Log:
>> As suggested by Ben Manes at "Upgrade ConcurrentLinkedHashMap" (https://issues.apache.org/jira/browse/OFBIZ-3779) - OFBIZ-3779
>>
>> The UtilCache class should use v1.0 of the CLHM library. While the previous version is fully functional, I am no longer
>> supporting it. The new design should be faster and more reliable due to not needing to use a pseudo LRU algorithm for performance
>> (which has degradation scenarios). A true LRU is now supported with no lock contention issues. Please consider upgrading when
>> convenient.
>>
>> http://code.google.com/p/concurrentlinkedhashmap/
>>
>> JavaDoc:
>> http://concurrentlinkedhashmap.googlecode.com/svn/wiki/release-1.0-LRU/index.html
>>
>> Added:
>>     ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar   (with props)
>> Removed:
>>     ofbiz/trunk/framework/base/lib/clhm-20100316.jar
>> Modified:
>>     ofbiz/trunk/.classpath
>>     ofbiz/trunk/LICENSE
>>
>> Modified: ofbiz/trunk/.classpath
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/.classpath?rev=947993&r1=947992&r2=947993&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/.classpath (original)
>> +++ ofbiz/trunk/.classpath Tue May 25 10:08:04 2010
>> @@ -15,7 +15,7 @@
>>      <classpathentry kind="lib" path="framework/base/lib/avalon-util-exception-1.0.0.jar"/>
>>      <classpathentry kind="lib" path="framework/base/lib/barcode4j-fop-ext-complete-2.0.jar"/>
>>      <classpathentry kind="lib" path="framework/base/lib/batik-all-1.7.jar"/>
>> -    <classpathentry kind="lib" path="framework/base/lib/clhm-20100316.jar"/>
>> +    <classpathentry kind="lib" path="framework/base/lib/clhm-release-1.0-lru.jar"/>
>>      <classpathentry kind="lib" path="framework/base/lib/hamcrest-all-1.2.jar"/>
>>      <classpathentry kind="lib" path="framework/base/lib/fop-0.95.jar"/>
>>      <classpathentry kind="lib" path="framework/base/lib/freemarker-2.3.15.jar"/>
>>
>> Modified: ofbiz/trunk/LICENSE
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/LICENSE?rev=947993&r1=947992&r2=947993&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/LICENSE (original)
>> +++ ofbiz/trunk/LICENSE Tue May 25 10:08:04 2010
>> @@ -21,7 +21,7 @@ ofbiz/trunk/framework/base/lib/avalon-fr
>>  ofbiz/trunk/framework/base/lib/avalon-util-exception-1.0.0.jar
>>  ofbiz/trunk/framework/base/lib/batik-all-1.7.jar
>>  ofbiz/trunk/framework/base/lib/barcode4j-fop-ext-complete-2.0.jar
>> -ofbiz/trunk/framework/base/lib/clhm-20100316.jar
>> +ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar
>>  ofbiz/trunk/framework/base/lib/jakarta-regexp-1.5.jar
>>  ofbiz/trunk/framework/base/lib/jpim-0.1.jar
>>  ofbiz/trunk/framework/base/lib/juel-2.2.1.jar
>>
>> Added: ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar?rev=947993&view=auto
>> ==============================================================================
>> Binary file - no diff available.
>>
>> Propchange: ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar
>> ------------------------------------------------------------------------------
>>     svn:mime-type = application/octet-stream
>>
>>
>>
>

[Jacques Le Roux]

Fixed at r948037, I missed the new ConcurrentLinkedHashMap.Builder

I used the default Weigher: from JavaDoc <<An entry is evicted from the map when the weighted capacity exceeds the maximum weighted
capacity threshold. A Weigher  instance determines how many units of capacity that a value consumes. The default singleton weigher
algorithm assigns each value a weight of 1 to bound the map by the number of key-value pairs. A map that holds collections may weigh
values by the number of elements in the collection and bound the map by the total number of elements it contains. A change to a
value that modifies its weight requires that an update operation is performed on the map.>>
I did not use any EvictionListener.

I tought it was  faster. But when I retried with ArtifactInfo with an instance not updated I  got the same result, so my 1st test
was done too fast and I finaly can't say anything about that (actually not even sure it was used in this case...)

Jacques


From: "Jacques Le Roux" <[hidden email]>

> Thanks and sorry Christian,
>
> I'm taking care of it right now...
>
> Jacques
>
> From: "Christian Geisert" <[hidden email]>
>> Seems like this broke the build.... (errors in UtilCache.java after a clean build)
>> I have no more time right now, will fix it later this afternoon if no one else beats me
>>
>> Christian
>>
>> [hidden email] schrieb:
>>> Author: jleroux
>>> Date: Tue May 25 10:08:04 2010
>>> New Revision: 947993
>>>
>>> URL: http://svn.apache.org/viewvc?rev=947993&view=rev
>>> Log:
>>> As suggested by Ben Manes at "Upgrade ConcurrentLinkedHashMap" (https://issues.apache.org/jira/browse/OFBIZ-3779) - OFBIZ-3779
>>>
>>> The UtilCache class should use v1.0 of the CLHM library. While the previous version is fully functional, I am no longer
>>> supporting it. The new design should be faster and more reliable due to not needing to use a pseudo LRU algorithm for
>>> performance (which has degradation scenarios). A true LRU is now supported with no lock contention issues. Please consider
>>> upgrading when convenient.
>>>
>>> http://code.google.com/p/concurrentlinkedhashmap/
>>>
>>> JavaDoc:
>>> http://concurrentlinkedhashmap.googlecode.com/svn/wiki/release-1.0-LRU/index.html
>>>
>>> Added:
>>>     ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar   (with props)
>>> Removed:
>>>     ofbiz/trunk/framework/base/lib/clhm-20100316.jar
>>> Modified:
>>>     ofbiz/trunk/.classpath
>>>     ofbiz/trunk/LICENSE
>>>
>>> Modified: ofbiz/trunk/.classpath
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/.classpath?rev=947993&r1=947992&r2=947993&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/.classpath (original)
>>> +++ ofbiz/trunk/.classpath Tue May 25 10:08:04 2010
>>> @@ -15,7 +15,7 @@
>>>      <classpathentry kind="lib" path="framework/base/lib/avalon-util-exception-1.0.0.jar"/>
>>>      <classpathentry kind="lib" path="framework/base/lib/barcode4j-fop-ext-complete-2.0.jar"/>
>>>      <classpathentry kind="lib" path="framework/base/lib/batik-all-1.7.jar"/>
>>> -    <classpathentry kind="lib" path="framework/base/lib/clhm-20100316.jar"/>
>>> +    <classpathentry kind="lib" path="framework/base/lib/clhm-release-1.0-lru.jar"/>
>>>      <classpathentry kind="lib" path="framework/base/lib/hamcrest-all-1.2.jar"/>
>>>      <classpathentry kind="lib" path="framework/base/lib/fop-0.95.jar"/>
>>>      <classpathentry kind="lib" path="framework/base/lib/freemarker-2.3.15.jar"/>
>>>
>>> Modified: ofbiz/trunk/LICENSE
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/LICENSE?rev=947993&r1=947992&r2=947993&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/LICENSE (original)
>>> +++ ofbiz/trunk/LICENSE Tue May 25 10:08:04 2010
>>> @@ -21,7 +21,7 @@ ofbiz/trunk/framework/base/lib/avalon-fr
>>>  ofbiz/trunk/framework/base/lib/avalon-util-exception-1.0.0.jar
>>>  ofbiz/trunk/framework/base/lib/batik-all-1.7.jar
>>>  ofbiz/trunk/framework/base/lib/barcode4j-fop-ext-complete-2.0.jar
>>> -ofbiz/trunk/framework/base/lib/clhm-20100316.jar
>>> +ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar
>>>  ofbiz/trunk/framework/base/lib/jakarta-regexp-1.5.jar
>>>  ofbiz/trunk/framework/base/lib/jpim-0.1.jar
>>>  ofbiz/trunk/framework/base/lib/juel-2.2.1.jar
>>>
>>> Added: ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar?rev=947993&view=auto
>>> ==============================================================================
>>> Binary file - no diff available.
>>>
>>> Propchange: ofbiz/trunk/framework/base/lib/clhm-release-1.0-lru.jar
>>> ------------------------------------------------------------------------------
>>>     svn:mime-type = application/octet-stream
>>>
>>>
>>>
>>
>
>