Re: svn commit: r966285 - in /ofbiz/trunk: .classpath LICENSE framework/base/lib/fop-0.95.jar framework/base/lib/fop-1.0.jar framework/base/lib/xmlgraphics-commons-1.3.1.jar framework/base/lib/xmlgraphics-commons-1.4.jar

[J. Eckard-2]

This commit breaks barcode rendering.

On Jul 21, 2010, at 11:44 AM, [hidden email] wrote:

> Author: erwan
> Date: Wed Jul 21 15:44:16 2010
> New Revision: 966285
>
> URL: http://svn.apache.org/viewvc?rev=966285&view=rev
> Log:
> Adding the new FOP 1.0 to OFBiz
>
> Added:
>    ofbiz/trunk/framework/base/lib/fop-1.0.jar   (with props)
>    ofbiz/trunk/framework/base/lib/xmlgraphics-commons-1.4.jar    
> (with props)
> Removed:
>    ofbiz/trunk/framework/base/lib/fop-0.95.jar
>    ofbiz/trunk/framework/base/lib/xmlgraphics-commons-1.3.1.jar
> Modified:
>    ofbiz/trunk/.classpath
>    ofbiz/trunk/LICENSE
>
> Modified: ofbiz/trunk/.classpath
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/.classpath?rev=966285&r1=966284&r2=966285&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/.classpath (original)
> +++ ofbiz/trunk/.classpath Wed Jul 21 15:44:16 2010
> @@ -17,7 +17,7 @@
>     <classpathentry kind="lib" path="framework/base/lib/batik-
> all-1.7.jar"/>
>     <classpathentry kind="lib" path="framework/base/lib/clhm-
> release-1.0-lru.jar"/>
>     <classpathentry kind="lib" path="framework/base/lib/hamcrest-
> all-1.2.jar"/>
> -    <classpathentry kind="lib" path="framework/base/lib/
> fop-0.95.jar"/>
> +    <classpathentry kind="lib" path="framework/base/lib/
> fop-1.0.jar"/>
>     <classpathentry kind="lib" path="framework/base/lib/
> freemarker-2.3.15.jar"/>
>     <classpathentry kind="lib" path="framework/base/lib/
> httpclient-4.0.jar"/>
>     <classpathentry kind="lib" path="framework/base/lib/
> httpcore-4.0.1.jar"/>
> @@ -48,7 +48,7 @@
>
>     <classpathentry kind="lib" path="framework/base/lib/xml-
> apis-2.9.1.jar"/>
>     <classpathentry kind="lib" path="framework/base/lib/xml-apis-
> ext-1.3.04.jar"/>
> -    <classpathentry kind="lib" path="framework/base/lib/xmlgraphics-
> commons-1.3.1.jar"/>
> +    <classpathentry kind="lib" path="framework/base/lib/xmlgraphics-
> commons-1.4.jar"/>
>     <classpathentry kind="lib" path="framework/base/lib/xmlrpc-
> client-3.1.2.jar"/>
>     <classpathentry kind="lib" path="framework/base/lib/xmlrpc-
> common-3.1.2.jar"/>
>     <classpathentry kind="lib" path="framework/base/lib/xmlrpc-
> server-3.1.2.jar"/>
>
> Modified: ofbiz/trunk/LICENSE
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/LICENSE?rev=966285&r1=966284&r2=966285&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/LICENSE (original)
> +++ ofbiz/trunk/LICENSE Wed Jul 21 15:44:16 2010
> @@ -101,9 +101,9 @@ ofbiz/trunk/framework/service/lib/common
> ofbiz/trunk/framework/service/lib/neethi-2.0.4.jar
> ofbiz/trunk/framework/service/lib/XmlSchema-1.4.3.jar
> ofbiz/trunk/framework/testtools/lib/selenium-java-client-driver.jar
> -ofbiz/trunk/framework/webapp/lib/fop-0.95.jar
> +ofbiz/trunk/framework/webapp/lib/fop-1.0.jar
> ofbiz/trunk/framework/webapp/lib/velocity-1.6.1.jar
> -ofbiz/trunk/framework/webapp/lib/xmlgraphics-commons-1.3.1.jar
> +ofbiz/trunk/framework/webapp/lib/xmlgraphics-commons-1.4.jar
> ofbiz/trunk/framework/webapp/lib/json-lib-2.2.3-jdk15.jar
> ofbiz/trunk/framework/webapp/lib/ezmorph-0.9.1.jar
> ofbiz/trunk/framework/webapp/lib/rome-0.9.jar
>
> Added: ofbiz/trunk/framework/base/lib/fop-1.0.jar
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/lib/fop-1.0.jar?rev=966285&view=auto
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> Binary file - no diff available.
>
> Propchange: ofbiz/trunk/framework/base/lib/fop-1.0.jar
> ------------------------------------------------------------------------------
>    svn:mime-type = application/octet-stream
>
> Added: ofbiz/trunk/framework/base/lib/xmlgraphics-commons-1.4.jar
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/lib/xmlgraphics-commons-1.4.jar?rev=966285&view=auto
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> Binary file - no diff available.
>
> Propchange: ofbiz/trunk/framework/base/lib/xmlgraphics-commons-1.4.jar
> ------------------------------------------------------------------------------
>    svn:mime-type = application/octet-stream
>
>

[Adam Heath-2]

Joe Eckard wrote:
> This commit breaks barcode rendering.

Whenever reporting an issue, it is always best to include the series
of steps it takes to cause the problem to occur.

>
> On Jul 21, 2010, at 11:44 AM, [hidden email] wrote:
>
>> Author: erwan
>> Date: Wed Jul 21 15:44:16 2010
>> New Revision: 966285
>>
>> URL: http://svn.apache.org/viewvc?rev=966285&view=rev
>> Log:
>> Adding the new FOP 1.0 to OFBiz
>>
>> Added:
>>    ofbiz/trunk/framework/base/lib/fop-1.0.jar   (with props)
>>    ofbiz/trunk/framework/base/lib/xmlgraphics-commons-1.4.jar   (with
>> props)
>> Removed:
>>    ofbiz/trunk/framework/base/lib/fop-0.95.jar
>>    ofbiz/trunk/framework/base/lib/xmlgraphics-commons-1.3.1.jar
>> Modified:
>>    ofbiz/trunk/.classpath
>>    ofbiz/trunk/LICENSE
>>
>> Modified: ofbiz/trunk/.classpath
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/.classpath?rev=966285&r1=966284&r2=966285&view=diff
>>
>> ==============================================================================
>>
>> --- ofbiz/trunk/.classpath (original)
>> +++ ofbiz/trunk/.classpath Wed Jul 21 15:44:16 2010
>> @@ -17,7 +17,7 @@
>>     <classpathentry kind="lib"
>> path="framework/base/lib/batik-all-1.7.jar"/>
>>     <classpathentry kind="lib"
>> path="framework/base/lib/clhm-release-1.0-lru.jar"/>
>>     <classpathentry kind="lib"
>> path="framework/base/lib/hamcrest-all-1.2.jar"/>
>> -    <classpathentry kind="lib" path="framework/base/lib/fop-0.95.jar"/>
>> +    <classpathentry kind="lib" path="framework/base/lib/fop-1.0.jar"/>
>>     <classpathentry kind="lib"
>> path="framework/base/lib/freemarker-2.3.15.jar"/>
>>     <classpathentry kind="lib"
>> path="framework/base/lib/httpclient-4.0.jar"/>
>>     <classpathentry kind="lib"
>> path="framework/base/lib/httpcore-4.0.1.jar"/>
>> @@ -48,7 +48,7 @@
>>
>>     <classpathentry kind="lib"
>> path="framework/base/lib/xml-apis-2.9.1.jar"/>
>>     <classpathentry kind="lib"
>> path="framework/base/lib/xml-apis-ext-1.3.04.jar"/>
>> -    <classpathentry kind="lib"
>> path="framework/base/lib/xmlgraphics-commons-1.3.1.jar"/>
>> +    <classpathentry kind="lib"
>> path="framework/base/lib/xmlgraphics-commons-1.4.jar"/>
>>     <classpathentry kind="lib"
>> path="framework/base/lib/xmlrpc-client-3.1.2.jar"/>
>>     <classpathentry kind="lib"
>> path="framework/base/lib/xmlrpc-common-3.1.2.jar"/>
>>     <classpathentry kind="lib"
>> path="framework/base/lib/xmlrpc-server-3.1.2.jar"/>
>>
>> Modified: ofbiz/trunk/LICENSE
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/LICENSE?rev=966285&r1=966284&r2=966285&view=diff
>>
>> ==============================================================================
>>
>> --- ofbiz/trunk/LICENSE (original)
>> +++ ofbiz/trunk/LICENSE Wed Jul 21 15:44:16 2010
>> @@ -101,9 +101,9 @@ ofbiz/trunk/framework/service/lib/common
>> ofbiz/trunk/framework/service/lib/neethi-2.0.4.jar
>> ofbiz/trunk/framework/service/lib/XmlSchema-1.4.3.jar
>> ofbiz/trunk/framework/testtools/lib/selenium-java-client-driver.jar
>> -ofbiz/trunk/framework/webapp/lib/fop-0.95.jar
>> +ofbiz/trunk/framework/webapp/lib/fop-1.0.jar
>> ofbiz/trunk/framework/webapp/lib/velocity-1.6.1.jar
>> -ofbiz/trunk/framework/webapp/lib/xmlgraphics-commons-1.3.1.jar
>> +ofbiz/trunk/framework/webapp/lib/xmlgraphics-commons-1.4.jar
>> ofbiz/trunk/framework/webapp/lib/json-lib-2.2.3-jdk15.jar
>> ofbiz/trunk/framework/webapp/lib/ezmorph-0.9.1.jar
>> ofbiz/trunk/framework/webapp/lib/rome-0.9.jar
>>
>> Added: ofbiz/trunk/framework/base/lib/fop-1.0.jar
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/lib/fop-1.0.jar?rev=966285&view=auto
>>
>> ==============================================================================
>>
>> Binary file - no diff available.
>>
>> Propchange: ofbiz/trunk/framework/base/lib/fop-1.0.jar
>> ------------------------------------------------------------------------------
>>
>>    svn:mime-type = application/octet-stream
>>
>> Added: ofbiz/trunk/framework/base/lib/xmlgraphics-commons-1.4.jar
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/lib/xmlgraphics-commons-1.4.jar?rev=966285&view=auto
>>
>> ==============================================================================
>>
>> Binary file - no diff available.
>>
>> Propchange: ofbiz/trunk/framework/base/lib/xmlgraphics-commons-1.4.jar
>> ------------------------------------------------------------------------------
>>
>>    svn:mime-type = application/octet-stream
>>
>>
>

[Erwan de FERRIERES]

Le 21/07/2010 21:42, Adam Heath a écrit :
> Joe Eckard wrote:
>> This commit breaks barcode rendering.
>
> Whenever reporting an issue, it is always best to include the series
> of steps it takes to cause the problem to occur.

Yep, I totally forgot to test the barcode rendering. I'm going to revert
my commit, so it will still be good.

 From what I saw, it may be a new use of xmlgraphics which makes the
image rendering fails :

2010-07-21 21:26:57,052 (http-0.0.0.0-8443-4)
[FopFactoryConfigurator.java:179:INFO ] Default page-height set to: 11in
2010-07-21 21:26:57,053 (http-0.0.0.0-8443-4)
[FopFactoryConfigurator.java:186:INFO ] Default page-width set to: 8.26in
2010-07-21 21:26:57,056 (http-0.0.0.0-8443-4) [
ApacheFopWorker.java:90 :INFO ] FOP-FontBaseURL: http://localhost:8080/
2010-07-21 21:26:58,374 (http-0.0.0.0-8443-4)
[LoggingEventListener.java:82 :ERROR] Image not available. URI:
(instream-object). Reason:
org.apache.xmlgraphics.image.loader.ImageException: The file format is
not supported. No ImagePreloader found for null (No context info available)

Cheers,


--
Erwan de FERRIERES
www.nereide.biz