It is always better to specify brief details of the bug fix in the
commit log, isn't it? ;) :-) -- Ashish On Sat, Aug 14, 2010 at 5:33 PM, <[hidden email]> wrote: > Author: jleroux > Date: Sat Aug 14 12:03:11 2010 > New Revision: 985471 > > URL: http://svn.apache.org/viewvc?rev=985471&view=rev > Log: > Fix a bug reported by rrhati on user ML > > Modified: > ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy > > Modified: ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy > URL: http://svn.apache.org/viewvc/ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy?rev=985471&r1=985470&r2=985471&view=diff > ============================================================================== > --- ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy (original) > +++ ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy Sat Aug 14 12:03:11 2010 > @@ -22,6 +22,7 @@ import org.ofbiz.entity.util.EntityUtil; > import org.ofbiz.order.shoppingcart.product.ProductPromoWorker; > > productPromoId = request.getParameter("productPromoId"); > +if (!productPromoId) productPromoId = parameters.productPromoId; > productPromo = delegator.findByPrimaryKey("ProductPromo", [productPromoId : productPromoId]); > > promoAutoDescription = ProductPromoWorker.makeAutoDescription(productPromo, delegator, locale); > > > |
Administrator
|
Right Ashish, it's a bad old habit :/ Fortunately it's easily fixed
Thanks for the reminder, done Jacques From: "Ashish Vijaywargiya" <[hidden email]> > It is always better to specify brief details of the bug fix in the > commit log, isn't it? ;) :-) > > -- > Ashish > > On Sat, Aug 14, 2010 at 5:33 PM, <[hidden email]> wrote: >> Author: jleroux >> Date: Sat Aug 14 12:03:11 2010 >> New Revision: 985471 >> >> URL: http://svn.apache.org/viewvc?rev=985471&view=rev >> Log: >> Fix a bug reported by rrhati on user ML >> >> Modified: >> ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy >> >> Modified: ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy >> URL: >> http://svn.apache.org/viewvc/ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy?rev=985471&r1=985470&r2=985471&view=diff >> ============================================================================== >> --- ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy >> (original) >> +++ ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy Sat Aug >> 14 12:03:11 2010 >> @@ -22,6 +22,7 @@ import org.ofbiz.entity.util.EntityUtil; >> import org.ofbiz.order.shoppingcart.product.ProductPromoWorker; >> >> productPromoId = request.getParameter("productPromoId"); >> +if (!productPromoId) productPromoId = parameters.productPromoId; >> productPromo = delegator.findByPrimaryKey("ProductPromo", [productPromoId : productPromoId]); >> >> promoAutoDescription = ProductPromoWorker.makeAutoDescription(productPromo, delegator, locale); >> >> >> > |
Thanks Jacques - much appreciated! :-)
-- Ashish On Sat, Aug 14, 2010 at 9:15 PM, Jacques Le Roux <[hidden email]> wrote: > Right Ashish, it's a bad old habit :/ Fortunately it's easily fixed > > Thanks for the reminder, done > > Jacques > > From: "Ashish Vijaywargiya" <[hidden email]> >> >> It is always better to specify brief details of the bug fix in the >> commit log, isn't it? ;) :-) >> >> -- >> Ashish >> >> On Sat, Aug 14, 2010 at 5:33 PM, <[hidden email]> wrote: >>> >>> Author: jleroux >>> Date: Sat Aug 14 12:03:11 2010 >>> New Revision: 985471 >>> >>> URL: http://svn.apache.org/viewvc?rev=985471&view=rev >>> Log: >>> Fix a bug reported by rrhati on user ML >>> >>> Modified: >>> >>> ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy >>> >>> Modified: >>> ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy >>> URL: >>> http://svn.apache.org/viewvc/ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy?rev=985471&r1=985470&r2=985471&view=diff >>> >>> ============================================================================== >>> --- >>> ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy >>> (original) >>> +++ >>> ofbiz/branches/release09.04/applications/order/webapp/ordermgr/WEB-INF/actions/entry/cart/ShowPromotionDetails.groovy >>> Sat Aug 14 12:03:11 2010 >>> @@ -22,6 +22,7 @@ import org.ofbiz.entity.util.EntityUtil; >>> import org.ofbiz.order.shoppingcart.product.ProductPromoWorker; >>> >>> productPromoId = request.getParameter("productPromoId"); >>> +if (!productPromoId) productPromoId = parameters.productPromoId; >>> productPromo = delegator.findByPrimaryKey("ProductPromo", [productPromoId >>> : productPromoId]); >>> >>> promoAutoDescription = >>> ProductPromoWorker.makeAutoDescription(productPromo, delegator, locale); >>> >>> >>> >> > > > |
Free forum by Nabble | Edit this page |