Re: svn commit: r993407 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/entity/CheckDb.groovy

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r993407 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/entity/CheckDb.groovy

Adam Heath-2
On 09/07/2010 11:02 AM, [hidden email] wrote:
> Author: erwan
> Date: Tue Sep  7 16:02:38 2010
> New Revision: 993407
>
> URL: http://svn.apache.org/viewvc?rev=993407&view=rev
> Log:
> OFBIZ-3912 -- Impossible to check DB by webtools https://issues.apache.org/jira/browse/OFBIZ-3912 -- A patch from Nicolas Malin

This is a bad commit message.

What was fixed?  The log message needs to stand alone, without a diff
attached.

What is the error, what was changed?

I find these kinds of problems, because once or twice a month I
attempt to cherry-pick things from trunk into our(brainfood) local
ofbiz installation.  All I have when I do so is the log message, user,
date, a diffstat, and nothing else.  This is very similiar to what
someone would have if they were on an embedded system, with no network
access, that possessed a saved copy of the log history.  They would
not have the ability to see a diff of the files.

ps: I removed the commit patch from this email reply, so that others
can see that there is no way to actually know what was
changed/fixed/improved upon.