OFBiz › OFBiz - Dev

Re: svn commit: r995384 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Scott Gray-2

Re: svn commit: r995384 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java

Hi Ashish,

It looks like you and Bilgin are going back and forth on this: http://svn.apache.org/viewvc?view=revision&revision=894359

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 9/09/2010, at 11:32 PM, [hidden email] wrote:

> Author: ashish
> Date: Thu Sep 9 11:32:28 2010
> New Revision: 995384
>
> URL: http://svn.apache.org/viewvc?rev=995384&view=rev
> Log:
> Fixing bug of reading node name. When we read first child element of the response of any third party integration for example ups etc, node name can't be read using "node.getLocalName()". So changing node.getLocalName() --> node.getNodeName().
>
> Thanks Vivek for the contribution.
>
> Modified:
> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
>
> Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java?rev=995384&r1=995383&r2=995384&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java (original)
> +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java Thu Sep 9 11:32:28 2010
> @@ -803,7 +803,7 @@ public class UtilXml {
> if (node != null) {
> do {
> if (node.getNodeType() == Node.ELEMENT_NODE && (childElementName == null ||
> - childElementName.equals(node.getLocalName()))) {
> + childElementName.equals(node.getNodeName()))) {
> Element childElement = (Element) node;
> return childElement;
> }
>
>

smime.p7s (3K) Download Attachment

Ashish Vijaywargiya

Re: svn commit: r995384 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java

Thanks Scott for your comment.
Bilgin, can you please look into this issue and provide/propose better
solution that works for both of us?

--
Ashish

On Fri, Sep 10, 2010 at 4:18 AM, Scott Gray <[hidden email]> wrote:

> Hi Ashish,
>
> It looks like you and Bilgin are going back and forth on this: http://svn.apache.org/viewvc?view=revision&revision=894359
>
> Regards
> Scott
>
> HotWax Media
> http://www.hotwaxmedia.com
>
> On 9/09/2010, at 11:32 PM, [hidden email] wrote:
>
>> Author: ashish
>> Date: Thu Sep 9 11:32:28 2010
>> New Revision: 995384
>>
>> URL: http://svn.apache.org/viewvc?rev=995384&view=rev
>> Log:
>> Fixing bug of reading node name. When we read first child element of the response of any third party integration for example ups etc, node name can't be read using "node.getLocalName()". So changing node.getLocalName() --> node.getNodeName().
>>
>> Thanks Vivek for the contribution.
>>
>> Modified:
>> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
>>
>> Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java?rev=995384&r1=995383&r2=995384&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java (original)
>> +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java Thu Sep 9 11:32:28 2010
>> @@ -803,7 +803,7 @@ public class UtilXml {
>> if (node != null) {
>> do {
>> if (node.getNodeType() == Node.ELEMENT_NODE && (childElementName == null ||
>> - childElementName.equals(node.getLocalName()))) {
>> + childElementName.equals(node.getNodeName()))) {
>> Element childElement = (Element) node;
>> return childElement;
>> }
>>
>>
>
>

Bilgin Ibryam-2

Re: svn commit: r995384 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java

I have no access to eclıpse for one more week. Feel free to make changes ıf
needed.

Bılgın
On Fri, Sep 10, 2010 at 8:01 AM, Ashish Vijaywargiya <
[hidden email]> wrote:

> Thanks Scott for your comment.
> Bilgin, can you please look into this issue and provide/propose better
> solution that works for both of us?
>
> --
> Ashish
>
> On Fri, Sep 10, 2010 at 4:18 AM, Scott Gray <[hidden email]>
> wrote:
> > Hi Ashish,
> >
> > It looks like you and Bilgin are going back and forth on this:
> http://svn.apache.org/viewvc?view=revision&revision=894359
> >
> > Regards
> > Scott
> >
> > HotWax Media
> > http://www.hotwaxmedia.com
> >
> > On 9/09/2010, at 11:32 PM, [hidden email] wrote:
> >
> >> Author: ashish
> >> Date: Thu Sep 9 11:32:28 2010
> >> New Revision: 995384
> >>
> >> URL: http://svn.apache.org/viewvc?rev=995384&view=rev
> >> Log:
> >> Fixing bug of reading node name. When we read first child element of the
> response of any third party integration for example ups etc, node name can't
> be read using "node.getLocalName()". So changing node.getLocalName() -->
> node.getNodeName().
> >>
> >> Thanks Vivek for the contribution.
> >>
> >> Modified:
> >> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
> >>
> >> Modified:
> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
> >> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java?rev=995384&r1=995383&r2=995384&view=diff
> >>
> ==============================================================================
> >> --- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
> (original)
> >> +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java Thu
> Sep 9 11:32:28 2010
> >> @@ -803,7 +803,7 @@ public class UtilXml {
> >> if (node != null) {
> >> do {
> >> if (node.getNodeType() == Node.ELEMENT_NODE &&
> (childElementName == null ||
> >> - childElementName.equals(node.getLocalName())))
> {
> >> + childElementName.equals(node.getNodeName()))) {
> >> Element childElement = (Element) node;
> >> return childElement;
> >> }
> >>
> >>
> >
> >
>

Ashish Vijaywargiya

Re: svn commit: r995384 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java

Thanks for your comment Bilgin.
We should discuss this issue in more details once you are back.

--
Ashish

On Sat, Sep 11, 2010 at 12:56 PM, Bilgin Ibryam <[hidden email]> wrote:

> I have no access to eclıpse for one more week. Feel free to make changes ıf
> needed.
>
> Bılgın
> On Fri, Sep 10, 2010 at 8:01 AM, Ashish Vijaywargiya <
> [hidden email]> wrote:
>
>> Thanks Scott for your comment.
>> Bilgin, can you please look into this issue and provide/propose better
>> solution that works for both of us?
>>
>> --
>> Ashish
>>
>> On Fri, Sep 10, 2010 at 4:18 AM, Scott Gray <[hidden email]>
>> wrote:
>> > Hi Ashish,
>> >
>> > It looks like you and Bilgin are going back and forth on this:
>> http://svn.apache.org/viewvc?view=revision&revision=894359
>> >
>> > Regards
>> > Scott
>> >
>> > HotWax Media
>> > http://www.hotwaxmedia.com
>> >
>> > On 9/09/2010, at 11:32 PM, [hidden email] wrote:
>> >
>> >> Author: ashish
>> >> Date: Thu Sep 9 11:32:28 2010
>> >> New Revision: 995384
>> >>
>> >> URL: http://svn.apache.org/viewvc?rev=995384&view=rev
>> >> Log:
>> >> Fixing bug of reading node name. When we read first child element of the
>> response of any third party integration for example ups etc, node name can't
>> be read using "node.getLocalName()". So changing node.getLocalName() -->
>> node.getNodeName().
>> >>
>> >> Thanks Vivek for the contribution.
>> >>
>> >> Modified:
>> >> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
>> >>
>> >> Modified:
>> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
>> >> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java?rev=995384&r1=995383&r2=995384&view=diff
>> >>
>> ==============================================================================
>> >> --- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
>> (original)
>> >> +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java Thu
>> Sep 9 11:32:28 2010
>> >> @@ -803,7 +803,7 @@ public class UtilXml {
>> >> if (node != null) {
>> >> do {
>> >> if (node.getNodeType() == Node.ELEMENT_NODE &&
>> (childElementName == null ||
>> >> - childElementName.equals(node.getLocalName())))
>> {
>> >> + childElementName.equals(node.getNodeName()))) {
>> >> Element childElement = (Element) node;
>> >> return childElement;
>> >> }
>> >>
>> >>
>> >
>> >
>>
>

BJ Freeman

Re: svn commit: r995384 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java

there was a third person that posted on the user ML and Adrain Responded
that has an immeadiate need to get is resolved.
see
subject: Recent change to UtilXml.java breaks talking to jax-ws.

Ashish Vijaywargiya sent the following on 9/11/2010 1:33 AM:

=========================
BJ Freeman <http://bjfreeman.elance.com>
Strategic Power Office with Supplier Automation <http://www.businessesnetwork.com/automation/viewforum.php?f=52>
Specialtymarket.com <http://www.specialtymarket.com/>
Systems Integrator-- Glad to Assist

Chat Y! messenger: bjfr33man

> Thanks for your comment Bilgin.
> We should discuss this issue in more details once you are back.
>
> --
> Ashish
>
> On Sat, Sep 11, 2010 at 12:56 PM, Bilgin Ibryam<[hidden email]> wrote:
>> I have no access to eclıpse for one more week. Feel free to make changes ıf
>> needed.
>>
>> Bılgın
>> On Fri, Sep 10, 2010 at 8:01 AM, Ashish Vijaywargiya<
>> [hidden email]> wrote:
>>
>>> Thanks Scott for your comment.
>>> Bilgin, can you please look into this issue and provide/propose better
>>> solution that works for both of us?
>>>
>>> --
>>> Ashish
>>>
>>> On Fri, Sep 10, 2010 at 4:18 AM, Scott Gray<[hidden email]>
>>> wrote:
>>>> Hi Ashish,
>>>>
>>>> It looks like you and Bilgin are going back and forth on this:
>>> http://svn.apache.org/viewvc?view=revision&revision=894359
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> HotWax Media
>>>> http://www.hotwaxmedia.com
>>>>
>>>> On 9/09/2010, at 11:32 PM, [hidden email] wrote:
>>>>
>>>>> Author: ashish
>>>>> Date: Thu Sep 9 11:32:28 2010
>>>>> New Revision: 995384
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=995384&view=rev
>>>>> Log:
>>>>> Fixing bug of reading node name. When we read first child element of the
>>> response of any third party integration for example ups etc, node name can't
>>> be read using "node.getLocalName()". So changing node.getLocalName() -->
>>> node.getNodeName().
>>>>>
>>>>> Thanks Vivek for the contribution.
>>>>>
>>>>> Modified:
>>>>> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
>>>>>
>>>>> Modified:
>>> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
>>>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java?rev=995384&r1=995383&r2=995384&view=diff
>>>>>
>>> ==============================================================================
>>>>> --- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
>>> (original)
>>>>> +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java Thu
>>> Sep 9 11:32:28 2010
>>>>> @@ -803,7 +803,7 @@ public class UtilXml {
>>>>> if (node != null) {
>>>>> do {
>>>>> if (node.getNodeType() == Node.ELEMENT_NODE&&
>>> (childElementName == null ||
>>>>> - childElementName.equals(node.getLocalName())))
>>> {
>>>>> + childElementName.equals(node.getNodeName()))) {
>>>>> Element childElement = (Element) node;
>>>>> return childElement;
>>>>> }
>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>

Ashish Vijaywargiya

Re: svn commit: r995384 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java

For now I have reverted my changes from trunk at r996122 and will get
back here with better fix.

--
Ashish

On Sat, Sep 11, 2010 at 3:51 PM, BJ Freeman <[hidden email]> wrote:

> there was a third person that posted on the user ML and Adrain Responded
> that has an immeadiate need to get is resolved.
> see
> subject: Recent change to UtilXml.java breaks talking to jax-ws.
>
> Ashish Vijaywargiya sent the following on 9/11/2010 1:33 AM:
>
>
> =========================
> BJ Freeman <http://bjfreeman.elance.com>
> Strategic Power Office with Supplier Automation
> <http://www.businessesnetwork.com/automation/viewforum.php?f=52>
> Specialtymarket.com <http://www.specialtymarket.com/>
> Systems Integrator-- Glad to Assist
>
> Chat Y! messenger: bjfr33man
>
>> Thanks for your comment Bilgin.
>> We should discuss this issue in more details once you are back.
>>
>> --
>> Ashish
>>
>> On Sat, Sep 11, 2010 at 12:56 PM, Bilgin Ibryam<[hidden email]> wrote:
>>>
>>> I have no access to eclıpse for one more week. Feel free to make changes
>>> ıf
>>> needed.
>>>
>>> Bılgın
>>> On Fri, Sep 10, 2010 at 8:01 AM, Ashish Vijaywargiya<
>>> [hidden email]> wrote:
>>>
>>>> Thanks Scott for your comment.
>>>> Bilgin, can you please look into this issue and provide/propose better
>>>> solution that works for both of us?
>>>>
>>>> --
>>>> Ashish
>>>>
>>>> On Fri, Sep 10, 2010 at 4:18 AM, Scott Gray<[hidden email]>
>>>> wrote:
>>>>>
>>>>> Hi Ashish,
>>>>>
>>>>> It looks like you and Bilgin are going back and forth on this:
>>>>
>>>> http://svn.apache.org/viewvc?view=revision&revision=894359
>>>>>
>>>>> Regards
>>>>> Scott
>>>>>
>>>>> HotWax Media
>>>>> http://www.hotwaxmedia.com
>>>>>
>>>>> On 9/09/2010, at 11:32 PM, [hidden email] wrote:
>>>>>
>>>>>> Author: ashish
>>>>>> Date: Thu Sep 9 11:32:28 2010
>>>>>> New Revision: 995384
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=995384&view=rev
>>>>>> Log:
>>>>>> Fixing bug of reading node name. When we read first child element of
>>>>>> the
>>>>
>>>> response of any third party integration for example ups etc, node name
>>>> can't
>>>> be read using "node.getLocalName()". So changing node.getLocalName()
>>>> -->
>>>> node.getNodeName().
>>>>>>
>>>>>> Thanks Vivek for the contribution.
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
>>>>>>
>>>>>> Modified:
>>>>
>>>> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
>>>>>>
>>>>>> URL:
>>>>
>>>>
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java?rev=995384&r1=995383&r2=995384&view=diff
>>>>>>
>>>>
>>>> ==============================================================================
>>>>>>
>>>>>> --- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
>>>>
>>>> (original)
>>>>>>
>>>>>> +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
>>>>>> Thu
>>>>
>>>> Sep 9 11:32:28 2010
>>>>>>
>>>>>> @@ -803,7 +803,7 @@ public class UtilXml {
>>>>>> if (node != null) {
>>>>>> do {
>>>>>> if (node.getNodeType() == Node.ELEMENT_NODE&&
>>>>
>>>> (childElementName == null ||
>>>>>>
>>>>>> -
>>>>>> childElementName.equals(node.getLocalName())))
>>>>
>>>> {
>>>>>>
>>>>>> + childElementName.equals(node.getNodeName())))
>>>>>> {
>>>>>> Element childElement = (Element) node;
>>>>>> return childElement;
>>>>>> }
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>