Re: svn commit: r997420 - in /ofbiz/trunk: applications/accounting/webapp/accounting/images/ applications/order/webapp/ordermgr/images/js/ applications/order/webapp/ordermgr/order/ applications/party/webapp/partymgr/js/ specialpurpose/ecommerce/webapp/ecom

[Jacques Le Roux]

Not quite right but still better
http://www.prototypejs.org/api/document/observe

http://www.prototypejs.org/api/event/observe
<<Of course, you'd want this line of code to run once the form exists in the DOM; but putting inline scripts in the document is
pretty obtrusive, so instead we'll go for a simple approach that waits till the page is fully loaded:

Event.observe(window, 'load', function() {
  Event.observe('signinForm', 'submit', checkForm);
});
Just a little wrapping…

Note that if your page is heavy, you might want to run this code before the page is fully loaded: just wait until the DOM is loaded,
that will be enough. (Prototype's dom:loaded event can help you with that.)>>

Jacques

From: <[hidden email]>

> Author: doogie
> Date: Wed Sep 15 17:56:37 2010
> New Revision: 997420
>
> URL: http://svn.apache.org/viewvc?rev=997420&view=rev
> Log:
> Fix incorrect use of window->load event, instead doing
> document->dom:loaded.  In internet explorer, the window->load event can
> happen before the document is actually parsed and converted to DOM nodes.
>
> Modified:
>    ofbiz/trunk/applications/accounting/webapp/accounting/images/costCenters.js
>    ofbiz/trunk/applications/order/webapp/ordermgr/images/js/OrderShippingInfo.js
>    ofbiz/trunk/applications/order/webapp/ordermgr/images/js/geoAutoCompleter.js
>    ofbiz/trunk/applications/order/webapp/ordermgr/images/js/return.js
>    ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl
>    ofbiz/trunk/applications/party/webapp/partymgr/js/PartyProfileContent.js
>    ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/checkoutProcess.js
>    ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/productAdditionalView.js
>    ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/profile.js
>    ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/quickAnonCustSettings.js
>    ofbiz/trunk/specialpurpose/webpos/webapp/webpos/images/js/SearchProducts.js
>    ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/js/application.js
>    ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/js/application.js
>    ofbiz/trunk/themes/tomahawk/includes/appbarClose.ftl
>
> Modified: ofbiz/trunk/applications/accounting/webapp/accounting/images/costCenters.js
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/webapp/accounting/images/costCenters.js?rev=997420&r1=997419&r2=997420&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/webapp/accounting/images/costCenters.js (original)
> +++ ofbiz/trunk/applications/accounting/webapp/accounting/images/costCenters.js Wed Sep 15 17:56:37 2010
> @@ -17,7 +17,7 @@
>  * under the License.
>  */
>
> -Event.observe(window, 'load', function() {
> +document.observe('dom:loaded', function() {
>     Event.observe($('costCentersSubmit'), 'click', processCostCenterData);
>     // Find all text boxes in form and add a method to list on for on change.
>     var categoryShareInputs = $('costCenters').getInputs('text');
>
> Modified: ofbiz/trunk/applications/order/webapp/ordermgr/images/js/OrderShippingInfo.js
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/images/js/OrderShippingInfo.js?rev=997420&r1=997419&r2=997420&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/webapp/ordermgr/images/js/OrderShippingInfo.js (original)
> +++ ofbiz/trunk/applications/order/webapp/ordermgr/images/js/OrderShippingInfo.js Wed Sep 15 17:56:37 2010
> @@ -18,7 +18,7 @@ under the License.
> */
>
> var validateNewShippingAdd = null;
> -Event.observe(window, 'load', function() {
> +document.observe('dom:loaded', function() {
>     if ($('addShippingAddress')) {
>         validateNewShippingAdd = new Validation('addShippingAddress', {immediate: true, onSubmit: false});
>         Event.observe($('countryGeoId'), 'change', function() {
>
> Modified: ofbiz/trunk/applications/order/webapp/ordermgr/images/js/geoAutoCompleter.js
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/images/js/geoAutoCompleter.js?rev=997420&r1=997419&r2=997420&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/webapp/ordermgr/images/js/geoAutoCompleter.js (original)
> +++ ofbiz/trunk/applications/order/webapp/ordermgr/images/js/geoAutoCompleter.js Wed Sep 15 17:56:37 2010
> @@ -17,7 +17,7 @@
>  * under the License.
>  */
>
> -Event.observe(window, 'load', function() {
> +document.observe('dom:loaded', function() {
>     // Autocompleter for shipping panel
>     // Preventing getCountryList() from calling and not removed all autocompleter functions so that we can reuse in future.
>     //getCountryList();
>
> Modified: ofbiz/trunk/applications/order/webapp/ordermgr/images/js/return.js
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/images/js/return.js?rev=997420&r1=997419&r2=997420&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/webapp/ordermgr/images/js/return.js (original)
> +++ ofbiz/trunk/applications/order/webapp/ordermgr/images/js/return.js Wed Sep 15 17:56:37 2010
> @@ -17,7 +17,7 @@ specific language governing permissions
> under the License.
> */
>
> -Event.observe(window, 'load', function() {
> +document.observe('dom:loaded', function() {
>     Event.observe($('returnHeaderTypeId'), 'change', function() {
>         changeStatusCorrespondingToHeaderType();
>     });
>
> Modified: ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl?rev=997420&r1=997419&r2=997420&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl (original)
> +++ ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl Wed Sep 15 17:56:37 2010
> @@ -346,7 +346,9 @@ under the License.
>         </form>
>       </div>
>       <script language="JavaScript" type="text/javascript">
> +       document.observe('dom:loaded', function() {
>         new Popup('newShippingAddressForm', 'newShippingAddress', {modal: true, position: 'center', trigger: 'click'})
> +       });
>       </script>
>       <table width="100%" border="0" cellpadding="1" cellspacing="0">
>         <#if shipGroup.supplierPartyId?has_content>
>
> Modified: ofbiz/trunk/applications/party/webapp/partymgr/js/PartyProfileContent.js
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/js/PartyProfileContent.js?rev=997420&r1=997419&r2=997420&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/party/webapp/partymgr/js/PartyProfileContent.js (original)
> +++ ofbiz/trunk/applications/party/webapp/partymgr/js/PartyProfileContent.js Wed Sep 15 17:56:37 2010
> @@ -19,7 +19,7 @@ under the License.
>
> var progressBar;
>
> -Event.observe(window, 'load', function() {
> +document.observe('dom:loaded', function() {
>   Event.observe('uploadPartyContent', 'submit', uploadPartyContent);
>   Event.observe('uploadPartyContent', 'submit', getUploadProgressStatus);
>   progressBar = new Control.ProgressBar('progress_bar');
>
> Modified: ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/checkoutProcess.js
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/checkoutProcess.js?rev=997420&r1=997419&r2=997420&view=diff
> ==============================================================================
> --- ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/checkoutProcess.js (original)
> +++ ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/checkoutProcess.js Wed Sep 15 17:56:37 2010
> @@ -21,7 +21,7 @@ var isShipStepValidate = false;
> var isShipOptionStepValidate = false;
> var isBillStepValidate = false;
>
> -Event.observe(window, 'load', function() {
> +document.observe('dom:loaded', function() {
>     // Cart
>     var validateCart = new Validation('cartForm', {immediate: true, onSubmit: false});
>     var validateShip = new Validation('shippingForm', {immediate: true, onSubmit: false});
>
> Modified: ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/productAdditionalView.js
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/productAdditionalView.js?rev=997420&r1=997419&r2=997420&view=diff
> ==============================================================================
> --- ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/productAdditionalView.js (original)
> +++ ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/productAdditionalView.js Wed Sep 15 17:56:37 2010
> @@ -53,4 +53,4 @@ imgView = {
>         }
>     }
> }
> -Event.observe(window, 'load', imgView.init, false);
> +document.observe('dom:loaded', imgView.init, false);
>
> Modified: ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/profile.js
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/profile.js?rev=997420&r1=997419&r2=997420&view=diff
> ==============================================================================
> --- ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/profile.js (original)
> +++ ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/profile.js Wed Sep 15 17:56:37 2010
> @@ -20,7 +20,7 @@ under the License.
> var validateNewUser = null;
> var validateEditUser = null;
> var validatePostalAddress = null;
> -Event.observe(window, 'load', function() {
> +document.observe('dom:loaded', function() {
>     if ($('newUserForm')) {
>         validateNewUser = new Validation('newUserForm', {immediate: true, onSubmit: false});
>         addValidations();
>
> Modified: ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/quickAnonCustSettings.js
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/quickAnonCustSettings.js?rev=997420&r1=997419&r2=997420&view=diff
> ==============================================================================
> --- ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/quickAnonCustSettings.js (original)
> +++ ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/quickAnonCustSettings.js Wed Sep 15 17:56:37 2010
> @@ -17,13 +17,13 @@ specific language governing permissions
> under the License.
> */
>
> -Event.observe(window, 'load', isValidElement);
> +document.observe('dom:loaded', isValidElement);
>
> function isValidElement(element){
>     var validator = new Validation('quickAnonProcessCustomer',  {immediate : true});
>  }
>
> -Event.observe(window, 'load', function() {
> +document.observe('dom:loaded', function() {
>     Event.observe('useShippingPostalAddressForBilling', 'click', changeText2);
> });
> function changeText2(){
>
> Modified: ofbiz/trunk/specialpurpose/webpos/webapp/webpos/images/js/SearchProducts.js
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/webpos/webapp/webpos/images/js/SearchProducts.js?rev=997420&r1=997419&r2=997420&view=diff
> ==============================================================================
> --- ofbiz/trunk/specialpurpose/webpos/webapp/webpos/images/js/SearchProducts.js (original)
> +++ ofbiz/trunk/specialpurpose/webpos/webapp/webpos/images/js/SearchProducts.js Wed Sep 15 17:56:37 2010
> @@ -17,7 +17,7 @@ specific language governing permissions
> under the License.
> */
>
> -Event.observe(window, 'load', function() {
> +document.observe('dom:loaded', function() {
>
>     // Autocompleter for good identification field
>     var j = 0;
>
> Modified: ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/js/application.js
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/js/application.js?rev=997420&r1=997419&r2=997420&view=diff
> ==============================================================================
> --- ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/js/application.js (original)
> +++ ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/js/application.js Wed Sep 15 17:56:37 2010
> @@ -80,7 +80,7 @@ javascript solution to make form focus s
> consistent cross browser form platforms that
> don't support input:focus (cough, cough, IE, cough)
> *****************************************************/
> -Event.observe(window, 'load', function() {
> +document.observe('dom:loaded', function() {
>     var fields = $$("input, textarea");
>     for (var i = 0; i < fields.length; i++) {
>       fields[i].onfocus = function() {this.className += ' focused';}
> @@ -168,7 +168,7 @@ ModalWindow = Class.create({
> });
>
> //LOAD MODAL PREFERENCE WINDOWS
> -Event.observe(window, 'load', function() {
> +document.observe('dom:loaded', function() {
>     get = new ModalWindow();
>     $("language").observe('click',function(e) {
>       var locale = new Element('div', {id:'modal-contents'}).update("<img src='/bizznesstime/images/ajax-loader.gif'/>Updating
> Languages, please wait...");
>
> Modified: ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/js/application.js
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/js/application.js?rev=997420&r1=997419&r2=997420&view=diff
> ==============================================================================
> --- ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/js/application.js (original)
> +++ ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/js/application.js Wed Sep 15 17:56:37 2010
> @@ -80,7 +80,7 @@ javascript solution to make form focus s
> consistent cross browser form platforms that
> don't support input:focus (cough, cough, IE, cough)
> *****************************************************/
> -Event.observe(window, 'load', function() {
> +document.observe('dom:loaded', function() {
>     var fields = $$("input, textarea");
>     for (var i = 0; i < fields.length; i++) {
>       fields[i].onfocus = function() {this.className += ' focused';}
> @@ -168,7 +168,7 @@ ModalWindow = Class.create({
> });
>
> //LOAD MODAL PREFERENCE WINDOWS
> -Event.observe(window, 'load', function() {
> +document.observe('dom:loaded', function() {
>     get = new ModalWindow();
>     $("language").observe('click',function(e) {
>       var locale = new Element('div', {id:'modal-contents'}).update("<img src='/bizznesstime/images/ajax-loader.gif'/>Updating
> Languages, please wait...");
>
> Modified: ofbiz/trunk/themes/tomahawk/includes/appbarClose.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/tomahawk/includes/appbarClose.ftl?rev=997420&r1=997419&r2=997420&view=diff
> ==============================================================================
> --- ofbiz/trunk/themes/tomahawk/includes/appbarClose.ftl (original)
> +++ ofbiz/trunk/themes/tomahawk/includes/appbarClose.ftl Wed Sep 15 17:56:37 2010
> @@ -108,7 +108,9 @@ under the License.
>
> <#if userLogin?exists>
> <script type="text/javascript">
> + document.observe('dom:loaded', function() {
>   var mainmenu = new DropDownMenu($('main-navigation'));
>   var appmenu = new DropDownMenu($('app-navigation'));
> + });
> </script>
> </#if>
>
>

[Jacques Le Roux]

From: "Jacques Le Roux" <[hidden email]>

> Not quite right but still better
> http://www.prototypejs.org/api/document/observe
>
> http://www.prototypejs.org/api/event/observe
> <<Of course, you'd want this line of code to run once the form exists in the DOM; but putting inline scripts in the document is
> pretty obtrusive, so instead we'll go for a simple approach that waits till the page is fully loaded:
>
> Event.observe(window, 'load', function() {
>  Event.observe('signinForm', 'submit', checkForm);
> });
> Just a little wrapping…
>
> Note that if your page is heavy, you might want to run this code before the page is fully loaded: just wait until the DOM is
> loaded, that will be enough. (Prototype's dom:loaded event can help you with that.)>>

Or is it by experience? Then another reasons to turn to jQuery?

Jacques

> Jacques
>
> From: <[hidden email]>
>> Author: doogie
>> Date: Wed Sep 15 17:56:37 2010
>> New Revision: 997420
>>
>> URL: http://svn.apache.org/viewvc?rev=997420&view=rev
>> Log:
>> Fix incorrect use of window->load event, instead doing
>> document->dom:loaded.  In internet explorer, the window->load event can
>> happen before the document is actually parsed and converted to DOM nodes.
>>
>> Modified:
>>    ofbiz/trunk/applications/accounting/webapp/accounting/images/costCenters.js
>>    ofbiz/trunk/applications/order/webapp/ordermgr/images/js/OrderShippingInfo.js
>>    ofbiz/trunk/applications/order/webapp/ordermgr/images/js/geoAutoCompleter.js
>>    ofbiz/trunk/applications/order/webapp/ordermgr/images/js/return.js
>>    ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl
>>    ofbiz/trunk/applications/party/webapp/partymgr/js/PartyProfileContent.js
>>    ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/checkoutProcess.js
>>    ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/productAdditionalView.js
>>    ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/profile.js
>>    ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/quickAnonCustSettings.js
>>    ofbiz/trunk/specialpurpose/webpos/webapp/webpos/images/js/SearchProducts.js
>>    ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/js/application.js
>>    ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/js/application.js
>>    ofbiz/trunk/themes/tomahawk/includes/appbarClose.ftl
>>
>> Modified: ofbiz/trunk/applications/accounting/webapp/accounting/images/costCenters.js
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/webapp/accounting/images/costCenters.js?rev=997420&r1=997419&r2=997420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/accounting/webapp/accounting/images/costCenters.js (original)
>> +++ ofbiz/trunk/applications/accounting/webapp/accounting/images/costCenters.js Wed Sep 15 17:56:37 2010
>> @@ -17,7 +17,7 @@
>>  * under the License.
>>  */
>>
>> -Event.observe(window, 'load', function() {
>> +document.observe('dom:loaded', function() {
>>     Event.observe($('costCentersSubmit'), 'click', processCostCenterData);
>>     // Find all text boxes in form and add a method to list on for on change.
>>     var categoryShareInputs = $('costCenters').getInputs('text');
>>
>> Modified: ofbiz/trunk/applications/order/webapp/ordermgr/images/js/OrderShippingInfo.js
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/images/js/OrderShippingInfo.js?rev=997420&r1=997419&r2=997420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/order/webapp/ordermgr/images/js/OrderShippingInfo.js (original)
>> +++ ofbiz/trunk/applications/order/webapp/ordermgr/images/js/OrderShippingInfo.js Wed Sep 15 17:56:37 2010
>> @@ -18,7 +18,7 @@ under the License.
>> */
>>
>> var validateNewShippingAdd = null;
>> -Event.observe(window, 'load', function() {
>> +document.observe('dom:loaded', function() {
>>     if ($('addShippingAddress')) {
>>         validateNewShippingAdd = new Validation('addShippingAddress', {immediate: true, onSubmit: false});
>>         Event.observe($('countryGeoId'), 'change', function() {
>>
>> Modified: ofbiz/trunk/applications/order/webapp/ordermgr/images/js/geoAutoCompleter.js
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/images/js/geoAutoCompleter.js?rev=997420&r1=997419&r2=997420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/order/webapp/ordermgr/images/js/geoAutoCompleter.js (original)
>> +++ ofbiz/trunk/applications/order/webapp/ordermgr/images/js/geoAutoCompleter.js Wed Sep 15 17:56:37 2010
>> @@ -17,7 +17,7 @@
>>  * under the License.
>>  */
>>
>> -Event.observe(window, 'load', function() {
>> +document.observe('dom:loaded', function() {
>>     // Autocompleter for shipping panel
>>     // Preventing getCountryList() from calling and not removed all autocompleter functions so that we can reuse in future.
>>     //getCountryList();
>>
>> Modified: ofbiz/trunk/applications/order/webapp/ordermgr/images/js/return.js
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/images/js/return.js?rev=997420&r1=997419&r2=997420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/order/webapp/ordermgr/images/js/return.js (original)
>> +++ ofbiz/trunk/applications/order/webapp/ordermgr/images/js/return.js Wed Sep 15 17:56:37 2010
>> @@ -17,7 +17,7 @@ specific language governing permissions
>> under the License.
>> */
>>
>> -Event.observe(window, 'load', function() {
>> +document.observe('dom:loaded', function() {
>>     Event.observe($('returnHeaderTypeId'), 'change', function() {
>>         changeStatusCorrespondingToHeaderType();
>>     });
>>
>> Modified: ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl?rev=997420&r1=997419&r2=997420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl (original)
>> +++ ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl Wed Sep 15 17:56:37 2010
>> @@ -346,7 +346,9 @@ under the License.
>>         </form>
>>       </div>
>>       <script language="JavaScript" type="text/javascript">
>> +       document.observe('dom:loaded', function() {
>>         new Popup('newShippingAddressForm', 'newShippingAddress', {modal: true, position: 'center', trigger: 'click'})
>> +       });
>>       </script>
>>       <table width="100%" border="0" cellpadding="1" cellspacing="0">
>>         <#if shipGroup.supplierPartyId?has_content>
>>
>> Modified: ofbiz/trunk/applications/party/webapp/partymgr/js/PartyProfileContent.js
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/js/PartyProfileContent.js?rev=997420&r1=997419&r2=997420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/party/webapp/partymgr/js/PartyProfileContent.js (original)
>> +++ ofbiz/trunk/applications/party/webapp/partymgr/js/PartyProfileContent.js Wed Sep 15 17:56:37 2010
>> @@ -19,7 +19,7 @@ under the License.
>>
>> var progressBar;
>>
>> -Event.observe(window, 'load', function() {
>> +document.observe('dom:loaded', function() {
>>   Event.observe('uploadPartyContent', 'submit', uploadPartyContent);
>>   Event.observe('uploadPartyContent', 'submit', getUploadProgressStatus);
>>   progressBar = new Control.ProgressBar('progress_bar');
>>
>> Modified: ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/checkoutProcess.js
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/checkoutProcess.js?rev=997420&r1=997419&r2=997420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/checkoutProcess.js (original)
>> +++ ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/checkoutProcess.js Wed Sep 15 17:56:37 2010
>> @@ -21,7 +21,7 @@ var isShipStepValidate = false;
>> var isShipOptionStepValidate = false;
>> var isBillStepValidate = false;
>>
>> -Event.observe(window, 'load', function() {
>> +document.observe('dom:loaded', function() {
>>     // Cart
>>     var validateCart = new Validation('cartForm', {immediate: true, onSubmit: false});
>>     var validateShip = new Validation('shippingForm', {immediate: true, onSubmit: false});
>>
>> Modified: ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/productAdditionalView.js
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/productAdditionalView.js?rev=997420&r1=997419&r2=997420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/productAdditionalView.js (original)
>> +++ ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/productAdditionalView.js Wed Sep 15 17:56:37 2010
>> @@ -53,4 +53,4 @@ imgView = {
>>         }
>>     }
>> }
>> -Event.observe(window, 'load', imgView.init, false);
>> +document.observe('dom:loaded', imgView.init, false);
>>
>> Modified: ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/profile.js
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/profile.js?rev=997420&r1=997419&r2=997420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/profile.js (original)
>> +++ ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/profile.js Wed Sep 15 17:56:37 2010
>> @@ -20,7 +20,7 @@ under the License.
>> var validateNewUser = null;
>> var validateEditUser = null;
>> var validatePostalAddress = null;
>> -Event.observe(window, 'load', function() {
>> +document.observe('dom:loaded', function() {
>>     if ($('newUserForm')) {
>>         validateNewUser = new Validation('newUserForm', {immediate: true, onSubmit: false});
>>         addValidations();
>>
>> Modified: ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/quickAnonCustSettings.js
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/quickAnonCustSettings.js?rev=997420&r1=997419&r2=997420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/quickAnonCustSettings.js (original)
>> +++ ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/images/quickAnonCustSettings.js Wed Sep 15 17:56:37 2010
>> @@ -17,13 +17,13 @@ specific language governing permissions
>> under the License.
>> */
>>
>> -Event.observe(window, 'load', isValidElement);
>> +document.observe('dom:loaded', isValidElement);
>>
>> function isValidElement(element){
>>     var validator = new Validation('quickAnonProcessCustomer',  {immediate : true});
>>  }
>>
>> -Event.observe(window, 'load', function() {
>> +document.observe('dom:loaded', function() {
>>     Event.observe('useShippingPostalAddressForBilling', 'click', changeText2);
>> });
>> function changeText2(){
>>
>> Modified: ofbiz/trunk/specialpurpose/webpos/webapp/webpos/images/js/SearchProducts.js
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/webpos/webapp/webpos/images/js/SearchProducts.js?rev=997420&r1=997419&r2=997420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/specialpurpose/webpos/webapp/webpos/images/js/SearchProducts.js (original)
>> +++ ofbiz/trunk/specialpurpose/webpos/webapp/webpos/images/js/SearchProducts.js Wed Sep 15 17:56:37 2010
>> @@ -17,7 +17,7 @@ specific language governing permissions
>> under the License.
>> */
>>
>> -Event.observe(window, 'load', function() {
>> +document.observe('dom:loaded', function() {
>>
>>     // Autocompleter for good identification field
>>     var j = 0;
>>
>> Modified: ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/js/application.js
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/js/application.js?rev=997420&r1=997419&r2=997420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/js/application.js (original)
>> +++ ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/js/application.js Wed Sep 15 17:56:37 2010
>> @@ -80,7 +80,7 @@ javascript solution to make form focus s
>> consistent cross browser form platforms that
>> don't support input:focus (cough, cough, IE, cough)
>> *****************************************************/
>> -Event.observe(window, 'load', function() {
>> +document.observe('dom:loaded', function() {
>>     var fields = $$("input, textarea");
>>     for (var i = 0; i < fields.length; i++) {
>>       fields[i].onfocus = function() {this.className += ' focused';}
>> @@ -168,7 +168,7 @@ ModalWindow = Class.create({
>> });
>>
>> //LOAD MODAL PREFERENCE WINDOWS
>> -Event.observe(window, 'load', function() {
>> +document.observe('dom:loaded', function() {
>>     get = new ModalWindow();
>>     $("language").observe('click',function(e) {
>>       var locale = new Element('div', {id:'modal-contents'}).update("<img src='/bizznesstime/images/ajax-loader.gif'/>Updating
>> Languages, please wait...");
>>
>> Modified: ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/js/application.js
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/js/application.js?rev=997420&r1=997419&r2=997420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/js/application.js (original)
>> +++ ofbiz/trunk/themes/droppingcrumbs/webapp/droppingcrumbs/js/application.js Wed Sep 15 17:56:37 2010
>> @@ -80,7 +80,7 @@ javascript solution to make form focus s
>> consistent cross browser form platforms that
>> don't support input:focus (cough, cough, IE, cough)
>> *****************************************************/
>> -Event.observe(window, 'load', function() {
>> +document.observe('dom:loaded', function() {
>>     var fields = $$("input, textarea");
>>     for (var i = 0; i < fields.length; i++) {
>>       fields[i].onfocus = function() {this.className += ' focused';}
>> @@ -168,7 +168,7 @@ ModalWindow = Class.create({
>> });
>>
>> //LOAD MODAL PREFERENCE WINDOWS
>> -Event.observe(window, 'load', function() {
>> +document.observe('dom:loaded', function() {
>>     get = new ModalWindow();
>>     $("language").observe('click',function(e) {
>>       var locale = new Element('div', {id:'modal-contents'}).update("<img src='/bizznesstime/images/ajax-loader.gif'/>Updating
>> Languages, please wait...");
>>
>> Modified: ofbiz/trunk/themes/tomahawk/includes/appbarClose.ftl
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/tomahawk/includes/appbarClose.ftl?rev=997420&r1=997419&r2=997420&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/themes/tomahawk/includes/appbarClose.ftl (original)
>> +++ ofbiz/trunk/themes/tomahawk/includes/appbarClose.ftl Wed Sep 15 17:56:37 2010
>> @@ -108,7 +108,9 @@ under the License.
>>
>> <#if userLogin?exists>
>> <script type="text/javascript">
>> + document.observe('dom:loaded', function() {
>>   var mainmenu = new DropDownMenu($('main-navigation'));
>>   var appmenu = new DropDownMenu($('app-navigation'));
>> + });
>> </script>
>> </#if>
>>
>>
>

[Adam Heath-2]

On 09/15/2010 02:40 PM, Jacques Le Roux wrote:

> From: "Jacques Le Roux" <[hidden email]>
>> Not quite right but still better
>> http://www.prototypejs.org/api/document/observe
>>
>> http://www.prototypejs.org/api/event/observe
>> <<Of course, you'd want this line of code to run once the form exists
>> in the DOM; but putting inline scripts in the document is pretty
>> obtrusive, so instead we'll go for a simple approach that waits till
>> the page is fully loaded:
>>
>> Event.observe(window, 'load', function() {
>> Event.observe('signinForm', 'submit', checkForm);
>> });
>> Just a little wrapping…
>>
>> Note that if your page is heavy, you might want to run this code
>> before the page is fully loaded: just wait until the DOM is loaded,
>> that will be enough. (Prototype's dom:loaded event can help you with
>> that.)>>
>
> Or is it by experience? Then another reasons to turn to jQuery?

This has nothing to do with jquery or prototype being better or worse
than anything else.

You can listen for both document and window load events in both jquery
and prototype.  Ofbiz was just doing it wrong.

In fact, the source level comments for dom:loaded in protoype mention
John Resig, of jquery fame.

[Jacques Le Roux]

I think you misunderstood what I meant. Did you read http://www.prototypejs.org/api/document/observe ?

It's pretty clear (unless I can't read English) <<If you used window.onload before you might want to switch to dom:loaded because it
will fire immediately after the HTML document is fully loaded, but before images on the page are fully loaded. >>
It's not what you said in your comment.

Also I was not stating that X was Better than Y but asking if by experience you observed that Prototype documentation (above) was
wrong for IE and maybe jQuery will do better...

Jacques

From http://www.prototypejs.org/api/document/observe
It's pretty clear that

From: "Adam Heath" <[hidden email]>

> On 09/15/2010 02:40 PM, Jacques Le Roux wrote:
>> From: "Jacques Le Roux" <[hidden email]>
>>> Not quite right but still better
>>> http://www.prototypejs.org/api/document/observe
>>>
>>> http://www.prototypejs.org/api/event/observe
>>> <<Of course, you'd want this line of code to run once the form exists
>>> in the DOM; but putting inline scripts in the document is pretty
>>> obtrusive, so instead we'll go for a simple approach that waits till
>>> the page is fully loaded:
>>>
>>> Event.observe(window, 'load', function() {
>>> Event.observe('signinForm', 'submit', checkForm);
>>> });
>>> Just a little wrapping…
>>>
>>> Note that if your page is heavy, you might want to run this code
>>> before the page is fully loaded: just wait until the DOM is loaded,
>>> that will be enough. (Prototype's dom:loaded event can help you with
>>> that.)>>
>>
>> Or is it by experience? Then another reasons to turn to jQuery?
>
> This has nothing to do with jquery or prototype being better or worse than anything else.
>
> You can listen for both document and window load events in both jquery and prototype.  Ofbiz was just doing it wrong.
>
> In fact, the source level comments for dom:loaded in protoype mention John Resig, of jquery fame.
>

[Jacques Le Roux]

In other words, except if some explanation are given about IE issue, this is a bad commit message: it does not say the truth.
Some will believe that <<dom:loaded>> is more complete than <<window, 'load'>> when, according to Prototype doc, <<dom:loaded>> is
actually fired before <<window, 'load'>>
Also it's a pity the thread/message as been cut and the context is not there anymore to better understand the subject

A bit condescending I'd say...

Jacques

From: "Jacques Le Roux" <[hidden email]>

>I think you misunderstood what I meant. Did you read http://www.prototypejs.org/api/document/observe ?
>
> It's pretty clear (unless I can't read English) <<If you used window.onload before you might want to switch to dom:loaded because
> it will fire immediately after the HTML document is fully loaded, but before images on the page are fully loaded. >>
> It's not what you said in your comment.
>
> Also I was not stating that X was Better than Y but asking if by experience you observed that Prototype documentation (above) was
> wrong for IE and maybe jQuery will do better...
>
> Jacques
>
>>From http://www.prototypejs.org/api/document/observe
> It's pretty clear that
>
> From: "Adam Heath" <[hidden email]>
>> On 09/15/2010 02:40 PM, Jacques Le Roux wrote:
>>> From: "Jacques Le Roux" <[hidden email]>
>>>> Not quite right but still better
>>>> http://www.prototypejs.org/api/document/observe
>>>>
>>>> http://www.prototypejs.org/api/event/observe
>>>> <<Of course, you'd want this line of code to run once the form exists
>>>> in the DOM; but putting inline scripts in the document is pretty
>>>> obtrusive, so instead we'll go for a simple approach that waits till
>>>> the page is fully loaded:
>>>>
>>>> Event.observe(window, 'load', function() {
>>>> Event.observe('signinForm', 'submit', checkForm);
>>>> });
>>>> Just a little wrapping…
>>>>
>>>> Note that if your page is heavy, you might want to run this code
>>>> before the page is fully loaded: just wait until the DOM is loaded,
>>>> that will be enough. (Prototype's dom:loaded event can help you with
>>>> that.)>>
>>>
>>> Or is it by experience? Then another reasons to turn to jQuery?
>>
>> This has nothing to do with jquery or prototype being better or worse than anything else.
>>
>> You can listen for both document and window load events in both jquery and prototype.  Ofbiz was just doing it wrong.
>>
>> In fact, the source level comments for dom:loaded in protoype mention John Resig, of jquery fame.
>>
>
>

[Adam Heath-2]

On 09/15/2010 05:30 PM, Jacques Le Roux wrote:
> In other words, except if some explanation are given about IE issue,
> this is a bad commit message: it does not say the truth.
> Some will believe that <<dom:loaded>> is more complete than <<window,
> 'load'>> when, according to Prototype doc, <<dom:loaded>> is actually
> fired before <<window, 'load'>>
> Also it's a pity the thread/message as been cut and the context is not
> there anymore to better understand the subject
>
> A bit condescending I'd say...

Actually, you are correct, I could have done better.  I'll change the
log message to something more meaningful, but it might take a day.

This brings up another point.  When someone points out something that
could be done better, it's not best to respond that they do things
wrong too.  The fact that both people did something poorly doesn't
mean that either person is allowed to do it wrong.  The wrongness for
each person is not related at all.

When I bring up these issues, I'm not really asking for the svn commit
log to be changed(it'd be nice, but it's not a requirement).  It's
more just a suggestion to be better going forward.

>
> Jacques
>
> From: "Jacques Le Roux" <[hidden email]>
>> I think you misunderstood what I meant. Did you read
>> http://www.prototypejs.org/api/document/observe ?
>>
>> It's pretty clear (unless I can't read English) <<If you used
>> window.onload before you might want to switch to dom:loaded because it
>> will fire immediately after the HTML document is fully loaded, but
>> before images on the page are fully loaded. >>
>> It's not what you said in your comment.
>>
>> Also I was not stating that X was Better than Y but asking if by
>> experience you observed that Prototype documentation (above) was wrong
>> for IE and maybe jQuery will do better...
>>
>> Jacques
>>
>>> From http://www.prototypejs.org/api/document/observe
>> It's pretty clear that
>>
>> From: "Adam Heath" <[hidden email]>
>>> On 09/15/2010 02:40 PM, Jacques Le Roux wrote:
>>>> From: "Jacques Le Roux" <[hidden email]>
>>>>> Not quite right but still better
>>>>> http://www.prototypejs.org/api/document/observe
>>>>>
>>>>> http://www.prototypejs.org/api/event/observe
>>>>> <<Of course, you'd want this line of code to run once the form exists
>>>>> in the DOM; but putting inline scripts in the document is pretty
>>>>> obtrusive, so instead we'll go for a simple approach that waits till
>>>>> the page is fully loaded:
>>>>>
>>>>> Event.observe(window, 'load', function() {
>>>>> Event.observe('signinForm', 'submit', checkForm);
>>>>> });
>>>>> Just a little wrapping…
>>>>>
>>>>> Note that if your page is heavy, you might want to run this code
>>>>> before the page is fully loaded: just wait until the DOM is loaded,
>>>>> that will be enough. (Prototype's dom:loaded event can help you with
>>>>> that.)>>
>>>>
>>>> Or is it by experience? Then another reasons to turn to jQuery?
>>>
>>> This has nothing to do with jquery or prototype being better or worse
>>> than anything else.
>>>
>>> You can listen for both document and window load events in both
>>> jquery and prototype. Ofbiz was just doing it wrong.
>>>
>>> In fact, the source level comments for dom:loaded in protoype mention
>>> John Resig, of jquery fame.
>>>
>>
>>
>
>

[Jacques Le Roux]

From: "Adam Heath" <[hidden email]>

> On 09/15/2010 05:30 PM, Jacques Le Roux wrote:
>> In other words, except if some explanation are given about IE issue,
>> this is a bad commit message: it does not say the truth.
>> Some will believe that <<dom:loaded>> is more complete than <<window,
>> 'load'>> when, according to Prototype doc, <<dom:loaded>> is actually
>> fired before <<window, 'load'>>
>> Also it's a pity the thread/message as been cut and the context is not
>> there anymore to better understand the subject
>>
>> A bit condescending I'd say...
>
> Actually, you are correct, I could have done better.  I'll change the log message to something more meaningful, but it might take
> a day.

You still don't answer my question: Is there a specific problem in IE? Else it's not "less meaningful" but untrue

> This brings up another point.  When someone points out something that could be done better, it's not best to respond that they do
> things wrong too.  The fact that both people did something poorly doesn't mean that either person is allowed to do it wrong.  The
> wrongness for each person is not related at all.

I can't see the point. It's related to?

> When I bring up these issues, I'm not really asking for the svn commit log to be changed(it'd be nice, but it's not a
> requirement).  It's more just a suggestion to be better going forward.

*I* asked for an explanation and possibly a change (see above)

Jacques (going to bed, begins to be late here...)

>
>
>
>>
>> Jacques
>>
>> From: "Jacques Le Roux" <[hidden email]>
>>> I think you misunderstood what I meant. Did you read
>>> http://www.prototypejs.org/api/document/observe ?
>>>
>>> It's pretty clear (unless I can't read English) <<If you used
>>> window.onload before you might want to switch to dom:loaded because it
>>> will fire immediately after the HTML document is fully loaded, but
>>> before images on the page are fully loaded. >>
>>> It's not what you said in your comment.
>>>
>>> Also I was not stating that X was Better than Y but asking if by
>>> experience you observed that Prototype documentation (above) was wrong
>>> for IE and maybe jQuery will do better...
>>>
>>> Jacques
>>>
>>>> From http://www.prototypejs.org/api/document/observe
>>> It's pretty clear that
>>>
>>> From: "Adam Heath" <[hidden email]>
>>>> On 09/15/2010 02:40 PM, Jacques Le Roux wrote:
>>>>> From: "Jacques Le Roux" <[hidden email]>
>>>>>> Not quite right but still better
>>>>>> http://www.prototypejs.org/api/document/observe
>>>>>>
>>>>>> http://www.prototypejs.org/api/event/observe
>>>>>> <<Of course, you'd want this line of code to run once the form exists
>>>>>> in the DOM; but putting inline scripts in the document is pretty
>>>>>> obtrusive, so instead we'll go for a simple approach that waits till
>>>>>> the page is fully loaded:
>>>>>>
>>>>>> Event.observe(window, 'load', function() {
>>>>>> Event.observe('signinForm', 'submit', checkForm);
>>>>>> });
>>>>>> Just a little wrapping…
>>>>>>
>>>>>> Note that if your page is heavy, you might want to run this code
>>>>>> before the page is fully loaded: just wait until the DOM is loaded,
>>>>>> that will be enough. (Prototype's dom:loaded event can help you with
>>>>>> that.)>>
>>>>>
>>>>> Or is it by experience? Then another reasons to turn to jQuery?
>>>>
>>>> This has nothing to do with jquery or prototype being better or worse
>>>> than anything else.
>>>>
>>>> You can listen for both document and window load events in both
>>>> jquery and prototype. Ofbiz was just doing it wrong.
>>>>
>>>> In fact, the source level comments for dom:loaded in protoype mention
>>>> John Resig, of jquery fame.
>>>>
>>>
>>>
>>
>>
>

[Adam Heath-2]

On 09/15/2010 06:04 PM, Jacques Le Roux wrote:

> From: "Adam Heath" <[hidden email]>
>> On 09/15/2010 05:30 PM, Jacques Le Roux wrote:
>>> In other words, except if some explanation are given about IE issue,
>>> this is a bad commit message: it does not say the truth.
>>> Some will believe that <<dom:loaded>> is more complete than <<window,
>>> 'load'>> when, according to Prototype doc, <<dom:loaded>> is actually
>>> fired before <<window, 'load'>>
>>> Also it's a pity the thread/message as been cut and the context is not
>>> there anymore to better understand the subject
>>>
>>> A bit condescending I'd say...
>>
>> Actually, you are correct, I could have done better. I'll change the
>> log message to something more meaningful, but it might take a day.
>
> You still don't answer my question: Is there a specific problem in IE?
> Else it's not "less meaningful" but untrue

I answered that in the revised commit message.

>
>> This brings up another point. When someone points out something that
>> could be done better, it's not best to respond that they do things
>> wrong too. The fact that both people did something poorly doesn't mean
>> that either person is allowed to do it wrong. The wrongness for each
>> person is not related at all.
>
> I can't see the point. It's related to?

I find something done in a poor fashion.  It would be nice if, going
forward, things were done better.  So I talk to the person, telling
them what they did, and how it could be done better.  Their immediate
response then is: "But you did A, B, and C bad, so I don't need to
listen to you!"

The other person doing something wrong, and me doing something wrong,
are completely separate.  They are not related at all.  It doesn't
matter if I did something wrong, it doesn't invalidate that I
discovered something that they did that should have done in a
different manner.

This is not *directly* related to this particular, exact incident, but
it's transitively related as a way I've seen people over the years
respond to constructive critiscm.

>> When I bring up these issues, I'm not really asking for the svn commit
>> log to be changed(it'd be nice, but it's not a requirement). It's more
>> just a suggestion to be better going forward.
>
> *I* asked for an explanation and possibly a change (see above)

I've since changed the commit message.

[Jacques Le Roux]

From: "Adam Heath" <[hidden email]>

> On 09/15/2010 06:04 PM, Jacques Le Roux wrote:
>> From: "Adam Heath" <[hidden email]>
>>> On 09/15/2010 05:30 PM, Jacques Le Roux wrote:
>>>> In other words, except if some explanation are given about IE issue,
>>>> this is a bad commit message: it does not say the truth.
>>>> Some will believe that <<dom:loaded>> is more complete than <<window,
>>>> 'load'>> when, according to Prototype doc, <<dom:loaded>> is actually
>>>> fired before <<window, 'load'>>
>>>> Also it's a pity the thread/message as been cut and the context is not
>>>> there anymore to better understand the subject
>>>>
>>>> A bit condescending I'd say...
>>>
>>> Actually, you are correct, I could have done better. I'll change the
>>> log message to something more meaningful, but it might take a day.
>>
>> You still don't answer my question: Is there a specific problem in IE?
>> Else it's not "less meaningful" but untrue
>
> I answered that in the revised commit message.
>
>>
>>> This brings up another point. When someone points out something that
>>> could be done better, it's not best to respond that they do things
>>> wrong too. The fact that both people did something poorly doesn't mean
>>> that either person is allowed to do it wrong. The wrongness for each
>>> person is not related at all.
>>
>> I can't see the point. It's related to?
>
> I find something done in a poor fashion.  It would be nice if, going
> forward, things were done better.  So I talk to the person, telling
> them what they did, and how it could be done better.  Their immediate
> response then is: "But you did A, B, and C bad, so I don't need to
> listen to you!"
>
> The other person doing something wrong, and me doing something wrong,
> are completely separate.  They are not related at all.  It doesn't
> matter if I did something wrong, it doesn't invalidate that I
> discovered something that they did that should have done in a
> different manner.
>
> This is not *directly* related to this particular, exact incident, but
> it's transitively related as a way I've seen people over the years
> respond to constructive critiscm.

Yes, I see. We should alway try to keep being positive, I agree

>>> When I bring up these issues, I'm not really asking for the svn commit
>>> log to be changed(it'd be nice, but it's not a requirement). It's more
>>> just a suggestion to be better going forward.
>>
>> *I* asked for an explanation and possibly a change (see above)
>
> I've since changed the commit message.

Yes, thanks I saw

Jacques