Receive Inventory for productTypeId SERVICE or AGGREGATEDSERV_CONF

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Receive Inventory for productTypeId SERVICE or AGGREGATEDSERV_CONF

Gavin Mabie-2
Hi

Before I register a JIRA on this matter, let me first check with the
community whether it is an issue at all.  In OrderServices.java there is a
code block which seems to me a bit confusing . The code block (lines 1077 -
1124) contains an if statement checking if a product is of type "SERVICE"
or "AGGREGATEDSERV_CONF".  It is executed in the create order context. If
"true" it then runs the "receiveInventoryProduct" service.

I believe that there are two issues with this logic:
1. It does not distinguish between purchase/sales orders;
2. It does not make sense to receive inventory in the context of a SERVICE;

Is thus a bug?

Gavin
Reply | Threaded
Open this post in threaded view
|

Re: Receive Inventory for productTypeId SERVICE or AGGREGATEDSERV_CONF

Jacques Le Roux
Administrator
Here you go, I can help more if you need http://ofbiz.markmail.org/thread/tzgqrufxncp32qh6 (a little sport is good)

Jacques

Le 17/09/2015 14:02, Gavin Mabie a écrit :

> Hi
>
> Before I register a JIRA on this matter, let me first check with the
> community whether it is an issue at all.  In OrderServices.java there is a
> code block which seems to me a bit confusing . The code block (lines 1077 -
> 1124) contains an if statement checking if a product is of type "SERVICE"
> or "AGGREGATEDSERV_CONF".  It is executed in the create order context. If
> "true" it then runs the "receiveInventoryProduct" service.
>
> I believe that there are two issues with this logic:
> 1. It does not distinguish between purchase/sales orders;
> 2. It does not make sense to receive inventory in the context of a SERVICE;
>
> Is thus a bug?
>
> Gavin
>