OFBiz › OFBiz - User

Refunding adjustments only

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

12 messages Options

bsanders1979

Refunding adjustments only

If you look at processRefundReturn, you will notice that none of the
code runs unless there is at least 1 line item. If you are refunding
only, say, freight charges, the refund will not actually occur. There is
a TODO labeled "add adjustment total" which sounds like the developers
are aware of the issue. Is there a reason that it has not been
implemented yet? If I were to try and implement the functionality
myself, is there anything I should be aware off? Can anyone offer some
tips/suggestions as to how to implement? Thanks.

Jacques Le Roux

Re: Refunding adjustments only

Administrator

I did not find any TODO in OrderReturnServices.processRefundReturn()
Are you sure its plain OFBiz code ?
If yes, which Release.revision are you using ?

Jacques

From: "Sanders, Brian" <[hidden email]>
If you look at processRefundReturn, you will notice that none of the
code runs unless there is at least 1 line item. If you are refunding
only, say, freight charges, the refund will not actually occur. There is
a TODO labeled "add adjustment total" which sounds like the developers
are aware of the issue. Is there a reason that it has not been
implemented yet? If I were to try and implement the functionality
myself, is there anything I should be aware off? Can anyone offer some
tips/suggestions as to how to implement? Thanks.

bsanders1979

RE: Refunding adjustments only

When the project was imported into our repo, the revision # was 684368.
The TODO was there.

-----Original Message-----
From: Jacques Le Roux [mailto:[hidden email]]
Sent: Tuesday, April 14, 2009 12:01 PM
To: [hidden email]
Subject: Re: Refunding adjustments only

I did not find any TODO in OrderReturnServices.processRefundReturn()
Are you sure its plain OFBiz code ?
If yes, which Release.revision are you using ?

Jacques

From: "Sanders, Brian" <[hidden email]>
If you look at processRefundReturn, you will notice that none of the
code runs unless there is at least 1 line item. If you are refunding
only, say, freight charges, the refund will not actually occur. There is
a TODO labeled "add adjustment total" which sounds like the developers
are aware of the issue. Is there a reason that it has not been
implemented yet? If I were to try and implement the functionality
myself, is there anything I should be aware off? Can anyone offer some
tips/suggestions as to how to implement? Thanks.

bsanders1979

RE: Refunding adjustments only

It's in the head revision as well on line 801.

-----Original Message-----
From: Sanders, Brian [mailto:[hidden email]]
Sent: Tuesday, April 14, 2009 12:32 PM
To: [hidden email]
Subject: RE: Refunding adjustments only

When the project was imported into our repo, the revision # was 684368.
The TODO was there.

-----Original Message-----
From: Jacques Le Roux [mailto:[hidden email]]
Sent: Tuesday, April 14, 2009 12:01 PM
To: [hidden email]
Subject: Re: Refunding adjustments only

I did not find any TODO in OrderReturnServices.processRefundReturn()
Are you sure its plain OFBiz code ?
If yes, which Release.revision are you using ?

Jacques

From: "Sanders, Brian" <[hidden email]>
If you look at processRefundReturn, you will notice that none of the
code runs unless there is at least 1 line item. If you are refunding
only, say, freight charges, the refund will not actually occur. There is
a TODO labeled "add adjustment total" which sounds like the developers
are aware of the issue. Is there a reason that it has not been
implemented yet? If I were to try and implement the functionality
myself, is there anything I should be aware off? Can anyone offer some
tips/suggestions as to how to implement? Thanks.

Rees Watkins

Refunding digital items

Hi

There is special code to invoice digital items see checkDigitalItemFulfillment

Is there corresponding code for returns in digital items?

Thanks
Rees

Jacques Le Roux

Re: Refunding adjustments only

Administrator

In reply to this post by bsanders1979

Are you speaking about the last release available at the moment (r764940) ?
I don't see nay TODO on line 801 and moreover this is not a line of OrderReturnServices.processRefundReturn() method.
The last change in this file was commited by me in r763175 one week ago
http://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReturnServices.java?r=763175

Could you clarify please ?

Jacques

From: "Sanders, Brian" <[hidden email]>

> It's in the head revision as well on line 801.
>
> -----Original Message-----
> From: Sanders, Brian [mailto:[hidden email]]
> Sent: Tuesday, April 14, 2009 12:32 PM
> To: [hidden email]
> Subject: RE: Refunding adjustments only
>
> When the project was imported into our repo, the revision # was 684368.
> The TODO was there.
>
> -----Original Message-----
> From: Jacques Le Roux [mailto:[hidden email]]
> Sent: Tuesday, April 14, 2009 12:01 PM
> To: [hidden email]
> Subject: Re: Refunding adjustments only
>
> I did not find any TODO in OrderReturnServices.processRefundReturn()
> Are you sure its plain OFBiz code ?
> If yes, which Release.revision are you using ?
>
> Jacques
>
> From: "Sanders, Brian" <[hidden email]>
> If you look at processRefundReturn, you will notice that none of the
> code runs unless there is at least 1 line item. If you are refunding
> only, say, freight charges, the refund will not actually occur. There is
> a TODO labeled "add adjustment total" which sounds like the developers
> are aware of the issue. Is there a reason that it has not been
> implemented yet? If I were to try and implement the functionality
> myself, is there anything I should be aware off? Can anyone offer some
> tips/suggestions as to how to implement? Thanks.
>
>
>
>

bsanders1979

RE: Refunding adjustments only

Ok, I was looking at the head for 4.0. It appears that the issue is
fixed in the latest. Thanks.

-----Original Message-----
From: Jacques Le Roux [mailto:[hidden email]]
Sent: Tuesday, April 14, 2009 4:15 PM
To: [hidden email]
Subject: Re: Refunding adjustments only

Are you speaking about the last release available at the moment
(r764940) ?
I don't see nay TODO on line 801 and moreover this is not a line of
OrderReturnServices.processRefundReturn() method.
The last change in this file was commited by me in r763175 one week ago
http://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/src/
org/ofbiz/order/order/OrderReturnServices.java?r=763175

Could you clarify please ?

Jacques

From: "Sanders, Brian" <[hidden email]>
> It's in the head revision as well on line 801.
>
> -----Original Message-----
> From: Sanders, Brian [mailto:[hidden email]]
> Sent: Tuesday, April 14, 2009 12:32 PM
> To: [hidden email]
> Subject: RE: Refunding adjustments only
>
> When the project was imported into our repo, the revision # was
684368.

> The TODO was there.
>
> -----Original Message-----
> From: Jacques Le Roux [mailto:[hidden email]]
> Sent: Tuesday, April 14, 2009 12:01 PM
> To: [hidden email]
> Subject: Re: Refunding adjustments only
>
> I did not find any TODO in OrderReturnServices.processRefundReturn()
> Are you sure its plain OFBiz code ?
> If yes, which Release.revision are you using ?
>
> Jacques
>
> From: "Sanders, Brian" <[hidden email]>
> If you look at processRefundReturn, you will notice that none of the
> code runs unless there is at least 1 line item. If you are refunding
> only, say, freight charges, the refund will not actually occur. There

is
> a TODO labeled "add adjustment total" which sounds like the developers
> are aware of the issue. Is there a reason that it has not been
> implemented yet? If I were to try and implement the functionality
> myself, is there anything I should be aware off? Can anyone offer some
> tips/suggestions as to how to implement? Thanks.
>
>
>
>

bsanders1979

RE: Refunding adjustments only

Well, it turns out it's not fixed in the latest. While it does make it
further into the code, it gets skipped over because of line 894:
while (itemByOrderIt.hasNext()) {

-----Original Message-----
From: Sanders, Brian [mailto:[hidden email]]
Sent: Wednesday, April 15, 2009 8:40 AM
To: [hidden email]
Subject: RE: Refunding adjustments only

Ok, I was looking at the head for 4.0. It appears that the issue is
fixed in the latest. Thanks.

-----Original Message-----
From: Jacques Le Roux [mailto:[hidden email]]
Sent: Tuesday, April 14, 2009 4:15 PM
To: [hidden email]
Subject: Re: Refunding adjustments only

Are you speaking about the last release available at the moment
(r764940) ?
I don't see nay TODO on line 801 and moreover this is not a line of
OrderReturnServices.processRefundReturn() method.
The last change in this file was commited by me in r763175 one week ago
http://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/src/
org/ofbiz/order/order/OrderReturnServices.java?r=763175

Could you clarify please ?

Jacques

From: "Sanders, Brian" <[hidden email]>
> It's in the head revision as well on line 801.
>
> -----Original Message-----
> From: Sanders, Brian [mailto:[hidden email]]
> Sent: Tuesday, April 14, 2009 12:32 PM
> To: [hidden email]
> Subject: RE: Refunding adjustments only
>
> When the project was imported into our repo, the revision # was
684368.

bsanders1979

RE: Refunding adjustments only

Part of an approach I considered to handle this situation would create a
dummy order adjustment so that I can link the manual return adjustment
to the original order. Would anyone consider this a hack/bad idea? What
about adding an orderId field to ReturnAdjustment? I am for creating the
order adjustment because you're putting both types of return adjustments
into the same bucket. My colleague, however, feels that it would be
better to add the orderId field to the entity. Also, I think this
functionality would be a good addition to the release so I planned on
attaching the patch to the Jira issue I opened. Thanks and have a good
weekend.

-----Original Message-----
From: Sanders, Brian [mailto:[hidden email]]
Sent: Wednesday, April 15, 2009 1:34 PM
To: [hidden email]
Subject: RE: Refunding adjustments only

Well, it turns out it's not fixed in the latest. While it does make it
further into the code, it gets skipped over because of line 894:
while (itemByOrderIt.hasNext()) {

-----Original Message-----
From: Sanders, Brian [mailto:[hidden email]]
Sent: Wednesday, April 15, 2009 8:40 AM
To: [hidden email]
Subject: RE: Refunding adjustments only

Ok, I was looking at the head for 4.0. It appears that the issue is
fixed in the latest. Thanks.

-----Original Message-----
From: Jacques Le Roux [mailto:[hidden email]]
Sent: Tuesday, April 14, 2009 4:15 PM
To: [hidden email]
Subject: Re: Refunding adjustments only

Are you speaking about the last release available at the moment
(r764940) ?
I don't see nay TODO on line 801 and moreover this is not a line of
OrderReturnServices.processRefundReturn() method.
The last change in this file was commited by me in r763175 one week ago
http://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/src/
org/ofbiz/order/order/OrderReturnServices.java?r=763175

Could you clarify please ?

Jacques

From: "Sanders, Brian" <[hidden email]>
> It's in the head revision as well on line 801.
>
> -----Original Message-----
> From: Sanders, Brian [mailto:[hidden email]]
> Sent: Tuesday, April 14, 2009 12:32 PM
> To: [hidden email]
> Subject: RE: Refunding adjustments only
>
> When the project was imported into our repo, the revision # was
684368.

Jacques Le Roux

Re: Refunding adjustments only

Administrator

Hi Brian,

Do you finally have a solution for this ?

Jacques

From: "Sanders, Brian" <[hidden email]>

> Part of an approach I considered to handle this situation would create a
> dummy order adjustment so that I can link the manual return adjustment
> to the original order. Would anyone consider this a hack/bad idea? What
> about adding an orderId field to ReturnAdjustment? I am for creating the
> order adjustment because you're putting both types of return adjustments
> into the same bucket. My colleague, however, feels that it would be
> better to add the orderId field to the entity. Also, I think this
> functionality would be a good addition to the release so I planned on
> attaching the patch to the Jira issue I opened. Thanks and have a good
> weekend.
>
> -----Original Message-----
> From: Sanders, Brian [mailto:[hidden email]]
> Sent: Wednesday, April 15, 2009 1:34 PM
> To: [hidden email]
> Subject: RE: Refunding adjustments only
>
> Well, it turns out it's not fixed in the latest. While it does make it
> further into the code, it gets skipped over because of line 894:
> while (itemByOrderIt.hasNext()) {
>
> -----Original Message-----
> From: Sanders, Brian [mailto:[hidden email]]
> Sent: Wednesday, April 15, 2009 8:40 AM
> To: [hidden email]
> Subject: RE: Refunding adjustments only
>
> Ok, I was looking at the head for 4.0. It appears that the issue is
> fixed in the latest. Thanks.
>
> -----Original Message-----
> From: Jacques Le Roux [mailto:[hidden email]]
> Sent: Tuesday, April 14, 2009 4:15 PM
> To: [hidden email]
> Subject: Re: Refunding adjustments only
>
> Are you speaking about the last release available at the moment
> (r764940) ?
> I don't see nay TODO on line 801 and moreover this is not a line of
> OrderReturnServices.processRefundReturn() method.
> The last change in this file was commited by me in r763175 one week ago
> http://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/src/
> org/ofbiz/order/order/OrderReturnServices.java?r=763175
>
> Could you clarify please ?
>
> Jacques
>
> From: "Sanders, Brian" <[hidden email]>
>> It's in the head revision as well on line 801.
>>
>> -----Original Message-----
>> From: Sanders, Brian [mailto:[hidden email]]
>> Sent: Tuesday, April 14, 2009 12:32 PM
>> To: [hidden email]
>> Subject: RE: Refunding adjustments only
>>
>> When the project was imported into our repo, the revision # was
> 684368.
>> The TODO was there.
>>
>> -----Original Message-----
>> From: Jacques Le Roux [mailto:[hidden email]]
>> Sent: Tuesday, April 14, 2009 12:01 PM
>> To: [hidden email]
>> Subject: Re: Refunding adjustments only
>>
>> I did not find any TODO in OrderReturnServices.processRefundReturn()
>> Are you sure its plain OFBiz code ?
>> If yes, which Release.revision are you using ?
>>
>> Jacques
>>
>> From: "Sanders, Brian" <[hidden email]>
>> If you look at processRefundReturn, you will notice that none of the
>> code runs unless there is at least 1 line item. If you are refunding
>> only, say, freight charges, the refund will not actually occur. There
> is
>> a TODO labeled "add adjustment total" which sounds like the developers
>> are aware of the issue. Is there a reason that it has not been
>> implemented yet? If I were to try and implement the functionality
>> myself, is there anything I should be aware off? Can anyone offer some
>> tips/suggestions as to how to implement? Thanks.
>>
>>
>>
>>
>
>

bsanders1979

RE: Refunding adjustments only

Hello Jacques,
We got the core functionality to work (the actual refund takes
place and the return completes), but there are a few more things that
need to happen. Essentially, if the adjustment is by itself, an invoice
does not get created and thus, there is no payment application.
According to Al, "in order to have an invoice, you have to have a
shipment, to have a shipment you need an item". Unfortunately, we do not
have time to code it correctly and meet our deadline, but I think we are
going to revisit it once we go live. If you can provide any sort of
guidance, that would be great. If you want, I will talk to him about
submitting a patch of what we got done so far to the Jira issue I
opened.

-----Original Message-----
From: Jacques Le Roux [mailto:[hidden email]]
Sent: Sunday, April 26, 2009 5:29 PM
To: [hidden email]
Subject: Re: Refunding adjustments only

Hi Brian,

Do you finally have a solution for this ?

Jacques

From: "Sanders, Brian" <[hidden email]>
> Part of an approach I considered to handle this situation would create
a
> dummy order adjustment so that I can link the manual return adjustment
> to the original order. Would anyone consider this a hack/bad idea?
What
> about adding an orderId field to ReturnAdjustment? I am for creating
the
> order adjustment because you're putting both types of return
adjustments

> into the same bucket. My colleague, however, feels that it would be
> better to add the orderId field to the entity. Also, I think this
> functionality would be a good addition to the release so I planned on
> attaching the patch to the Jira issue I opened. Thanks and have a good
> weekend.
>
> -----Original Message-----
> From: Sanders, Brian [mailto:[hidden email]]
> Sent: Wednesday, April 15, 2009 1:34 PM
> To: [hidden email]
> Subject: RE: Refunding adjustments only
>
> Well, it turns out it's not fixed in the latest. While it does make it
> further into the code, it gets skipped over because of line 894:
> while (itemByOrderIt.hasNext()) {
>
> -----Original Message-----
> From: Sanders, Brian [mailto:[hidden email]]
> Sent: Wednesday, April 15, 2009 8:40 AM
> To: [hidden email]
> Subject: RE: Refunding adjustments only
>
> Ok, I was looking at the head for 4.0. It appears that the issue is
> fixed in the latest. Thanks.
>
> -----Original Message-----
> From: Jacques Le Roux [mailto:[hidden email]]
> Sent: Tuesday, April 14, 2009 4:15 PM
> To: [hidden email]
> Subject: Re: Refunding adjustments only
>
> Are you speaking about the last release available at the moment
> (r764940) ?
> I don't see nay TODO on line 801 and moreover this is not a line of
> OrderReturnServices.processRefundReturn() method.
> The last change in this file was commited by me in r763175 one week

ago
>
http://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/src/

> org/ofbiz/order/order/OrderReturnServices.java?r=763175
>
> Could you clarify please ?
>
> Jacques
>
> From: "Sanders, Brian" <[hidden email]>
>> It's in the head revision as well on line 801.
>>
>> -----Original Message-----
>> From: Sanders, Brian [mailto:[hidden email]]
>> Sent: Tuesday, April 14, 2009 12:32 PM
>> To: [hidden email]
>> Subject: RE: Refunding adjustments only
>>
>> When the project was imported into our repo, the revision # was
> 684368.
>> The TODO was there.
>>
>> -----Original Message-----
>> From: Jacques Le Roux [mailto:[hidden email]]
>> Sent: Tuesday, April 14, 2009 12:01 PM
>> To: [hidden email]
>> Subject: Re: Refunding adjustments only
>>
>> I did not find any TODO in OrderReturnServices.processRefundReturn()
>> Are you sure its plain OFBiz code ?
>> If yes, which Release.revision are you using ?
>>
>> Jacques
>>
>> From: "Sanders, Brian" <[hidden email]>
>> If you look at processRefundReturn, you will notice that none of the
>> code runs unless there is at least 1 line item. If you are refunding
>> only, say, freight charges, the refund will not actually occur. There
> is
>> a TODO labeled "add adjustment total" which sounds like the

developers
>> are aware of the issue. Is there a reason that it has not been
>> implemented yet? If I were to try and implement the functionality
>> myself, is there anything I should be aware off? Can anyone offer
some
>> tips/suggestions as to how to implement? Thanks.
>>
>>
>>
>>
>
>

Jacques Le Roux

Re: Refunding adjustments only

Administrator

Hi Brian,

Yes I saw, after my message, the Jira issue. It's not a big deal but yes a patch would be welcome.

Thanks

Jacques

From: "Sanders, Brian" <[hidden email]>

> Hello Jacques,
> We got the core functionality to work (the actual refund takes
> place and the return completes), but there are a few more things that
> need to happen. Essentially, if the adjustment is by itself, an invoice
> does not get created and thus, there is no payment application.
> According to Al, "in order to have an invoice, you have to have a
> shipment, to have a shipment you need an item". Unfortunately, we do not
> have time to code it correctly and meet our deadline, but I think we are
> going to revisit it once we go live. If you can provide any sort of
> guidance, that would be great. If you want, I will talk to him about
> submitting a patch of what we got done so far to the Jira issue I
> opened.
>
> -----Original Message-----
> From: Jacques Le Roux [mailto:[hidden email]]
> Sent: Sunday, April 26, 2009 5:29 PM
> To: [hidden email]
> Subject: Re: Refunding adjustments only
>
> Hi Brian,
>
> Do you finally have a solution for this ?
>
> Jacques
>
> From: "Sanders, Brian" <[hidden email]>
>> Part of an approach I considered to handle this situation would create
> a
>> dummy order adjustment so that I can link the manual return adjustment
>> to the original order. Would anyone consider this a hack/bad idea?
> What
>> about adding an orderId field to ReturnAdjustment? I am for creating
> the
>> order adjustment because you're putting both types of return
> adjustments
>> into the same bucket. My colleague, however, feels that it would be
>> better to add the orderId field to the entity. Also, I think this
>> functionality would be a good addition to the release so I planned on
>> attaching the patch to the Jira issue I opened. Thanks and have a good
>> weekend.
>>
>> -----Original Message-----
>> From: Sanders, Brian [mailto:[hidden email]]
>> Sent: Wednesday, April 15, 2009 1:34 PM
>> To: [hidden email]
>> Subject: RE: Refunding adjustments only
>>
>> Well, it turns out it's not fixed in the latest. While it does make it
>> further into the code, it gets skipped over because of line 894:
>> while (itemByOrderIt.hasNext()) {
>>
>> -----Original Message-----
>> From: Sanders, Brian [mailto:[hidden email]]
>> Sent: Wednesday, April 15, 2009 8:40 AM
>> To: [hidden email]
>> Subject: RE: Refunding adjustments only
>>
>> Ok, I was looking at the head for 4.0. It appears that the issue is
>> fixed in the latest. Thanks.
>>
>> -----Original Message-----
>> From: Jacques Le Roux [mailto:[hidden email]]
>> Sent: Tuesday, April 14, 2009 4:15 PM
>> To: [hidden email]
>> Subject: Re: Refunding adjustments only
>>
>> Are you speaking about the last release available at the moment
>> (r764940) ?
>> I don't see nay TODO on line 801 and moreover this is not a line of
>> OrderReturnServices.processRefundReturn() method.
>> The last change in this file was commited by me in r763175 one week
> ago
>>
> http://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/src/
>> org/ofbiz/order/order/OrderReturnServices.java?r=763175
>>
>> Could you clarify please ?
>>
>> Jacques
>>
>> From: "Sanders, Brian" <[hidden email]>
>>> It's in the head revision as well on line 801.
>>>
>>> -----Original Message-----
>>> From: Sanders, Brian [mailto:[hidden email]]
>>> Sent: Tuesday, April 14, 2009 12:32 PM
>>> To: [hidden email]
>>> Subject: RE: Refunding adjustments only
>>>
>>> When the project was imported into our repo, the revision # was
>> 684368.
>>> The TODO was there.
>>>
>>> -----Original Message-----
>>> From: Jacques Le Roux [mailto:[hidden email]]
>>> Sent: Tuesday, April 14, 2009 12:01 PM
>>> To: [hidden email]
>>> Subject: Re: Refunding adjustments only
>>>
>>> I did not find any TODO in OrderReturnServices.processRefundReturn()
>>> Are you sure its plain OFBiz code ?
>>> If yes, which Release.revision are you using ?
>>>
>>> Jacques
>>>
>>> From: "Sanders, Brian" <[hidden email]>
>>> If you look at processRefundReturn, you will notice that none of the
>>> code runs unless there is at least 1 line item. If you are refunding
>>> only, say, freight charges, the refund will not actually occur. There
>> is
>>> a TODO labeled "add adjustment total" which sounds like the
> developers
>>> are aware of the issue. Is there a reason that it has not been
>>> implemented yet? If I were to try and implement the functionality
>>> myself, is there anything I should be aware off? Can anyone offer
> some
>>> tips/suggestions as to how to implement? Thanks.
>>>
>>>
>>>
>>>
>>
>>
>
>