*Role entities question

[Bilgin Ibryam]

Hi all,

I'm looking at various role entities and noticed that some of them has
fromDate - thruDate, but others don't have.
I just wanted to know what is the pattern/best practice to follow when
adding fromDate - thruDate fields?

What do you think about these changes:
1) ProductStoreRole has fromDate - thruDate, but FacilityRole don't. I
think FacilityRole should also has fromDate - thruDate.
2) May be ProductStoreGroupRole and FacilityGroupRole should also have
fromDate - thruDate?
3) Is it needed fromDate - thruDate fields in PicklistRole?

Thanks in advance,
Bilgin Ibryam

[Jacopo Cappellato-3]

Hi Bilgin ,

from/thru dates (with from date in the primary key) are useful when  
you have to record the history of roles associated to an entity (e.g.  
"who was the administrator of the product store in 2004?").
That said, ProductStoreRole, ProductStoreGroupRole, FacilityGroupRole  
seem all good canditates for the from/thru dates fields addition; IMO  
this is not the case with PicklistRole: picklists lifecycle usually  
lasts a few days (or hours) and I don't think that the information  
about expired roles would be useful.

Jacopo


On Jul 17, 2008, at 10:17 AM, Bilgin Ibryam wrote:

>
>
> Hi all,
>
> I'm looking at various role entities and noticed that some of them has
> fromDate - thruDate, but others don't have.
> I just wanted to know what is the pattern/best practice to follow when
> adding fromDate - thruDate fields?
>
> What do you think about these changes:
> 1) ProductStoreRole has fromDate - thruDate, but FacilityRole don't. I
> think FacilityRole should also has fromDate - thruDate.
> 2) May be ProductStoreGroupRole and FacilityGroupRole should also have
> fromDate - thruDate?
> 3) Is it needed fromDate - thruDate fields in PicklistRole?
>
> Thanks in advance,
> Bilgin Ibryam
>

[Adrian Crum]

I agree with Jacopo. From/Thru dates should be used in entities that are
expected to keep historical data.

-Adrian

Jacopo Cappellato wrote:

> Hi Bilgin ,
>
> from/thru dates (with from date in the primary key) are useful when you
> have to record the history of roles associated to an entity (e.g. "who
> was the administrator of the product store in 2004?").
> That said, ProductStoreRole, ProductStoreGroupRole, FacilityGroupRole
> seem all good canditates for the from/thru dates fields addition; IMO
> this is not the case with PicklistRole: picklists lifecycle usually
> lasts a few days (or hours) and I don't think that the information about
> expired roles would be useful.
>
> Jacopo
>
>
> On Jul 17, 2008, at 10:17 AM, Bilgin Ibryam wrote:
>
>>
>>
>> Hi all,
>>
>> I'm looking at various role entities and noticed that some of them has
>> fromDate - thruDate, but others don't have.
>> I just wanted to know what is the pattern/best practice to follow when
>> adding fromDate - thruDate fields?
>>
>> What do you think about these changes:
>> 1) ProductStoreRole has fromDate - thruDate, but FacilityRole don't. I
>> think FacilityRole should also has fromDate - thruDate.
>> 2) May be ProductStoreGroupRole and FacilityGroupRole should also have
>> fromDate - thruDate?
>> 3) Is it needed fromDate - thruDate fields in PicklistRole?
>>
>> Thanks in advance,
>> Bilgin Ibryam
>>
>
>

[Ashish Vijaywargiya]

+1

On Thu, Jul 17, 2008 at 1:58 PM, Jacopo Cappellato <
[hidden email]> wrote:

> Hi Bilgin ,
>
> from/thru dates (with from date in the primary key) are useful when you
> have to record the history of roles associated to an entity (e.g. "who was
> the administrator of the product store in 2004?").
> That said, ProductStoreRole, ProductStoreGroupRole, FacilityGroupRole seem
> all good canditates for the from/thru dates fields addition; IMO this is not
> the case with PicklistRole: picklists lifecycle usually lasts a few days (or
> hours) and I don't think that the information about expired roles would be
> useful.
>
> Jacopo
>
>
>
> On Jul 17, 2008, at 10:17 AM, Bilgin Ibryam wrote:
>
>
>>
>> Hi all,
>>
>> I'm looking at various role entities and noticed that some of them has
>> fromDate - thruDate, but others don't have.
>> I just wanted to know what is the pattern/best practice to follow when
>> adding fromDate - thruDate fields?
>>
>> What do you think about these changes:
>> 1) ProductStoreRole has fromDate - thruDate, but FacilityRole don't. I
>> think FacilityRole should also has fromDate - thruDate.
>> 2) May be ProductStoreGroupRole and FacilityGroupRole should also have
>> fromDate - thruDate?
>> 3) Is it needed fromDate - thruDate fields in PicklistRole?
>>
>> Thanks in advance,
>> Bilgin Ibryam
>>
>>
>

--
Ashish Vijaywargiya
Indore, India
http://en.wikipedia.org/wiki/Indore

[Bilgin Ibryam]

Jacopo, Adrian, Ashish, thanks for your comments.
Then I'd like to propose the following changes:

Add fromDate - thruDate fields to following entities:
ProductStoreGroupRole
FacilityGroupRole
FacilityRole
AgreementRole
MarketingCampaignRole
SegmentGroupRole

Remove fromDate - thruDate fields to following entities:
PicklistRole


WDYT?
If there are no other candidate entities and objections, I will commit
this after one week.

Bilgin

[Jacopo Cappellato-3]

On Jul 18, 2008, at 11:13 AM, Bilgin Ibryam wrote:

>
> Jacopo, Adrian, Ashish, thanks for your comments.
> Then I'd like to propose the following changes:
>
> Add fromDate - thruDate fields to following entities:
> ProductStoreGroupRole
> FacilityGroupRole
> FacilityRole
> AgreementRole
> MarketingCampaignRole
> SegmentGroupRole
>

It makes sense to me, even if changing the primary keys of entity is a  
pain (especially if we do this without having a real world problem to  
address); if we will do this (I'd like to hear others opinion) we may  
also commit some maintenance services that can be invoked to upgrade  
the data in these entities from an older version.

> Remove fromDate - thruDate fields to following entities:
> PicklistRole
>

Hmmm... I was not aware that the from/thru fields were already in the  
PicklistRole entity... if this is the case, then maybe we should leave  
them in.


Jacopo

>
> WDYT?
> If there are no other candidate entities and objections, I will commit
> this after one week.
>
> Bilgin
>

[David E Jones]

On Jul 18, 2008, at 3:23 AM, Jacopo Cappellato wrote:

> On Jul 18, 2008, at 11:13 AM, Bilgin Ibryam wrote:
>
>>
>> Jacopo, Adrian, Ashish, thanks for your comments.
>> Then I'd like to propose the following changes:
>>
>> Add fromDate - thruDate fields to following entities:
>> ProductStoreGroupRole
>> FacilityGroupRole
>> FacilityRole
>> AgreementRole
>> MarketingCampaignRole
>> SegmentGroupRole

Just keep in mind these are a PITA to change, so unless someone has a  
reason to change each one of them I wouldn't recommend it, I guess  
unless you're really bored or something...

Anyway, what I mean by that is the stuff I described to Adrian about  
changing entities in certain ways, especially when changing the  
primary key. There is a short description of this on this page:

http://docs.ofbiz.org/display/OFBTECH/General+Entity+Overview

It's in the Deprecated Entities section of that page.

> It makes sense to me, even if changing the primary keys of entity is  
> a pain (especially if we do this without having a real world problem  
> to address); if we will do this (I'd like to hear others opinion) we  
> may also commit some maintenance services that can be invoked to  
> upgrade the data in these entities from an older version.
>
>> Remove fromDate - thruDate fields to following entities:
>> PicklistRole
>
> Hmmm... I was not aware that the from/thru fields were already in  
> the PicklistRole entity... if this is the case, then maybe we should  
> leave them in.

I agree. If it's there let's leave it.

-David

[Bilgin Ibryam]

I thought that it would be useful to keep role histories in these
entities, but didn't realized that it will modify the primary keys and
makes it PITA.

I will give up(for now).
Thanks for your help guys.

Bilgin