SVN Revision 510680

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

SVN Revision 510680

Adrian Crum
 From the commit log - "gave the main content area a ID tag"

I have no issues with giving a <div> element an id, but looking at the
GlobalDecorator I see this code:

<container style="contentarea">
     <container id="column-container">
       ...
     </container>
</container>

Since nothing will ever be inserted between the two containers, why do we need
two of them? This seems redundant. Why can't the "contentarea" contain columns?

Reply | Threaded
Open this post in threaded view
|

Re: SVN Revision 510680

cjhowe
Also, revision 510681..

.left-border{...
}

I thought we were trying to move away from using the style as a
descriptor of classes and id

my understanding is that the preference is for the class name to
describe the content to be decorated, not the decoration.

--- Adrian Crum <[hidden email]> wrote:

>  From the commit log - "gave the main content area a ID tag"
>
> I have no issues with giving a <div> element an id, but looking at
> the
> GlobalDecorator I see this code:
>
> <container style="contentarea">
>      <container id="column-container">
>        ...
>      </container>
> </container>
>
> Since nothing will ever be inserted between the two containers, why
> do we need
> two of them? This seems redundant. Why can't the "contentarea"
> contain columns?
>
>

Reply | Threaded
Open this post in threaded view
|

Re: SVN Revision 510680

Adrian Crum
I agree. Problem is there is so much code dependent upon some of those
improperly named classes that it is impractical to just rename them.

I can see the project slipping down the slippery slope of putting every little
thing inside a <div> element. And that concerns me.

A better way to handle multi-column layout would be to have component-specific
style sheets and load them via the GlobalDecorator. Each component could then
style its own columns.


Chris Howe wrote:

> Also, revision 510681..
>
> .left-border{...
> }
>
> I thought we were trying to move away from using the style as a
> descriptor of classes and id
>
> my understanding is that the preference is for the class name to
> describe the content to be decorated, not the decoration.
>
> --- Adrian Crum <[hidden email]> wrote:
>
>
>> From the commit log - "gave the main content area a ID tag"
>>
>>I have no issues with giving a <div> element an id, but looking at
>>the
>>GlobalDecorator I see this code:
>>
>><container style="contentarea">
>>     <container id="column-container">
>>       ...
>>     </container>
>></container>
>>
>>Since nothing will ever be inserted between the two containers, why
>>do we need
>>two of them? This seems redundant. Why can't the "contentarea"
>>contain columns?
>>
>>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: SVN Revision 510680

Adrian Crum
Adrian Crum wrote:
> A better way to handle multi-column layout would be to have
> component-specific style sheets and load them via the GlobalDecorator.

I meant load them via the layoutSettings.styleSheets[] array.