Secure URLs question

[Jacques Le Roux]

Not sure how to deal with that also

<link text="${uiLabelMap.ContentGoToFind}" target="CMSContentFind?VIEW_INDEX=${CMSContentFindViewIndex}&amp;${CMSContentFindQueryString}" style="tabletext"/>

Jacques

[David E Jones-3]

This is kind of a bad pattern since it puts presentation-specific code  
in the data preparation, ie the CMSContentFindQueryString variable is  
a presentation-specific parameter string that is prepared in a the  
data preparation code. While not a terrible thing to do, it does  
reduce reusability and complicates things like this.

The best solution is probably to find the code that maintains the  
"CMSContentFindQueryString" field, and then put the necessary  
parameters in this link. It may be that the field is use to keep  
context for a chain of pages, which is a bit of a mess and while I've  
seen that sort of thing done in different places it's a bit error-
prone and there may be better approaches.

I guess in other words, find out of the parameters are necessary and  
include what you can and then the rest... well we can either tear it  
apart and rewrite the stuff, or we might get lucky and whoever wrote  
will hop in... ;)

-David


On Apr 1, 2009, at 12:18 PM, Jacques Le Roux wrote:

> Not sure how to deal with that also
>
> <link text="${uiLabelMap.ContentGoToFind}" target="CMSContentFind?
> VIEW_INDEX=${CMSContentFindViewIndex}&amp;$
> {CMSContentFindQueryString}" style="tabletext"/>
>
> Jacques

[Jacques Le Roux]

This looks like an old stuff introduced with the content component. From recent Al's answers, I don't think he has time for that.
I will continue, ignoring it, and if I, or anybody else, find time we will fix it. Same for the other issue...

Thanks

Jacques

From: "David E Jones" <[hidden email]>

>
> This is kind of a bad pattern since it puts presentation-specific code  in the data preparation, ie the CMSContentFindQueryString
> variable is  a presentation-specific parameter string that is prepared in a the  data preparation code. While not a terrible thing
> to do, it does  reduce reusability and complicates things like this.
>
> The best solution is probably to find the code that maintains the  "CMSContentFindQueryString" field, and then put the necessary
> parameters in this link. It may be that the field is use to keep  context for a chain of pages, which is a bit of a mess and while
> I've  seen that sort of thing done in different places it's a bit error- prone and there may be better approaches.
>
> I guess in other words, find out of the parameters are necessary and  include what you can and then the rest... well we can either
> tear it  apart and rewrite the stuff, or we might get lucky and whoever wrote  will hop in... ;)
>
> -David
>
>
> On Apr 1, 2009, at 12:18 PM, Jacques Le Roux wrote:
>
>> Not sure how to deal with that also
>>
>> <link text="${uiLabelMap.ContentGoToFind}" target="CMSContentFind? VIEW_INDEX=${CMSContentFindViewIndex}&amp;$
>> {CMSContentFindQueryString}" style="tabletext"/>
>>
>> Jacques
>

[Gil Portenseigne]

During a SFA contact creation i tried to use the link "Go Back", leading to an
error.

To correct this :


Index: applications/marketing/webapp/sfa/WEB-INF/controller.xml
===================================================================
--- applications/marketing/webapp/sfa/WEB-INF/controller.xml (revision 761579)
+++ applications/marketing/webapp/sfa/WEB-INF/controller.xml (working copy)
@@ -174,6 +174,10 @@
         <event type="service" invoke="createContact"/>
         <response name="success" type="view" value="viewprofile"/>
     </request-map>
+    <request-map uri="backHome">
+        <security https="true" auth="true" />
+        <response name="success" type="view" value="CreateContact" />
+    </request-map>
     
     <!-- Forecast Requests -->
     <request-map uri="FindSalesForecast">

Thanks

Gil PORTENSEIGNE

[hans_bakker]

could it be you are not using the latest from svn?...this was corrected
a few days ago.....

Regards,
Hans

On Fri, 2009-04-03 at 11:34 +0200, gil portenseigne wrote:

> During a SFA contact creation i tried to use the link "Go Back", leading to an
> error.
>
> To correct this :
>
>
> Index: applications/marketing/webapp/sfa/WEB-INF/controller.xml
> ===================================================================
> --- applications/marketing/webapp/sfa/WEB-INF/controller.xml (revision 761579)
> +++ applications/marketing/webapp/sfa/WEB-INF/controller.xml (working copy)
> @@ -174,6 +174,10 @@
>          <event type="service" invoke="createContact"/>
>          <response name="success" type="view" value="viewprofile"/>
>      </request-map>
> +    <request-map uri="backHome">
> +        <security https="true" auth="true" />
> +        <response name="success" type="view" value="CreateContact" />
> +    </request-map>
>      
>      <!-- Forecast Requests -->
>      <request-map uri="FindSalesForecast">
>
> Thanks
>
> Gil PORTENSEIGNE

--
Antwebsystems.com: Quality OFBiz services for competitive rates

[Gil Portenseigne]

Normally, i am using the latest of the svn... , i have made an update, and
tried again. I found the same error, so i will try to explain it more
precisely :

After creating a contact in the sfa module
(https://localhost:8443/sfa/control/createContact) I manage to create contact
information... but the link found here (Go back) call
https://localhost:8443/sfa/control/backHome, and this backHome is not define in
the SFA controller... That's why i proposed to add it in the controller.

Are you sure that's the bug you are talking about ?

(Sorry, but these are my first steps in ofbiz project)

Regards,

Gil

[hans_bakker]

Hi Gil,

have a look at the top of the controller file there you see that the
controller file from 'common' is included, there you will find
backhome.....

i updated the controller file from sfa so it is using the request
viewprofile from party (also included) where the home location is
saved....what was not happening in this case....

thanks for reporting,

Regards,
Hans

On Mon, 2009-04-06 at 10:18 +0200, gil portenseigne wrote:

> Normally, i am using the latest of the svn... , i have made an update, and
> tried again. I found the same error, so i will try to explain it more
> precisely :
>
> After creating a contact in the sfa module
> (https://localhost:8443/sfa/control/createContact) I manage to create contact
> information... but the link found here (Go back) call
> https://localhost:8443/sfa/control/backHome, and this backHome is not define in
> the SFA controller... That's why i proposed to add it in the controller.
>
> Are you sure that's the bug you are talking about ?
>
> (Sorry, but these are my first steps in ofbiz project)
>
> Regards,
>
> Gil

--
Antwebsystems.com: Quality OFBiz services for competitive rates

[Gil Portenseigne]

Hi Hans,

Ok, I didn't see the include controller files.... now I understand how that
works with the home location.

thank you for your explanation !

Gil