Serious flaw in Mini-language <call-service> element

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Serious flaw in Mini-language <call-service> element

Adrian Crum-3
While overhauling the Mini-language <call-service> element, I discovered
a serious bug.

In CallService.java, line 203 has this:

if (UtilValidate.isEmpty(this.requireNewTransactionStr) &&
this.transactionTimeout < 0) {

The problem is, requireNewTransactionStr is initialized from the
"require-new-transaction" attribute, and the schema provides a default
value of "false" - so the expression in line 203 ALWAYS evaluates to false.

I fixed the bug by removing the if-else block and just use the else
portion - which was the only part that worked.

-Adrian