ShipmentReceipt potential bugs and potential enhancements proposal

[Christian Carlow-OFBizzer]

When a ShipmentReceipt is created, an AcctgTrans is also created with
the shipmentId field set but not the receiptId.  Should the
AcctgTrans.receiptId also be set since it exists?

Also, when a ShipmentReceipt is cancelled, no AcctgTrans and
corresponding debit/credit AcctgTransEntry records are created. Should
cancelling ShipmentReceipt also trigger AcctgTrans and AcctgTransEntry
creation?

Also, does it make sense add an enhancement to allow the ShipmentReceipt
quantityAccepted and quantityRejected fields to be altered?  Sometimes
quantityRejected is not known until the shipment quantity is received in
full using quantityAccepted then stock moved to a location that
evaluates for rejects.  If the location determines rejects, shouldn't it
be allowed to deduct ShipmentReceipt quantityAccepted and add
quantityRejected?  If so, can it be assumed altering should also trigger
the creation of AcctgTrans and AcctgTransEntry records?

I already asked about ShipmentReceipt modifications back when first
joining the community:
http://ofbiz.135035.n4.nabble.com/How-to-modify-received-and-rejected-quantities-of-shipment-receipts-td4648430.html

In the post, Pierre suggested creating a return instead of altering the
ShipmentReceipt but neither ReturnItem nor the other return entities
make reference to the ShipmentReceipt to which it is supposed to apply.  
If returns are the proper way of handling rejected quantity determined
after ShipmentReceipt, shouldn't some return entity like ReturnItem make
reference to the ShipmentReceipt entity so that the rejected quantity
can be determined?

Waiting for community feedback before creating JIRAs.

[Jacques Le Roux]

HI Christian,

What is the situation here?

Jacques

Le 24/08/2014 02:17, Christian Carlow a écrit :

> When a ShipmentReceipt is created, an AcctgTrans is also created with the shipmentId field set but not the receiptId.  Should the
> AcctgTrans.receiptId also be set since it exists?
>
> Also, when a ShipmentReceipt is cancelled, no AcctgTrans and corresponding debit/credit AcctgTransEntry records are created. Should cancelling
> ShipmentReceipt also trigger AcctgTrans and AcctgTransEntry creation?
>
> Also, does it make sense add an enhancement to allow the ShipmentReceipt quantityAccepted and quantityRejected fields to be altered?  Sometimes
> quantityRejected is not known until the shipment quantity is received in full using quantityAccepted then stock moved to a location that evaluates
> for rejects.  If the location determines rejects, shouldn't it be allowed to deduct ShipmentReceipt quantityAccepted and add quantityRejected?  If
> so, can it be assumed altering should also trigger the creation of AcctgTrans and AcctgTransEntry records?
>
> I already asked about ShipmentReceipt modifications back when first joining the community:
> http://ofbiz.135035.n4.nabble.com/How-to-modify-received-and-rejected-quantities-of-shipment-receipts-td4648430.html
>
> In the post, Pierre suggested creating a return instead of altering the ShipmentReceipt but neither ReturnItem nor the other return entities make
> reference to the ShipmentReceipt to which it is supposed to apply.  If returns are the proper way of handling rejected quantity determined after
> ShipmentReceipt, shouldn't some return entity like ReturnItem make reference to the ShipmentReceipt entity so that the rejected quantity can be
> determined?
>
> Waiting for community feedback before creating JIRAs.
>
>
>
>

[Christian Carlow-OFBizzer]

Hey Jacques,

Sorry, missed this back in January.  No progress has been made on these
issues but I do need the ShipmentReceipt to ReturnItem association
immediately.  I'll create a JIRA for further discussion.

The first part still seems relevant as well.  AcctgTrans are created
when ShipmentReceipts are created but none are created to undo if
ShipmentReceipt is cancelled.

As for allowing ShipmentReceipt quantity fields to be updated after
creation, Pierre's suggestion to use the Return entities seems the best
approach so it can be disregarded as an issue.

On Wed, 2015-01-07 at 22:40 +0100, Jacques Le Roux wrote:

> HI Christian,
>
> What is the situation here?
>
> Jacques
>
> Le 24/08/2014 02:17, Christian Carlow a écrit :
> > When a ShipmentReceipt is created, an AcctgTrans is also created with the shipmentId field set but not the receiptId.  Should the
> > AcctgTrans.receiptId also be set since it exists?
> >
> > Also, when a ShipmentReceipt is cancelled, no AcctgTrans and corresponding debit/credit AcctgTransEntry records are created. Should cancelling
> > ShipmentReceipt also trigger AcctgTrans and AcctgTransEntry creation?
> >
> > Also, does it make sense add an enhancement to allow the ShipmentReceipt quantityAccepted and quantityRejected fields to be altered?  Sometimes
> > quantityRejected is not known until the shipment quantity is received in full using quantityAccepted then stock moved to a location that evaluates
> > for rejects.  If the location determines rejects, shouldn't it be allowed to deduct ShipmentReceipt quantityAccepted and add quantityRejected?  If
> > so, can it be assumed altering should also trigger the creation of AcctgTrans and AcctgTransEntry records?
> >
> > I already asked about ShipmentReceipt modifications back when first joining the community:
> > http://ofbiz.135035.n4.nabble.com/How-to-modify-received-and-rejected-quantities-of-shipment-receipts-td4648430.html
> >
> > In the post, Pierre suggested creating a return instead of altering the ShipmentReceipt but neither ReturnItem nor the other return entities make
> > reference to the ShipmentReceipt to which it is supposed to apply.  If returns are the proper way of handling rejected quantity determined after
> > ShipmentReceipt, shouldn't some return entity like ReturnItem make reference to the ShipmentReceipt entity so that the rejected quantity can be
> > determined?
> >
> > Waiting for community feedback before creating JIRAs.
> >
> >
> >
> >