Shipping returns broken?

[Ean Schuessler]

I'm trying to process vendor returns using, approximately, revision
811564. It looks like the Google Checkout SECAS in special purpose
attempt to run when you change a shipment to "packed". That Google
Checkout code makes the assumption that you can get an order id from
each item in the shipment. Since this is a return, not an order, there
is no order id and the code fails with a null pointer exception.

What frightens me the most about this is that its been broken for
months. Is anyone processing returns off a recent (ie. in the last 10
months) version of OFBiz?

--
Ean Schuessler, CTO
[hidden email]
214-720-0700 x 315
Brainfood, Inc.
http://www.brainfood.com

[Tim Ruppert]

I haven't looked at it myself recently Ean, but I'm pretty darn sure that we are processing returns, thru Google Checkout, on a version that's at least branched from around the beginning of December.

Cheers,
Ruppert

On Feb 4, 2010, at 5:00 PM, Ean Schuessler wrote:

> I'm trying to process vendor returns using, approximately, revision
> 811564. It looks like the Google Checkout SECAS in special purpose
> attempt to run when you change a shipment to "packed". That Google
> Checkout code makes the assumption that you can get an order id from
> each item in the shipment. Since this is a return, not an order, there
> is no order id and the code fails with a null pointer exception.
>
> What frightens me the most about this is that its been broken for
> months. Is anyone processing returns off a recent (ie. in the last 10
> months) version of OFBiz?
>
> --
> Ean Schuessler, CTO
> [hidden email]
> 214-720-0700 x 315
> Brainfood, Inc.
> http://www.brainfood.com
>

[Adam Heath-2]

Tim Ruppert wrote:
> I haven't looked at it myself recently Ean, but I'm pretty darn sure that we are processing returns, thru Google Checkout, on a version that's at least branched from around the beginning of December.

Try processing a vendor return, that has a shipment attached, but that
isn't connected to googlecheckout, with specialpurpose/googlecheckout
available as a component.  You'll get a NPE, because googlecheckout
assumes an order item is available.

This is due to the googlecheckout component adding an eca that
*always* runs when an Shipment changes status, and then in
sendItemsShipped, assumes anc order is attached to the shipment; this
isn't the case when a Return is being processed.  So, this would fail
in *all* situations when googlecheckout is available as a component,
and you aren't actually using a component.

[Ean Schuessler]

Adam Heath wrote:

> Tim Ruppert wrote:
>  
>> I haven't looked at it myself recently Ean, but I'm pretty darn sure that we are processing returns, thru Google Checkout, on a version that's at least branched from around the beginning of December.
>>    
> Try processing a vendor return, that has a shipment attached, but that
> isn't connected to googlecheckout, with specialpurpose/googlecheckout
> available as a component.  You'll get a NPE, because googlecheckout
> assumes an order item is available.
>
> This is due to the googlecheckout component adding an eca that
> *always* runs when an Shipment changes status, and then in
> sendItemsShipped, assumes anc order is attached to the shipment; this
> isn't the case when a Return is being processed.  So, this would fail
> in *all* situations when googlecheckout is available as a component,
> and you aren't actually using a component.
>  

Basically right. You have to attempt to generate an outgoing shipment

off a vendor return. This can't work because the GoogleCheckout code
tries to look up the order for the shipment, which doesn't exist in this
case. Tim, if you have a fix for that can you check it in?

--
Ean Schuessler, CTO
[hidden email]
214-720-0700 x 315
Brainfood, Inc.
http://www.brainfood.com

[Tim Ruppert]

I'll ask around and see if we're doing exactly this workflow.  I know for a fact that we are utilizing Google Checkout and returns are being processed no problem.

Cheers,
Ruppert
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595

On Feb 5, 2010, at 2:18 PM, Ean Schuessler wrote:

> Adam Heath wrote:
>> Tim Ruppert wrote:
>>
>>> I haven't looked at it myself recently Ean, but I'm pretty darn sure that we are processing returns, thru Google Checkout, on a version that's at least branched from around the beginning of December.
>>>
>> Try processing a vendor return, that has a shipment attached, but that
>> isn't connected to googlecheckout, with specialpurpose/googlecheckout
>> available as a component.  You'll get a NPE, because googlecheckout
>> assumes an order item is available.
>>
>> This is due to the googlecheckout component adding an eca that
>> *always* runs when an Shipment changes status, and then in
>> sendItemsShipped, assumes anc order is attached to the shipment; this
>> isn't the case when a Return is being processed.  So, this would fail
>> in *all* situations when googlecheckout is available as a component,
>> and you aren't actually using a component.
>>
> Basically right. You have to attempt to generate an outgoing shipment
> off a vendor return. This can't work because the GoogleCheckout code
> tries to look up the order for the shipment, which doesn't exist in this
> case. Tim, if you have a fix for that can you check it in?
>
> --
> Ean Schuessler, CTO
> [hidden email]
> 214-720-0700 x 315
> Brainfood, Inc.
> http://www.brainfood.com
>

[Adam Heath-2]

Tim Ruppert wrote:
> I'll ask around and see if we're doing exactly this workflow.  I know for a fact that we are utilizing Google Checkout and returns are being processed no problem.

Nonono.  Googlecheckout is not being used.  It's just existing at
specialpurpose/googlecheckout.

>
> Cheers,
> Ruppert
> --
> Tim Ruppert
> HotWax Media
> http://www.hotwaxmedia.com
>
> o:801.649.6594
> f:801.649.6595
>
> On Feb 5, 2010, at 2:18 PM, Ean Schuessler wrote:
>
>> Adam Heath wrote:
>>> Tim Ruppert wrote:
>>>
>>>> I haven't looked at it myself recently Ean, but I'm pretty darn sure that we are processing returns, thru Google Checkout, on a version that's at least branched from around the beginning of December.
>>>>
>>> Try processing a vendor return, that has a shipment attached, but that
>>> isn't connected to googlecheckout, with specialpurpose/googlecheckout
>>> available as a component.  You'll get a NPE, because googlecheckout
>>> assumes an order item is available.
>>>
>>> This is due to the googlecheckout component adding an eca that
>>> *always* runs when an Shipment changes status, and then in
>>> sendItemsShipped, assumes anc order is attached to the shipment; this
>>> isn't the case when a Return is being processed.  So, this would fail
>>> in *all* situations when googlecheckout is available as a component,
>>> and you aren't actually using a component.
>>>
>> Basically right. You have to attempt to generate an outgoing shipment
>> off a vendor return. This can't work because the GoogleCheckout code
>> tries to look up the order for the shipment, which doesn't exist in this
>> case. Tim, if you have a fix for that can you check it in?
>>
>> --
>> Ean Schuessler, CTO
>> [hidden email]
>> 214-720-0700 x 315
>> Brainfood, Inc.
>> http://www.brainfood.com
>>
>

[Tim Ruppert]

Ok - thanks - I was misunderstanding - thanks for the clarification.

Cheers,
Ruppert

On Feb 5, 2010, at 9:30 PM, Adam Heath wrote:

> Tim Ruppert wrote:
>> I'll ask around and see if we're doing exactly this workflow.  I know for a fact that we are utilizing Google Checkout and returns are being processed no problem.
>
> Nonono.  Googlecheckout is not being used.  It's just existing at
> specialpurpose/googlecheckout.
>
>>
>> Cheers,
>> Ruppert
>> --
>> Tim Ruppert
>> HotWax Media
>> http://www.hotwaxmedia.com
>>
>> o:801.649.6594
>> f:801.649.6595
>>
>> On Feb 5, 2010, at 2:18 PM, Ean Schuessler wrote:
>>
>>> Adam Heath wrote:
>>>> Tim Ruppert wrote:
>>>>
>>>>> I haven't looked at it myself recently Ean, but I'm pretty darn sure that we are processing returns, thru Google Checkout, on a version that's at least branched from around the beginning of December.
>>>>>
>>>> Try processing a vendor return, that has a shipment attached, but that
>>>> isn't connected to googlecheckout, with specialpurpose/googlecheckout
>>>> available as a component.  You'll get a NPE, because googlecheckout
>>>> assumes an order item is available.
>>>>
>>>> This is due to the googlecheckout component adding an eca that
>>>> *always* runs when an Shipment changes status, and then in
>>>> sendItemsShipped, assumes anc order is attached to the shipment; this
>>>> isn't the case when a Return is being processed.  So, this would fail
>>>> in *all* situations when googlecheckout is available as a component,
>>>> and you aren't actually using a component.
>>>>
>>> Basically right. You have to attempt to generate an outgoing shipment
>>> off a vendor return. This can't work because the GoogleCheckout code
>>> tries to look up the order for the shipment, which doesn't exist in this
>>> case. Tim, if you have a fix for that can you check it in?
>>>
>>> --
>>> Ean Schuessler, CTO
>>> [hidden email]
>>> 214-720-0700 x 315
>>> Brainfood, Inc.
>>> http://www.brainfood.com
>>>
>>
>

[Mridul Pathak-2]

I tried it but was not able to reproduce it.  I think I am not  
following the steps correctly.  It would be really helpful if you can  
explain the exact steps to reproduce it.

--
Thanks & Regards,
Mridul Pathak


On Feb 5, 2010, at 2:18 PM, Ean Schuessler wrote:

> Adam Heath wrote:
>> Tim Ruppert wrote:
>>
>>> I haven't looked at it myself recently Ean, but I'm pretty darn  
>>> sure that we are processing returns, thru Google Checkout, on a  
>>> version that's at least branched from around the beginning of  
>>> December.
>>>
>> Try processing a vendor return, that has a shipment attached, but  
>> that
>> isn't connected to googlecheckout, with specialpurpose/googlecheckout
>> available as a component.  You'll get a NPE, because googlecheckout
>> assumes an order item is available.
>>
>> This is due to the googlecheckout component adding an eca that
>> *always* runs when an Shipment changes status, and then in
>> sendItemsShipped, assumes anc order is attached to the shipment; this
>> isn't the case when a Return is being processed.  So, this would fail
>> in *all* situations when googlecheckout is available as a component,
>> and you aren't actually using a component.
>>
> Basically right. You have to attempt to generate an outgoing shipment
> off a vendor return. This can't work because the GoogleCheckout code
> tries to look up the order for the shipment, which doesn't exist in  
> this
> case. Tim, if you have a fix for that can you check it in?
>
> --
> Ean Schuessler, CTO
> [hidden email]
> 214-720-0700 x 315
> Brainfood, Inc.
> http://www.brainfood.com
>

[Ean Schuessler]

Mridul Pathak wrote:
> I tried it but was not able to reproduce it.  I think I am not
> following the steps correctly.  It would be really helpful if you can
> explain the exact steps to reproduce it.
Did you generate a shipment from the return? You will have to create a
return, accept it and then create a shipment from the return. Then try
running that shipment through its pick, pack, ship routine.

--
Ean Schuessler, CTO
[hidden email]
214-720-0700 x 315
Brainfood, Inc.
http://www.brainfood.com