Hello All,
In getInvoiceAddressByType() method of InvoiceWorker, it is fetching address from PartyContactWithPurpose in case of empty InvoiceContactMech. This method calls from two methods getBillToAddress() and getSendFromAddress() of same class. Here, my concerns are: - There is no way to check that returned address is invoice associated address or party address. It is misleading. - There is no control of user to get the address linked to invoice only. My proposals are: 1). System should return party address only if user really demand for it. We can override method and pass additional parameter for achieving this. 2). We can remove PartyContactMech fetching logic from method by considering that user don't want party addresses as Invoice address. This will help user to know the exact source of address. Please let me know your thoughts on this. -- Thanks & Regards --- Arun Patidar Manager, Enterprise Software Development HotWax Systems www.hotwaxsystems.com |
Agree with overriding the method signature. Just one note is to keep the
existing behavior as default. That means, if developer use the same method then it should behave how it behaves right now. Regards, -- Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Wed, May 11, 2016 at 4:52 PM, Arun Patidar < [hidden email]> wrote: > Hello All, > > In getInvoiceAddressByType() method of InvoiceWorker, it is fetching > address from PartyContactWithPurpose in case of empty InvoiceContactMech. > This method calls from two methods getBillToAddress() and > getSendFromAddress() of same class. > > Here, my concerns are: > - There is no way to check that returned address is invoice associated > address or party address. It is misleading. > - There is no control of user to get the address linked to invoice only. > > My proposals are: > 1). System should return party address only if user really demand for it. > We can override method and pass additional parameter for achieving this. > 2). We can remove PartyContactMech fetching logic from method by > considering that user don't want party addresses as Invoice address. > > This will help user to know the exact source of address. Please let me > know your thoughts on this. > > -- > Thanks & Regards > --- > Arun Patidar > Manager, Enterprise Software Development > HotWax Systems > www.hotwaxsystems.com > > |
Administrator
|
I agree with Rishi,
Jacques Le 12/05/2016 à 16:23, Rishi Solanki a écrit : > Agree with overriding the method signature. Just one note is to keep the > existing behavior as default. That means, if developer use the same method > then it should behave how it behaves right now. > > > Regards, > -- > Rishi Solanki > Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > > On Wed, May 11, 2016 at 4:52 PM, Arun Patidar < > [hidden email]> wrote: > >> Hello All, >> >> In getInvoiceAddressByType() method of InvoiceWorker, it is fetching >> address from PartyContactWithPurpose in case of empty InvoiceContactMech. >> This method calls from two methods getBillToAddress() and >> getSendFromAddress() of same class. >> >> Here, my concerns are: >> - There is no way to check that returned address is invoice associated >> address or party address. It is misleading. >> - There is no control of user to get the address linked to invoice only. >> >> My proposals are: >> 1). System should return party address only if user really demand for it. >> We can override method and pass additional parameter for achieving this. >> 2). We can remove PartyContactMech fetching logic from method by >> considering that user don't want party addresses as Invoice address. >> >> This will help user to know the exact source of address. Please let me >> know your thoughts on this. >> >> -- >> Thanks & Regards >> --- >> Arun Patidar >> Manager, Enterprise Software Development >> HotWax Systems >> www.hotwaxsystems.com >> >> |
Thanks Jacques and Rishi for your input and confirmation. I will take
care of your suggestions. Thanks & Regards --- Arun Patidar Manager, Enterprise Software Development HotWax Systems www.hotwaxsystems.com On Thursday 12 May 2016 09:03 PM, Jacques Le Roux wrote: > I agree with Rishi, > > Jacques > > > Le 12/05/2016 à 16:23, Rishi Solanki a écrit : >> Agree with overriding the method signature. Just one note is to keep the >> existing behavior as default. That means, if developer use the same >> method >> then it should behave how it behaves right now. >> >> >> Regards, >> -- >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Wed, May 11, 2016 at 4:52 PM, Arun Patidar < >> [hidden email]> wrote: >> >>> Hello All, >>> >>> In getInvoiceAddressByType() method of InvoiceWorker, it is fetching >>> address from PartyContactWithPurpose in case of empty >>> InvoiceContactMech. >>> This method calls from two methods getBillToAddress() and >>> getSendFromAddress() of same class. >>> >>> Here, my concerns are: >>> - There is no way to check that returned address is invoice associated >>> address or party address. It is misleading. >>> - There is no control of user to get the address linked to invoice >>> only. >>> >>> My proposals are: >>> 1). System should return party address only if user really demand >>> for it. >>> We can override method and pass additional parameter for achieving >>> this. >>> 2). We can remove PartyContactMech fetching logic from method by >>> considering that user don't want party addresses as Invoice address. >>> >>> This will help user to know the exact source of address. Please let me >>> know your thoughts on this. >>> >>> -- >>> Thanks & Regards >>> --- >>> Arun Patidar >>> Manager, Enterprise Software Development >>> HotWax Systems >>> www.hotwaxsystems.com >>> >>> > > |
Free forum by Nabble | Edit this page |