Strange double posting behaviour on IE7

[Scott Gray]

Hi All,

I've come across a bug where forms are being double posted when using IE7,
the strange thing is I can't replicate it on the demo server (
https://demo.hotwaxmedia.com/partymgr/control/main).

Is the demo server running the same code as the trunk?

Can anybody else confirm the double posting behaviour for me?  Easy way is
to create a new party group and then find the party group by its group name
(using IE7 of course)

Thanks
Scott

[Kane Lo]

Yes, the IE6 and IE7 are double posting. I have created an issue b4 on Jira.
It is becos of the IE7 will submit the post data, regardless the job should
be passed to a javascript. And the javascript also post the data. Thus it
becomes double post. I have a patch inside the Jira, to check if it is IE7,
then the javascript will stop post the data.

----- Original Message -----
From: "Scott Gray" <[hidden email]>
To: <[hidden email]>
Sent: Saturday, July 21, 2007 10:02 AM
Subject: Strange double posting behaviour on IE7

> Hi All,
>
> I've come across a bug where forms are being double posted when using IE7,
> the strange thing is I can't replicate it on the demo server (
> https://demo.hotwaxmedia.com/partymgr/control/main).
>
> Is the demo server running the same code as the trunk?
>
> Can anybody else confirm the double posting behaviour for me?  Easy way is
> to create a new party group and then find the party group by its group
> name
> (using IE7 of course)
>
> Thanks
> Scott
>

[Scott Gray]

Thanks Kane,

Do you we need the javascript to perform a submit?  I tested in Firefox
2.0.0.5 and the forms work fine without it, is anyone aware of any browsers
that require it?

Thanks
Scott

On 21/07/07, Kane Lo <[hidden email]> wrote:

>
> Yes, the IE6 and IE7 are double posting. I have created an issue b4 on
> Jira.
> It is becos of the IE7 will submit the post data, regardless the job
> should
> be passed to a javascript. And the javascript also post the data. Thus it
> becomes double post. I have a patch inside the Jira, to check if it is
> IE7,
> then the javascript will stop post the data.
>
> ----- Original Message -----
> From: "Scott Gray" <[hidden email]>
> To: <[hidden email]>
> Sent: Saturday, July 21, 2007 10:02 AM
> Subject: Strange double posting behaviour on IE7
>
>
> > Hi All,
> >
> > I've come across a bug where forms are being double posted when using
> IE7,
> > the strange thing is I can't replicate it on the demo server (
> > https://demo.hotwaxmedia.com/partymgr/control/main).
> >
> > Is the demo server running the same code as the trunk?
> >
> > Can anybody else confirm the double posting behaviour for me?  Easy way
> is
> > to create a new party group and then find the party group by its group
> > name
> > (using IE7 of course)
> >
> > Thanks
> > Scott
> >
>
>

[David E Jones]

This probably goes back to rev 532409 and the discussion around it, back in April.

I was opposed to that javascript change, and my guess is this bug in IE is a direct result of it.

I just changed this in SVN rev 558253.

What we need now is a number of people to test this to make sure it is working properly, and so that no one feels the desire to change it back again.

-David


Scott Gray wrote:

> Thanks Kane,
>
> Do you we need the javascript to perform a submit?  I tested in Firefox
> 2.0.0.5 and the forms work fine without it, is anyone aware of any browsers
> that require it?
>
> Thanks
> Scott
>
> On 21/07/07, Kane Lo <[hidden email]> wrote:
>>
>> Yes, the IE6 and IE7 are double posting. I have created an issue b4 on
>> Jira.
>> It is becos of the IE7 will submit the post data, regardless the job
>> should
>> be passed to a javascript. And the javascript also post the data. Thus it
>> becomes double post. I have a patch inside the Jira, to check if it is
>> IE7,
>> then the javascript will stop post the data.
>>
>> ----- Original Message -----
>> From: "Scott Gray" <[hidden email]>
>> To: <[hidden email]>
>> Sent: Saturday, July 21, 2007 10:02 AM
>> Subject: Strange double posting behaviour on IE7
>>
>>
>> > Hi All,
>> >
>> > I've come across a bug where forms are being double posted when using
>> IE7,
>> > the strange thing is I can't replicate it on the demo server (
>> > https://demo.hotwaxmedia.com/partymgr/control/main).
>> >
>> > Is the demo server running the same code as the trunk?
>> >
>> > Can anybody else confirm the double posting behaviour for me?  Easy way
>> is
>> > to create a new party group and then find the party group by its group
>> > name
>> > (using IE7 of course)
>> >
>> > Thanks
>> > Scott
>> >
>>
>>
>

[Scott Gray]

Thanks David, looks like the bulk of browsers are covered we'll just have to
wait and see on the rest.

Regards
Scott

On 21/07/07, David E Jones <[hidden email]> wrote:

>
>
> This probably goes back to rev 532409 and the discussion around it, back
> in April.
>
> I was opposed to that javascript change, and my guess is this bug in IE is
> a direct result of it.
>
> I just changed this in SVN rev 558253.
>
> What we need now is a number of people to test this to make sure it is
> working properly, and so that no one feels the desire to change it back
> again.
>
> -David
>
>
> Scott Gray wrote:
> > Thanks Kane,
> >
> > Do you we need the javascript to perform a submit?  I tested in Firefox
> > 2.0.0.5 and the forms work fine without it, is anyone aware of any
> browsers
> > that require it?
> >
> > Thanks
> > Scott
> >
> > On 21/07/07, Kane Lo <[hidden email]> wrote:
> >>
> >> Yes, the IE6 and IE7 are double posting. I have created an issue b4 on
> >> Jira.
> >> It is becos of the IE7 will submit the post data, regardless the job
> >> should
> >> be passed to a javascript. And the javascript also post the data. Thus
> it
> >> becomes double post. I have a patch inside the Jira, to check if it is
> >> IE7,
> >> then the javascript will stop post the data.
> >>
> >> ----- Original Message -----
> >> From: "Scott Gray" <[hidden email]>
> >> To: <[hidden email]>
> >> Sent: Saturday, July 21, 2007 10:02 AM
> >> Subject: Strange double posting behaviour on IE7
> >>
> >>
> >> > Hi All,
> >> >
> >> > I've come across a bug where forms are being double posted when using
> >> IE7,
> >> > the strange thing is I can't replicate it on the demo server (
> >> > https://demo.hotwaxmedia.com/partymgr/control/main).
> >> >
> >> > Is the demo server running the same code as the trunk?
> >> >
> >> > Can anybody else confirm the double posting behaviour for me?  Easy
> way
> >> is
> >> > to create a new party group and then find the party group by its
> group
> >> > name
> >> > (using IE7 of course)
> >> >
> >> > Thanks
> >> > Scott
> >> >
> >>
> >>
> >
>

[Scott Gray]

Oh Kane, I couldn't find your jira issue, is it still open and if so, could
you point me to it?

Thanks
Scott

On 21/07/07, Scott Gray <[hidden email]> wrote:

>
> Thanks David, looks like the bulk of browsers are covered we'll just have
> to wait and see on the rest.
>
> Regards
> Scott
>
> On 21/07/07, David E Jones <[hidden email]> wrote:
> >
> >
> > This probably goes back to rev 532409 and the discussion around it, back
> > in April.
> >
> > I was opposed to that javascript change, and my guess is this bug in IE
> > is a direct result of it.
> >
> > I just changed this in SVN rev 558253.
> >
> > What we need now is a number of people to test this to make sure it is
> > working properly, and so that no one feels the desire to change it back
> > again.
> >
> > -David
> >
> >
> > Scott Gray wrote:
> > > Thanks Kane,
> > >
> > > Do you we need the javascript to perform a submit?  I tested in
> > Firefox
> > > 2.0.0.5 and the forms work fine without it, is anyone aware of any
> > browsers
> > > that require it?
> > >
> > > Thanks
> > > Scott
> > >
> > > On 21/07/07, Kane Lo <[hidden email]> wrote:
> > >>
> > >> Yes, the IE6 and IE7 are double posting. I have created an issue b4
> > on
> > >> Jira.
> > >> It is becos of the IE7 will submit the post data, regardless the job
> > >> should
> > >> be passed to a javascript. And the javascript also post the data.
> > Thus it
> > >> becomes double post. I have a patch inside the Jira, to check if it
> > is
> > >> IE7,
> > >> then the javascript will stop post the data.
> > >>
> > >> ----- Original Message -----
> > >> From: "Scott Gray" <[hidden email] >
> > >> To: <[hidden email]>
> > >> Sent: Saturday, July 21, 2007 10:02 AM
> > >> Subject: Strange double posting behaviour on IE7
> > >>
> > >>
> > >> > Hi All,
> > >> >
> > >> > I've come across a bug where forms are being double posted when
> > using
> > >> IE7,
> > >> > the strange thing is I can't replicate it on the demo server (
> > >> > https://demo.hotwaxmedia.com/partymgr/control/main).
> > >> >
> > >> > Is the demo server running the same code as the trunk?
> > >> >
> > >> > Can anybody else confirm the double posting behaviour for me?  Easy
> > way
> > >> is
> > >> > to create a new party group and then find the party group by its
> > group
> > >> > name
> > >> > (using IE7 of course)
> > >> >
> > >> > Thanks
> > >> > Scott
> > >> >
> > >>
> > >>
> > >
> >
>
>

[Jacques Le Roux]

Hi Scott,

https://issues.apache.org/jira/browse/OFBIZ-978

Jacques

De : "Scott Gray" <[hidden email]>

> Oh Kane, I couldn't find your jira issue, is it still open and if so, could
> you point me to it?
>
> Thanks
> Scott
>
> On 21/07/07, Scott Gray <[hidden email]> wrote:
> >
> > Thanks David, looks like the bulk of browsers are covered we'll just have
> > to wait and see on the rest.
> >
> > Regards
> > Scott
> >
> > On 21/07/07, David E Jones <[hidden email]> wrote:
> > >
> > >
> > > This probably goes back to rev 532409 and the discussion around it, back
> > > in April.
> > >
> > > I was opposed to that javascript change, and my guess is this bug in IE
> > > is a direct result of it.
> > >
> > > I just changed this in SVN rev 558253.
> > >
> > > What we need now is a number of people to test this to make sure it is
> > > working properly, and so that no one feels the desire to change it back
> > > again.
> > >
> > > -David
> > >
> > >
> > > Scott Gray wrote:
> > > > Thanks Kane,
> > > >
> > > > Do you we need the javascript to perform a submit?  I tested in
> > > Firefox
> > > > 2.0.0.5 and the forms work fine without it, is anyone aware of any
> > > browsers
> > > > that require it?
> > > >
> > > > Thanks
> > > > Scott
> > > >
> > > > On 21/07/07, Kane Lo <[hidden email]> wrote:
> > > >>
> > > >> Yes, the IE6 and IE7 are double posting. I have created an issue b4
> > > on
> > > >> Jira.
> > > >> It is becos of the IE7 will submit the post data, regardless the job
> > > >> should
> > > >> be passed to a javascript. And the javascript also post the data.
> > > Thus it
> > > >> becomes double post. I have a patch inside the Jira, to check if it
> > > is
> > > >> IE7,
> > > >> then the javascript will stop post the data.
> > > >>
> > > >> ----- Original Message -----
> > > >> From: "Scott Gray" <[hidden email] >
> > > >> To: <[hidden email]>
> > > >> Sent: Saturday, July 21, 2007 10:02 AM
> > > >> Subject: Strange double posting behaviour on IE7
> > > >>
> > > >>
> > > >> > Hi All,
> > > >> >
> > > >> > I've come across a bug where forms are being double posted when
> > > using
> > > >> IE7,
> > > >> > the strange thing is I can't replicate it on the demo server (
> > > >> > https://demo.hotwaxmedia.com/partymgr/control/main).
> > > >> >
> > > >> > Is the demo server running the same code as the trunk?
> > > >> >
> > > >> > Can anybody else confirm the double posting behaviour for me?  Easy
> > > way
> > > >> is
> > > >> > to create a new party group and then find the party group by its
> > > group
> > > >> > name
> > > >> > (using IE7 of course)
> > > >> >
> > > >> > Thanks
> > > >> > Scott
> > > >> >
> > > >>
> > > >>
> > > >
> > >
> >
> >
>

[Scott Gray]

Thanks Jacques, I've gone ahead and closed it.

Regards
Scott

On 21/07/07, Jacques Le Roux <[hidden email]> wrote:

>
> Hi Scott,
>
> https://issues.apache.org/jira/browse/OFBIZ-978
>
> Jacques
>
> De : "Scott Gray" <[hidden email]>
> > Oh Kane, I couldn't find your jira issue, is it still open and if so,
> could
> > you point me to it?
> >
> > Thanks
> > Scott
> >
> > On 21/07/07, Scott Gray <[hidden email]> wrote:
> > >
> > > Thanks David, looks like the bulk of browsers are covered we'll just
> have
> > > to wait and see on the rest.
> > >
> > > Regards
> > > Scott
> > >
> > > On 21/07/07, David E Jones <[hidden email]> wrote:
> > > >
> > > >
> > > > This probably goes back to rev 532409 and the discussion around it,
> back
> > > > in April.
> > > >
> > > > I was opposed to that javascript change, and my guess is this bug in
> IE
> > > > is a direct result of it.
> > > >
> > > > I just changed this in SVN rev 558253.
> > > >
> > > > What we need now is a number of people to test this to make sure it
> is
> > > > working properly, and so that no one feels the desire to change it
> back
> > > > again.
> > > >
> > > > -David
> > > >
> > > >
> > > > Scott Gray wrote:
> > > > > Thanks Kane,
> > > > >
> > > > > Do you we need the javascript to perform a submit?  I tested in
> > > > Firefox
> > > > > 2.0.0.5 and the forms work fine without it, is anyone aware of any
> > > > browsers
> > > > > that require it?
> > > > >
> > > > > Thanks
> > > > > Scott
> > > > >
> > > > > On 21/07/07, Kane Lo <[hidden email]> wrote:
> > > > >>
> > > > >> Yes, the IE6 and IE7 are double posting. I have created an issue
> b4
> > > > on
> > > > >> Jira.
> > > > >> It is becos of the IE7 will submit the post data, regardless the
> job
> > > > >> should
> > > > >> be passed to a javascript. And the javascript also post the data.
> > > > Thus it
> > > > >> becomes double post. I have a patch inside the Jira, to check if
> it
> > > > is
> > > > >> IE7,
> > > > >> then the javascript will stop post the data.
> > > > >>
> > > > >> ----- Original Message -----
> > > > >> From: "Scott Gray" <[hidden email] >
> > > > >> To: <[hidden email]>
> > > > >> Sent: Saturday, July 21, 2007 10:02 AM
> > > > >> Subject: Strange double posting behaviour on IE7
> > > > >>
> > > > >>
> > > > >> > Hi All,
> > > > >> >
> > > > >> > I've come across a bug where forms are being double posted when
> > > > using
> > > > >> IE7,
> > > > >> > the strange thing is I can't replicate it on the demo server (
> > > > >> > https://demo.hotwaxmedia.com/partymgr/control/main).
> > > > >> >
> > > > >> > Is the demo server running the same code as the trunk?
> > > > >> >
> > > > >> > Can anybody else confirm the double posting behaviour for
> me?  Easy
> > > > way
> > > > >> is
> > > > >> > to create a new party group and then find the party group by
> its
> > > > group
> > > > >> > name
> > > > >> > (using IE7 of course)
> > > > >> >
> > > > >> > Thanks
> > > > >> > Scott
> > > > >> >
> > > > >>
> > > > >>
> > > > >
> > > >
> > >
> > >
> >
>

[jonwimp]

I remember David Jones' objection to that change to javascript codes.

I commented on it before. The original codes (before the change in question) is correct, ie, the
javascript codes do NOT do a post. The change in question makes the javascript do a post.

I believe someone correctly corrected the submit function. And then, it was incorrectly reverted
to former incorrect codes.

I've been using the correct submit function (without javascript post) for months now, even before
the correct corrections came in (which happened to coincide and agree with my own corrections).
Works in both Firefox and IE.

Jonathon

David E Jones wrote:

>
> This probably goes back to rev 532409 and the discussion around it, back
> in April.
>
> I was opposed to that javascript change, and my guess is this bug in IE
> is a direct result of it.
>
> I just changed this in SVN rev 558253.
>
> What we need now is a number of people to test this to make sure it is
> working properly, and so that no one feels the desire to change it back
> again.
>
> -David
>
>
> Scott Gray wrote:
>> Thanks Kane,
>>
>> Do you we need the javascript to perform a submit?  I tested in Firefox
>> 2.0.0.5 and the forms work fine without it, is anyone aware of any
>> browsers
>> that require it?
>>
>> Thanks
>> Scott
>>
>> On 21/07/07, Kane Lo <[hidden email]> wrote:
>>>
>>> Yes, the IE6 and IE7 are double posting. I have created an issue b4 on
>>> Jira.
>>> It is becos of the IE7 will submit the post data, regardless the job
>>> should
>>> be passed to a javascript. And the javascript also post the data.
>>> Thus it
>>> becomes double post. I have a patch inside the Jira, to check if it is
>>> IE7,
>>> then the javascript will stop post the data.
>>>
>>> ----- Original Message -----
>>> From: "Scott Gray" <[hidden email]>
>>> To: <[hidden email]>
>>> Sent: Saturday, July 21, 2007 10:02 AM
>>> Subject: Strange double posting behaviour on IE7
>>>
>>>
>>> > Hi All,
>>> >
>>> > I've come across a bug where forms are being double posted when using
>>> IE7,
>>> > the strange thing is I can't replicate it on the demo server (
>>> > https://demo.hotwaxmedia.com/partymgr/control/main).
>>> >
>>> > Is the demo server running the same code as the trunk?
>>> >
>>> > Can anybody else confirm the double posting behaviour for me?  Easy
>>> way
>>> is
>>> > to create a new party group and then find the party group by its group
>>> > name
>>> > (using IE7 of course)
>>> >
>>> > Thanks
>>> > Scott
>>> >
>>>
>>>
>>
>
>

[Scott Gray]

Thanks for the recap Jonathon, I'm glad everything has gone well for you.

Regards
Scott

On 21/07/07, Jonathon -- Improov <[hidden email]> wrote:

>
> I remember David Jones' objection to that change to javascript codes.
>
> I commented on it before. The original codes (before the change in
> question) is correct, ie, the
> javascript codes do NOT do a post. The change in question makes the
> javascript do a post.
>
> I believe someone correctly corrected the submit function. And then, it
> was incorrectly reverted
> to former incorrect codes.
>
> I've been using the correct submit function (without javascript post) for
> months now, even before
> the correct corrections came in (which happened to coincide and agree with
> my own corrections).
> Works in both Firefox and IE.
>
> Jonathon
>
> David E Jones wrote:
> >
> > This probably goes back to rev 532409 and the discussion around it, back
> > in April.
> >
> > I was opposed to that javascript change, and my guess is this bug in IE
> > is a direct result of it.
> >
> > I just changed this in SVN rev 558253.
> >
> > What we need now is a number of people to test this to make sure it is
> > working properly, and so that no one feels the desire to change it back
> > again.
> >
> > -David
> >
> >
> > Scott Gray wrote:
> >> Thanks Kane,
> >>
> >> Do you we need the javascript to perform a submit?  I tested in Firefox
> >> 2.0.0.5 and the forms work fine without it, is anyone aware of any
> >> browsers
> >> that require it?
> >>
> >> Thanks
> >> Scott
> >>
> >> On 21/07/07, Kane Lo <[hidden email]> wrote:
> >>>
> >>> Yes, the IE6 and IE7 are double posting. I have created an issue b4 on
> >>> Jira.
> >>> It is becos of the IE7 will submit the post data, regardless the job
> >>> should
> >>> be passed to a javascript. And the javascript also post the data.
> >>> Thus it
> >>> becomes double post. I have a patch inside the Jira, to check if it is
> >>> IE7,
> >>> then the javascript will stop post the data.
> >>>
> >>> ----- Original Message -----
> >>> From: "Scott Gray" <[hidden email]>
> >>> To: <[hidden email]>
> >>> Sent: Saturday, July 21, 2007 10:02 AM
> >>> Subject: Strange double posting behaviour on IE7
> >>>
> >>>
> >>> > Hi All,
> >>> >
> >>> > I've come across a bug where forms are being double posted when
> using
> >>> IE7,
> >>> > the strange thing is I can't replicate it on the demo server (
> >>> > https://demo.hotwaxmedia.com/partymgr/control/main).
> >>> >
> >>> > Is the demo server running the same code as the trunk?
> >>> >
> >>> > Can anybody else confirm the double posting behaviour for me?  Easy
> >>> way
> >>> is
> >>> > to create a new party group and then find the party group by its
> group
> >>> > name
> >>> > (using IE7 of course)
> >>> >
> >>> > Thanks
> >>> > Scott
> >>> >
> >>>
> >>>
> >>
> >
> >
>
>

[jonwimp]

Thank you, Scott. Yes, I have been enjoying OFBiz, and still am.

By the way, that wasn't just a recap. David asked for testers.

He didn't ask for an explanation of the bug, though. So I'm just saying I tested it to work, and
it has worked for a very long time now.

Jonathon

Scott Gray wrote:

> Thanks for the recap Jonathon, I'm glad everything has gone well for you.
>
> Regards
> Scott
>
> On 21/07/07, Jonathon -- Improov <[hidden email]> wrote:
>>
>> I remember David Jones' objection to that change to javascript codes.
>>
>> I commented on it before. The original codes (before the change in
>> question) is correct, ie, the
>> javascript codes do NOT do a post. The change in question makes the
>> javascript do a post.
>>
>> I believe someone correctly corrected the submit function. And then, it
>> was incorrectly reverted
>> to former incorrect codes.
>>
>> I've been using the correct submit function (without javascript post) for
>> months now, even before
>> the correct corrections came in (which happened to coincide and agree
>> with
>> my own corrections).
>> Works in both Firefox and IE.
>>
>> Jonathon
>>
>> David E Jones wrote:
>> >
>> > This probably goes back to rev 532409 and the discussion around it,
>> back
>> > in April.
>> >
>> > I was opposed to that javascript change, and my guess is this bug in IE
>> > is a direct result of it.
>> >
>> > I just changed this in SVN rev 558253.
>> >
>> > What we need now is a number of people to test this to make sure it is
>> > working properly, and so that no one feels the desire to change it back
>> > again.
>> >
>> > -David
>> >
>> >
>> > Scott Gray wrote:
>> >> Thanks Kane,
>> >>
>> >> Do you we need the javascript to perform a submit?  I tested in
>> Firefox
>> >> 2.0.0.5 and the forms work fine without it, is anyone aware of any
>> >> browsers
>> >> that require it?
>> >>
>> >> Thanks
>> >> Scott
>> >>
>> >> On 21/07/07, Kane Lo <[hidden email]> wrote:
>> >>>
>> >>> Yes, the IE6 and IE7 are double posting. I have created an issue
>> b4 on
>> >>> Jira.
>> >>> It is becos of the IE7 will submit the post data, regardless the job
>> >>> should
>> >>> be passed to a javascript. And the javascript also post the data.
>> >>> Thus it
>> >>> becomes double post. I have a patch inside the Jira, to check if
>> it is
>> >>> IE7,
>> >>> then the javascript will stop post the data.
>> >>>
>> >>> ----- Original Message -----
>> >>> From: "Scott Gray" <[hidden email]>
>> >>> To: <[hidden email]>
>> >>> Sent: Saturday, July 21, 2007 10:02 AM
>> >>> Subject: Strange double posting behaviour on IE7
>> >>>
>> >>>
>> >>> > Hi All,
>> >>> >
>> >>> > I've come across a bug where forms are being double posted when
>> using
>> >>> IE7,
>> >>> > the strange thing is I can't replicate it on the demo server (
>> >>> > https://demo.hotwaxmedia.com/partymgr/control/main).
>> >>> >
>> >>> > Is the demo server running the same code as the trunk?
>> >>> >
>> >>> > Can anybody else confirm the double posting behaviour for me?  Easy
>> >>> way
>> >>> is
>> >>> > to create a new party group and then find the party group by its
>> group
>> >>> > name
>> >>> > (using IE7 of course)
>> >>> >
>> >>> > Thanks
>> >>> > Scott
>> >>> >
>> >>>
>> >>>
>> >>
>> >
>> >
>>
>>
>
>
> ------------------------------------------------------------------------
>
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.5.476 / Virus Database: 269.10.11/909 - Release Date: 7/20/2007 4:39 PM