Hi
I've been adding some small enhancements to the display of products in ecommerce. Most of the changes are modifications to productdetails.ftl. I'd like to submit my changes, but if I submit one big patch it'll be difficult for anyone to review. If I submit several small patches, one per feature added, they'll be a lot easier to review. But the moment one of the patches is applied, the others will no longer apply cleanly. What is the recommended procedure? I don't mind submitting one patch per feature, and re-submitting new versions of pending ones as each is accepted. But if there's a simpler approach, I'm happy to do it! Cheers, Anne. -- Coherent Software Australia Pty Ltd PO Box 2773 Cheltenham Vic 3192 Phone: (03) 9585 6788 Fax: (03) 9585 1086 Web: http://www.cohsoft.com.au/ Email: [hidden email] Bonsai ERP, the all-inclusive ERP system http://www.bonsaierp.com.au/ |
Administrator
|
I'd suggest to 1st create a Jira, attach the big patch and then we will see
Thanks Jacques From: "Anne Jessel" <[hidden email]> > Hi > > I've been adding some small enhancements to the display of products in > ecommerce. Most of the changes are modifications to > productdetails.ftl. > > I'd like to submit my changes, but if I submit one big patch it'll be > difficult for anyone to review. If I submit several small patches, one > per feature added, they'll be a lot easier to review. But the moment > one of the patches is applied, the others will no longer apply > cleanly. > > What is the recommended procedure? I don't mind submitting one patch > per feature, and re-submitting new versions of pending ones as each is > accepted. But if there's a simpler approach, I'm happy to do it! > > Cheers, > Anne. > > -- > Coherent Software Australia Pty Ltd > PO Box 2773 > Cheltenham Vic 3192 > Phone: (03) 9585 6788 > Fax: (03) 9585 1086 > Web: http://www.cohsoft.com.au/ > Email: [hidden email] > > Bonsai ERP, the all-inclusive ERP system > http://www.bonsaierp.com.au/ > |
Done, at OFBIZ-4024.
Let me know if it needs any changes. Cheers, Anne. On 17 November 2010 21:39, Jacques Le Roux <[hidden email]> wrote: > I'd suggest to 1st create a Jira, attach the big patch and then we will see > > Thanks > > Jacques > > From: "Anne Jessel" <[hidden email]> >> >> Hi >> >> I've been adding some small enhancements to the display of products in >> ecommerce. Most of the changes are modifications to >> productdetails.ftl. >> >> I'd like to submit my changes, but if I submit one big patch it'll be >> difficult for anyone to review. If I submit several small patches, one >> per feature added, they'll be a lot easier to review. But the moment >> one of the patches is applied, the others will no longer apply >> cleanly. >> >> What is the recommended procedure? I don't mind submitting one patch >> per feature, and re-submitting new versions of pending ones as each is >> accepted. But if there's a simpler approach, I'm happy to do it! >> >> Cheers, >> Anne. >> >> -- >> Coherent Software Australia Pty Ltd >> PO Box 2773 >> Cheltenham Vic 3192 >> Phone: (03) 9585 6788 >> Fax: (03) 9585 1086 >> Web: http://www.cohsoft.com.au/ >> Email: [hidden email] >> >> Bonsai ERP, the all-inclusive ERP system >> http://www.bonsaierp.com.au/ >> > > -- Coherent Software Australia Pty Ltd PO Box 2773 Cheltenham Vic 3192 Phone: (03) 9585 6788 Fax: (03) 9585 1086 Web: http://www.cohsoft.com.au/ Email: [hidden email] Bonsai ERP, the all-inclusive ERP system http://www.bonsaierp.com.au/ |
Free forum by Nabble | Edit this page |