Tags consistency

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Tags consistency

Jacques Le Roux
Administrator
I wonder about something : before tags used in simple-method and other XML files where consistent now it's not.
For instance consider "<if-compare field-name" it's always used in widget screens and menus conditions. Same for "<entity-and list-name" and I guess most of others.

Any comments ?

Thanks

Jacques

Reply | Threaded
Open this post in threaded view
|

Re: Tags consistency

David E Jones-3

Jacques,

It's great to have your help with all of this stuff. I'm sorry you got  
caught in the changes as some needed are not totally trivial, and I  
was changing them manually (instead of search/replace) in order to  
test things as I went along. It looks like there was one case were  
backward compatibility was broken, but that was my first priority  
before migrating everything because even for "trivial" changes like  
this testing is important and realistically issues are guaranteed to  
arise (that's usually true when you only have a couple of changes, and  
absolutely certain when you get into the hundreds and thousands of  
changes).

It seems like you have things pretty well underway, so thanks gain for  
your help on all of this and for the patience of others too.

-David


On Dec 31, 2008, at 2:15 AM, Jacques Le Roux wrote:

> I wonder about something : before tags used in simple-method and  
> other XML files where consistent now it's not.
> For instance consider "<if-compare field-name" it's always used in  
> widget screens and menus conditions. Same for "<entity-and list-
> name" and I guess most of others.
>
> Any comments ?
>
> Thanks
>
> Jacques
>

Reply | Threaded
Open this post in threaded view
|

Re: Tags consistency

David E Jones-3

I forgot to mention one thing, which I guess was the main question too.

Yes, we should similarly clean up the various widgets and such that  
use similar tags. At one point I tried using a common XSD file that  
could contain all of the share-able elements, but the parser was  
having issues with that combined with the local XSD file loading,  
hence the redundancy in XSD files. In a way it's good because some of  
the code for processing tags is different, but actually most of it is  
the same so it would be good for another reason to have a single XSD  
file for the common elements.

For now though the next effort is to make the manual changes necessary  
in the widget XSD files, make code changes as needed and test the  
changes in different places, and then off we go...

-David


On Dec 31, 2008, at 12:24 PM, David E Jones wrote:

>
> Jacques,
>
> It's great to have your help with all of this stuff. I'm sorry you  
> got caught in the changes as some needed are not totally trivial,  
> and I was changing them manually (instead of search/replace) in  
> order to test things as I went along. It looks like there was one  
> case were backward compatibility was broken, but that was my first  
> priority before migrating everything because even for "trivial"  
> changes like this testing is important and realistically issues are  
> guaranteed to arise (that's usually true when you only have a couple  
> of changes, and absolutely certain when you get into the hundreds  
> and thousands of changes).
>
> It seems like you have things pretty well underway, so thanks gain  
> for your help on all of this and for the patience of others too.
>
> -David
>
>
> On Dec 31, 2008, at 2:15 AM, Jacques Le Roux wrote:
>
>> I wonder about something : before tags used in simple-method and  
>> other XML files where consistent now it's not.
>> For instance consider "<if-compare field-name" it's always used in  
>> widget screens and menus conditions. Same for "<entity-and list-
>> name" and I guess most of others.
>>
>> Any comments ?
>>
>> Thanks
>>
>> Jacques
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: Tags consistency

Jacques Le Roux
Administrator
In reply to this post by David E Jones-3
Of course, it't not realistic to expect to really test the changes I made these last days (it's commonly hundreds of them by commit
and there are a dozen of commits so far)
But I took your idea of using artifact info for testing changes.
It's a very efficient tool, and not only for this task, thank you for that !

Jacques

From: "David E Jones" <[hidden email]>

> Jacques,
>
> It's great to have your help with all of this stuff. I'm sorry you got
> caught in the changes as some needed are not totally trivial, and I
> was changing them manually (instead of search/replace) in order to
> test things as I went along. It looks like there was one case were
> backward compatibility was broken, but that was my first priority
> before migrating everything because even for "trivial" changes like
> this testing is important and realistically issues are guaranteed to
> arise (that's usually true when you only have a couple of changes, and
> absolutely certain when you get into the hundreds and thousands of
> changes).
>
> It seems like you have things pretty well underway, so thanks gain for
> your help on all of this and for the patience of others too.
>
> -David
>
>
> On Dec 31, 2008, at 2:15 AM, Jacques Le Roux wrote:
>
>> I wonder about something : before tags used in simple-method and
>> other XML files where consistent now it's not.
>> For instance consider "<if-compare field-name" it's always used in
>> widget screens and menus conditions. Same for "<entity-and list-
>> name" and I guess most of others.
>>
>> Any comments ?
>>
>> Thanks
>>
>> Jacques
>>
>