Tomahawk theme

[Jacques Le Roux]

Hi,

I have created a new improvement issue for the Tomahawk theme
https://issues.apache.org/jira/browse/OFBIZ-3530

I wonder if there is currently a WIP or a Jira created for the lookups button (should be transparent).
I can work on it else.

This theme is wonderful, and almost perfet from the start, great enhancement.
I think will commit the layered lookups today, the 10.04 will look and respond brightly

Thanks guys!

Jacques

[Bruno Busco]

Hi Jacques,
thank you for all the screenshot-reports. They will be really usefull
to address the remaining issues.
Developing the Tomahawk theme was a nice chat-based collaboration
experience between me in Napoli, Italy and Erik in Dallas, Texas.

Regarding the lookup icon:
This is not related to the theme itself but must be fixed in the FTL files.
What happens is that the FTL files renders the lookup fields with a
different HTML from what is rendered by the form widget.
In order to make OFBiz more consistent we need to have the FTL
generate the same HTML structure as the form widget and not to have
the theme do all the work to handle all variants of things.

The lookups in the FTL in https://ofbiz-vm.apache.org/catalog/control/main
have this HTML:

<div>
   <label for="keywordSearchCategoryId">Category ID:</label>
   <input type="text" name="SEARCH_CATEGORY_ID"
id="keywordSearchCategoryId" size="15" maxlength="20" value=""/><a
href="javascript:call_fieldlookup2($('keywordSearchCategoryId'),'LookupProductCategory');"><img
src='/images/fieldlookup.gif' width='15' height='14' alt="Click here
For Field Lookup" /></a>
    </div>

but if you go in
https://ofbiz-vm.apache.org/assetmaint/control/EditFixedAsset?fixedAssetId=DEMO_PROJECTOR
you will see that the lookups have this HTML:

<div class="field-lookup"><ul>
<li><input type="text"
 name="parentFixedAssetId" size="25"
id="EditFixedAsset_parentFixedAssetId" autocomplete="off"/></li><li>
<a href="javascript:call_fieldlookup2(document.EditFixedAsset.parentFixedAssetId,'LookupFixedAsset');">
<span id="EditFixedAsset_parentFixedAssetId_indicator" style="display:
none" class="indicator"><img /></span>
</a></li></ul></div>

Using this HTML *all* the themes already handle it very well. Every
theme can specify a different icon and tomahawk uses a very nice card
icon with a transparent background.

-Bruno

2010/3/3 Jacques Le Roux <[hidden email]>:

> Hi,
>
> I have created a new improvement issue for the Tomahawk theme
> https://issues.apache.org/jira/browse/OFBIZ-3530
>
> I wonder if there is currently a WIP or a Jira created for the lookups
> button (should be transparent).
> I can work on it else.
>
> This theme is wonderful, and almost perfet from the start, great
> enhancement.
> I think will commit the layered lookups today, the 10.04 will look and
> respond brightly
>
> Thanks guys!
>
> Jacques
>
>
>

[Jacopo Cappellato-4]

On Mar 3, 2010, at 7:42 AM, Bruno Busco wrote:

> Developing the Tomahawk theme was a nice chat-based collaboration
> experience between me in Napoli, Italy and Erik in Dallas, Texas.

You did an excellent job. Kudos!

Jacopo

[Jacques Le Roux]

Hi Bruno,

Inline...

From: "Bruno Busco" <[hidden email]>
> Hi Jacques,
> thank you for all the screenshot-reports. They will be really usefull
> to address the remaining issues.

I did  scan only the Party Component because I had already scanned the others (but SFA, Project and Workeffort but did not find much
if any there) while testing the layered lookups before the Tomahawk theme has been introduced. Anyway, like I said in the issue this
is certainly not component specific. Also as I explained in the issue, I'd like to get rid of all these UI inconsistencies we have
accumulated in years, the most proeminent being the buttons. But as you explain below maybe FTL files are the culprit also there,
the Pandora box...

> Developing the Tomahawk theme was a nice chat-based collaboration
> experience between me in Napoli, Italy and Erik in Dallas, Texas.

Your collaborative work is really a great success, bravo!

> Regarding the lookup icon:
> This is not related to the theme itself but must be fixed in the FTL files.
> What happens is that the FTL files renders the lookup fields with a
> different HTML from what is rendered by the form widget.
> In order to make OFBiz more consistent we need to have the FTL
> generate the same HTML structure as the form widget and not to have
> the theme do all the work to handle all variants of things.
>
> The lookups in the FTL in https://ofbiz-vm.apache.org/catalog/control/main
> have this HTML:
>
> <div>
>   <label for="keywordSearchCategoryId">Category ID:</label>
>   <input type="text" name="SEARCH_CATEGORY_ID"
> id="keywordSearchCategoryId" size="15" maxlength="20" value=""/><a
> href="javascript:call_fieldlookup2($('keywordSearchCategoryId'),'LookupProductCategory');"><img
> src='/images/fieldlookup.gif' width='15' height='14' alt="Click here
> For Field Lookup" /></a>
>    </div>
>
> but if you go in
> https://ofbiz-vm.apache.org/assetmaint/control/EditFixedAsset?fixedAssetId=DEMO_PROJECTOR
> you will see that the lookups have this HTML:
>
> <div class="field-lookup"><ul>
> <li><input type="text"
> name="parentFixedAssetId" size="25"
> id="EditFixedAsset_parentFixedAssetId" autocomplete="off"/></li><li>
> <a href="javascript:call_fieldlookup2(document.EditFixedAsset.parentFixedAssetId,'LookupFixedAsset');">
> <span id="EditFixedAsset_parentFixedAssetId_indicator" style="display:
> none" class="indicator"><img /></span>
> </a></li></ul></div>
>
> Using this HTML *all* the themes already handle it very well. Every
> theme can specify a different icon and tomahawk uses a very nice card
> icon with a transparent background.

I have reformated and put that in the issue. Thanks for the input, valuable and appreciated.

BTW I will not commit the layered lookups today, because I thought after that the link colors (in retrieved lookup list) in some
cases are hardly legible in Tomahawk and it's the default theme now.

Jacques

> -Bruno
>
> 2010/3/3 Jacques Le Roux <[hidden email]>:
>> Hi,
>>
>> I have created a new improvement issue for the Tomahawk theme
>> https://issues.apache.org/jira/browse/OFBIZ-3530
>>
>> I wonder if there is currently a WIP or a Jira created for the lookups
>> button (should be transparent).
>> I can work on it else.
>>
>> This theme is wonderful, and almost perfet from the start, great
>> enhancement.
>> I think will commit the layered lookups today, the 10.04 will look and
>> respond brightly
>>
>> Thanks guys!
>>
>> Jacques
>>
>>
>>
>

[gomola]

Hey Jacques, I would be the first to say to look for more improvements
on these interfaces. I think we are making good progress, I am thinking
about an even cleaner flatter design as a future skin. I am working on a
series of icons for the interfaces, I would like to pronounce them more
also. Ultimately it would be good to restructure these buttons, but we
have a plan to work with what we can here.

Thanks
Erik

Bruno Busco wrote:

> Hi Jacques,
> thank you for all the screenshot-reports. They will be really usefull
> to address the remaining issues.
> Developing the Tomahawk theme was a nice chat-based collaboration
> experience between me in Napoli, Italy and Erik in Dallas, Texas.
>
> Regarding the lookup icon:
> This is not related to the theme itself but must be fixed in the FTL files.
> What happens is that the FTL files renders the lookup fields with a
> different HTML from what is rendered by the form widget.
> In order to make OFBiz more consistent we need to have the FTL
> generate the same HTML structure as the form widget and not to have
> the theme do all the work to handle all variants of things.
>
> The lookups in the FTL in https://ofbiz-vm.apache.org/catalog/control/main
> have this HTML:
>
> <div>
>    <label for="keywordSearchCategoryId">Category ID:</label>
>    <input type="text" name="SEARCH_CATEGORY_ID"
> id="keywordSearchCategoryId" size="15" maxlength="20" value=""/><a
> href="javascript:call_fieldlookup2($('keywordSearchCategoryId'),'LookupProductCategory');"><img
> src='/images/fieldlookup.gif' width='15' height='14' alt="Click here
> For Field Lookup" /></a>
>     </div>
>
> but if you go in
> https://ofbiz-vm.apache.org/assetmaint/control/EditFixedAsset?fixedAssetId=DEMO_PROJECTOR
> you will see that the lookups have this HTML:
>
> <div class="field-lookup"><ul>
> <li><input type="text"
>  name="parentFixedAssetId" size="25"
> id="EditFixedAsset_parentFixedAssetId" autocomplete="off"/></li><li>
> <a href="javascript:call_fieldlookup2(document.EditFixedAsset.parentFixedAssetId,'LookupFixedAsset');">
> <span id="EditFixedAsset_parentFixedAssetId_indicator" style="display:
> none" class="indicator"><img /></span>
> </a></li></ul></div>
>
> Using this HTML *all* the themes already handle it very well. Every
> theme can specify a different icon and tomahawk uses a very nice card
> icon with a transparent background.
>
> -Bruno
>
> 2010/3/3 Jacques Le Roux <[hidden email]>:
>  
>> Hi,
>>
>> I have created a new improvement issue for the Tomahawk theme
>> https://issues.apache.org/jira/browse/OFBIZ-3530
>>
>> I wonder if there is currently a WIP or a Jira created for the lookups
>> button (should be transparent).
>> I can work on it else.
>>
>> This theme is wonderful, and almost perfet from the start, great
>> enhancement.
>> I think will commit the layered lookups today, the 10.04 will look and
>> respond brightly
>>
>> Thanks guys!
>>
>> Jacques
>>
>>
>>
>>    

[Jacques Le Roux]

Thanks for the update Erik,

Yes for the buttons we will do that later, I understand your point of view.

Jacques

From: "Erik Schuessler" <[hidden email]>

> Hey Jacques, I would be the first to say to look for more improvements
> on these interfaces. I think we are making good progress, I am thinking
> about an even cleaner flatter design as a future skin. I am working on a
> series of icons for the interfaces, I would like to pronounce them more
> also. Ultimately it would be good to restructure these buttons, but we
> have a plan to work with what we can here.
>
> Thanks
> Erik
>
> Bruno Busco wrote:
>> Hi Jacques,
>> thank you for all the screenshot-reports. They will be really usefull
>> to address the remaining issues.
>> Developing the Tomahawk theme was a nice chat-based collaboration
>> experience between me in Napoli, Italy and Erik in Dallas, Texas.
>>
>> Regarding the lookup icon:
>> This is not related to the theme itself but must be fixed in the FTL files.
>> What happens is that the FTL files renders the lookup fields with a
>> different HTML from what is rendered by the form widget.
>> In order to make OFBiz more consistent we need to have the FTL
>> generate the same HTML structure as the form widget and not to have
>> the theme do all the work to handle all variants of things.
>>
>> The lookups in the FTL in https://ofbiz-vm.apache.org/catalog/control/main
>> have this HTML:
>>
>> <div>
>>    <label for="keywordSearchCategoryId">Category ID:</label>
>>    <input type="text" name="SEARCH_CATEGORY_ID"
>> id="keywordSearchCategoryId" size="15" maxlength="20" value=""/><a
>> href="javascript:call_fieldlookup2($('keywordSearchCategoryId'),'LookupProductCategory');"><img
>> src='/images/fieldlookup.gif' width='15' height='14' alt="Click here
>> For Field Lookup" /></a>
>>     </div>
>>
>> but if you go in
>> https://ofbiz-vm.apache.org/assetmaint/control/EditFixedAsset?fixedAssetId=DEMO_PROJECTOR
>> you will see that the lookups have this HTML:
>>
>> <div class="field-lookup"><ul>
>> <li><input type="text"
>>  name="parentFixedAssetId" size="25"
>> id="EditFixedAsset_parentFixedAssetId" autocomplete="off"/></li><li>
>> <a href="javascript:call_fieldlookup2(document.EditFixedAsset.parentFixedAssetId,'LookupFixedAsset');">
>> <span id="EditFixedAsset_parentFixedAssetId_indicator" style="display:
>> none" class="indicator"><img /></span>
>> </a></li></ul></div>
>>
>> Using this HTML *all* the themes already handle it very well. Every
>> theme can specify a different icon and tomahawk uses a very nice card
>> icon with a transparent background.
>>
>> -Bruno
>>
>> 2010/3/3 Jacques Le Roux <[hidden email]>:
>>  
>>> Hi,
>>>
>>> I have created a new improvement issue for the Tomahawk theme
>>> https://issues.apache.org/jira/browse/OFBIZ-3530
>>>
>>> I wonder if there is currently a WIP or a Jira created for the lookups
>>> button (should be transparent).
>>> I can work on it else.
>>>
>>> This theme is wonderful, and almost perfet from the start, great
>>> enhancement.
>>> I think will commit the layered lookups today, the 10.04 will look and
>>> respond brightly
>>>
>>> Thanks guys!
>>>
>>> Jacques
>>>
>>>
>>>
>>>    
>