Typo error in GeneralLedgerServices.xml

[Cimballi]

Hi,

I think there is a typo error in the file
"accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml".
In the "createAcctgTransAndEntriesForPaymentApplication" method, the
comment "<!--Credit -->" is above the "D" entry and the comment "<!--
Debit -->" is above the "C" entry.
I think it should be the opposite. Lines 2249 and 2259 in version
"ofbiz-rel9.04-2009-09-25-v818777".

Cimballi

[Rishi Solanki]

Hi Cimballi,
I see the typo is there in if part in else it is right.

Rishi Solanki
Enterprise Software Developer
HotWax Media Pvt. Ltd.



On Fri, Oct 9, 2009 at 5:18 AM, Cimballi <[hidden email]> wrote:

> Hi,
>
> I think there is a typo error in the file
> "accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml".
> In the "createAcctgTransAndEntriesForPaymentApplication" method, the
> comment "<!--Credit -->" is above the "D" entry and the comment "<!--
> Debit -->" is above the "C" entry.
> I think it should be the opposite. Lines 2249 and 2259 in version
> "ofbiz-rel9.04-2009-09-25-v818777".
>
> Cimballi
>

[Cimballi-2]

Yes Rishi, exactly.


On Fri, Oct 9, 2009 at 3:40 AM, Rishi Solanki <[hidden email]> wrote:

> Hi Cimballi,
> I see the typo is there in if part in else it is right.
>
> Rishi Solanki
> Enterprise Software Developer
> HotWax Media Pvt. Ltd.
>
>
>
> On Fri, Oct 9, 2009 at 5:18 AM, Cimballi <[hidden email]> wrote:
>
>> Hi,
>>
>> I think there is a typo error in the file
>> "accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml".
>> In the "createAcctgTransAndEntriesForPaymentApplication" method, the
>> comment "<!--Credit -->" is above the "D" entry and the comment "<!--
>> Debit -->" is above the "C" entry.
>> I think it should be the opposite. Lines 2249 and 2259 in version
>> "ofbiz-rel9.04-2009-09-25-v818777".
>>
>> Cimballi
>>
>

[Jacques Le Roux]

Thanks to both,

Fixed at r829611

Jacques

From: "Cimballi" <[hidden email]>

> Yes Rishi, exactly.
>
>
> On Fri, Oct 9, 2009 at 3:40 AM, Rishi Solanki <[hidden email]> wrote:
>> Hi Cimballi,
>> I see the typo is there in if part in else it is right.
>>
>> Rishi Solanki
>> Enterprise Software Developer
>> HotWax Media Pvt. Ltd.
>>
>>
>>
>> On Fri, Oct 9, 2009 at 5:18 AM, Cimballi <[hidden email]> wrote:
>>
>>> Hi,
>>>
>>> I think there is a typo error in the file
>>> "accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml".
>>> In the "createAcctgTransAndEntriesForPaymentApplication" method, the
>>> comment "<!--Credit -->" is above the "D" entry and the comment "<!--
>>> Debit -->" is above the "C" entry.
>>> I think it should be the opposite. Lines 2249 and 2259 in version
>>> "ofbiz-rel9.04-2009-09-25-v818777".
>>>
>>> Cimballi
>>>
>>
>