UI improvement for tables in OFBiz

[Jacques Le Roux]

Hi Mayank,

It would seem more logical to me to decide about the naming convention for alignment classes after having decided which CSS framework we prefer to
refer for tables.

I see no hurry in that, do you have for another reason? If so then please start the detailed comparison of the 2 CSS frameworks to help us to decide.

Thanks

Jacques


Le 09/09/2017 à 14:13, Mayank Lambhate a écrit :

> Hello Jacques, All,
>
> I think this would be a good idea to check which of the CSS styling in
> either Bootstrap or Foundation works best for OFBiz tables.
>
> Also coming to the original discussion of using specific classes for
> alignment of table data, Can we pick the naming convention from Bootstrap
> Alignment classes?
>
> https://getbootstrap.com/docs/3.3/css/#type-alignment
> <https://getbootstrap.com/docs/3.3/css/#type-alignment>
> Thanks,
>
> *Mayank Lambhate* | Enterprise Software Engineer
> HotWax Systems <http://www.hotwaxsystems.com/>
>
>
> On Thu, Sep 7, 2017 at 8:11 PM, Paul Mandeltort <[hidden email]> wrote:
>
>> In the other thread, folks were talking about Vaadin which would supersede
>> this discussion, I believe.
>>
>> For this application I think Vaadin (in particular the Grid component) is
>> an ideal fit, because it is a complete UI framework, vs Bootstrap which is
>> just a nice client-side CSS/JS theme.
>>
>> Replacing the various obsolete implementations of tabular data display
>> with the Vaadin Grid component alone would make ofbiz an order of magnitude
>> more usable for most of its apps.
>>
>> https://vaadin.com/docs/-/part/framework/components/components-grid.html
>>
>> -P
>>
>> On Sep 7, 2017, 3:29 AM -0500, Jacques Le Roux <
>> [hidden email]>, wrote:
>>> Hi Michael, All,
>>>
>>> Why not Foundation?
>>>
>>> It's true that Bootstrap, I guess due to its origin,  is more widely
>> used, but Foundation has some arguments.
>>> https://www.google.fr/search?q=Bootstrap+vs+Foundation&ie=UTF-8
>>>
>>> Nnotably when it comes to tables that OFBiz uses a lot (please see
>> Rajesh's and my message before in the thread).
>>> Beware, I don't mean to use Foundation as is, simply to refer to its CSS
>> definitions as Taher suggested for Bootstrap.
>>> At least to compare both for OFBiz before picking one
>>>
>>> Jacques
>>>
>>>
>>> Le 07/09/2017 à 10:05, Michael Brohl a écrit :
>>>> A bit late to the party but I totally agree that we should make use of
>> an existing standard instead of reinventing our own wheel.
>>>> +1 for bootstrap
>>>>
>>>> Regards,
>>>>
>>>> Michael
>>>>
>>>>
>>>> Am 26.08.17 um 21:19 schrieb Taher Alkhateeb:
>>>>> If I may suggest, I think we should go with something established and
>>>>> not come up with our own CSS dictionary. So for example, we can
>>>>> utilize pre-existing definitions from bootstrap [1]
>>>>>
>>>>> [1] https://getbootstrap.com/docs/3.3/css/#tables
>>>>>
>>>>> On Sat, Aug 26, 2017 at 3:27 PM, Mayank Lambhate
>>>>> <[hidden email]> wrote:
>>>>>> Hello All,
>>>>>>
>>>>>> The tables used in OFBiz currently don`t have any standard for
>> defining the
>>>>>> alignment of data inside the tables. IMO, following are the points
>> relevant
>>>>>> to alignment of data in tables -
>>>>>>
>>>>>>      1. Numeric data (Right Aligned)
>>>>>>      2. Non-Numeric (Left Aligned)
>>>>>>      3. Table headers to be aligned with the data.
>>>>>>
>>>>>> Also, the names of classes used for aligning data are a bit
>> confusing. We
>>>>>> can come up with more generic names of the classes, also we can
>> define
>>>>>> certain classes that could be specific to the alignment of data
>> inside
>>>>>> tables.
>>>>>>
>>>>>> Please let me know what you think about this.
>>>>>>
>>>>>>
>>>>>> Thanks and Regards
>>>>>>
>>>>>> *Mayank Lambhate* | Enterprise Software Engineer
>>>>>> HotWax Systems <http://www.hotwaxsystems.com/
>>>>

[Deepak Dixit-3]

Hi,

I think instead of directly using bootstrap defined classes we can define
it based on context.

Like for as we display amount/numeric values as right aligned, and for this
bootstrap has pull-right class.
pull-right does not make sense its to generic, we can define new classes to
meet ERP needs.
We can use ofbiz defined field type in fieldtype*,xml file for these kind
of field.

This is an example where we can't use direct bootstrap classes so its good
to have our own definition.




Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Sun, Sep 10, 2017 at 4:16 PM, Jacques Le Roux <
[hidden email]> wrote:

> Hi Mayank,
>
> It would seem more logical to me to decide about the naming convention for
> alignment classes after having decided which CSS framework we prefer to
> refer for tables.
>
> I see no hurry in that, do you have for another reason? If so then please
> start the detailed comparison of the 2 CSS frameworks to help us to decide.
>
> Thanks
>
> Jacques
>
>
>
> Le 09/09/2017 à 14:13, Mayank Lambhate a écrit :
>
>> Hello Jacques, All,
>>
>> I think this would be a good idea to check which of the CSS styling in
>> either Bootstrap or Foundation works best for OFBiz tables.
>>
>> Also coming to the original discussion of using specific classes for
>> alignment of table data, Can we pick the naming convention from Bootstrap
>> Alignment classes?
>>
>> https://getbootstrap.com/docs/3.3/css/#type-alignment
>> <https://getbootstrap.com/docs/3.3/css/#type-alignment>
>> Thanks,
>>
>> *Mayank Lambhate* | Enterprise Software Engineer
>> HotWax Systems <http://www.hotwaxsystems.com/>
>>
>>
>> On Thu, Sep 7, 2017 at 8:11 PM, Paul Mandeltort <[hidden email]>
>> wrote:
>>
>> In the other thread, folks were talking about Vaadin which would supersede
>>> this discussion, I believe.
>>>
>>> For this application I think Vaadin (in particular the Grid component) is
>>> an ideal fit, because it is a complete UI framework, vs Bootstrap which
>>> is
>>> just a nice client-side CSS/JS theme.
>>>
>>> Replacing the various obsolete implementations of tabular data display
>>> with the Vaadin Grid component alone would make ofbiz an order of
>>> magnitude
>>> more usable for most of its apps.
>>>
>>> https://vaadin.com/docs/-/part/framework/components/components-grid.html
>>>
>>> -P
>>>
>>> On Sep 7, 2017, 3:29 AM -0500, Jacques Le Roux <
>>> [hidden email]>, wrote:
>>>
>>>> Hi Michael, All,
>>>>
>>>> Why not Foundation?
>>>>
>>>> It's true that Bootstrap, I guess due to its origin,  is more widely
>>>>
>>> used, but Foundation has some arguments.
>>>
>>>> https://www.google.fr/search?q=Bootstrap+vs+Foundation&ie=UTF-8
>>>>
>>>> Nnotably when it comes to tables that OFBiz uses a lot (please see
>>>>
>>> Rajesh's and my message before in the thread).
>>>
>>>> Beware, I don't mean to use Foundation as is, simply to refer to its CSS
>>>>
>>> definitions as Taher suggested for Bootstrap.
>>>
>>>> At least to compare both for OFBiz before picking one
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 07/09/2017 à 10:05, Michael Brohl a écrit :
>>>>
>>>>> A bit late to the party but I totally agree that we should make use of
>>>>>
>>>> an existing standard instead of reinventing our own wheel.
>>>
>>>> +1 for bootstrap
>>>>>
>>>>> Regards,
>>>>>
>>>>> Michael
>>>>>
>>>>>
>>>>> Am 26.08.17 um 21:19 schrieb Taher Alkhateeb:
>>>>>
>>>>>> If I may suggest, I think we should go with something established and
>>>>>> not come up with our own CSS dictionary. So for example, we can
>>>>>> utilize pre-existing definitions from bootstrap [1]
>>>>>>
>>>>>> [1] https://getbootstrap.com/docs/3.3/css/#tables
>>>>>>
>>>>>> On Sat, Aug 26, 2017 at 3:27 PM, Mayank Lambhate
>>>>>> <[hidden email]> wrote:
>>>>>>
>>>>>>> Hello All,
>>>>>>>
>>>>>>> The tables used in OFBiz currently don`t have any standard for
>>>>>>>
>>>>>> defining the
>>>
>>>> alignment of data inside the tables. IMO, following are the points
>>>>>>>
>>>>>> relevant
>>>
>>>> to alignment of data in tables -
>>>>>>>
>>>>>>>      1. Numeric data (Right Aligned)
>>>>>>>      2. Non-Numeric (Left Aligned)
>>>>>>>      3. Table headers to be aligned with the data.
>>>>>>>
>>>>>>> Also, the names of classes used for aligning data are a bit
>>>>>>>
>>>>>> confusing. We
>>>
>>>> can come up with more generic names of the classes, also we can
>>>>>>>
>>>>>> define
>>>
>>>> certain classes that could be specific to the alignment of data
>>>>>>>
>>>>>> inside
>>>
>>>> tables.
>>>>>>>
>>>>>>> Please let me know what you think about this.
>>>>>>>
>>>>>>>
>>>>>>> Thanks and Regards
>>>>>>>
>>>>>>> *Mayank Lambhate* | Enterprise Software Engineer
>>>>>>> HotWax Systems <http://www.hotwaxsystems.com/
>>>>>>>
>>>>>>
>>>>>
>

[Mayank Lambhate]

Hello,

I agree with Deepak that we can define our own CSS classes based on the
context and we can take the names from fieldtype*.xml.

I think once this is done, we can proceed with the comparison for UI
frameworks to be used and the CSS classes would remain the same.

I have created a ticket for the same.
https://issues.apache.org/jira/browse/OFBIZ-9750


*Mayank Lambhate* | Enterprise Software Engineer
HotWax Systems <http://www.hotwaxsystems.com/>


On Mon, Sep 11, 2017 at 10:34 AM, Deepak Dixit <
[hidden email]> wrote:

> Hi,
>
> I think instead of directly using bootstrap defined classes we can define
> it based on context.
>
> Like for as we display amount/numeric values as right aligned, and for this
> bootstrap has pull-right class.
> pull-right does not make sense its to generic, we can define new classes to
> meet ERP needs.
> We can use ofbiz defined field type in fieldtype*,xml file for these kind
> of field.
>
> This is an example where we can't use direct bootstrap classes so its good
> to have our own definition.
>
>
>
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> www.hotwax.co
>
> On Sun, Sep 10, 2017 at 4:16 PM, Jacques Le Roux <
> [hidden email]> wrote:
>
> > Hi Mayank,
> >
> > It would seem more logical to me to decide about the naming convention
> for
> > alignment classes after having decided which CSS framework we prefer to
> > refer for tables.
> >
> > I see no hurry in that, do you have for another reason? If so then please
> > start the detailed comparison of the 2 CSS frameworks to help us to
> decide.
> >
> > Thanks
> >
> > Jacques
> >
> >
> >
> > Le 09/09/2017 à 14:13, Mayank Lambhate a écrit :
> >
> >> Hello Jacques, All,
> >>
> >> I think this would be a good idea to check which of the CSS styling in
> >> either Bootstrap or Foundation works best for OFBiz tables.
> >>
> >> Also coming to the original discussion of using specific classes for
> >> alignment of table data, Can we pick the naming convention from
> Bootstrap
> >> Alignment classes?
> >>
> >> https://getbootstrap.com/docs/3.3/css/#type-alignment
> >> <https://getbootstrap.com/docs/3.3/css/#type-alignment>
> >> Thanks,
> >>
> >> *Mayank Lambhate* | Enterprise Software Engineer
> >> HotWax Systems <http://www.hotwaxsystems.com/>
> >>
> >>
> >> On Thu, Sep 7, 2017 at 8:11 PM, Paul Mandeltort <[hidden email]>
> >> wrote:
> >>
> >> In the other thread, folks were talking about Vaadin which would
> supersede
> >>> this discussion, I believe.
> >>>
> >>> For this application I think Vaadin (in particular the Grid component)
> is
> >>> an ideal fit, because it is a complete UI framework, vs Bootstrap which
> >>> is
> >>> just a nice client-side CSS/JS theme.
> >>>
> >>> Replacing the various obsolete implementations of tabular data display
> >>> with the Vaadin Grid component alone would make ofbiz an order of
> >>> magnitude
> >>> more usable for most of its apps.
> >>>
> >>> https://vaadin.com/docs/-/part/framework/components/
> components-grid.html
> >>>
> >>> -P
> >>>
> >>> On Sep 7, 2017, 3:29 AM -0500, Jacques Le Roux <
> >>> [hidden email]>, wrote:
> >>>
> >>>> Hi Michael, All,
> >>>>
> >>>> Why not Foundation?
> >>>>
> >>>> It's true that Bootstrap, I guess due to its origin,  is more widely
> >>>>
> >>> used, but Foundation has some arguments.
> >>>
> >>>> https://www.google.fr/search?q=Bootstrap+vs+Foundation&ie=UTF-8
> >>>>
> >>>> Nnotably when it comes to tables that OFBiz uses a lot (please see
> >>>>
> >>> Rajesh's and my message before in the thread).
> >>>
> >>>> Beware, I don't mean to use Foundation as is, simply to refer to its
> CSS
> >>>>
> >>> definitions as Taher suggested for Bootstrap.
> >>>
> >>>> At least to compare both for OFBiz before picking one
> >>>>
> >>>> Jacques
> >>>>
> >>>>
> >>>> Le 07/09/2017 à 10:05, Michael Brohl a écrit :
> >>>>
> >>>>> A bit late to the party but I totally agree that we should make use
> of
> >>>>>
> >>>> an existing standard instead of reinventing our own wheel.
> >>>
> >>>> +1 for bootstrap
> >>>>>
> >>>>> Regards,
> >>>>>
> >>>>> Michael
> >>>>>
> >>>>>
> >>>>> Am 26.08.17 um 21:19 schrieb Taher Alkhateeb:
> >>>>>
> >>>>>> If I may suggest, I think we should go with something established
> and
> >>>>>> not come up with our own CSS dictionary. So for example, we can
> >>>>>> utilize pre-existing definitions from bootstrap [1]
> >>>>>>
> >>>>>> [1] https://getbootstrap.com/docs/3.3/css/#tables
> >>>>>>
> >>>>>> On Sat, Aug 26, 2017 at 3:27 PM, Mayank Lambhate
> >>>>>> <[hidden email]> wrote:
> >>>>>>
> >>>>>>> Hello All,
> >>>>>>>
> >>>>>>> The tables used in OFBiz currently don`t have any standard for
> >>>>>>>
> >>>>>> defining the
> >>>
> >>>> alignment of data inside the tables. IMO, following are the points
> >>>>>>>
> >>>>>> relevant
> >>>
> >>>> to alignment of data in tables -
> >>>>>>>
> >>>>>>>      1. Numeric data (Right Aligned)
> >>>>>>>      2. Non-Numeric (Left Aligned)
> >>>>>>>      3. Table headers to be aligned with the data.
> >>>>>>>
> >>>>>>> Also, the names of classes used for aligning data are a bit
> >>>>>>>
> >>>>>> confusing. We
> >>>
> >>>> can come up with more generic names of the classes, also we can
> >>>>>>>
> >>>>>> define
> >>>
> >>>> certain classes that could be specific to the alignment of data
> >>>>>>>
> >>>>>> inside
> >>>
> >>>> tables.
> >>>>>>>
> >>>>>>> Please let me know what you think about this.
> >>>>>>>
> >>>>>>>
> >>>>>>> Thanks and Regards
> >>>>>>>
> >>>>>>> *Mayank Lambhate* | Enterprise Software Engineer
> >>>>>>> HotWax Systems <http://www.hotwaxsystems.com/
> >>>>>>>
> >>>>>>
> >>>>>
> >
>