Upgrade to latest Gradle version 4.6?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Upgrade to latest Gradle version 4.6?

Michael Brohl-3
Hi all,

I wanted to check if the current OFBiz version is running under the
latest early access version of Oracle JDK 10 and what it takes to make
it work.

The current Gradle version we use is not able to detect the Java version
correctly and must be updated for it. I changed the
gradle-wrapper.properties to use Gradle 4.6 and now JDK 10 is detected.
The project does not compile but this would be part of the next steps.

Can we/do we want to upgrade Gradle to version 4.6 or are there any
objections against it?

If we want to upgrade, I would file a Jira for this task, try to make
everything work with JDK 1.8 first and provide a patch for it.

Thanks and regards,

Michael Brohl
ecomify GmbH
www.ecomify.de




smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Upgrade to latest Gradle version 4.6?

taher
Hi Michael,

I see no problem in upgrading, we would however face a warning everytime we
run a server task which I described in [1]. I have been thinking a lot of a
solution and I think I am close to getting something done.

So I would suggest yeah go for it and I will try to accelerate a solution
to resolve this warning since it fundamentally changes how we invoke server
tasks

[1] https://issues.apache.org/jira/browse/OFBIZ-9972

On Mar 1, 2018 1:43 AM, "Michael Brohl" <[hidden email]> wrote:

Hi all,

I wanted to check if the current OFBiz version is running under the latest
early access version of Oracle JDK 10 and what it takes to make it work.

The current Gradle version we use is not able to detect the Java version
correctly and must be updated for it. I changed the
gradle-wrapper.properties to use Gradle 4.6 and now JDK 10 is detected. The
project does not compile but this would be part of the next steps.

Can we/do we want to upgrade Gradle to version 4.6 or are there any
objections against it?

If we want to upgrade, I would file a Jira for this task, try to make
everything work with JDK 1.8 first and provide a patch for it.

Thanks and regards,

Michael Brohl
ecomify GmbH
www.ecomify.de
Reply | Threaded
Open this post in threaded view
|

Re: Upgrade to latest Gradle version 4.6?

Nicolas Malin-2
Hello,

I found the same situation Michael to use java 10

I updated to gradle 4.7 so if you are always ok, I can realize the
update version on trunk.

Taher thanks for your alert with gradle 5, I will take care about that
and try do find some ideas.

Just for information, I compiled ofbiz trunk on jdk10 with update
build.gradle :$

svn diff build.gradle
Index: build.gradle
@@ -200,6 +200,8 @@
  excludedJavaSources.add
'org/apache/ofbiz/order/thirdparty/taxware/TaxwareUTL.java'
+excludedJavaSources.add
'org/apache/ofbiz/content/survey/PdfSurveyServices.java'
+excludedJavaSources.add
'org/apache/ofbiz/content/compdoc/CompDocServices.java'

Ok it's not a good solution, now I will understand how solve
CompDocServices.java and PdfSurveyServices.java correctly :)

Nicolas


On 28/02/2018 23:50, Taher Alkhateeb wrote:

> Hi Michael,
>
> I see no problem in upgrading, we would however face a warning everytime we
> run a server task which I described in [1]. I have been thinking a lot of a
> solution and I think I am close to getting something done.
>
> So I would suggest yeah go for it and I will try to accelerate a solution
> to resolve this warning since it fundamentally changes how we invoke server
> tasks
>
> [1] https://issues.apache.org/jira/browse/OFBIZ-9972
>
> On Mar 1, 2018 1:43 AM, "Michael Brohl" <[hidden email]> wrote:
>
> Hi all,
>
> I wanted to check if the current OFBiz version is running under the latest
> early access version of Oracle JDK 10 and what it takes to make it work.
>
> The current Gradle version we use is not able to detect the Java version
> correctly and must be updated for it. I changed the
> gradle-wrapper.properties to use Gradle 4.6 and now JDK 10 is detected. The
> project does not compile but this would be part of the next steps.
>
> Can we/do we want to upgrade Gradle to version 4.6 or are there any
> objections against it?
>
> If we want to upgrade, I would file a Jira for this task, try to make
> everything work with JDK 1.8 first and provide a patch for it.
>
> Thanks and regards,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
>

Reply | Threaded
Open this post in threaded view
|

Re: Upgrade to latest Gradle version 4.6?

taher
Yeah I still did not come up with a solution, and if we don't do this
right it might be disturbing to our users who are used to the syntax
by now.

Essentially, my problem is that if we move the arguments from the task
name e.g. "ofbiz --load-data readers=seed" to flags e.g. "gradlew
ofbiz -Pargs="--load-data readers=seed" is that you cannot run more
than one OFBiz command at the same time (annoying). A solution might
be to have each OFBiz command hold its own args as in ./gradlew ofbiz
-Pargs1="--load-data readers=seed" However, it seems you cannot call
the same task name twice with different arguments, so gradle will
consider it one call.

Whatever solution we come up with, you and I will quickly adjust to
it, I'm worried about the rest of the users. That's why I'm taking it
slow here

On Thu, May 17, 2018 at 11:54 AM, Nicolas Malin
<[hidden email]> wrote:

> Hello,
>
> I found the same situation Michael to use java 10
>
> I updated to gradle 4.7 so if you are always ok, I can realize the update
> version on trunk.
>
> Taher thanks for your alert with gradle 5, I will take care about that and
> try do find some ideas.
>
> Just for information, I compiled ofbiz trunk on jdk10 with update
> build.gradle :$
>
> svn diff build.gradle
> Index: build.gradle
> @@ -200,6 +200,8 @@
>  excludedJavaSources.add
> 'org/apache/ofbiz/order/thirdparty/taxware/TaxwareUTL.java'
> +excludedJavaSources.add
> 'org/apache/ofbiz/content/survey/PdfSurveyServices.java'
> +excludedJavaSources.add
> 'org/apache/ofbiz/content/compdoc/CompDocServices.java'
>
> Ok it's not a good solution, now I will understand how solve
> CompDocServices.java and PdfSurveyServices.java correctly :)
>
> Nicolas
>
>
>
> On 28/02/2018 23:50, Taher Alkhateeb wrote:
>>
>> Hi Michael,
>>
>> I see no problem in upgrading, we would however face a warning everytime
>> we
>> run a server task which I described in [1]. I have been thinking a lot of
>> a
>> solution and I think I am close to getting something done.
>>
>> So I would suggest yeah go for it and I will try to accelerate a solution
>> to resolve this warning since it fundamentally changes how we invoke
>> server
>> tasks
>>
>> [1] https://issues.apache.org/jira/browse/OFBIZ-9972
>>
>> On Mar 1, 2018 1:43 AM, "Michael Brohl" <[hidden email]> wrote:
>>
>> Hi all,
>>
>> I wanted to check if the current OFBiz version is running under the latest
>> early access version of Oracle JDK 10 and what it takes to make it work.
>>
>> The current Gradle version we use is not able to detect the Java version
>> correctly and must be updated for it. I changed the
>> gradle-wrapper.properties to use Gradle 4.6 and now JDK 10 is detected.
>> The
>> project does not compile but this would be part of the next steps.
>>
>> Can we/do we want to upgrade Gradle to version 4.6 or are there any
>> objections against it?
>>
>> If we want to upgrade, I would file a Jira for this task, try to make
>> everything work with JDK 1.8 first and provide a patch for it.
>>
>> Thanks and regards,
>>
>> Michael Brohl
>> ecomify GmbH
>> www.ecomify.de
>>
>