OFBiz › OFBiz - Dev

[VOTE] [RELEASE] Apache OFBiz 13.07.01

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Jacopo Cappellato-4

[VOTE] [RELEASE] Apache OFBiz 13.07.01

This is the vote thread to approve the first release for the 13.07 branch. This new release, "Apache OFBiz 13.07.01" (major release number: "13.07"; minor release number: "01") is the first release of the 13.07 series and contains all the features of the trunk up to July 2013, stabilized with bug fixes (some enhancements and refactoring) since then. It will become the OFBiz current "stable" release and users of the 12.04 series will be encouraged to migrate to this release.

This is the first release series that doesn't contain the specialpurpose components (except for the "ecommerce" component); the community may decide to release separately the specialpurpose components (all bundled together or each in its package).

The candidate release files can be downloaded from here:

https://dist.apache.org/repos/dist/dev/ofbiz/

(committers only) or from here:

http://people.apache.org/~jacopoc/dist/

(everyone else)

and are:

* apache-ofbiz-13.07.01.zip: the release package
* KEYS: text file with keys
* apache-ofbiz-13.07.01.zip.asc: the detached signature file
* apache-ofbiz-13.07.01.zip.md5, apache-ofbiz-13.07.01.zip.sha: hashes

Please download the zip file and check its signatures (for instructions on testing the signatures see http://www.apache.org/info/verification.html), then test the release.

Vote:

[ +1] release as Apache OFBiz 13.07.01
[ -1] do not release

This vote will be closed in 5 days.
For more details about this process please read http://www.apache.org/foundation/voting.html

The following text is quoted from the above url:
"Votes on whether a package is ready to be released use majority approval -- i.e. at least three PMC members must vote affirmatively for release, and there must be more positive than negative votes. Releases may not be vetoed. Generally the community will cancel the release vote if anyone identifies serious problems, but in most cases the ultimate decision, lies with the individual serving as release manager."

Kind Regards,

Jacopo

Jacques Le Roux

Re: [VOTE] [RELEASE] Apache OFBiz 13.07.01

Administrator

+0 (miss below ;)

MD5 OK

Failure in run tests in Windows 7

production-run-tests.testProductionRunDateChange Failure Assertion failed: ([taskTimeDifference=-3600000.0] equals 0.0 as Double OR
[taskTimeDifference=-3600000.0] equals 1.0 as Double OR [taskTimeDifference=-3600000.0] equals -1.0 as Double OR )

junit.framework.AssertionFailedError: Assertion failed: ([taskTimeDifference=-3600000.0] equals 0.0 as Double OR [taskTimeDifference=-3600000.0]
equals 1.0 as Double OR [taskTimeDifference=-3600000.0] equals -1.0 as Double OR )
at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:147)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:238)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:340)
at org.ofbiz.base.start.Start.start(Start.java:382)
at org.ofbiz.base.start.Start.main(Start.java:122)

Same failure in Ubuntu 13.10 running in virtualbox on Windows7

I don't vote -1 because on Buildbot all is OK: http://ci.apache.org/builders/ofbiz-branch13 including last commit
r1579547 (in revision-of-13.07.01.txt) is actually not an OFBiz commit http://svn.apache.org/viewvc?view=revision&revision=1579547
The last one is 1579328, we should rather put this value in revision-of-13.07.01.txt

Jacques

Le 20/03/2014 09:55, Jacopo Cappellato a écrit :

> This is the vote thread to approve the first release for the 13.07 branch. This new release, "Apache OFBiz 13.07.01" (major release number: "13.07"; minor release number: "01") is the first release of the 13.07 series and contains all the features of the trunk up to July 2013, stabilized with bug fixes (some enhancements and refactoring) since then. It will become the OFBiz current "stable" release and users of the 12.04 series will be encouraged to migrate to this release.
>
> This is the first release series that doesn't contain the specialpurpose components (except for the "ecommerce" component); the community may decide to release separately the specialpurpose components (all bundled together or each in its package).
>
> The candidate release files can be downloaded from here:
>
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> (committers only) or from here:
>
> http://people.apache.org/~jacopoc/dist/
>
> (everyone else)
>
> and are:
>
> * apache-ofbiz-13.07.01.zip: the release package
> * KEYS: text file with keys
> * apache-ofbiz-13.07.01.zip.asc: the detached signature file
> * apache-ofbiz-13.07.01.zip.md5, apache-ofbiz-13.07.01.zip.sha: hashes
>
> Please download the zip file and check its signatures (for instructions on testing the signatures see http://www.apache.org/info/verification.html), then test the release.
>
> Vote:
>
> [ +1] release as Apache OFBiz 13.07.01
> [ -1] do not release
>
> This vote will be closed in 5 days.
> For more details about this process please read http://www.apache.org/foundation/voting.html
>
> The following text is quoted from the above url:
> "Votes on whether a package is ready to be released use majority approval -- i.e. at least three PMC members must vote affirmatively for release, and there must be more positive than negative votes. Releases may not be vetoed. Generally the community will cancel the release vote if anyone identifies serious problems, but in most cases the ultimate decision, lies with the individual serving as release manager."
>
> Kind Regards,
>
> Jacopo
>

Christian Geisert

Re: [VOTE] [RELEASE] Apache OFBiz 13.07.01

Am 22.03.2014 20:48, schrieb Jacques Le Roux:

I can confirm this failure (Java 1.6.0_38 under Ubuntu) - changing
Locale to en doesn't help. Same problem with trunk.

I'll try to have a closer look later (insert $RANT about Minilang)

Apart from that I didn't notice any issues (signature/md5 ok, creating
orders from backend and shop etc.)

Christian

Pierre Smits

Re: [VOTE] [RELEASE] Apache OFBiz 13.07.01

In reply to this post by Jacques Le Roux

-1

For the following reasons:

1)
The issues as described in OFBIZ-4130 and OFBIZ-5319 are not resolved.
Given that the main issue (4130) is now more than 3 years old without being
addressed and the second more than 6 months old.
Not addressing such a security issue for reasons like 'i don't experienced
this issue in my (augmented version) of OFBiz' or 'I don't understand what
the issue is about' is putting users - who want to use OFBiz for its
multi-tenancy aspect - to risk.

2)
Removal of (all but one) special purpose applications - or including new
ones (in future releases) - should not take place without

1. A formal vote on inclusion/exclusion of each of the special purpose
apps, given the controversies expressed in the past by several community
members, including committers like Adrian, Hans and Jacques. Rereading
those mail threads didn't convince me that there was consensus on the
subject.
2. having mechanisms (explanatory documents in the website and wiki, but
also download placeholders) in place to enable users to download excluded
special purpose apps.
Given that we advice users to download stable releases we should not
expose users to having to download nightly builds of trunk so they can
extract the apps they want/need from the special purpose folder.

Regards,

Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Sat, Mar 22, 2014 at 8:48 PM, Jacques Le Roux <
[hidden email]> wrote:

> +0 (miss below ;)
>
> MD5 OK
>
> Failure in run tests in Windows 7
>
> production-run-tests.testProductionRunDateChange Failure Assertion
> failed: ([taskTimeDifference=-3600000.0] equals 0.0 as Double OR
> [taskTimeDifference=-3600000.0] equals 1.0 as Double OR
> [taskTimeDifference=-3600000.0] equals -1.0 as Double OR )
>
> junit.framework.AssertionFailedError: Assertion failed:
> ([taskTimeDifference=-3600000.0] equals 0.0 as Double OR
> [taskTimeDifference=-3600000.0] equals 1.0 as Double OR
> [taskTimeDifference=-3600000.0] equals -1.0 as Double OR )
> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:147)
> at org.ofbiz.base.container.ContainerLoader.start(
> ContainerLoader.java:238)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:340)
> at org.ofbiz.base.start.Start.start(Start.java:382)
> at org.ofbiz.base.start.Start.main(Start.java:122)
>
> Same failure in Ubuntu 13.10 running in virtualbox on Windows7
>
> I don't vote -1 because on Buildbot all is OK:
> http://ci.apache.org/builders/ofbiz-branch13 including last commit
> r1579547 (in revision-of-13.07.01.txt) is actually not an OFBiz commit
> http://svn.apache.org/viewvc?view=revision&revision=1579547
> The last one is 1579328, we should rather put this value in
> revision-of-13.07.01.txt
>
> Jacques
>
>
> Le 20/03/2014 09:55, Jacopo Cappellato a écrit :
>
> This is the vote thread to approve the first release for the 13.07
>> branch. This new release, "Apache OFBiz 13.07.01" (major release number:
>> "13.07"; minor release number: "01") is the first release of the 13.07
>> series and contains all the features of the trunk up to July 2013,
>> stabilized with bug fixes (some enhancements and refactoring) since then.
>> It will become the OFBiz current "stable" release and users of the 12.04
>> series will be encouraged to migrate to this release.
>>
>> This is the first release series that doesn't contain the specialpurpose
>> components (except for the "ecommerce" component); the community may decide
>> to release separately the specialpurpose components (all bundled together
>> or each in its package).
>>
>> The candidate release files can be downloaded from here:
>>
>> https://dist.apache.org/repos/dist/dev/ofbiz/
>>
>> (committers only) or from here:
>>
>> http://people.apache.org/~jacopoc/dist/
>>
>> (everyone else)
>>
>> and are:
>>
>> * apache-ofbiz-13.07.01.zip: the release package
>> * KEYS: text file with keys
>> * apache-ofbiz-13.07.01.zip.asc: the detached signature file
>> * apache-ofbiz-13.07.01.zip.md5, apache-ofbiz-13.07.01.zip.sha: hashes
>>
>> Please download the zip file and check its signatures (for instructions
>> on testing the signatures see http://www.apache.org/info/
>> verification.html), then test the release.
>>
>> Vote:
>>
>> [ +1] release as Apache OFBiz 13.07.01
>> [ -1] do not release
>>
>> This vote will be closed in 5 days.
>> For more details about this process please read http://www.apache.org/
>> foundation/voting.html
>>
>> The following text is quoted from the above url:
>> "Votes on whether a package is ready to be released use majority approval
>> -- i.e. at least three PMC members must vote affirmatively for release, and
>> there must be more positive than negative votes. Releases may not be
>> vetoed. Generally the community will cancel the release vote if anyone
>> identifies serious problems, but in most cases the ultimate decision, lies
>> with the individual serving as release manager."
>>
>> Kind Regards,
>>
>> Jacopo
>>
>>

Christian Geisert

Re: [VOTE] [RELEASE] Apache OFBiz 13.07.01

In reply to this post by Christian Geisert

Am 23.03.2014 00:09, schrieb Christian Geisert:

> Am 22.03.2014 20:48, schrieb Jacques Le Roux:
>> +0 (miss below ;)
>>
>> MD5 OK
>>
>> Failure in run tests in Windows 7
>>
>> production-run-tests.testProductionRunDateChange Failure Assertion
>> failed: ([taskTimeDifference=-3600000.0] equals 0.0 as Double OR
>> [taskTimeDifference=-3600000.0] equals 1.0 as Double OR
>> [taskTimeDifference=-3600000.0] equals -1.0 as Double OR )
>>
>> junit.framework.AssertionFailedError: Assertion failed:
>> ([taskTimeDifference=-3600000.0] equals 0.0 as Double OR
>> [taskTimeDifference=-3600000.0] equals 1.0 as Double OR
>> [taskTimeDifference=-3600000.0] equals -1.0 as Double OR )
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:147)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:238)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:340)
>> at org.ofbiz.base.start.Start.start(Start.java:382)
>> at org.ofbiz.base.start.Start.main(Start.java:122)
>>
>> Same failure in Ubuntu 13.10 running in virtualbox on Windows7
>
> I can confirm this failure (Java 1.6.0_38 under Ubuntu) - changing
> Locale to en doesn't help. Same problem with trunk.
>
> I'll try to have a closer look later (insert $RANT about Minilang)

Wow, that was fun ;-)

There's actually a hint inside the code:


And there is a DST next week here in Germany...

But the difference is calculated in millisecs and not in hours so the
allowed difference should be +/- 60 * 60 * 1000 ms

I don't think this is a showstopper for the release (the actual
calculating is right, just a bug in the test - and it will last for just
one week...)

So +1 for the release

Christian

Jacopo Cappellato-4

Re: [VOTE] [RELEASE] Apache OFBiz 13.07.01

Christian, thank you for digging into this issue.
I would actually prefer to cancel this vote, and prepare a new set of release files and then start again.

Jacopo

On Mar 23, 2014, at 3:10 AM, Christian Geisert <[hidden email]> wrote:

> Am 23.03.2014 00:09, schrieb Christian Geisert:
>> Am 22.03.2014 20:48, schrieb Jacques Le Roux:
>>> +0 (miss below ;)
>>>
>>> MD5 OK
>>>
>>> Failure in run tests in Windows 7
>>>
>>> production-run-tests.testProductionRunDateChange Failure Assertion
>>> failed: ([taskTimeDifference=-3600000.0] equals 0.0 as Double OR
>>> [taskTimeDifference=-3600000.0] equals 1.0 as Double OR
>>> [taskTimeDifference=-3600000.0] equals -1.0 as Double OR )
>>>
>>> junit.framework.AssertionFailedError: Assertion failed:
>>> ([taskTimeDifference=-3600000.0] equals 0.0 as Double OR
>>> [taskTimeDifference=-3600000.0] equals 1.0 as Double OR
>>> [taskTimeDifference=-3600000.0] equals -1.0 as Double OR )
>>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:147)
>>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:238)
>>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:340)
>>> at org.ofbiz.base.start.Start.start(Start.java:382)
>>> at org.ofbiz.base.start.Start.main(Start.java:122)
>>>
>>> Same failure in Ubuntu 13.10 running in virtualbox on Windows7
>>
>> I can confirm this failure (Java 1.6.0_38 under Ubuntu) - changing
>> Locale to en doesn't help. Same problem with trunk.
>>
>> I'll try to have a closer look later (insert $RANT about Minilang)
>
> Wow, that was fun ;-)
>
> There's actually a hint inside the code:
> 
>
> And there is a DST next week here in Germany...
>
> But the difference is calculated in millisecs and not in hours so the
> allowed difference should be +/- 60 * 60 * 1000 ms
>
> I don't think this is a showstopper for the release (the actual
> calculating is right, just a bug in the test - and it will last for just
> one week...)
>
> So +1 for the release
>
> Christian
>

Jacopo Cappellato-4

[CANCEL] [VOTE] [RELEASE] Apache OFBiz 13.07.01

In reply to this post by Jacopo Cappellato-4

The vote has been cancelled in order to fix some of the issues that have been reported (at least, because it is preventing the tests to pass, the DST issue reported by Jacques and analyzed/fixed by Christian).
I am going to prepare a new set of candidate release files soon and then I will start a new vote.
Thanks for all your feedback!

Jacopo

On Mar 20, 2014, at 9:55 AM, Jacopo Cappellato <[hidden email]> wrote: