[Vote] upgrading OFBiz to JDK 8 on trunk
Locked
 
|
Hi Everyone,
May I suggest a vote in reference to the email thread and JIRA mentioned below on what follows: 1- actually upgrade to JDK 8 (by applying the patches in JIRA). 2- commit functional and Java 8 code into trunk going forward . 3- upgrade infrastructure (demo, build, ...) to host OFBiz on JDK 8 . The patches and the code to move to JDK 8 are ready and tested with at least "./ant clean-all load-demo run-tests" on JDK 8u45 and all 882 tests pass from my side. I also logged into the system and navigated to a few random screens just to run some smoke tests randomly and I did not encounter any problems. Mail Thread: http://markmail.org/message/wbomdrdwl77yntx4 JIRA: https://issues.apache.org/jira/browse/OFBIZ-6458 Taher Alkhateeb |
Re: [Vote] upgrading OFBiz to JDK 8 on trunk
Administrator
|
Hi Taher, All,
This was a bit premature, but I think now that Adrian has agreed about using LinkedHashMap in StringUtil substitutionPatternMap (with an improvement on thread-safety, also thanks Scoot for confirmation about the origin of the issue) and fixed generics for ECJ (Eclipse compiler for internal Java auto-completion), we should do a vote again about allowing to use Java 8 new features in trunk. I can take care of the infrastructure upgrade... Note: I just successfully ran the tests again with jdk1.8.0_31 on Win 7 (trunk HEAD) Jacques Le 08/06/2015 12:56, Taher Alkhateeb a écrit : > Hi Everyone, > > May I suggest a vote in reference to the email thread and JIRA mentioned below on what follows: > 1- actually upgrade to JDK 8 (by applying the patches in JIRA). > 2- commit functional and Java 8 code into trunk going forward . > 3- upgrade infrastructure (demo, build, ...) to host OFBiz on JDK 8 . > > The patches and the code to move to JDK 8 are ready and tested with at least "./ant clean-all load-demo run-tests" on JDK 8u45 and all 882 tests pass from my side. I also logged into the system and navigated to a few random screens just to run some smoke tests randomly and I did not encounter any problems. > > Mail Thread: http://markmail.org/message/wbomdrdwl77yntx4 > JIRA: https://issues.apache.org/jira/browse/OFBIZ-6458 > > Taher Alkhateeb > |
Re: [Vote] upgrading OFBiz to JDK 8 on trunk
|
Administrator
|
BTW, as I just wrote at OFBIZ-6458 we could simply use a lazy consensus. So I propose that if nobody is against we commit the last 2 patches at
OFBIZ-6458 and then allow to commit Java 8 specific code. Though if we want the trunk demo and build to work we need to make some infra changes before. I will look at it this weekend, nothing prevents us to already run the trunk with Java 8. Jacques Le 18/06/2015 15:09, Jacques Le Roux a écrit : > Hi Taher, All, > > This was a bit premature, but I think now that Adrian has agreed about using LinkedHashMap in StringUtil substitutionPatternMap (with an improvement > on thread-safety, also thanks Scoot for confirmation about the origin of the issue) and fixed generics for ECJ (Eclipse compiler for internal Java > auto-completion), we should do a vote again about allowing to use Java 8 new features in trunk. I can take care of the infrastructure upgrade... > > Note: I just successfully ran the tests again with jdk1.8.0_31 on Win 7 (trunk HEAD) > > Jacques > > Le 08/06/2015 12:56, Taher Alkhateeb a écrit : >> Hi Everyone, >> >> May I suggest a vote in reference to the email thread and JIRA mentioned below on what follows: >> 1- actually upgrade to JDK 8 (by applying the patches in JIRA). >> 2- commit functional and Java 8 code into trunk going forward . >> 3- upgrade infrastructure (demo, build, ...) to host OFBiz on JDK 8 . >> >> The patches and the code to move to JDK 8 are ready and tested with at least "./ant clean-all load-demo run-tests" on JDK 8u45 and all 882 tests >> pass from my side. I also logged into the system and navigated to a few random screens just to run some smoke tests randomly and I did not >> encounter any problems. >> >> Mail Thread: http://markmail.org/message/wbomdrdwl77yntx4 >> JIRA: https://issues.apache.org/jira/browse/OFBIZ-6458 >> >> Taher Alkhateeb >> > |
Re: [Vote] upgrading OFBiz to JDK 8 on trunk
|
Ok for me, move to the height level :)
Nicolas Le 18/06/2015 21:36, Jacques Le Roux a écrit : > BTW, as I just wrote at OFBIZ-6458 we could simply use a lazy > consensus. So I propose that if nobody is against we commit the last 2 > patches at OFBIZ-6458 and then allow to commit Java 8 specific code. > Though if we want the trunk demo and build to work we need to make > some infra changes before. I will look at it this weekend, nothing > prevents us to already run the trunk with Java 8. > > Jacques > > Le 18/06/2015 15:09, Jacques Le Roux a écrit : >> Hi Taher, All, >> >> This was a bit premature, but I think now that Adrian has agreed >> about using LinkedHashMap in StringUtil substitutionPatternMap (with >> an improvement on thread-safety, also thanks Scoot for confirmation >> about the origin of the issue) and fixed generics for ECJ (Eclipse >> compiler for internal Java auto-completion), we should do a vote >> again about allowing to use Java 8 new features in trunk. I can take >> care of the infrastructure upgrade... >> >> Note: I just successfully ran the tests again with jdk1.8.0_31 on Win >> 7 (trunk HEAD) >> >> Jacques >> >> Le 08/06/2015 12:56, Taher Alkhateeb a écrit : >>> Hi Everyone, >>> >>> May I suggest a vote in reference to the email thread and JIRA >>> mentioned below on what follows: >>> 1- actually upgrade to JDK 8 (by applying the patches in JIRA). >>> 2- commit functional and Java 8 code into trunk going forward . >>> 3- upgrade infrastructure (demo, build, ...) to host OFBiz on JDK 8 . >>> >>> The patches and the code to move to JDK 8 are ready and tested with >>> at least "./ant clean-all load-demo run-tests" on JDK 8u45 and all >>> 882 tests pass from my side. I also logged into the system and >>> navigated to a few random screens just to run some smoke tests >>> randomly and I did not encounter any problems. >>> >>> Mail Thread: http://markmail.org/message/wbomdrdwl77yntx4 >>> JIRA: https://issues.apache.org/jira/browse/OFBIZ-6458 >>> >>> Taher Alkhateeb >>> >> |
|
|
All tests pass from my side on Debian Linux with JDK 8 U 45 after applying
the commits in OFBIZ-6458 and thanks to Adrian we have all other issues ironed out. Taher Alkhateeb On Jun 18, 2015 10:48 PM, "Nicolas Malin" <[hidden email]> wrote: > Ok for me, move to the height level :) > > Nicolas > > Le 18/06/2015 21:36, Jacques Le Roux a écrit : > >> BTW, as I just wrote at OFBIZ-6458 we could simply use a lazy consensus. >> So I propose that if nobody is against we commit the last 2 patches at >> OFBIZ-6458 and then allow to commit Java 8 specific code. >> Though if we want the trunk demo and build to work we need to make some >> infra changes before. I will look at it this weekend, nothing prevents us >> to already run the trunk with Java 8. >> >> Jacques >> >> Le 18/06/2015 15:09, Jacques Le Roux a écrit : >> >>> Hi Taher, All, >>> >>> This was a bit premature, but I think now that Adrian has agreed about >>> using LinkedHashMap in StringUtil substitutionPatternMap (with an >>> improvement on thread-safety, also thanks Scoot for confirmation about the >>> origin of the issue) and fixed generics for ECJ (Eclipse compiler for >>> internal Java auto-completion), we should do a vote again about allowing to >>> use Java 8 new features in trunk. I can take care of the infrastructure >>> upgrade... >>> >>> Note: I just successfully ran the tests again with jdk1.8.0_31 on Win 7 >>> (trunk HEAD) >>> >>> Jacques >>> >>> Le 08/06/2015 12:56, Taher Alkhateeb a écrit : >>> >>>> Hi Everyone, >>>> >>>> May I suggest a vote in reference to the email thread and JIRA >>>> mentioned below on what follows: >>>> 1- actually upgrade to JDK 8 (by applying the patches in JIRA). >>>> 2- commit functional and Java 8 code into trunk going forward . >>>> 3- upgrade infrastructure (demo, build, ...) to host OFBiz on JDK 8 . >>>> >>>> The patches and the code to move to JDK 8 are ready and tested with at >>>> least "./ant clean-all load-demo run-tests" on JDK 8u45 and all 882 tests >>>> pass from my side. I also logged into the system and navigated to a few >>>> random screens just to run some smoke tests randomly and I did not >>>> encounter any problems. >>>> >>>> Mail Thread: http://markmail.org/message/wbomdrdwl77yntx4 >>>> JIRA: https://issues.apache.org/jira/browse/OFBIZ-6458 >>>> >>>> Taher Alkhateeb >>>> >>>> >>> > |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |