What is the meaning of the code in JmsListenerFactory?

[Jacopo Cappellato-4]

Hi all,

could you please help me to understand the meaning of the code in JmsListenerFactory that deals with the initialization of listeners? I am confused and before I touch it I would like to be sure I am not missing anything.

Specifically:

1) what is the purpose of the while block in the run() method?
2) under what circumstances the loadListener method could return a null object? or a listener that is not connected?

Kind regards,

Jacopo

[Jacopo Cappellato-4]

On Jul 26, 2012, at 5:15 PM, Jacopo Cappellato wrote:

> Hi all,
>
> could you please help me to understand the meaning of the code in JmsListenerFactory that deals with the initialization of listeners? I am confused and before I touch it I would like to be sure I am not missing anything.
>
> Specifically:
>
> 1) what is the purpose of the while block in the run() method?
> 2) under what circumstances the loadListener method could return a null object? or a listener that is not connected?

3) why are we composing the "serverKey" concatenating server.jndi-server-name + server.jndi-name + server.topic-queue rather then the simpler jms-service.name + server.jndi-server-name? this latter form guarantees that the key is unique while the former doesn't.

>
> Kind regards,
>
> Jacopo
>
>

[Jacques Le Roux]

Hi Jacopo,

Did you continue to investigate ?

Thanks

Jacques


Le 26/07/2012 à 17:41, Jacopo Cappellato a écrit :

> On Jul 26, 2012, at 5:15 PM, Jacopo Cappellato wrote:
>
>> Hi all,
>>
>> could you please help me to understand the meaning of the code in JmsListenerFactory that deals with the initialization of listeners? I am confused and before I touch it I would like to be sure I am not missing anything.
>>
>> Specifically:
>>
>> 1) what is the purpose of the while block in the run() method?
>> 2) under what circumstances the loadListener method could return a null object? or a listener that is not connected?
> 3) why are we composing the "serverKey" concatenating server.jndi-server-name + server.jndi-name + server.topic-queue rather then the simpler jms-service.name + server.jndi-server-name? this latter form guarantees that the key is unique while the former doesn't.
>
>> Kind regards,
>>
>> Jacopo
>>
>>
>

[Jacopo Cappellato-5]

Hi Jacques,

if I well remember at that time I concluded that rather than trying to
improve that code it was better to re-design (e.g. leveraging Apache
Camel) and implement from scratch once the need would arise.

Jacopo

On Wed, Aug 16, 2017 at 9:48 AM, Jacques Le Roux <
[hidden email]> wrote:

> Hi Jacopo,
>
> Did you continue to investigate ?
>
> Thanks
>
> Jacques
>
>
> Le 26/07/2012 à 17:41, Jacopo Cappellato a écrit :
>
>> On Jul 26, 2012, at 5:15 PM, Jacopo Cappellato wrote:
>>
>> Hi all,
>>>
>>> could you please help me to understand the meaning of the code in
>>> JmsListenerFactory that deals with the initialization of listeners? I am
>>> confused and before I touch it I would like to be sure I am not missing
>>> anything.
>>>
>>> Specifically:
>>>
>>> 1) what is the purpose of the while block in the run() method?
>>> 2) under what circumstances the loadListener method could return a null
>>> object? or a listener that is not connected?
>>>
>> 3) why are we composing the "serverKey" concatenating
>> server.jndi-server-name + server.jndi-name + server.topic-queue rather then
>> the simpler jms-service.name + server.jndi-server-name? this latter form
>> guarantees that the key is unique while the former doesn't.
>>
>> Kind regards,
>>>
>>> Jacopo
>>>
>>>
>>>
>>
>

[Jacques Le Roux]

OK, thanks

So should I also close related Jiras like https://issues.apache.org/jira/browse/OFBIZ-4453 ?

Jacques


Le 16/08/2017 à 10:04, Jacopo Cappellato a écrit :

> Hi Jacques,
>
> if I well remember at that time I concluded that rather than trying to
> improve that code it was better to re-design (e.g. leveraging Apache
> Camel) and implement from scratch once the need would arise.
>
> Jacopo
>
> On Wed, Aug 16, 2017 at 9:48 AM, Jacques Le Roux <
> [hidden email]> wrote:
>
>> Hi Jacopo,
>>
>> Did you continue to investigate ?
>>
>> Thanks
>>
>> Jacques
>>
>>
>> Le 26/07/2012 à 17:41, Jacopo Cappellato a écrit :
>>
>>> On Jul 26, 2012, at 5:15 PM, Jacopo Cappellato wrote:
>>>
>>> Hi all,
>>>> could you please help me to understand the meaning of the code in
>>>> JmsListenerFactory that deals with the initialization of listeners? I am
>>>> confused and before I touch it I would like to be sure I am not missing
>>>> anything.
>>>>
>>>> Specifically:
>>>>
>>>> 1) what is the purpose of the while block in the run() method?
>>>> 2) under what circumstances the loadListener method could return a null
>>>> object? or a listener that is not connected?
>>>>
>>> 3) why are we composing the "serverKey" concatenating
>>> server.jndi-server-name + server.jndi-name + server.topic-queue rather then
>>> the simpler jms-service.name + server.jndi-server-name? this latter form
>>> guarantees that the key is unique while the former doesn't.
>>>
>>> Kind regards,
>>>> Jacopo
>>>>
>>>>
>>>>

[Michael Brohl-3]

Hi Jacques,

I would leave it open because it serves as a reminder to work on this.

It's on our agenda because we have projects which make use of JMS/Camel.
And there are ideas to make this compatible with the OFBiz standard.

Thanks,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 16.08.17 um 10:31 schrieb Jacques Le Roux:

> OK, thanks
>
> So should I also close related Jiras like
> https://issues.apache.org/jira/browse/OFBIZ-4453 ?
>
> Jacques
>
>
> Le 16/08/2017 à 10:04, Jacopo Cappellato a écrit :
>> Hi Jacques,
>>
>> if I well remember at that time I concluded that rather than trying to
>> improve that code it was better to re-design (e.g. leveraging Apache
>> Camel) and implement from scratch once the need would arise.
>>
>> Jacopo
>>
>> On Wed, Aug 16, 2017 at 9:48 AM, Jacques Le Roux <
>> [hidden email]> wrote:
>>
>>> Hi Jacopo,
>>>
>>> Did you continue to investigate ?
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>> Le 26/07/2012 à 17:41, Jacopo Cappellato a écrit :
>>>
>>>> On Jul 26, 2012, at 5:15 PM, Jacopo Cappellato wrote:
>>>>
>>>> Hi all,
>>>>> could you please help me to understand the meaning of the code in
>>>>> JmsListenerFactory that deals with the initialization of
>>>>> listeners? I am
>>>>> confused and before I touch it I would like to be sure I am not
>>>>> missing
>>>>> anything.
>>>>>
>>>>> Specifically:
>>>>>
>>>>> 1) what is the purpose of the while block in the run() method?
>>>>> 2) under what circumstances the loadListener method could return a
>>>>> null
>>>>> object? or a listener that is not connected?
>>>>>
>>>> 3) why are we composing the "serverKey" concatenating
>>>> server.jndi-server-name + server.jndi-name + server.topic-queue
>>>> rather then
>>>> the simpler jms-service.name + server.jndi-server-name? this latter
>>>> form
>>>> guarantees that the key is unique while the former doesn't.
>>>>
>>>> Kind regards,
>>>>> Jacopo
>>>>>
>>>>>
>>>>>
>

[Jacques Le Roux]

OK Michael,

In the meantime, I simply did OFBIZ-4454

Jacques


Le 16/08/2017 à 10:43, Michael Brohl a écrit :

> Hi Jacques,
>
> I would leave it open because it serves as a reminder to work on this.
>
> It's on our agenda because we have projects which make use of JMS/Camel. And there are ideas to make this compatible with the OFBiz standard.
>
> Thanks,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
>
>
> Am 16.08.17 um 10:31 schrieb Jacques Le Roux:
>> OK, thanks
>>
>> So should I also close related Jiras like https://issues.apache.org/jira/browse/OFBIZ-4453 ?
>>
>> Jacques
>>
>>
>> Le 16/08/2017 à 10:04, Jacopo Cappellato a écrit :
>>> Hi Jacques,
>>>
>>> if I well remember at that time I concluded that rather than trying to
>>> improve that code it was better to re-design (e.g. leveraging Apache
>>> Camel) and implement from scratch once the need would arise.
>>>
>>> Jacopo
>>>
>>> On Wed, Aug 16, 2017 at 9:48 AM, Jacques Le Roux <
>>> [hidden email]> wrote:
>>>
>>>> Hi Jacopo,
>>>>
>>>> Did you continue to investigate ?
>>>>
>>>> Thanks
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 26/07/2012 à 17:41, Jacopo Cappellato a écrit :
>>>>
>>>>> On Jul 26, 2012, at 5:15 PM, Jacopo Cappellato wrote:
>>>>>
>>>>> Hi all,
>>>>>> could you please help me to understand the meaning of the code in
>>>>>> JmsListenerFactory that deals with the initialization of listeners? I am
>>>>>> confused and before I touch it I would like to be sure I am not missing
>>>>>> anything.
>>>>>>
>>>>>> Specifically:
>>>>>>
>>>>>> 1) what is the purpose of the while block in the run() method?
>>>>>> 2) under what circumstances the loadListener method could return a null
>>>>>> object? or a listener that is not connected?
>>>>>>
>>>>> 3) why are we composing the "serverKey" concatenating
>>>>> server.jndi-server-name + server.jndi-name + server.topic-queue rather then
>>>>> the simpler jms-service.name + server.jndi-server-name? this latter form
>>>>> guarantees that the key is unique while the former doesn't.
>>>>>
>>>>> Kind regards,
>>>>>> Jacopo
>>>>>>
>>>>>>
>>>>>>
>>
>
>