What is the purpose of the two .jj files we have in OFBiz (Parser.jj and JSON.jj) and the associated ant tasks "ofbiz-javacc" and "ofbiz-jjtree"?
Thanks, Jacopo |
I think they're for Adam's sql component, no idea if that work was ever finished.
Regards Scott On 23/03/2012, at 8:58 PM, Jacopo Cappellato wrote: > What is the purpose of the two .jj files we have in OFBiz (Parser.jj and JSON.jj) and the associated ant tasks "ofbiz-javacc" and "ofbiz-jjtree"? > > Thanks, > > Jacopo > |
can we remove them? If we get rid of this we will be able to clean a few things (i.e. remove $OFBIZ_HOME/lib/build/javac and a few more tasks)
Jacopo On Mar 23, 2012, at 9:00 AM, Scott Gray wrote: > I think they're for Adam's sql component, no idea if that work was ever finished. > > Regards > Scott > > On 23/03/2012, at 8:58 PM, Jacopo Cappellato wrote: > >> What is the purpose of the two .jj files we have in OFBiz (Parser.jj and JSON.jj) and the associated ant tasks "ofbiz-javacc" and "ofbiz-jjtree"? >> >> Thanks, >> >> Jacopo >> > |
My general rule of thumb is that if the application components aren't using it then it doesn't belong in the framework.
Regards Scott On 23/03/2012, at 9:07 PM, Jacopo Cappellato wrote: > can we remove them? If we get rid of this we will be able to clean a few things (i.e. remove $OFBIZ_HOME/lib/build/javac and a few more tasks) > > Jacopo > > On Mar 23, 2012, at 9:00 AM, Scott Gray wrote: > >> I think they're for Adam's sql component, no idea if that work was ever finished. >> >> Regards >> Scott >> >> On 23/03/2012, at 8:58 PM, Jacopo Cappellato wrote: >> >>> What is the purpose of the two .jj files we have in OFBiz (Parser.jj and JSON.jj) and the associated ant tasks "ofbiz-javacc" and "ofbiz-jjtree"? >>> >>> Thanks, >>> >>> Jacopo >>> >> > |
Scott you are right. But the components wont compile without them.
I recommend, refactor the components first, then we can tell what is needed and what is not. For example, base and start wont compile separately. Either move the classes that are needed by base to base, or merge them for now, until we know for sure what is needed by other component. I mean by wont compile separately, is you can not compile base as a component, then included in the classpath while compiling "start" Same thing applies to "start". On Fri, Mar 23, 2012 at 4:33 AM, Scott Gray <[hidden email]> wrote: > My general rule of thumb is that if the application components aren't using it then it doesn't belong in the framework. > > Regards > Scott > > On 23/03/2012, at 9:07 PM, Jacopo Cappellato wrote: > >> can we remove them? If we get rid of this we will be able to clean a few things (i.e. remove $OFBIZ_HOME/lib/build/javac and a few more tasks) >> >> Jacopo >> >> On Mar 23, 2012, at 9:00 AM, Scott Gray wrote: >> >>> I think they're for Adam's sql component, no idea if that work was ever finished. >>> >>> Regards >>> Scott >>> >>> On 23/03/2012, at 8:58 PM, Jacopo Cappellato wrote: >>> >>>> What is the purpose of the two .jj files we have in OFBiz (Parser.jj and JSON.jj) and the associated ant tasks "ofbiz-javacc" and "ofbiz-jjtree"? >>>> >>>> Thanks, >>>> >>>> Jacopo >>>> >>> >> > |
Hi Mansour,
I was talking more about framework features that go unused, you're talking about parts of the framework that are fundamental to the framework itself. For example my understanding of the sql component was that it would allow SQL queries against the delegator e.g. SQL -> Delegator -> SQL to database. I don't know if it was ever finished and I don't know if anyone knows how to use it, it certainly isn't used anywhere in the applications. Even if it were finished, I don't know that it needs to be in the framework but then it probably doesn't help that I don't really understand its purpose. Regards Scott On 23/03/2012, at 11:59 PM, Mansour Al Akeel wrote: > Scott you are right. But the components wont compile without them. > I recommend, refactor the components first, then we can tell what is > needed and what is not. > > For example, base and start wont compile separately. Either move the > classes that are needed by base to base, or merge them for now, until > we know for sure what is needed by other component. > > I mean by wont compile separately, is you can not compile base as a > component, then included in the classpath while compiling "start" > Same thing applies to "start". > > > > On Fri, Mar 23, 2012 at 4:33 AM, Scott Gray <[hidden email]> wrote: >> My general rule of thumb is that if the application components aren't using it then it doesn't belong in the framework. >> >> Regards >> Scott >> >> On 23/03/2012, at 9:07 PM, Jacopo Cappellato wrote: >> >>> can we remove them? If we get rid of this we will be able to clean a few things (i.e. remove $OFBIZ_HOME/lib/build/javac and a few more tasks) >>> >>> Jacopo >>> >>> On Mar 23, 2012, at 9:00 AM, Scott Gray wrote: >>> >>>> I think they're for Adam's sql component, no idea if that work was ever finished. >>>> >>>> Regards >>>> Scott >>>> >>>> On 23/03/2012, at 8:58 PM, Jacopo Cappellato wrote: >>>> >>>>> What is the purpose of the two .jj files we have in OFBiz (Parser.jj and JSON.jj) and the associated ant tasks "ofbiz-javacc" and "ofbiz-jjtree"? >>>>> >>>>> Thanks, >>>>> >>>>> Jacopo >>>>> >>>> >>> >> |
Scott,
thank you for the clarification. On Fri, Mar 23, 2012 at 7:07 AM, Scott Gray <[hidden email]> wrote: > Hi Mansour, > > I was talking more about framework features that go unused, you're talking about parts of the framework that are fundamental to the framework itself. > > For example my understanding of the sql component was that it would allow SQL queries against the delegator e.g. SQL -> Delegator -> SQL to database. I don't know if it was ever finished and I don't know if anyone knows how to use it, it certainly isn't used anywhere in the applications. Even if it were finished, I don't know that it needs to be in the framework but then it probably doesn't help that I don't really understand its purpose. > > Regards > Scott > > On 23/03/2012, at 11:59 PM, Mansour Al Akeel wrote: > >> Scott you are right. But the components wont compile without them. >> I recommend, refactor the components first, then we can tell what is >> needed and what is not. >> >> For example, base and start wont compile separately. Either move the >> classes that are needed by base to base, or merge them for now, until >> we know for sure what is needed by other component. >> >> I mean by wont compile separately, is you can not compile base as a >> component, then included in the classpath while compiling "start" >> Same thing applies to "start". >> >> >> >> On Fri, Mar 23, 2012 at 4:33 AM, Scott Gray <[hidden email]> wrote: >>> My general rule of thumb is that if the application components aren't using it then it doesn't belong in the framework. >>> >>> Regards >>> Scott >>> >>> On 23/03/2012, at 9:07 PM, Jacopo Cappellato wrote: >>> >>>> can we remove them? If we get rid of this we will be able to clean a few things (i.e. remove $OFBIZ_HOME/lib/build/javac and a few more tasks) >>>> >>>> Jacopo >>>> >>>> On Mar 23, 2012, at 9:00 AM, Scott Gray wrote: >>>> >>>>> I think they're for Adam's sql component, no idea if that work was ever finished. >>>>> >>>>> Regards >>>>> Scott >>>>> >>>>> On 23/03/2012, at 8:58 PM, Jacopo Cappellato wrote: >>>>> >>>>>> What is the purpose of the two .jj files we have in OFBiz (Parser.jj and JSON.jj) and the associated ant tasks "ofbiz-javacc" and "ofbiz-jjtree"? >>>>>> >>>>>> Thanks, >>>>>> >>>>>> Jacopo >>>>>> >>>>> >>>> >>> > |
Free forum by Nabble | Edit this page |