Why was this done?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

Why was this done?

Ruth Hoffman-2
Could someone explain to me - and ignorant OFBiz committer wannabe - why
the following method in version 9.04:

     public static GenericDelegator getGenericDelegator(String
delegatorName) { ... }

No longer exists in the DelegatorFactory class in the most recent trunk
version?

In its place I see:

     public static Delegator getDelegator(String delegatorName) {...}

Is there a reason this was changed or taken out? Should I be calling a
different method to get my 9.04 code to work with the current trunk version?

Thanks much.
Ruth
Reply | Threaded
Open this post in threaded view
|

Re: Why was this done?

BJ Freeman
did a search of the commits
http://svn.apache.org/viewvc?view=revision&revision=821391

Ruth Hoffman sent the following on 9/16/2011 1:42 PM:

> Could someone explain to me - and ignorant OFBiz committer wannabe - why
> the following method in version 9.04:
>
>     public static GenericDelegator getGenericDelegator(String
> delegatorName) { ... }
>
> No longer exists in the DelegatorFactory class in the most recent trunk
> version?
>
> In its place I see:
>
>     public static Delegator getDelegator(String delegatorName) {...}
>
> Is there a reason this was changed or taken out? Should I be calling a
> different method to get my 9.04 code to work with the current trunk
> version?
>
> Thanks much.
> Ruth
>
Reply | Threaded
Open this post in threaded view
|

Re: Why was this done?

Ruth Hoffman-2
Thanks BJ.

I guess OFBiz is not too backward compatible. Oh well, too bad. This
breaks all kinds of things in 9.04 that I'd like to carry over to 10.x.

Best Regards,
Ruth

On 9/16/11 5:14 PM, BJ Freeman wrote:

> did a search of the commits
> http://svn.apache.org/viewvc?view=revision&revision=821391
>
> Ruth Hoffman sent the following on 9/16/2011 1:42 PM:
>> Could someone explain to me - and ignorant OFBiz committer wannabe - why
>> the following method in version 9.04:
>>
>>      public static GenericDelegator getGenericDelegator(String
>> delegatorName) { ... }
>>
>> No longer exists in the DelegatorFactory class in the most recent trunk
>> version?
>>
>> In its place I see:
>>
>>      public static Delegator getDelegator(String delegatorName) {...}
>>
>> Is there a reason this was changed or taken out? Should I be calling a
>> different method to get my 9.04 code to work with the current trunk
>> version?
>>
>> Thanks much.
>> Ruth
>>
Reply | Threaded
Open this post in threaded view
|

Re: Why was this done?

BJ Freeman
one of the reasons I stuck with the minilang

Ruth Hoffman sent the following on 9/16/2011 2:21 PM:

> Thanks BJ.
>
> I guess OFBiz is not too backward compatible. Oh well, too bad. This
> breaks all kinds of things in 9.04 that I'd like to carry over to 10.x.
>
> Best Regards,
> Ruth
>
> On 9/16/11 5:14 PM, BJ Freeman wrote:
>> did a search of the commits
>> http://svn.apache.org/viewvc?view=revision&revision=821391
>>
>> Ruth Hoffman sent the following on 9/16/2011 1:42 PM:
>>> Could someone explain to me - and ignorant OFBiz committer wannabe - why
>>> the following method in version 9.04:
>>>
>>>      public static GenericDelegator getGenericDelegator(String
>>> delegatorName) { ... }
>>>
>>> No longer exists in the DelegatorFactory class in the most recent trunk
>>> version?
>>>
>>> In its place I see:
>>>
>>>      public static Delegator getDelegator(String delegatorName) {...}
>>>
>>> Is there a reason this was changed or taken out? Should I be calling a
>>> different method to get my 9.04 code to work with the current trunk
>>> version?
>>>
>>> Thanks much.
>>> Ruth
>>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Why was this done?

Ruth Hoffman-2
Hi BJ:

This could still be a problem with minilang if whoever didn't upgrade
that. Have you tried moving some custom minilang from 9.04 to 10.x? Just
curious.

Anyhow, I haven't figured out a way to use minilang when writing new
servlets - which is were this problem is most annoying.

Best Regards,
Ruth
On 9/16/11 5:29 PM, BJ Freeman wrote:

> one of the reasons I stuck with the minilang
>
> Ruth Hoffman sent the following on 9/16/2011 2:21 PM:
>> Thanks BJ.
>>
>> I guess OFBiz is not too backward compatible. Oh well, too bad. This
>> breaks all kinds of things in 9.04 that I'd like to carry over to 10.x.
>>
>> Best Regards,
>> Ruth
>>
>> On 9/16/11 5:14 PM, BJ Freeman wrote:
>>> did a search of the commits
>>> http://svn.apache.org/viewvc?view=revision&revision=821391
>>>
>>> Ruth Hoffman sent the following on 9/16/2011 1:42 PM:
>>>> Could someone explain to me - and ignorant OFBiz committer wannabe - why
>>>> the following method in version 9.04:
>>>>
>>>>       public static GenericDelegator getGenericDelegator(String
>>>> delegatorName) { ... }
>>>>
>>>> No longer exists in the DelegatorFactory class in the most recent trunk
>>>> version?
>>>>
>>>> In its place I see:
>>>>
>>>>       public static Delegator getDelegator(String delegatorName) {...}
>>>>
>>>> Is there a reason this was changed or taken out? Should I be calling a
>>>> different method to get my 9.04 code to work with the current trunk
>>>> version?
>>>>
>>>> Thanks much.
>>>> Ruth
>>>>
Reply | Threaded
Open this post in threaded view
|

Re: Why was this done?

BJ Freeman
I don't remember any problems. been a few years since I did it.
I don't believe there is any different calls in minilang at the minilang
syntax.
http://svn.apache.org/viewvc?view=revision&revision=672898
see the first three
Most my java code went though a layer that interfaced to ofbiz
so all I had to-do is change the interface.
did this to protect me from the way ofbiz kept being changed from 4.0

Ruth Hoffman sent the following on 9/16/2011 2:41 PM:

> Hi BJ:
>
> This could still be a problem with minilang if whoever didn't upgrade
> that. Have you tried moving some custom minilang from 9.04 to 10.x? Just
> curious.
>
> Anyhow, I haven't figured out a way to use minilang when writing new
> servlets - which is were this problem is most annoying.
>
> Best Regards,
> Ruth
> On 9/16/11 5:29 PM, BJ Freeman wrote:
>> one of the reasons I stuck with the minilang
>>
>> Ruth Hoffman sent the following on 9/16/2011 2:21 PM:
>>> Thanks BJ.
>>>
>>> I guess OFBiz is not too backward compatible. Oh well, too bad. This
>>> breaks all kinds of things in 9.04 that I'd like to carry over to 10.x.
>>>
>>> Best Regards,
>>> Ruth
>>>
>>> On 9/16/11 5:14 PM, BJ Freeman wrote:
>>>> did a search of the commits
>>>> http://svn.apache.org/viewvc?view=revision&revision=821391
>>>>
>>>> Ruth Hoffman sent the following on 9/16/2011 1:42 PM:
>>>>> Could someone explain to me - and ignorant OFBiz committer wannabe
>>>>> - why
>>>>> the following method in version 9.04:
>>>>>
>>>>>       public static GenericDelegator getGenericDelegator(String
>>>>> delegatorName) { ... }
>>>>>
>>>>> No longer exists in the DelegatorFactory class in the most recent
>>>>> trunk
>>>>> version?
>>>>>
>>>>> In its place I see:
>>>>>
>>>>>       public static Delegator getDelegator(String delegatorName) {...}
>>>>>
>>>>> Is there a reason this was changed or taken out? Should I be calling a
>>>>> different method to get my 9.04 code to work with the current trunk
>>>>> version?
>>>>>
>>>>> Thanks much.
>>>>> Ruth
>>>>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Why was this done?

BJ Freeman
In reply to this post by Ruth Hoffman-2
are you speaking as in a Class or has the uses of Httpservlet?

Ruth Hoffman sent the following on 9/16/2011 2:41 PM:
> Anyhow, I haven't figured out a way to use minilang when writing new
> servlets - which is were this problem is most annoying.
Reply | Threaded
Open this post in threaded view
|

Re: Why was this done?

Ruth Hoffman-2
Both. For example EventHandler implementations and some custom servlets
that extend HttpServlet.
Ruth
On 9/16/11 6:00 PM, BJ Freeman wrote:
> are you speaking as in a Class or has the uses of Httpservlet?
>
> Ruth Hoffman sent the following on 9/16/2011 2:41 PM:
>> Anyhow, I haven't figured out a way to use minilang when writing new
>> servlets - which is were this problem is most annoying.
Reply | Threaded
Open this post in threaded view
|

Re: Why was this done?

BJ Freeman
there are many exmaples of events that are minilanq.
look at
specialpurpose\googlecheckout\script\org\ofbiz\googleCheckout\PrepareXMLTemplate.xml
chris gives a lot of examples

Ruth Hoffman sent the following on 9/16/2011 3:17 PM:

> Both. For example EventHandler implementations and some custom servlets
> that extend HttpServlet.
> Ruth
> On 9/16/11 6:00 PM, BJ Freeman wrote:
>> are you speaking as in a Class or has the uses of Httpservlet?
>>
>> Ruth Hoffman sent the following on 9/16/2011 2:41 PM:
>>> Anyhow, I haven't figured out a way to use minilang when writing new
>>> servlets - which is were this problem is most annoying.
>
Reply | Threaded
Open this post in threaded view
|

Re: Why was this done?

Ruth Hoffman-2
Hi BJ:

Not sure I follow. These don't look like EventHandlers to me. (I mean a
class that "implements" EventHandler) . These look like events. Even so,
a closer look shows that within some of these events, the Bean Shell is
being called. That seems pretty crazy to me. The same problems can
occur. OK, lets not go there...I use minilang when I feel it is
appropriate.

Anyhow, thanks.

Appreciate your help in understanding this.

Best Regards,
Ruth

On 9/16/11 6:27 PM, BJ Freeman wrote:

> there are many exmaples of events that are minilanq.
> look at
> specialpurpose\googlecheckout\script\org\ofbiz\googleCheckout\PrepareXMLTemplate.xml
> chris gives a lot of examples
>
> Ruth Hoffman sent the following on 9/16/2011 3:17 PM:
>> Both. For example EventHandler implementations and some custom servlets
>> that extend HttpServlet.
>> Ruth
>> On 9/16/11 6:00 PM, BJ Freeman wrote:
>>> are you speaking as in a Class or has the uses of Httpservlet?
>>>
>>> Ruth Hoffman sent the following on 9/16/2011 2:41 PM:
>>>> Anyhow, I haven't figured out a way to use minilang when writing new
>>>> servlets - which is were this problem is most annoying.
Reply | Threaded
Open this post in threaded view
|

Re: Why was this done?

BJ Freeman
if you talking about java events and listeners then do a java class then
use run to call minilang as a service.

Ruth Hoffman sent the following on 9/16/2011 3:44 PM:

> Hi BJ:
>
> Not sure I follow. These don't look like EventHandlers to me. (I mean a
> class that "implements" EventHandler) . These look like events. Even so,
> a closer look shows that within some of these events, the Bean Shell is
> being called. That seems pretty crazy to me. The same problems can
> occur. OK, lets not go there...I use minilang when I feel it is
> appropriate.
>
> Anyhow, thanks.
>
> Appreciate your help in understanding this.
>
> Best Regards,
> Ruth
>
> On 9/16/11 6:27 PM, BJ Freeman wrote:
>> there are many exmaples of events that are minilanq.
>> look at
>> specialpurpose\googlecheckout\script\org\ofbiz\googleCheckout\PrepareXMLTemplate.xml
>>
>> chris gives a lot of examples
>>
>> Ruth Hoffman sent the following on 9/16/2011 3:17 PM:
>>> Both. For example EventHandler implementations and some custom servlets
>>> that extend HttpServlet.
>>> Ruth
>>> On 9/16/11 6:00 PM, BJ Freeman wrote:
>>>> are you speaking as in a Class or has the uses of Httpservlet?
>>>>
>>>> Ruth Hoffman sent the following on 9/16/2011 2:41 PM:
>>>>> Anyhow, I haven't figured out a way to use minilang when writing new
>>>>> servlets - which is were this problem is most annoying.
>
Reply | Threaded
Open this post in threaded view
|

Re: Why was this done?

Adrian Crum-3
In reply to this post by Ruth Hoffman-2
Ruth,

A simple search and replace will make your modifications compatible with
the newer version.

The change was the result of a months-long discussion on the dev mailing
list (August 2009 to October 2009). If you want more detail, you can
look it up.

-Adrian

On 9/16/2011 10:21 PM, Ruth Hoffman wrote:

> Thanks BJ.
>
> I guess OFBiz is not too backward compatible. Oh well, too bad. This
> breaks all kinds of things in 9.04 that I'd like to carry over to 10.x.
>
> Best Regards,
> Ruth
>
> On 9/16/11 5:14 PM, BJ Freeman wrote:
>> did a search of the commits
>> http://svn.apache.org/viewvc?view=revision&revision=821391
>>
>> Ruth Hoffman sent the following on 9/16/2011 1:42 PM:
>>> Could someone explain to me - and ignorant OFBiz committer wannabe -
>>> why
>>> the following method in version 9.04:
>>>
>>>      public static GenericDelegator getGenericDelegator(String
>>> delegatorName) { ... }
>>>
>>> No longer exists in the DelegatorFactory class in the most recent trunk
>>> version?
>>>
>>> In its place I see:
>>>
>>>      public static Delegator getDelegator(String delegatorName) {...}
>>>
>>> Is there a reason this was changed or taken out? Should I be calling a
>>> different method to get my 9.04 code to work with the current trunk
>>> version?
>>>
>>> Thanks much.
>>> Ruth
>>>
Reply | Threaded
Open this post in threaded view
|

Re: Why was this done?

Ruth Hoffman-2
Hi Adrian:
Thanks for the info.

The challenge I have is that I'd like to support a forward compatible
application on an existing 9.04 instance. Specifically, I have a
Component I developed on a 9.04 instance that I'd like to run
(unaltered) on 10.x and beyond. I'd like it to be plug-in play so that I
can support it (and test it) on 9.04 and 10.4 without code changes.

Now I'm going to have to have at least 2 instances - one for each
release - of OFBiz in order to properly test and support.

So, I will do to do as you suggest, or alternatively not support it on 10.x.

Thanks again and Best Regards,
Ruth

On 9/17/11 4:38 AM, Adrian Crum wrote:

> Ruth,
>
> A simple search and replace will make your modifications compatible
> with the newer version.
>
> The change was the result of a months-long discussion on the dev
> mailing list (August 2009 to October 2009). If you want more detail,
> you can look it up.
>
> -Adrian
>
> On 9/16/2011 10:21 PM, Ruth Hoffman wrote:
>> Thanks BJ.
>>
>> I guess OFBiz is not too backward compatible. Oh well, too bad. This
>> breaks all kinds of things in 9.04 that I'd like to carry over to 10.x.
>>
>> Best Regards,
>> Ruth
>>
>> On 9/16/11 5:14 PM, BJ Freeman wrote:
>>> did a search of the commits
>>> http://svn.apache.org/viewvc?view=revision&revision=821391
>>>
>>> Ruth Hoffman sent the following on 9/16/2011 1:42 PM:
>>>> Could someone explain to me - and ignorant OFBiz committer wannabe
>>>> - why
>>>> the following method in version 9.04:
>>>>
>>>>      public static GenericDelegator getGenericDelegator(String
>>>> delegatorName) { ... }
>>>>
>>>> No longer exists in the DelegatorFactory class in the most recent
>>>> trunk
>>>> version?
>>>>
>>>> In its place I see:
>>>>
>>>>      public static Delegator getDelegator(String delegatorName) {...}
>>>>
>>>> Is there a reason this was changed or taken out? Should I be calling a
>>>> different method to get my 9.04 code to work with the current trunk
>>>> version?
>>>>
>>>> Thanks much.
>>>> Ruth
>>>>
>