XML Import on Windows
Locked
12
12
 
Administrator
|
XML Import on Windows does not support anymore \ as separator you must /
This is a regression Jacques |
|
Could you be more specific? -David On Feb 7, 2009, at 1:32 PM, Jacques Le Roux wrote: > XML Import on Windows does not support anymore \ as separator you > must / > This is a regression > > Jacques > |
|
Administrator
|
On *Windows* (Xp sp3), I tried to import
C:\ofbizRun\applications\ecommerce\data\DemoProduct.xml and I add to use C:/ofbizRun/applications/ecommerce/data/DemoProduct.xml BTW I'm facing also an UTF-8 BOM problem when I want to import the content of this file using the text import option. I switch to Ubuntu 8.10 to test (I should set another machine with a KWM I have, but it's too noisy, an Pentium HT proc, a kind of electric heater. actually ;o) The error I get is ERROR: Error parsing entity xml file: javolution.xml.stream.XMLStreamException: ';' expected (at line 1, column 0) Jacques From: "David E Jones" <[hidden email]> > > Could you be more specific? > > -David > > On Feb 7, 2009, at 1:32 PM, Jacques Le Roux wrote: > >> XML Import on Windows does not support anymore \ as separator you must / >> This is a regression >> >> Jacques >> > |
|
|
How are you doing the import (ie webapp and which page, or command line and which args, etc)? -David On Feb 7, 2009, at 2:37 PM, Jacques Le Roux wrote: > On *Windows* (Xp sp3), I tried to import > C:\ofbizRun\applications\ecommerce\data\DemoProduct.xml > and I add to use > C:/ofbizRun/applications/ecommerce/data/DemoProduct.xml > > BTW I'm facing also an UTF-8 BOM problem when I want to import the > content of this file using the text import option. I switch to > Ubuntu 8.10 to test (I should set another machine with a KWM I have, > but it's too noisy, an Pentium HT proc, a kind of electric heater. > actually ;o) > The error I get is > ERROR: Error parsing entity xml file: > javolution.xml.stream.XMLStreamException: ';' expected (at line 1, > column 0) > > Jacques > > From: "David E Jones" <[hidden email]> >> >> Could you be more specific? >> >> -David >> >> On Feb 7, 2009, at 1:32 PM, Jacques Le Roux wrote: >> >>> XML Import on Windows does not support anymore \ as separator you >>> must / >>> This is a regression >>> >>> Jacques >>> > > |
|
Administrator
|
I just used Webtools/XML import.
I tried on Linux : same issue. Not that, for the moment, it's the sole file that I found that has this problem (the BOM - http://en.wikipedia.org/wiki/Byte-order_mark- in content I mean, of course on Linux I have no "\" in path issue :o). It sounds like a special character has slipped in. But I don't know how to get rid of it. I tried Scite which is capable of doing change from UTF-8 BOM to UTF-8 without BOM and vice-versa, but noways so far... Jacques From: "David E Jones" <[hidden email]> > > How are you doing the import (ie webapp and which page, or command line and which args, etc)? > > -David > > > On Feb 7, 2009, at 2:37 PM, Jacques Le Roux wrote: > >> On *Windows* (Xp sp3), I tried to import >> C:\ofbizRun\applications\ecommerce\data\DemoProduct.xml >> and I add to use >> C:/ofbizRun/applications/ecommerce/data/DemoProduct.xml >> >> BTW I'm facing also an UTF-8 BOM problem when I want to import the content of this file using the text import option. I switch >> to Ubuntu 8.10 to test (I should set another machine with a KWM I have, but it's too noisy, an Pentium HT proc, a kind of >> electric heater. actually ;o) >> The error I get is >> ERROR: Error parsing entity xml file: javolution.xml.stream.XMLStreamException: ';' expected (at line 1, column 0) >> >> Jacques >> >> From: "David E Jones" <[hidden email]> >>> >>> Could you be more specific? >>> >>> -David >>> >>> On Feb 7, 2009, at 1:32 PM, Jacques Le Roux wrote: >>> >>>> XML Import on Windows does not support anymore \ as separator you must / >>>> This is a regression >>>> >>>> Jacques >>>> >> >> > |
|
Administrator
|
Actually the weird thing is that the problem appears when you copy/paste the text from the file to the area on Webtools/XML import
page, on Windows and on Linux as well. So trying to get rid of the BOM char in file is a nonsense. Actually I even think that there is no BOM char in the file (since Scite would detect it else, and because it you tried both encoding with Scite and save the file, the file size does not change). Acutally it's no a big problem, only a weird issue. Which may hide something more annoying maybe, that's why I tried to understand... Enough for me today anyway... Jacques From: "Jacques Le Roux" <[hidden email]> >I just used Webtools/XML import. > I tried on Linux : same issue. Not that, for the moment, it's the sole file that I found that has this problem (the BOM - > http://en.wikipedia.org/wiki/Byte-order_mark- in content I mean, of course on Linux I have no "\" in path issue :o). It sounds > like a special character has slipped in. But I don't know how to get rid of it. I tried Scite which is capable of doing change > from UTF-8 BOM to UTF-8 without BOM and vice-versa, but noways so far... > > Jacques > > From: "David E Jones" <[hidden email]> >> >> How are you doing the import (ie webapp and which page, or command line and which args, etc)? >> >> -David >> >> >> On Feb 7, 2009, at 2:37 PM, Jacques Le Roux wrote: >> >>> On *Windows* (Xp sp3), I tried to import >>> C:\ofbizRun\applications\ecommerce\data\DemoProduct.xml >>> and I add to use >>> C:/ofbizRun/applications/ecommerce/data/DemoProduct.xml >>> >>> BTW I'm facing also an UTF-8 BOM problem when I want to import the content of this file using the text import option. I switch >>> to Ubuntu 8.10 to test (I should set another machine with a KWM I have, but it's too noisy, an Pentium HT proc, a kind of >>> electric heater. actually ;o) >>> The error I get is >>> ERROR: Error parsing entity xml file: javolution.xml.stream.XMLStreamException: ';' expected (at line 1, column 0) >>> >>> Jacques >>> >>> From: "David E Jones" <[hidden email]> >>>> >>>> Could you be more specific? >>>> >>>> -David >>>> >>>> On Feb 7, 2009, at 1:32 PM, Jacques Le Roux wrote: >>>> >>>>> XML Import on Windows does not support anymore \ as separator you must / >>>>> This is a regression >>>>> >>>>> Jacques >>>>> >>> >>> >> > > |
|
Administrator
|
In reply to this post by Jacques Le Roux
Actually it's not a regression, it was not working already in R4 (but I thought it was, weird, maybe it was before...)
Jacques From: "Jacques Le Roux" <[hidden email]> > XML Import on Windows does not support anymore \ as separator you must / > This is a regression > > Jacques > |
|
Administrator
|
In reply to this post by Jacques Le Roux
Importing the same text (DemoProduct.xml content) in R4 works well
Jacques From: "Jacques Le Roux" <[hidden email]> > Actually the weird thing is that the problem appears when you copy/paste the text from the file to the area on Webtools/XML import > page, on Windows and on Linux as well. > So trying to get rid of the BOM char in file is a nonsense. Actually I even think that there is no BOM char in the file (since > Scite would detect it else, and because it you tried both encoding with Scite and save the file, the file size does not change). > Acutally it's no a big problem, only a weird issue. Which may hide something more annoying maybe, that's why I tried to > understand... Enough for me today anyway... > > Jacques > > From: "Jacques Le Roux" <[hidden email]> >>I just used Webtools/XML import. >> I tried on Linux : same issue. Not that, for the moment, it's the sole file that I found that has this problem (the BOM - >> http://en.wikipedia.org/wiki/Byte-order_mark- in content I mean, of course on Linux I have no "\" in path issue :o). It sounds >> like a special character has slipped in. But I don't know how to get rid of it. I tried Scite which is capable of doing change >> from UTF-8 BOM to UTF-8 without BOM and vice-versa, but noways so far... >> >> Jacques >> >> From: "David E Jones" <[hidden email]> >>> >>> How are you doing the import (ie webapp and which page, or command line and which args, etc)? >>> >>> -David >>> >>> >>> On Feb 7, 2009, at 2:37 PM, Jacques Le Roux wrote: >>> >>>> On *Windows* (Xp sp3), I tried to import >>>> C:\ofbizRun\applications\ecommerce\data\DemoProduct.xml >>>> and I add to use >>>> C:/ofbizRun/applications/ecommerce/data/DemoProduct.xml >>>> >>>> BTW I'm facing also an UTF-8 BOM problem when I want to import the content of this file using the text import option. I switch >>>> to Ubuntu 8.10 to test (I should set another machine with a KWM I have, but it's too noisy, an Pentium HT proc, a kind of >>>> electric heater. actually ;o) >>>> The error I get is >>>> ERROR: Error parsing entity xml file: javolution.xml.stream.XMLStreamException: ';' expected (at line 1, column 0) >>>> >>>> Jacques >>>> >>>> From: "David E Jones" <[hidden email]> >>>>> >>>>> Could you be more specific? >>>>> >>>>> -David >>>>> >>>>> On Feb 7, 2009, at 1:32 PM, Jacques Le Roux wrote: >>>>> >>>>>> XML Import on Windows does not support anymore \ as separator you must / >>>>>> This is a regression >>>>>> >>>>>> Jacques >>>>>> >>>> >>>> >>> >> >> > > |
|
Administrator
|
In reply to this post by Jacques Le Roux
Fixed in r744652 (this were it proves useful to have a Windows commiter : not all our users are on Linux ;o)
Jacques From: "Jacques Le Roux" <[hidden email]> > Actually it's not a regression, it was not working already in R4 (but I thought it was, weird, maybe it was before...) > > Jacques > > From: "Jacques Le Roux" <[hidden email]> >> XML Import on Windows does not support anymore \ as separator you must / >> This is a regression >> >> Jacques >> > |
|
Administrator
|
In reply to this post by Jacques Le Roux
I gave up on this one. Anyway in such case we can save the data in a file an import it
Jacques From: "Jacques Le Roux" <[hidden email]> > Importing the same text (DemoProduct.xml content) in R4 works well > > Jacques > > From: "Jacques Le Roux" <[hidden email]> >> Actually the weird thing is that the problem appears when you copy/paste the text from the file to the area on Webtools/XML >> import page, on Windows and on Linux as well. >> So trying to get rid of the BOM char in file is a nonsense. Actually I even think that there is no BOM char in the file (since >> Scite would detect it else, and because it you tried both encoding with Scite and save the file, the file size does not change). >> Acutally it's no a big problem, only a weird issue. Which may hide something more annoying maybe, that's why I tried to >> understand... Enough for me today anyway... >> >> Jacques >> >> From: "Jacques Le Roux" <[hidden email]> >>>I just used Webtools/XML import. >>> I tried on Linux : same issue. Not that, for the moment, it's the sole file that I found that has this problem (the BOM - >>> http://en.wikipedia.org/wiki/Byte-order_mark- in content I mean, of course on Linux I have no "\" in path issue :o). It sounds >>> like a special character has slipped in. But I don't know how to get rid of it. I tried Scite which is capable of doing change >>> from UTF-8 BOM to UTF-8 without BOM and vice-versa, but noways so far... >>> >>> Jacques >>> >>> From: "David E Jones" <[hidden email]> >>>> >>>> How are you doing the import (ie webapp and which page, or command line and which args, etc)? >>>> >>>> -David >>>> >>>> >>>> On Feb 7, 2009, at 2:37 PM, Jacques Le Roux wrote: >>>> >>>>> On *Windows* (Xp sp3), I tried to import >>>>> C:\ofbizRun\applications\ecommerce\data\DemoProduct.xml >>>>> and I add to use >>>>> C:/ofbizRun/applications/ecommerce/data/DemoProduct.xml >>>>> >>>>> BTW I'm facing also an UTF-8 BOM problem when I want to import the content of this file using the text import option. I >>>>> switch to Ubuntu 8.10 to test (I should set another machine with a KWM I have, but it's too noisy, an Pentium HT proc, a >>>>> kind of electric heater. actually ;o) >>>>> The error I get is >>>>> ERROR: Error parsing entity xml file: javolution.xml.stream.XMLStreamException: ';' expected (at line 1, column 0) >>>>> >>>>> Jacques >>>>> >>>>> From: "David E Jones" <[hidden email]> >>>>>> >>>>>> Could you be more specific? >>>>>> >>>>>> -David >>>>>> >>>>>> On Feb 7, 2009, at 1:32 PM, Jacques Le Roux wrote: >>>>>> >>>>>>> XML Import on Windows does not support anymore \ as separator you must / >>>>>>> This is a regression >>>>>>> >>>>>>> Jacques >>>>>>> >>>>> >>>>> >>>> >>> >>> >> >> > |
|
|
In reply to this post by Jacques Le Roux
Jacques, I also don't like the solution in 744652, it is guaranteed to break other things. Could you describe the problem in a little more detail, ie what you do and what happens? The only description I can find in the emails is "XML Import on Windows does not support anymore \ as separator you must /" and I can only guess about what that means... One helpful detail (in addition to a more detailed general description) is what is the input string and what is it after it is canonicalized? -David On Feb 15, 2009, at 3:54 AM, Jacques Le Roux wrote: > Fixed in r744652 (this were it proves useful to have a Windows > commiter : not all our users are on Linux ;o) > > Jacques > > From: "Jacques Le Roux" <[hidden email]> >> Actually it's not a regression, it was not working already in R4 >> (but I thought it was, weird, maybe it was before...) >> Jacques >> From: "Jacques Le Roux" <[hidden email]> >>> XML Import on Windows does not support anymore \ as separator you >>> must / >>> This is a regression >>> Jacques >>> >> > |
|
Administrator
|
David,
I just gave some details in a response to Hans's proposition Thread "Re: svn commit: r744652 -/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java" Tell me if you need more details Jacques From: "David E Jones" <[hidden email]> > > Jacques, > > I also don't like the solution in 744652, it is guaranteed to break > other things. > > Could you describe the problem in a little more detail, ie what you do > and what happens? The only description I can find in the emails is > "XML Import on Windows does not support anymore \ as separator you > must /" and I can only guess about what that means... > > One helpful detail (in addition to a more detailed general > description) is what is the input string and what is it after it is > canonicalized? > > -David > > > On Feb 15, 2009, at 3:54 AM, Jacques Le Roux wrote: > >> Fixed in r744652 (this were it proves useful to have a Windows >> commiter : not all our users are on Linux ;o) >> >> Jacques >> >> From: "Jacques Le Roux" <[hidden email]> >>> Actually it's not a regression, it was not working already in R4 >>> (but I thought it was, weird, maybe it was before...) >>> Jacques >>> From: "Jacques Le Roux" <[hidden email]> >>>> XML Import on Windows does not support anymore \ as separator you >>>> must / >>>> This is a regression >>>> Jacques >>>> >>> >> > |
|
|
Okay, yes, I should have acknowledged that email as well, but it also has no detail... the only relevant bit I can find is this: "It does not work because in UtilHttp.canonicalizeParameter <<StringUtil.defaultWebEncoder.canonicalize(paramValue, StringUtil.esapiCanonicalizeStrict);>> does not encode correctly such paths." In other words, the information I have from both emails is that "it doesn't work". But, WHY doesn't it work? HOW is it failing? Any error messages or other information about what is actually happening (perhaps even the stuff I mentioned in my previous email about what the canonicalized String that is causing the problem looks like)? Does that make sense? In other words, I'm saying there is relevant details that are missing and either I have to get OFBiz going on a Windows machine and test it myself, or try to get more details from you. On the testing it myself note, there aren't even enough details to do that in here! Which page did you go to? What did you enter? What happened (so that I can see if I'm experiencing the same thing)? This is really basic stuff... isn't it? I mean, if someone was reporting a bug to you, what information would YOU want to see? -David On Feb 15, 2009, at 10:10 AM, Jacques Le Roux wrote: > David, > > I just gave some details in a response to Hans's proposition > Thread "Re: svn commit: r744652 -/ofbiz/trunk/framework/base/src/org/ > ofbiz/base/util/UtilHttp.java" > > Tell me if you need more details > > Jacques > > > From: "David E Jones" <[hidden email]> >> Jacques, >> I also don't like the solution in 744652, it is guaranteed to >> break other things. >> Could you describe the problem in a little more detail, ie what you >> do and what happens? The only description I can find in the emails >> is "XML Import on Windows does not support anymore \ as separator >> you must /" and I can only guess about what that means... >> One helpful detail (in addition to a more detailed general >> description) is what is the input string and what is it after it >> is canonicalized? >> -David >> On Feb 15, 2009, at 3:54 AM, Jacques Le Roux wrote: >>> Fixed in r744652 (this were it proves useful to have a Windows >>> commiter : not all our users are on Linux ;o) >>> >>> Jacques >>> >>> From: "Jacques Le Roux" <[hidden email]> >>>> Actually it's not a regression, it was not working already in R4 >>>> (but I thought it was, weird, maybe it was before...) >>>> Jacques >>>> From: "Jacques Le Roux" <[hidden email]> >>>>> XML Import on Windows does not support anymore \ as separator >>>>> you must / >>>>> This is a regression >>>>> Jacques >>>>> >>>> >>> >> > |
|
Administrator
|
Of course, at 1st sight it seems that not having a Windows machine at hand does not facilitate the case. But actually you don't need
to have one Simply try to enter a Windows style path in Import Xml in Webtools and you will see the problem if you revert my 2 commits (sorry for that) If you want to see the error message do it on demo server. But this message will not help you a lot IMO. From: "David E Jones" <[hidden email]> > > Okay, yes, I should have acknowledged that email as well, but it also has no detail... the only relevant bit I can find is this: > "It does not work because in UtilHttp.canonicalizeParameter <<StringUtil.defaultWebEncoder.canonicalize(paramValue, > StringUtil.esapiCanonicalizeStrict);>> does not encode correctly such paths." > > In other words, the information I have from both emails is that "it doesn't work". But, WHY doesn't it work? HOW is it failing? > Any error messages or other information about what is actually happening > (perhaps even the stuff I mentioned in my previous email about what the canonicalized String that is causing the problem looks > like)? The canonicalized String (without my change) is ugly and I guess you will not get much information from it. > Does that make sense? In other words, I'm saying there is relevant details that are missing and either I have to get OFBiz going > on a Windows machine and test it myself, or try to get more details from you. :D, don't be upset, I ready to help as much as I can > On the testing it myself note, there aren't even enough details to do that in here! Which page did you go to? OFBiz/Webtools/Import Xml >What did you enter? c:\quelque_chose\nimportequoi (in the filename field) >What happened (so that I can see if I'm experiencing the same thing)? Try to reproduce on demo server, it should help (Mmm... if it has not been updated ... OK for now...) > This is really basic stuff... isn't it? I mean, if someone was reporting a bug to you, what information would YOU want to see? I tred to give you what it's needed. Let me know if you need more :o) Jacques > -David > > > On Feb 15, 2009, at 10:10 AM, Jacques Le Roux wrote: > >> David, >> >> I just gave some details in a response to Hans's proposition >> Thread "Re: svn commit: r744652 -/ofbiz/trunk/framework/base/src/org/ ofbiz/base/util/UtilHttp.java" >> >> Tell me if you need more details >> >> Jacques >> >> >> From: "David E Jones" <[hidden email]> >>> Jacques, >>> I also don't like the solution in 744652, it is guaranteed to break other things. >>> Could you describe the problem in a little more detail, ie what you do and what happens? The only description I can find in >>> the emails is "XML Import on Windows does not support anymore \ as separator you must /" and I can only guess about what >>> that means... >>> One helpful detail (in addition to a more detailed general description) is what is the input string and what is it after it >>> is canonicalized? >>> -David >>> On Feb 15, 2009, at 3:54 AM, Jacques Le Roux wrote: >>>> Fixed in r744652 (this were it proves useful to have a Windows commiter : not all our users are on Linux ;o) >>>> >>>> Jacques >>>> >>>> From: "Jacques Le Roux" <[hidden email]> >>>>> Actually it's not a regression, it was not working already in R4 (but I thought it was, weird, maybe it was before...) >>>>> Jacques >>>>> From: "Jacques Le Roux" <[hidden email]> >>>>>> XML Import on Windows does not support anymore \ as separator you must / >>>>>> This is a regression >>>>>> Jacques >>>>>> >>>>> >>>> >>> >> > |
|
|
On Feb 15, 2009, at 11:18 AM, Jacques Le Roux wrote: >> In other words, the information I have from both emails is that >> "it doesn't work". But, WHY doesn't it work? HOW is it failing? >> Any error messages or other information about what is actually >> happening > >> (perhaps even the stuff I mentioned in my previous email about >> what the canonicalized String that is causing the problem looks >> like)? > > The canonicalized String (without my change) is ugly and I guess you > will not get much information from it. That's the point! It's great to know that it is ugly, but what does that MEAN? Actually my guess is that 100% of the information I need I'll get from that text. If I understand right the WHOLE problem with this is that the string input by the user is being mangled so the system can't use it. Therefore the only really relevant details are: 1. an example of an original string that this is breaking 2. what that string looks like after it has been "mangled" by the canonicalization Chances are with just that information we can find a better solution to this. -David |
|
Administrator
|
I just tried on demo server
input c:\quelque_chose\nimportequoi error ERROR: reading file name (c:quelque_chosenimportequoi): null In debugger locally input D:\workspace\ofbizRun\applications\ecommerce\data\DemoProduct.xml canonicalized D:workspaceofbizRun plicationsìmmerceÚaÞoProduct.xml Error ERROR: reading file name (D:workspaceofbizRun<br/>plicationsìmmerceÚaÞoProduct.xml): null I meaned ugly :o) Jacques From: "David E Jones" <[hidden email]> > > On Feb 15, 2009, at 11:18 AM, Jacques Le Roux wrote: > >>> In other words, the information I have from both emails is that "it doesn't work". But, WHY doesn't it work? HOW is it >>> failing? Any error messages or other information about what is actually happening >> >>> (perhaps even the stuff I mentioned in my previous email about what the canonicalized String that is causing the problem looks >>> like)? >> >> The canonicalized String (without my change) is ugly and I guess you will not get much information from it. > > That's the point! It's great to know that it is ugly, but what does that MEAN? > > Actually my guess is that 100% of the information I need I'll get from that text. If I understand right the WHOLE problem with > this is that the string input by the user is being mangled so the system can't use it. Therefore the only really relevant > details are: > > 1. an example of an original string that this is breaking > 2. what that string looks like after it has been "mangled" by the canonicalization > > Chances are with just that information we can find a better solution to this. > > -David > > |
|
Administrator
|
There is something I completly forgot to report about this problem : canonicalize() is acceptinp escaped \ using traditionnal \\ (I
also tried \\\\) Of course I tried before implementing my hack, but this did not work either. BTW I don't see in which case the string ":\" located at position 1 (ie a string corresponding to the regexp ^.:\.*$) will be harmfull if backslashs are transformed to forward slashs since I don't know so far a protocol represented with only 1 character. So a not encoded colon can't be found (so far) in a correct URL at position 1 followed by a not encoded backslash. Am I overseeing something ? Else we could say that it's deterministic as long as a protocol is not represendted by a sole character (an even in that case why shall we find backslash just after ?) References: http://www.rfc-editor.org/rfc/rfc1738.txt https://kanis.fr/svn/trunk/wk/lisp/muse/muse-protocols.el HTH Jacques From: "Jacques Le Roux" <[hidden email]> >I just tried on demo server > input > c:\quelque_chose\nimportequoi > error > ERROR: reading file name (c:quelque_chosenimportequoi): null > > In debugger locally > input > D:\workspace\ofbizRun\applications\ecommerce\data\DemoProduct.xml > canonicalized > D:workspaceofbizRun > plicationsìmmerceÚaÞoProduct.xml > Error > ERROR: reading file name (D:workspaceofbizRun<br/>plicationsìmmerceÚaÞoProduct.xml): null > > I meaned ugly :o) > > Jacques > > From: "David E Jones" <[hidden email]> >> >> On Feb 15, 2009, at 11:18 AM, Jacques Le Roux wrote: >> >>>> In other words, the information I have from both emails is that "it doesn't work". But, WHY doesn't it work? HOW is it >>>> failing? Any error messages or other information about what is actually happening >>> >>>> (perhaps even the stuff I mentioned in my previous email about what the canonicalized String that is causing the problem >>>> looks >>>> like)? >>> >>> The canonicalized String (without my change) is ugly and I guess you will not get much information from it. >> >> That's the point! It's great to know that it is ugly, but what does that MEAN? >> >> Actually my guess is that 100% of the information I need I'll get from that text. If I understand right the WHOLE problem with >> this is that the string input by the user is being mangled so the system can't use it. Therefore the only really relevant >> details are: >> >> 1. an example of an original string that this is breaking >> 2. what that string looks like after it has been "mangled" by the canonicalization >> >> Chances are with just that information we can find a better solution to this. >> >> -David >> >> > > |
|
Administrator
|
As this does not make sens (we are not dealing only with URL, I was stupid - actually hardly awake). I'm looking for a real
solution... Jacques From: "Jacques Le Roux" <[hidden email]> > There is something I completly forgot to report about this problem : canonicalize() is acceptinp escaped \ using traditionnal \\ > (I > also tried \\\\) Of course I tried before implementing my hack, but this did not work either. > > BTW I don't see in which case the string ":\" located at position 1 (ie a string corresponding to the regexp ^.:\.*$) will be > harmfull if backslashs are transformed to forward slashs since I don't know so far a protocol represented with only 1 character. > So > a not encoded colon can't be found (so far) in a correct URL at position 1 followed by a not encoded backslash. > > Am I overseeing something ? Else we could say that it's deterministic as long as a protocol is not represendted by a sole > character (an even in that case why shall we find backslash just after ?) > > References: > http://www.rfc-editor.org/rfc/rfc1738.txt > https://kanis.fr/svn/trunk/wk/lisp/muse/muse-protocols.el > > HTH > > Jacques > > From: "Jacques Le Roux" <[hidden email]> >>I just tried on demo server >> input >> c:\quelque_chose\nimportequoi >> error >> ERROR: reading file name (c:quelque_chosenimportequoi): null >> >> In debugger locally >> input >> D:\workspace\ofbizRun\applications\ecommerce\data\DemoProduct.xml >> canonicalized >> D:workspaceofbizRun >> plicationsìmmerceÚaÞoProduct.xml >> Error >> ERROR: reading file name (D:workspaceofbizRun<br/>plicationsìmmerceÚaÞoProduct.xml): null >> >> I meaned ugly :o) >> >> Jacques >> >> From: "David E Jones" <[hidden email]> >>> >>> On Feb 15, 2009, at 11:18 AM, Jacques Le Roux wrote: >>> >>>>> In other words, the information I have from both emails is that "it doesn't work". But, WHY doesn't it work? HOW is it >>>>> failing? Any error messages or other information about what is actually happening >>>> >>>>> (perhaps even the stuff I mentioned in my previous email about what the canonicalized String that is causing the problem >>>>> looks >>>>> like)? >>>> >>>> The canonicalized String (without my change) is ugly and I guess you will not get much information from it. >>> >>> That's the point! It's great to know that it is ugly, but what does that MEAN? >>> >>> Actually my guess is that 100% of the information I need I'll get from that text. If I understand right the WHOLE problem with >>> this is that the string input by the user is being mangled so the system can't use it. Therefore the only really relevant >>> details are: >>> >>> 1. an example of an original string that this is breaking >>> 2. what that string looks like after it has been "mangled" by the canonicalization >>> >>> Chances are with just that information we can find a better solution to this. >>> >>> -David >>> >>> >> >> > > |
|
Administrator
|
As I can't find a good solution, I thought that maybe we could use a javascript function to change the value (Windows path with
backslashs) before it's encoded. But this means to have it everywhere it's needed (for instance in contents..., etc.) What do you think ? Jacques From: "Jacques Le Roux" <[hidden email]> > As this does not make sens (we are not dealing only with URL, I was stupid - actually hardly awake). I'm looking for a real > solution... > > Jacques > > From: "Jacques Le Roux" <[hidden email]> >> There is something I completly forgot to report about this problem : canonicalize() is acceptinp escaped \ using traditionnal \\ >> (I >> also tried \\\\) Of course I tried before implementing my hack, but this did not work either. >> >> BTW I don't see in which case the string ":\" located at position 1 (ie a string corresponding to the regexp ^.:\.*$) will be >> harmfull if backslashs are transformed to forward slashs since I don't know so far a protocol represented with only 1 character. >> So >> a not encoded colon can't be found (so far) in a correct URL at position 1 followed by a not encoded backslash. >> >> Am I overseeing something ? Else we could say that it's deterministic as long as a protocol is not represendted by a sole >> character (an even in that case why shall we find backslash just after ?) >> >> References: >> http://www.rfc-editor.org/rfc/rfc1738.txt >> https://kanis.fr/svn/trunk/wk/lisp/muse/muse-protocols.el >> >> HTH >> >> Jacques >> >> From: "Jacques Le Roux" <[hidden email]> >>>I just tried on demo server >>> input >>> c:\quelque_chose\nimportequoi >>> error >>> ERROR: reading file name (c:quelque_chosenimportequoi): null >>> >>> In debugger locally >>> input >>> D:\workspace\ofbizRun\applications\ecommerce\data\DemoProduct.xml >>> canonicalized >>> D:workspaceofbizRun >>> plicationsìmmerceÚaÞoProduct.xml >>> Error >>> ERROR: reading file name (D:workspaceofbizRun<br/>plicationsìmmerceÚaÞoProduct.xml): null >>> >>> I meaned ugly :o) >>> >>> Jacques >>> >>> From: "David E Jones" <[hidden email]> >>>> >>>> On Feb 15, 2009, at 11:18 AM, Jacques Le Roux wrote: >>>> >>>>>> In other words, the information I have from both emails is that "it doesn't work". But, WHY doesn't it work? HOW is it >>>>>> failing? Any error messages or other information about what is actually happening >>>>> >>>>>> (perhaps even the stuff I mentioned in my previous email about what the canonicalized String that is causing the problem >>>>>> looks >>>>>> like)? >>>>> >>>>> The canonicalized String (without my change) is ugly and I guess you will not get much information from it. >>>> >>>> That's the point! It's great to know that it is ugly, but what does that MEAN? >>>> >>>> Actually my guess is that 100% of the information I need I'll get from that text. If I understand right the WHOLE problem with >>>> this is that the string input by the user is being mangled so the system can't use it. Therefore the only really relevant >>>> details are: >>>> >>>> 1. an example of an original string that this is breaking >>>> 2. what that string looks like after it has been "mangled" by the canonicalization >>>> >>>> Chances are with just that information we can find a better solution to this. >>>> >>>> -David >>>> >>>> >>> >>> >> >> > > |
|
|
For my first contribution, I have make a correction for two minor bugs in
the front of ofBiz, on the Party Component. ofBiz Revision : 745068 Bug one : In the Party Skills, the update doesn't work, because there's a service-multi who is calling in the request-map 'updatePartySkillExt', instead of a simple service, in the controller.xml file. (replace <event type="service-multi" invoke="updatePartySkill"/> by <event type="service" invoke="updatePartySkill"/>) Bug two : In the Trainings, the update doesn't work because : - In the file controller.xml : For the request-map 'updatePersonTrainingsExt' there is a service-multi who is calling in the request-map, instead of a simple service. (replace <event type="service-multi" invoke="updatePersonTraining"/> by <event type="service" invoke="updatePersonTraining"/>) - In the file PersonTrainingForms.xml : the target attribute of the form 'ListPersonTrainings' is not correct : replace target="updatePersonTrainingsExt?partyId=${partyId}" by target="updatePersonTrainingsExt?" If you approve it, I make patchs and create a Jira issue for it. Regards, Louis Briolet. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |