buildbot failure in ASF Buildbot on ofbiz-trunk

[buildbot]

The Buildbot has detected a new failure on builder ofbiz-trunk while building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/ofbiz-trunk/builds/2737

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: ceres_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch ofbiz/trunk] 1305004
Blamelist:

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot

[Adam Heath-2]

On 05/04/2012 01:44 PM, [hidden email] wrote:

> The Buildbot has detected a new failure on builder ofbiz-trunk while building ASF Buildbot.
> Full details are available at:
>  http://ci.apache.org/builders/ofbiz-trunk/builds/2737
>
> Buildbot URL: http://ci.apache.org/
>
> Buildslave for this Build: ceres_ubuntu
>
> Build Reason: scheduler
> Build Source Stamp: [branch ofbiz/trunk] 1305004
> Blamelist:
>
> BUILD FAILED: failed compile_1

(search for '# Tests:', and eventually you'll find the bad group.
Then, page up to find the bad test.

     [java] 328534 [main] INFO NoModule - [JUNIT] Results for test
suite: basetests
     [java] 328534 [main] INFO org.ofbiz.testtools.TestRunContainer -
[JUNIT] Pass: false | # Tests: 65 | # Failed: 1 # Errors: 0


And that seems to be this:

     [java] 328535 [main] INFO org.ofbiz.testtools.TestRunContainer -
-->
testReadXmlLangNewStyle(org.ofbiz.base.util.test.UtilPropertiesTests):
null
     [java] 328535 [main] INFO NoModule -
junit.framework.AssertionFailedError


Looking at that code, is it wrong; it says it is testing UTF-8 stuff,
but then calls String.getBytes(), without actually converting it to
UTF-8(using either "UTF-8", or UtilIO.UTF8).  However, that might not
be the actual problem that is occuring.

It's possible that someone this is using a default platform encoding,
which is not configured correctly in the new test environment.  Fixing
the test environment is *not* the correct fix.  Ofbiz shouldn't depend
on that.  Instead, if should force the correct value to be used at
*every* call site.

[Adrian Crum-3]

On 5/4/2012 9:06 PM, Adam Heath wrote:

> On 05/04/2012 01:44 PM, [hidden email] wrote:
>> The Buildbot has detected a new failure on builder ofbiz-trunk while building ASF Buildbot.
>> Full details are available at:
>>   http://ci.apache.org/builders/ofbiz-trunk/builds/2737
>>
>> Buildbot URL: http://ci.apache.org/
>>
>> Buildslave for this Build: ceres_ubuntu
>>
>> Build Reason: scheduler
>> Build Source Stamp: [branch ofbiz/trunk] 1305004
>> Blamelist:
>>
>> BUILD FAILED: failed compile_1
> (search for '# Tests:', and eventually you'll find the bad group.
> Then, page up to find the bad test.
>
>       [java] 328534 [main] INFO NoModule - [JUNIT] Results for test
> suite: basetests
>       [java] 328534 [main] INFO org.ofbiz.testtools.TestRunContainer -
> [JUNIT] Pass: false | # Tests: 65 | # Failed: 1 # Errors: 0
>
>
> And that seems to be this:
>
>       [java] 328535 [main] INFO org.ofbiz.testtools.TestRunContainer -
> -->
> testReadXmlLangNewStyle(org.ofbiz.base.util.test.UtilPropertiesTests):
> null
>       [java] 328535 [main] INFO NoModule -
> junit.framework.AssertionFailedError
>
>
> Looking at that code, is it wrong; it says it is testing UTF-8 stuff,
> but then calls String.getBytes(), without actually converting it to
> UTF-8(using either "UTF-8", or UtilIO.UTF8).  However, that might not
> be the actual problem that is occuring.
>
> It's possible that someone this is using a default platform encoding,
> which is not configured correctly in the new test environment.  Fixing
> the test environment is *not* the correct fix.  Ofbiz shouldn't depend
> on that.  Instead, if should force the correct value to be used at
> *every* call site.
>

Interesting theory, but why does it pass during another run?

I checked the log files of other failures and saw that different test
suites fail and then pass later.

-Adrian