cobertura detection

[Erwan de FERRIERES-2]

Hi Doogie,

a long time ago, you committed code to test the presence of the
cobertura classes:
https://fisheye6.atlassian.com/changelog/ofbiz?cs=889839.
Today (maybe since ?), this is not working with the ant shell script
located at the OFBiz's root.

I created the related Jira issue:
http://issues.apache.org/jira/browse/OFBIZ-4783

Would it be possible you take a look ?

Thanks,

--
Erwan de FERRIERES

[Adam Heath-2]

On 04/12/2012 07:02 AM, Erwan de FERRIERES wrote:

> Hi Doogie,
>
> a long time ago, you committed code to test the presence of the
> cobertura classes:
> https://fisheye6.atlassian.com/changelog/ofbiz?cs=889839.
> Today (maybe since ?), this is not working with the ant shell script
> located at the OFBiz's root.
>
> I created the related Jira issue:
> http://issues.apache.org/jira/browse/OFBIZ-4783
>
> Would it be possible you take a look ?

I have, and you are the one who broke it.  You changed the cobertura
version from 0.9.3, to 0.9.4.1, without checking *all* files, to see if
anything referenced it.

I just fixed the broken reference, but now it still needs the asm
library, which was removed.  I'm not certain how ivy functions(I could
learn, but would take time), maybe you could add a download-asm that is
depended-on by download-cobertura.

On another note, please, people, check your work as much as you can.
It's better to not do it at all if it might break something, then to go
ahead, and do it without understanding, and without sitting around
watching for breakage, and fixing it.  I know that I have broken stuff
the last weak; but I am sticking around and fixing it correctly, by
going forward.

At the least, scan the commit history to see when things were added,
then send emails publically to the list.  If no response is given, a
private mail is then required.  For this issue, only a public email was
sent to me, and I was busy with $work to notice.  I was checking private
mail tho.

[Erwan de FERRIERES]

Le 21/05/2012 15:47, Adam Heath a écrit :

> On 04/12/2012 07:02 AM, Erwan de FERRIERES wrote:
>> Hi Doogie,
>>
>> a long time ago, you committed code to test the presence of the
>> cobertura classes:
>> https://fisheye6.atlassian.com/changelog/ofbiz?cs=889839.
>> Today (maybe since ?), this is not working with the ant shell script
>> located at the OFBiz's root.
>>
>> I created the related Jira issue:
>> http://issues.apache.org/jira/browse/OFBIZ-4783
>>
>> Would it be possible you take a look ?
>
> I have, and you are the one who broke it. You changed the cobertura
> version from 0.9.3, to 0.9.4.1, without checking *all* files, to see if
> anything referenced it.
>
> I just fixed the broken reference, but now it still needs the asm
> library, which was removed. I'm not certain how ivy functions(I could
> learn, but would take time), maybe you could add a download-asm that is
> depended-on by download-cobertura.

Thanks a lot... And I'm so angry about me that I was the one introducing
the bug. Thanks again !!

>
> On another note, please, people, check your work as much as you can.
> It's better to not do it at all if it might break something, then to go
> ahead, and do it without understanding, and without sitting around
> watching for breakage, and fixing it. I know that I have broken stuff
> the last weak; but I am sticking around and fixing it correctly, by
> going forward.
>
> At the least, scan the commit history to see when things were added,
> then send emails publically to the list. If no response is given, a
> private mail is then required. For this issue, only a public email was
> sent to me, and I was busy with $work to notice. I was checking private
> mail tho.
>

--
Erwan de FERRIERES
www.nereide.biz